[jira] [Commented] (IGNITE-11798) Memory leak on unstable topology caused by partition reservation

2020-02-13 Thread Andrey Mashenkov (Jira) 


[ 
https://issues.apache.org/jira/browse/IGNITE-11798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17036075#comment-17036075
 ] 

Andrey Mashenkov commented on IGNITE-11798:
---

LGTM, merged to master.

Thanks for contribution!

> Memory leak on unstable topology caused by partition reservation
> 
>
> Key: IGNITE-11798
> URL: https://issues.apache.org/jira/browse/IGNITE-11798
> Project: Ignite
>  Issue Type: Bug
>  Components: cache, sql
>Affects Versions: 2.7
>Reporter: Pavel Vinokurov
>Assignee: Taras Ledkov
>Priority: Major
> Fix For: 2.9
>
> Attachments: PartitionReservationReproducer.java
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Executing queries on unstable topology leads to OOM caused by leak of  the 
> partition reservation.
> The reproducer is attached.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (IGNITE-11798) Memory leak on unstable topology caused by partition reservation

2020-02-07 Thread Ignite TC Bot (Jira) 


[ 
https://issues.apache.org/jira/browse/IGNITE-11798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17032272#comment-17032272
 ] 

Ignite TC Bot commented on IGNITE-11798:


{panel:title=Branch: [pull/7251/head] Base: [master] : No blockers 
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
[TeamCity *--> Run :: All* 
Results|https://ci.ignite.apache.org/viewLog.html?buildId=4927133&buildTypeId=IgniteTests24Java8_RunAll]

> Memory leak on unstable topology caused by partition reservation
> 
>
> Key: IGNITE-11798
> URL: https://issues.apache.org/jira/browse/IGNITE-11798
> Project: Ignite
>  Issue Type: Bug
>  Components: cache, sql
>Affects Versions: 2.7
>Reporter: Pavel Vinokurov
>Assignee: Taras Ledkov
>Priority: Major
> Attachments: PartitionReservationReproducer.java
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Executing queries on unstable topology leads to OOM caused by leak of  the 
> partition reservation.
> The reproducer is attached.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (IGNITE-11798) Memory leak on unstable topology caused by partition reservation

2020-01-29 Thread Taras Ledkov (Jira) 


[ 
https://issues.apache.org/jira/browse/IGNITE-11798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17025854#comment-17025854
 ] 

Taras Ledkov commented on IGNITE-11798:
---

[~amashenkov], that's right.
We must to check reservations map on each exchange because 
lastAffinityChangedTopologyVersion may return current version instead of really 
last changed version *when exchange isn't done*.
So. reservation map may contain any older versions which is added when query 
request is processed.


> Memory leak on unstable topology caused by partition reservation
> 
>
> Key: IGNITE-11798
> URL: https://issues.apache.org/jira/browse/IGNITE-11798
> Project: Ignite
>  Issue Type: Bug
>  Components: cache, sql
>Affects Versions: 2.7
>Reporter: Pavel Vinokurov
>Assignee: Taras Ledkov
>Priority: Major
> Attachments: PartitionReservationReproducer.java
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Executing queries on unstable topology leads to OOM caused by leak of  the 
> partition reservation.
> The reproducer is attached.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (IGNITE-11798) Memory leak on unstable topology caused by partition reservation

2020-01-23 Thread Andrey Mashenkov (Jira) 


[ 
https://issues.apache.org/jira/browse/IGNITE-11798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17021922#comment-17021922
 ] 

Andrey Mashenkov commented on IGNITE-11798:
---

[~tledkov-gridgain],
Looks like PartitionsExchangeAware.onDoneAfterTopologyUnlock() is called on 
every topology change event. 
So, mass client join\leave topology can start multiple partition reservation 
invalidation tasks for same affinity version, isn't it?

> Memory leak on unstable topology caused by partition reservation
> 
>
> Key: IGNITE-11798
> URL: https://issues.apache.org/jira/browse/IGNITE-11798
> Project: Ignite
>  Issue Type: Bug
>  Components: cache, sql
>Affects Versions: 2.7
>Reporter: Pavel Vinokurov
>Assignee: Taras Ledkov
>Priority: Major
> Attachments: PartitionReservationReproducer.java
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Executing queries on unstable topology leads to OOM caused by leak of  the 
> partition reservation.
> The reproducer is attached.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (IGNITE-11798) Memory leak on unstable topology caused by partition reservation

2020-01-23 Thread Ignite TC Bot (Jira) 


[ 
https://issues.apache.org/jira/browse/IGNITE-11798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17021896#comment-17021896
 ] 

Ignite TC Bot commented on IGNITE-11798:


{panel:title=Branch: [pull/7251/head] Base: [master] : No blockers 
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
[TeamCity *--> Run :: All* 
Results|https://ci.ignite.apache.org/viewLog.html?buildId=4927133&buildTypeId=IgniteTests24Java8_RunAll]

> Memory leak on unstable topology caused by partition reservation
> 
>
> Key: IGNITE-11798
> URL: https://issues.apache.org/jira/browse/IGNITE-11798
> Project: Ignite
>  Issue Type: Bug
>  Components: cache, sql
>Affects Versions: 2.7
>Reporter: Pavel Vinokurov
>Assignee: Taras Ledkov
>Priority: Major
> Attachments: PartitionReservationReproducer.java
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Executing queries on unstable topology leads to OOM caused by leak of  the 
> partition reservation.
> The reproducer is attached.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)