[jira] [Commented] (IGNITE-11868) GridClient#data() should be deprecated/removed.
[
https://issues.apache.org/jira/browse/IGNITE-11868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16943766#comment-16943766
]
Ivan Rakov commented on IGNITE-11868:
-
[~slava.koptilin] [~kcheng.mvp] Thanks for your contribution and review!
Merged to master.
> GridClient#data() should be deprecated/removed.
> ---
>
> Key: IGNITE-11868
> URL: https://issues.apache.org/jira/browse/IGNITE-11868
> Project: Ignite
> Issue Type: Bug
>Affects Versions: 2.7
>Reporter: Vyacheslav Koptilin
>Assignee: kcheng.mvp
>Priority: Minor
> Labels: newbie
> Fix For: 2.8
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> It seems that {{GridClient#data()}} does not make sense after IGNITE-3488 and
> therefore it can be removed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-11868) GridClient#data() should be deprecated/removed.
[
https://issues.apache.org/jira/browse/IGNITE-11868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16943242#comment-16943242
]
Denis A. Magda commented on IGNITE-11868:
-
[~slava.koptilin], as long as [~ivan.glukos] is not responding we are free to
merge the changes. Could you please merge the patch?
> GridClient#data() should be deprecated/removed.
> ---
>
> Key: IGNITE-11868
> URL: https://issues.apache.org/jira/browse/IGNITE-11868
> Project: Ignite
> Issue Type: Bug
>Affects Versions: 2.7
>Reporter: Vyacheslav Koptilin
>Assignee: kcheng.mvp
>Priority: Minor
> Labels: newbie
> Fix For: 2.8
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> It seems that {{GridClient#data()}} does not make sense after IGNITE-3488 and
> therefore it can be removed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-11868) GridClient#data() should be deprecated/removed.
[
https://issues.apache.org/jira/browse/IGNITE-11868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16937849#comment-16937849
]
Vyacheslav Koptilin commented on IGNITE-11868:
--
Hi [~kcheng.mvp], thanks for the contribution!
Hi [~ivan.glukos], could you please take a look and merge the change?
> GridClient#data() should be deprecated/removed.
> ---
>
> Key: IGNITE-11868
> URL: https://issues.apache.org/jira/browse/IGNITE-11868
> Project: Ignite
> Issue Type: Bug
>Affects Versions: 2.7
>Reporter: Vyacheslav Koptilin
>Assignee: kcheng.mvp
>Priority: Minor
> Labels: newbie
> Fix For: 2.8
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> It seems that {{GridClient#data()}} does not make sense after IGNITE-3488 and
> therefore it can be removed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-11868) GridClient#data() should be deprecated/removed.
[
https://issues.apache.org/jira/browse/IGNITE-11868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16937809#comment-16937809
]
kcheng.mvp commented on IGNITE-11868:
-
[~slava.koptilin] TeamCity is green
https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_BuildApacheIgnite&branch_IgniteTests24Java8=pull%2F6868%2Fhead&tab=buildTypeStatusDiv
Can you help do the further process.
Thanks
> GridClient#data() should be deprecated/removed.
> ---
>
> Key: IGNITE-11868
> URL: https://issues.apache.org/jira/browse/IGNITE-11868
> Project: Ignite
> Issue Type: Bug
>Affects Versions: 2.7
>Reporter: Vyacheslav Koptilin
>Assignee: kcheng.mvp
>Priority: Minor
> Labels: newbie
> Fix For: 2.8
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> It seems that {{GridClient#data()}} does not make sense after IGNITE-3488 and
> therefore it can be removed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-11868) GridClient#data() should be deprecated/removed.
[
https://issues.apache.org/jira/browse/IGNITE-11868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16935670#comment-16935670
]
Vyacheslav Koptilin commented on IGNITE-11868:
--
Hi [~kcheng.mvp],
In general, the change looks good to me. I triggered 'RunAll' for this pull
request and got a visa from the Teamcity bot.
(I think the following page will be useful to understand how it works:
[https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot])
Could you please change the state of the ticket from "In progress" to "Patch
available"
Also, take into account my comment
[https://github.com/apache/ignite/pull/6894#discussion_r327007694]
Thank you!
> GridClient#data() should be deprecated/removed.
> ---
>
> Key: IGNITE-11868
> URL: https://issues.apache.org/jira/browse/IGNITE-11868
> Project: Ignite
> Issue Type: Bug
>Affects Versions: 2.7
>Reporter: Vyacheslav Koptilin
>Assignee: kcheng.mvp
>Priority: Minor
> Labels: newbie
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> It seems that {{GridClient#data()}} does not make sense after IGNITE-3488 and
> therefore it can be removed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-11868) GridClient#data() should be deprecated/removed.
[
https://issues.apache.org/jira/browse/IGNITE-11868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16935671#comment-16935671
]
Ignite TC Bot commented on IGNITE-11868:
{panel:title=Branch: [pull/6894/head] Base: [master] : No blockers
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
[TeamCity *--> Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=4624628&buildTypeId=IgniteTests24Java8_RunAll]
> GridClient#data() should be deprecated/removed.
> ---
>
> Key: IGNITE-11868
> URL: https://issues.apache.org/jira/browse/IGNITE-11868
> Project: Ignite
> Issue Type: Bug
>Affects Versions: 2.7
>Reporter: Vyacheslav Koptilin
>Assignee: kcheng.mvp
>Priority: Minor
> Labels: newbie
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> It seems that {{GridClient#data()}} does not make sense after IGNITE-3488 and
> therefore it can be removed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-11868) GridClient#data() should be deprecated/removed.
[
https://issues.apache.org/jira/browse/IGNITE-11868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16934971#comment-16934971
]
kcheng.mvp commented on IGNITE-11868:
-
[~slava.koptilin] Can you help do the code review.
PR is : https://github.com/apache/ignite/pull/6894
TeamCity is green :
https://ci.ignite.apache.org/viewLog.html?buildId=4621223&buildTypeId=IgniteTests24Java8_RunCache
> GridClient#data() should be deprecated/removed.
> ---
>
> Key: IGNITE-11868
> URL: https://issues.apache.org/jira/browse/IGNITE-11868
> Project: Ignite
> Issue Type: Bug
>Affects Versions: 2.7
>Reporter: Vyacheslav Koptilin
>Assignee: kcheng.mvp
>Priority: Minor
> Labels: newbie
> Time Spent: 20m
> Remaining Estimate: 0h
>
> It seems that {{GridClient#data()}} does not make sense after IGNITE-3488 and
> therefore it can be removed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-11868) GridClient#data() should be deprecated/removed.
[
https://issues.apache.org/jira/browse/IGNITE-11868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16934463#comment-16934463
]
kcheng.mvp commented on IGNITE-11868:
-
[~slava.koptilin] my fault, there are references from unit test. i will try to
remove this method.
> GridClient#data() should be deprecated/removed.
> ---
>
> Key: IGNITE-11868
> URL: https://issues.apache.org/jira/browse/IGNITE-11868
> Project: Ignite
> Issue Type: Bug
>Affects Versions: 2.7
>Reporter: Vyacheslav Koptilin
>Assignee: kcheng.mvp
>Priority: Minor
> Labels: newbie
>
> It seems that {{GridClient#data()}} does not make sense after IGNITE-3488 and
> therefore it can be removed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-11868) GridClient#data() should be deprecated/removed.
[
https://issues.apache.org/jira/browse/IGNITE-11868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16934340#comment-16934340
]
Vyacheslav Koptilin commented on IGNITE-11868:
--
Hello [~kcheng.mvp],
Well, this method is internal (it should not affect end-users) and therefore
that its use can be reworked I think.
However, could you please list all tests that use this method? I could not find
such tests.
> GridClient#data() should be deprecated/removed.
> ---
>
> Key: IGNITE-11868
> URL: https://issues.apache.org/jira/browse/IGNITE-11868
> Project: Ignite
> Issue Type: Bug
>Affects Versions: 2.7
>Reporter: Vyacheslav Koptilin
>Assignee: kcheng.mvp
>Priority: Minor
> Labels: newbie
>
> It seems that {{GridClient#data()}} does not make sense after IGNITE-3488 and
> therefore it can be removed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-11868) GridClient#data() should be deprecated/removed.
[
https://issues.apache.org/jira/browse/IGNITE-11868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16929978#comment-16929978
]
kcheng.mvp commented on IGNITE-11868:
-
[~slava.koptilin] I noticed there are lots of tests use this method. Seems we
can not simply remove this method, so can we just annotate it as deprecated?
> GridClient#data() should be deprecated/removed.
> ---
>
> Key: IGNITE-11868
> URL: https://issues.apache.org/jira/browse/IGNITE-11868
> Project: Ignite
> Issue Type: Bug
>Affects Versions: 2.7
>Reporter: Vyacheslav Koptilin
>Assignee: kcheng.mvp
>Priority: Minor
> Labels: newbie
>
> It seems that {{GridClient#data()}} does not make sense after IGNITE-3488 and
> therefore it can be removed.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
