[jira] [Commented] (IGNITE-12799) Set right SpEL at Spring Data tests

2020-03-19 Thread Vyacheslav Koptilin (Jira) 


[ 
https://issues.apache.org/jira/browse/IGNITE-12799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17062422#comment-17062422
 ] 

Vyacheslav Koptilin commented on IGNITE-12799:
--

Hello [~schernolyas],

I have merged your fix. Thank you for your efforts!

> Set right SpEL at Spring Data tests
> ---
>
> Key: IGNITE-12799
> URL: https://issues.apache.org/jira/browse/IGNITE-12799
> Project: Ignite
>  Issue Type: Bug
>  Components: spring
>Affects Versions: 2.8.1
>Reporter: Sergey Chernolyas
>Assignee: Sergey Chernolyas
>Priority: Trivial
> Fix For: 2.8.1
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> PersonExpressionRepository uses  SpEL "@cacheNames.personCacheName". It is 
> wrong. SpEL "#\{cacheNames.personCacheName}" must be used.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (IGNITE-12799) Set right SpEL at Spring Data tests

2020-03-19 Thread Vyacheslav Koptilin (Jira) 


[ 
https://issues.apache.org/jira/browse/IGNITE-12799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17062373#comment-17062373
 ] 

Vyacheslav Koptilin commented on IGNITE-12799:
--

Hi [~schernolyas],

Thank you for the added test. I will take a look.

> Set right SpEL at Spring Data tests
> ---
>
> Key: IGNITE-12799
> URL: https://issues.apache.org/jira/browse/IGNITE-12799
> Project: Ignite
>  Issue Type: Bug
>  Components: spring
>Affects Versions: 2.8.1
>Reporter: Sergey Chernolyas
>Assignee: Sergey Chernolyas
>Priority: Trivial
> Fix For: 2.8.1
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> PersonExpressionRepository uses  SpEL "@cacheNames.personCacheName". It is 
> wrong. SpEL "#\{cacheNames.personCacheName}" must be used.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (IGNITE-12799) Set right SpEL at Spring Data tests

2020-03-18 Thread Sergey Chernolyas (Jira) 


[ 
https://issues.apache.org/jira/browse/IGNITE-12799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17061959#comment-17061959
 ] 

Sergey Chernolyas commented on IGNITE-12799:


Hi [~slava.koptilin]!

Class org.springframework.context.expression.StandardBeanExpressionResolver 
thinks that SpEL is between "#\{" and "}".  It  doesn't  recognize SpEL in all 
other strings. It was my error.  Also, you can look at 
[https://docs.spring.io/spring-framework/docs/current/javadoc-api/org/springframework/context/expression/StandardBeanExpressionResolver.html]

I have appended test method which checks cache names. Test method 
[https://github.com/apache/ignite/blob/2e5df6d42536c53421f18cd68c4befe0939f26ac/modules/spring-data-2.0/src/test/java/org/apache/ignite/springdata/IgniteSpringDataCrudSelfExpressionTest.java#L116]
 checks that SpEL have been processed.

 

> Set right SpEL at Spring Data tests
> ---
>
> Key: IGNITE-12799
> URL: https://issues.apache.org/jira/browse/IGNITE-12799
> Project: Ignite
>  Issue Type: Bug
>  Components: spring
>Affects Versions: 2.8.1
>Reporter: Sergey Chernolyas
>Assignee: Sergey Chernolyas
>Priority: Trivial
> Fix For: 2.8.1
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> PersonExpressionRepository uses  SpEL "@cacheNames.personCacheName". It is 
> wrong. SpEL "#\{cacheNames.personCacheName}" must be used.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (IGNITE-12799) Set right SpEL at Spring Data tests

2020-03-18 Thread Vyacheslav Koptilin (Jira) 


[ 
https://issues.apache.org/jira/browse/IGNITE-12799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17061760#comment-17061760
 ] 

Vyacheslav Koptilin commented on IGNITE-12799:
--

Hello [~schernolyas],

I am not an expert in spring data at all. However, I have the following 
question:
IGNITE-12582 contains new tests and it is verified by TC Boat (has a green 
visa). Does it mean there are no tests that cover the bug you are trying to fix 
in this pull-request?

Thanks,
S.

> Set right SpEL at Spring Data tests
> ---
>
> Key: IGNITE-12799
> URL: https://issues.apache.org/jira/browse/IGNITE-12799
> Project: Ignite
>  Issue Type: Bug
>  Components: spring
>Affects Versions: 2.8.1
>Reporter: Sergey Chernolyas
>Assignee: Sergey Chernolyas
>Priority: Trivial
> Fix For: 2.8.1
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> PersonExpressionRepository uses  SpEL "@cacheNames.personCacheName". It is 
> wrong. SpEL "#\{cacheNames.personCacheName}" must be used.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (IGNITE-12799) Set right SpEL at Spring Data tests

2020-03-18 Thread Ignite TC Bot (Jira) 


[ 
https://issues.apache.org/jira/browse/IGNITE-12799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17061709#comment-17061709
 ] 

Ignite TC Bot commented on IGNITE-12799:


{panel:title=Branch: [pull/7545/head] Base: [master] : No blockers 
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
[TeamCity *-- Run :: All* 
Results|https://ci.ignite.apache.org/viewLog.html?buildId=5136931buildTypeId=IgniteTests24Java8_RunAll]

> Set right SpEL at Spring Data tests
> ---
>
> Key: IGNITE-12799
> URL: https://issues.apache.org/jira/browse/IGNITE-12799
> Project: Ignite
>  Issue Type: Bug
>  Components: spring
>Affects Versions: 2.8.1
>Reporter: Sergey Chernolyas
>Assignee: Sergey Chernolyas
>Priority: Trivial
> Fix For: 2.8.1
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> PersonExpressionRepository uses  SpEL "@cacheNames.personCacheName". It is 
> wrong. SpEL "#\{cacheNames.personCacheName}" must be used.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)