[jira] [Commented] (IGNITE-12922) SqlViewMetricExporterSpi is redundant entity
[
https://issues.apache.org/jira/browse/IGNITE-12922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196593#comment-17196593
]
Andrey N. Gura commented on IGNITE-12922:
-
[~nizhikov] LGTM. Please proceed with merge. Thanks for contribution!
> SqlViewMetricExporterSpi is redundant entity
> -
>
> Key: IGNITE-12922
> URL: https://issues.apache.org/jira/browse/IGNITE-12922
> Project: Ignite
> Issue Type: Bug
>Affects Versions: 2.8
>Reporter: Andrey N. Gura
>Assignee: Nikolay Izhikov
>Priority: Major
> Labels: IEP-35
> Fix For: 2.10
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> {{SqlViewMetricExporterSpi}} is redundant entity both in terms of design and
> in terms of user experience.
> {{METRICS}} SQL view is the internal entity that could exist regardless of
> any exporters configuration. So it should be created on indexing module
> initialization. Also from an user stand point it is strange to configure
> special exporter in order to get access to the {{METRICS}} view via SQL.
> See also IGNITE-12921.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-12922) SqlViewMetricExporterSpi is redundant entity
[
https://issues.apache.org/jira/browse/IGNITE-12922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17179182#comment-17179182
]
Andrey N. Gura commented on IGNITE-12922:
-
[~nizhikov] This change is very similar to #8135 (or built on it). It still
doesn't solve described problem. Could you please look at my code review
comments to #8135? I address this issue in these comments.
> SqlViewMetricExporterSpi is redundant entity
> -
>
> Key: IGNITE-12922
> URL: https://issues.apache.org/jira/browse/IGNITE-12922
> Project: Ignite
> Issue Type: Bug
>Affects Versions: 2.8
>Reporter: Andrey N. Gura
>Assignee: Nikolay Izhikov
>Priority: Major
> Labels: IEP-35
> Fix For: 2.10
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> {{SqlViewMetricExporterSpi}} is redundant entity both in terms of design and
> in terms of user experience.
> {{METRICS}} SQL view is the internal entity that could exist regardless of
> any exporters configuration. So it should be created on indexing module
> initialization. Also from an user stand point it is strange to configure
> special exporter in order to get access to the {{METRICS}} view via SQL.
> See also IGNITE-12921.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-12922) SqlViewMetricExporterSpi is redundant entity
[
https://issues.apache.org/jira/browse/IGNITE-12922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17155196#comment-17155196
]
Aleksey Plekhanov commented on IGNITE-12922:
[~agura], [~nizhikov], does anyone have plans to work on this ticket to resolve
it in 2.9 release? Should we move this ticket to the next release?
> SqlViewMetricExporterSpi is redundant entity
> -
>
> Key: IGNITE-12922
> URL: https://issues.apache.org/jira/browse/IGNITE-12922
> Project: Ignite
> Issue Type: Bug
>Affects Versions: 2.8
>Reporter: Andrey N. Gura
>Priority: Major
> Labels: IEP-35
> Fix For: 2.9
>
>
> {{SqlViewMetricExporterSpi}} is redundant entity both in terms of design and
> in terms of user experience.
> {{METRICS}} SQL view is the internal entity that could exist regardless of
> any exporters configuration. So it should be created on indexing module
> initialization. Also from an user stand point it is strange to configure
> special exporter in order to get access to the {{METRICS}} view via SQL.
> See also IGNITE-12921.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-12922) SqlViewMetricExporterSpi is redundant entity
[
https://issues.apache.org/jira/browse/IGNITE-12922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089656#comment-17089656
]
Nikolay Izhikov commented on IGNITE-12922:
--
Hello, [~agura] Thanks for the tickets!
I think this improvement should be included in 2.9 release because 2.8.1 is a
bugfix release.
> SqlViewMetricExporterSpi is redundant entity
> -
>
> Key: IGNITE-12922
> URL: https://issues.apache.org/jira/browse/IGNITE-12922
> Project: Ignite
> Issue Type: Bug
>Affects Versions: 2.8
>Reporter: Andrey N. Gura
>Priority: Major
> Labels: IEP-35
> Fix For: 2.8.1
>
>
> {{SqlViewMetricExporterSpi}} is redundant entity both in terms of design and
> in terms of user experience.
> {{METRICS}} SQL view is the internal entity that could exist regardless of
> any exporters configuration. So it should be created on indexing module
> initialization. Also from an user stand point it is strange to configure
> special exporter in order to get access to the {{METRICS}} view via SQL.
> See also IGNITE-12921.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
