[jira] [Commented] (IGNITE-13017) Remove hardcoded delay from re-marking failed node as alive.

2020-06-09 Thread Anton Vinogradov (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-13017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17129200#comment-17129200
 ] 

Anton Vinogradov commented on IGNITE-13017:
---

Merged to master.
Thanks for your contribution!

> Remove hardcoded delay from re-marking failed node as alive.
> 
>
> Key: IGNITE-13017
> URL: https://issues.apache.org/jira/browse/IGNITE-13017
> Project: Ignite
>  Issue Type: Sub-task
>Affects Versions: 2.8.1
>Reporter: Vladimir Steshin
>Assignee: Vladimir Steshin
>Priority: Major
>  Labels: iep-45
> Attachments: WostCaseStepByStep.txt
>
>
> We should remove hardcoded timeout from:
> {code:java}
> boolean 
> ServerImpl.CrossRingMessageSendState.markLastFailedNodeAlive() {
> if (state == RingMessageSendState.FORWARD_PASS || state == 
> RingMessageSendState.BACKWARD_PASS) {
>...
> if (--failedNodes <= 0) {
> ...
> state = RingMessageSendState.STARTING_POINT;
> try {
> Thread.sleep(200);
> }
> catch (InterruptedException e) {
> Thread.currentThread().interrupt();
> }
> }
> return true;
> }
> return false;
> }
> {code}
> This can bring additional 200ms to duration of failed node detection. 
> See '_WorstCaseStepByStep.txt_', step 6. And IGNITE-13016 for more details. 
> This ticket is part of it.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (IGNITE-13017) Remove hardcoded delay from re-marking failed node as alive.

2020-05-29 Thread Ignite TC Bot (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-13017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119360#comment-17119360
 ] 

Ignite TC Bot commented on IGNITE-13017:


{panel:title=Branch: [pull/7870/head] Base: [master] : No blockers 
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
[TeamCity *-- Run :: All* 
Results|https://ci.ignite.apache.org/viewLog.html?buildId=5345755buildTypeId=IgniteTests24Java8_RunAll]

> Remove hardcoded delay from re-marking failed node as alive.
> 
>
> Key: IGNITE-13017
> URL: https://issues.apache.org/jira/browse/IGNITE-13017
> Project: Ignite
>  Issue Type: Sub-task
>Reporter: Vladimir Steshin
>Assignee: Vladimir Steshin
>Priority: Major
>  Labels: iep-45
> Attachments: WostCaseStepByStep.txt
>
>
> We should remove hardcoded timeout from:
> {code:java}
> boolean 
> ServerImpl.CrossRingMessageSendState.markLastFailedNodeAlive() {
> if (state == RingMessageSendState.FORWARD_PASS || state == 
> RingMessageSendState.BACKWARD_PASS) {
>...
> if (--failedNodes <= 0) {
> ...
> state = RingMessageSendState.STARTING_POINT;
> try {
> Thread.sleep(200);
> }
> catch (InterruptedException e) {
> Thread.currentThread().interrupt();
> }
> }
> return true;
> }
> return false;
> }
> {code}
> This can bring additional 200ms to duration of failed node detection. 
> See '_WorstCaseStepByStep.txt_', step 6. And IGNITE-13016 for more details. 
> This ticket is part of it.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)