[jira] [Commented] (IGNITE-13142) SQL constraint not null added on key prevents correct inserts

2020-07-10 Thread Aleksey Plekhanov (Jira) 


[ 
https://issues.apache.org/jira/browse/IGNITE-13142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17155193#comment-17155193
 ] 

Aleksey Plekhanov commented on IGNITE-13142:


[~skalashnikov], looks good to me. Thanks for the contribution!

Merged to master, cherry-picked to 2.9.

> SQL constraint not null added on key prevents correct inserts
> -
>
> Key: IGNITE-13142
> URL: https://issues.apache.org/jira/browse/IGNITE-13142
> Project: Ignite
>  Issue Type: Bug
>Reporter: Sergey Kalashnikov
>Assignee: Sergey Kalashnikov
>Priority: Major
> Fix For: 2.9
>
> Attachments: SqlNotNullKeyFielfTest.java
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> It is possible to configure {{QueryEntity}} so that subsequent inserts would 
> fail.
> - lowercase {{keyFieldName}}
> - not null constraint on {{keyFieldName}}
> {code:java}
> new QueryEntity()
> .setTableName("Person")
> .setKeyFieldName("id")
> .setKeyType("java.lang.Integer")
> .setValueType("Person")
> .setFields(new LinkedHashMap<>(
> F.asMap("id", "java.lang.Integer",
> "name", "java.lang.String",
> "age", "java.lang.Integer")))
> .setNotNullFields(F.asSet("id", "name", "age"
> {code}
> The following SQL produces error: Null value is not allowed for column 'ID'
> {code}
> insert into Person (id, name, age) values (1, 'John Doe', 30)
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (IGNITE-13142) SQL constraint not null added on key prevents correct inserts

2020-07-10 Thread Ignite TC Bot (Jira) 


[ 
https://issues.apache.org/jira/browse/IGNITE-13142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17155188#comment-17155188
 ] 

Ignite TC Bot commented on IGNITE-13142:


{panel:title=Branch: [pull/7961/head] Base: [master] : No blockers 
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
{panel:title=Branch: [pull/7961/head] Base: [master] : New Tests 
(14)|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}
{color:#8b}Queries 1{color} [tests 6]
* {color:#013220}IgniteBinaryCacheQueryTestSuite: 
SqlNotNullKeyValueFieldTest.testQueryEntity[key=ID val=VAL] - PASSED{color}
* {color:#013220}IgniteBinaryCacheQueryTestSuite: 
SqlNotNullKeyValueFieldTest.testQuotedDDL[key=ID val=VAL] - PASSED{color}
* {color:#013220}IgniteBinaryCacheQueryTestSuite: 
SqlNotNullKeyValueFieldTest.testUnquotedDDL[key=ID val=VAL] - PASSED{color}
* {color:#013220}IgniteBinaryCacheQueryTestSuite: 
SqlNotNullKeyValueFieldTest.testQueryEntity[key=id val=val] - PASSED{color}
* {color:#013220}IgniteBinaryCacheQueryTestSuite: 
SqlNotNullKeyValueFieldTest.testQuotedDDL[key=id val=val] - PASSED{color}
* {color:#013220}IgniteBinaryCacheQueryTestSuite: 
SqlNotNullKeyValueFieldTest.testUnquotedDDL[key=id val=val] - PASSED{color}

{color:#8b}Service Grid{color} [tests 4]
* {color:#013220}IgniteServiceGridTestSuite: 
ServiceDeploymentProcessIdSelfTest.topologyVersion[Test event=IgniteBiTuple 
[val1=DiscoveryEvent [evtNode=cf585f8e-97f6-4dca-9535-0329a1bfe769, topVer=0, 
nodeId8=bc67cb33, msg=, type=NODE_JOINED, tstamp=1593117756068], 
val2=AffinityTopologyVersion [topVer=2790516118756588940, minorTopVer=0]]] - 
PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite: 
ServiceDeploymentProcessIdSelfTest.requestId[Test event=IgniteBiTuple 
[val1=DiscoveryEvent [evtNode=cf585f8e-97f6-4dca-9535-0329a1bfe769, topVer=0, 
nodeId8=bc67cb33, msg=, type=NODE_JOINED, tstamp=1593117756068], 
val2=AffinityTopologyVersion [topVer=2790516118756588940, minorTopVer=0]]] - 
PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite: 
ServiceDeploymentProcessIdSelfTest.topologyVersion[Test event=IgniteBiTuple 
[val1=DiscoveryCustomEvent [customMsg=ServiceChangeBatchRequest 
[id=8aac73de271-56b203db-074e-4d33-b892-7b73db6e08d6, reqs=SingletonList 
[ServiceUndeploymentRequest []]], affTopVer=null, super=DiscoveryEvent 
[evtNode=e3e47a41-8897-4dfd-a2ae-094b923e9b42, topVer=0, nodeId8=e3e47a41, 
msg=null, type=DISCOVERY_CUSTOM_EVT, tstamp=1593117756068]], 
val2=AffinityTopologyVersion [topVer=-4319664596444763260, minorTopVer=0]]] - 
PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite: 
ServiceDeploymentProcessIdSelfTest.requestId[Test event=IgniteBiTuple 
[val1=DiscoveryCustomEvent [customMsg=ServiceChangeBatchRequest 
[id=8aac73de271-56b203db-074e-4d33-b892-7b73db6e08d6, reqs=SingletonList 
[ServiceUndeploymentRequest []]], affTopVer=null, super=DiscoveryEvent 
[evtNode=e3e47a41-8897-4dfd-a2ae-094b923e9b42, topVer=0, nodeId8=e3e47a41, 
msg=null, type=DISCOVERY_CUSTOM_EVT, tstamp=1593117756068]], 
val2=AffinityTopologyVersion [topVer=-4319664596444763260, minorTopVer=0]]] - 
PASSED{color}

{color:#8b}Service Grid (legacy mode){color} [tests 4]
* {color:#013220}IgniteServiceGridTestSuite: 
ServiceDeploymentProcessIdSelfTest.topologyVersion[Test event=IgniteBiTuple 
[val1=DiscoveryEvent [evtNode=953f81fa-db06-4110-a163-cab52e0eed5c, topVer=0, 
nodeId8=dcaa2d32, msg=, type=NODE_JOINED, tstamp=1593117739931], 
val2=AffinityTopologyVersion [topVer=-6283083835210186696, minorTopVer=0]]] - 
PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite: 
ServiceDeploymentProcessIdSelfTest.requestId[Test event=IgniteBiTuple 
[val1=DiscoveryEvent [evtNode=953f81fa-db06-4110-a163-cab52e0eed5c, topVer=0, 
nodeId8=dcaa2d32, msg=, type=NODE_JOINED, tstamp=1593117739931], 
val2=AffinityTopologyVersion [topVer=-6283083835210186696, minorTopVer=0]]] - 
PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite: 
ServiceDeploymentProcessIdSelfTest.topologyVersion[Test event=IgniteBiTuple 
[val1=DiscoveryCustomEvent [customMsg=ServiceChangeBatchRequest 
[id=f9b873de271-87c85835-de7d-455b-87d1-d66341f2d8db, reqs=SingletonList 
[ServiceUndeploymentRequest []]], affTopVer=null, super=DiscoveryEvent 
[evtNode=baec8421-9b51-43a9-9b9d-9d3c10d2822c, topVer=0, nodeId8=baec8421, 
msg=null, type=DISCOVERY_CUSTOM_EVT, tstamp=1593117739931]], 
val2=AffinityTopologyVersion [topVer=-6243374504219412140, minorTopVer=0]]] - 
PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite: 
ServiceDeploymentProcessIdSelfTest.requestId[Test event=IgniteBiTuple 
[val1=DiscoveryCustomEvent [customMsg=ServiceChangeBatchRequest 
[id=f9b873de271-87c85835-de7d-455b-87d1-d66341f2d8db, reqs=SingletonList 
[ServiceUndeploymentRequest []]], affTopVer=null, super=DiscoveryEvent 
[evtNode=baec8421-9b51-43a9-9b9d-9d3c10d2822c, topVer=0, nodeId8=baec8421, 
msg=null, type=DISCOVERY_CUSTOM_EVT,