[jira] [Commented] (IGNITE-13185) API to change Cluster Tag and notify about change of Cluster Tag

2020-07-10 Thread Ilya Kasnacheev (Jira) 


[ 
https://issues.apache.org/jira/browse/IGNITE-13185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17155321#comment-17155321
 ] 

Ilya Kasnacheev commented on IGNITE-13185:
--

I have cherry-picked this ticket to 2.9.

> API to change Cluster Tag and notify about change of Cluster Tag
> 
>
> Key: IGNITE-13185
> URL: https://issues.apache.org/jira/browse/IGNITE-13185
> Project: Ignite
>  Issue Type: Improvement
>  Components: general, UI, visor
>Reporter: Sergey Chugunov
>Assignee: Sergey Chugunov
>Priority: Major
> Fix For: 2.9
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> IGNITE-12111 introduced new feature to identify and distinguish different 
> clusters.
> To make the feature more usable we need new command in CLI interface to 
> change Cluster Tag and new event to subscribe for changes of Cluster Tag.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (IGNITE-13185) API to change Cluster Tag and notify about change of Cluster Tag

2020-07-10 Thread Aleksey Plekhanov (Jira) 


[ 
https://issues.apache.org/jira/browse/IGNITE-13185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17155211#comment-17155211
 ] 

Aleksey Plekhanov commented on IGNITE-13185:


[~sergey-chugunov], I have no objections.

> API to change Cluster Tag and notify about change of Cluster Tag
> 
>
> Key: IGNITE-13185
> URL: https://issues.apache.org/jira/browse/IGNITE-13185
> Project: Ignite
>  Issue Type: Improvement
>  Components: general, UI, visor
>Reporter: Sergey Chugunov
>Assignee: Sergey Chugunov
>Priority: Major
> Fix For: 2.10
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> IGNITE-12111 introduced new feature to identify and distinguish different 
> clusters.
> To make the feature more usable we need new command in CLI interface to 
> change Cluster Tag and new event to subscribe for changes of Cluster Tag.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (IGNITE-13185) API to change Cluster Tag and notify about change of Cluster Tag

2020-07-10 Thread Sergey Chugunov (Jira) 


[ 
https://issues.apache.org/jira/browse/IGNITE-13185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17155210#comment-17155210
 ] 

Sergey Chugunov commented on IGNITE-13185:
--

[~alex_pl],

I think this ticket could be cherry-picked to 2.9 branch as well as 
IGNITE-12111 is already there and this one improves usability of Cluster ID and 
Tag.

What do you think?

> API to change Cluster Tag and notify about change of Cluster Tag
> 
>
> Key: IGNITE-13185
> URL: https://issues.apache.org/jira/browse/IGNITE-13185
> Project: Ignite
>  Issue Type: Improvement
>  Components: general, UI, visor
>Reporter: Sergey Chugunov
>Assignee: Sergey Chugunov
>Priority: Major
> Fix For: 2.10
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> IGNITE-12111 introduced new feature to identify and distinguish different 
> clusters.
> To make the feature more usable we need new command in CLI interface to 
> change Cluster Tag and new event to subscribe for changes of Cluster Tag.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (IGNITE-13185) API to change Cluster Tag and notify about change of Cluster Tag

2020-07-08 Thread Sergey Chugunov (Jira) 


[ 
https://issues.apache.org/jira/browse/IGNITE-13185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17153634#comment-17153634
 ] 

Sergey Chugunov commented on IGNITE-13185:
--

[~alex_pl], 

Sure, I'll take a look right now.

> API to change Cluster Tag and notify about change of Cluster Tag
> 
>
> Key: IGNITE-13185
> URL: https://issues.apache.org/jira/browse/IGNITE-13185
> Project: Ignite
>  Issue Type: Improvement
>  Components: general, UI, visor
>Reporter: Sergey Chugunov
>Assignee: Sergey Chugunov
>Priority: Major
> Fix For: 2.10
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> IGNITE-12111 introduced new feature to identify and distinguish different 
> clusters.
> To make the feature more usable we need new command in CLI interface to 
> change Cluster Tag and new event to subscribe for changes of Cluster Tag.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (IGNITE-13185) API to change Cluster Tag and notify about change of Cluster Tag

2020-07-08 Thread Aleksey Plekhanov (Jira) 


[ 
https://issues.apache.org/jira/browse/IGNITE-13185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17153630#comment-17153630
 ] 

Aleksey Plekhanov commented on IGNITE-13185:


[~ilyak], [~sergey-chugunov], looks like master is broken after this fix, 
because control.sh utility was moved to a separate module earlier. Can you 
please have a look? 

> API to change Cluster Tag and notify about change of Cluster Tag
> 
>
> Key: IGNITE-13185
> URL: https://issues.apache.org/jira/browse/IGNITE-13185
> Project: Ignite
>  Issue Type: Improvement
>  Components: general, UI, visor
>Reporter: Sergey Chugunov
>Assignee: Sergey Chugunov
>Priority: Major
> Fix For: 2.10
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> IGNITE-12111 introduced new feature to identify and distinguish different 
> clusters.
> To make the feature more usable we need new command in CLI interface to 
> change Cluster Tag and new event to subscribe for changes of Cluster Tag.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (IGNITE-13185) API to change Cluster Tag and notify about change of Cluster Tag

2020-07-08 Thread Ilya Kasnacheev (Jira) 


[ 
https://issues.apache.org/jira/browse/IGNITE-13185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17153585#comment-17153585
 ] 

Ilya Kasnacheev commented on IGNITE-13185:
--

Thank you for this contribution, [~sergey-chugunov], I have merged it to master.

Please provide release notes and documentation for this feature.

If you feel that this issue needs to be included to 2.9, please discuss it with 
[~alexpl] since it is his call.

> API to change Cluster Tag and notify about change of Cluster Tag
> 
>
> Key: IGNITE-13185
> URL: https://issues.apache.org/jira/browse/IGNITE-13185
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Sergey Chugunov
>Assignee: Sergey Chugunov
>Priority: Major
> Fix For: 2.10
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> IGNITE-12111 introduced new feature to identify and distinguish different 
> clusters.
> To make the feature more usable we need new command in CLI interface to 
> change Cluster Tag and new event to subscribe for changes of Cluster Tag.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (IGNITE-13185) API to change Cluster Tag and notify about change of Cluster Tag

2020-07-08 Thread Sergey Chugunov (Jira) 


[ 
https://issues.apache.org/jira/browse/IGNITE-13185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17153565#comment-17153565
 ] 

Sergey Chugunov commented on IGNITE-13185:
--

[~ilyak],

I addressed your comments in the PR and got another green visa - could you take 
another look at the change?

Thanks!

> API to change Cluster Tag and notify about change of Cluster Tag
> 
>
> Key: IGNITE-13185
> URL: https://issues.apache.org/jira/browse/IGNITE-13185
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Sergey Chugunov
>Assignee: Sergey Chugunov
>Priority: Major
> Fix For: 2.9
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> IGNITE-12111 introduced new feature to identify and distinguish different 
> clusters.
> To make the feature more usable we need new command in CLI interface to 
> change Cluster Tag and new event to subscribe for changes of Cluster Tag.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (IGNITE-13185) API to change Cluster Tag and notify about change of Cluster Tag

2020-07-08 Thread Ignite TC Bot (Jira) 


[ 
https://issues.apache.org/jira/browse/IGNITE-13185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17153562#comment-17153562
 ] 

Ignite TC Bot commented on IGNITE-13185:


{panel:title=Branch: [pull/7964/head] Base: [master] : No blockers 
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
{panel:title=Branch: [pull/7964/head] Base: [master] : New Tests 
(14)|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}
{color:#8b}ZooKeeper (Discovery) 2{color} [tests 1]
* {color:#013220}ZookeeperDiscoverySpiTestSuite2: 
GridCommandHandlerTest.testClusterChangeTag - PASSED{color}

{color:#8b}Basic 3{color} [tests 5]
* {color:#013220}IgniteBasicWithPersistenceTestSuite: 
IgniteClusterIdTagTest.testTagChangedEvent - PASSED{color}
* {color:#013220}IgniteBasicWithPersistenceTestSuite: 
IgniteClusterIdTagTest.testChangeTagExceptions - PASSED{color}
* {color:#013220}IgniteBasicWithPersistenceTestSuite: 
IgniteClusterIdTagTest.testTagChangedEventMultinodeWithRemoteFilter - 
PASSED{color}
* {color:#013220}IgniteBasicWithPersistenceTestSuite: 
GridCommandHandlerWithSSLTest.testClusterChangeTag - PASSED{color}
* {color:#013220}IgniteBasicWithPersistenceTestSuite: 
GridCommandHandlerTest.testClusterChangeTag - PASSED{color}

{color:#8b}Service Grid{color} [tests 4]
* {color:#013220}IgniteServiceGridTestSuite: 
ServiceDeploymentProcessIdSelfTest.requestId[Test event=IgniteBiTuple 
[val1=DiscoveryEvent [evtNode=81b9c70a-66c6-40a1-a42b-9adcf98689a2, topVer=0, 
nodeId8=f492af84, msg=, type=NODE_JOINED, tstamp=1594140404418], 
val2=AffinityTopologyVersion [topVer=1603531752557536031, minorTopVer=0]]] - 
PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite: 
ServiceDeploymentProcessIdSelfTest.topologyVersion[Test event=IgniteBiTuple 
[val1=DiscoveryCustomEvent [customMsg=ServiceChangeBatchRequest 
[id=504763a2371-627cdcf5-6732-4614-bf82-6f1b2935b10e, reqs=SingletonList 
[ServiceUndeploymentRequest []]], affTopVer=null, super=DiscoveryEvent 
[evtNode=0eaf3a62-1a20-4020-b091-2f23ca8dcebc, topVer=0, nodeId8=0eaf3a62, 
msg=null, type=DISCOVERY_CUSTOM_EVT, tstamp=1594140404418]], 
val2=AffinityTopologyVersion [topVer=8992486467505103191, minorTopVer=0]]] - 
PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite: 
ServiceDeploymentProcessIdSelfTest.requestId[Test event=IgniteBiTuple 
[val1=DiscoveryCustomEvent [customMsg=ServiceChangeBatchRequest 
[id=504763a2371-627cdcf5-6732-4614-bf82-6f1b2935b10e, reqs=SingletonList 
[ServiceUndeploymentRequest []]], affTopVer=null, super=DiscoveryEvent 
[evtNode=0eaf3a62-1a20-4020-b091-2f23ca8dcebc, topVer=0, nodeId8=0eaf3a62, 
msg=null, type=DISCOVERY_CUSTOM_EVT, tstamp=1594140404418]], 
val2=AffinityTopologyVersion [topVer=8992486467505103191, minorTopVer=0]]] - 
PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite: 
ServiceDeploymentProcessIdSelfTest.topologyVersion[Test event=IgniteBiTuple 
[val1=DiscoveryEvent [evtNode=81b9c70a-66c6-40a1-a42b-9adcf98689a2, topVer=0, 
nodeId8=f492af84, msg=, type=NODE_JOINED, tstamp=1594140404418], 
val2=AffinityTopologyVersion [topVer=1603531752557536031, minorTopVer=0]]] - 
PASSED{color}

{color:#8b}Service Grid (legacy mode){color} [tests 4]
* {color:#013220}IgniteServiceGridTestSuite: 
ServiceDeploymentProcessIdSelfTest.topologyVersion[Test event=IgniteBiTuple 
[val1=DiscoveryEvent [evtNode=52c9cd13-bdcf-43e8-888f-092f6e7648af, topVer=0, 
nodeId8=b47077f5, msg=, type=NODE_JOINED, tstamp=1594140341796], 
val2=AffinityTopologyVersion [topVer=7632917585497587426, minorTopVer=0]]] - 
PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite: 
ServiceDeploymentProcessIdSelfTest.requestId[Test event=IgniteBiTuple 
[val1=DiscoveryEvent [evtNode=52c9cd13-bdcf-43e8-888f-092f6e7648af, topVer=0, 
nodeId8=b47077f5, msg=, type=NODE_JOINED, tstamp=1594140341796], 
val2=AffinityTopologyVersion [topVer=7632917585497587426, minorTopVer=0]]] - 
PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite: 
ServiceDeploymentProcessIdSelfTest.topologyVersion[Test event=IgniteBiTuple 
[val1=DiscoveryCustomEvent [customMsg=ServiceChangeBatchRequest 
[id=8263b2a2371-8bf97cb3-627c-4ddd-a48a-b7c064bc6249, reqs=SingletonList 
[ServiceUndeploymentRequest []]], affTopVer=null, super=DiscoveryEvent 
[evtNode=95c9650d-48f5-4426-aaeb-b932c36d0a69, topVer=0, nodeId8=95c9650d, 
msg=null, type=DISCOVERY_CUSTOM_EVT, tstamp=1594140341796]], 
val2=AffinityTopologyVersion [topVer=-4059230009518180750, minorTopVer=0]]] - 
PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite: 
ServiceDeploymentProcessIdSelfTest.requestId[Test event=IgniteBiTuple 
[val1=DiscoveryCustomEvent [customMsg=ServiceChangeBatchRequest 
[id=8263b2a2371-8bf97cb3-627c-4ddd-a48a-b7c064bc6249, reqs=SingletonList 
[ServiceUndeploymentRequest []]], affTopVer=null, super=DiscoveryEvent 
[evtNode=95c9650d-48f5-4426-aaeb-b932c36d0a69, topVer=0, nodeId8=95c9650d, 
msg=null, type=DISCOVERY_CUSTOM_EVT,

[jira] [Commented] (IGNITE-13185) API to change Cluster Tag and notify about change of Cluster Tag

2020-07-02 Thread Ignite TC Bot (Jira) 


[ 
https://issues.apache.org/jira/browse/IGNITE-13185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17150026#comment-17150026
 ] 

Ignite TC Bot commented on IGNITE-13185:


{panel:title=Branch: [pull/7964/head] Base: [master] : No blockers 
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
{panel:title=Branch: [pull/7964/head] Base: [master] : New Tests 
(14)|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}
{color:#8b}ZooKeeper (Discovery) 2{color} [tests 1]
* {color:#013220}ZookeeperDiscoverySpiTestSuite2: 
GridCommandHandlerTest.testClusterChangeTag - PASSED{color}

{color:#8b}Basic 3{color} [tests 5]
* {color:#013220}IgniteBasicWithPersistenceTestSuite: 
IgniteClusterIdTagTest.testTagChangedEvent - PASSED{color}
* {color:#013220}IgniteBasicWithPersistenceTestSuite: 
IgniteClusterIdTagTest.testChangeTagExceptions - PASSED{color}
* {color:#013220}IgniteBasicWithPersistenceTestSuite: 
IgniteClusterIdTagTest.testTagChangedEventMultinodeWithRemoteFilter - 
PASSED{color}
* {color:#013220}IgniteBasicWithPersistenceTestSuite: 
GridCommandHandlerWithSSLTest.testClusterChangeTag - PASSED{color}
* {color:#013220}IgniteBasicWithPersistenceTestSuite: 
GridCommandHandlerTest.testClusterChangeTag - PASSED{color}

{color:#8b}Service Grid{color} [tests 4]
* {color:#013220}IgniteServiceGridTestSuite: 
ServiceDeploymentProcessIdSelfTest.topologyVersion[Test event=IgniteBiTuple 
[val1=DiscoveryCustomEvent [customMsg=ServiceChangeBatchRequest 
[id=dd35e050371-f933b01a-9734-4d56-b9b6-519cdc0ac07d, reqs=SingletonList 
[ServiceUndeploymentRequest []]], affTopVer=null, super=DiscoveryEvent 
[evtNode=c41a7e5c-6f76-4c3c-81ca-214b68c544f2, topVer=0, nodeId8=c41a7e5c, 
msg=null, type=DISCOVERY_CUSTOM_EVT, tstamp=1593517691865]], 
val2=AffinityTopologyVersion [topVer=-8832215235125097063, minorTopVer=0]]] - 
PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite: 
ServiceDeploymentProcessIdSelfTest.requestId[Test event=IgniteBiTuple 
[val1=DiscoveryCustomEvent [customMsg=ServiceChangeBatchRequest 
[id=dd35e050371-f933b01a-9734-4d56-b9b6-519cdc0ac07d, reqs=SingletonList 
[ServiceUndeploymentRequest []]], affTopVer=null, super=DiscoveryEvent 
[evtNode=c41a7e5c-6f76-4c3c-81ca-214b68c544f2, topVer=0, nodeId8=c41a7e5c, 
msg=null, type=DISCOVERY_CUSTOM_EVT, tstamp=1593517691865]], 
val2=AffinityTopologyVersion [topVer=-8832215235125097063, minorTopVer=0]]] - 
PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite: 
ServiceDeploymentProcessIdSelfTest.topologyVersion[Test event=IgniteBiTuple 
[val1=DiscoveryEvent [evtNode=00d39de4-648f-4138-ab37-962935a1bb5a, topVer=0, 
nodeId8=a41e8cd2, msg=, type=NODE_JOINED, tstamp=1593517691865], 
val2=AffinityTopologyVersion [topVer=-2234418847054097440, minorTopVer=0]]] - 
PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite: 
ServiceDeploymentProcessIdSelfTest.requestId[Test event=IgniteBiTuple 
[val1=DiscoveryEvent [evtNode=00d39de4-648f-4138-ab37-962935a1bb5a, topVer=0, 
nodeId8=a41e8cd2, msg=, type=NODE_JOINED, tstamp=1593517691865], 
val2=AffinityTopologyVersion [topVer=-2234418847054097440, minorTopVer=0]]] - 
PASSED{color}

{color:#8b}Service Grid (legacy mode){color} [tests 4]
* {color:#013220}IgniteServiceGridTestSuite: 
ServiceDeploymentProcessIdSelfTest.topologyVersion[Test event=IgniteBiTuple 
[val1=DiscoveryEvent [evtNode=c1773332-2e0d-439f-8e9c-526115490c21, topVer=0, 
nodeId8=6442d543, msg=, type=NODE_JOINED, tstamp=1593526018992], 
val2=AffinityTopologyVersion [topVer=6853082273767427558, minorTopVer=0]]] - 
PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite: 
ServiceDeploymentProcessIdSelfTest.requestId[Test event=IgniteBiTuple 
[val1=DiscoveryEvent [evtNode=c1773332-2e0d-439f-8e9c-526115490c21, topVer=0, 
nodeId8=6442d543, msg=, type=NODE_JOINED, tstamp=1593526018992], 
val2=AffinityTopologyVersion [topVer=6853082273767427558, minorTopVer=0]]] - 
PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite: 
ServiceDeploymentProcessIdSelfTest.topologyVersion[Test event=IgniteBiTuple 
[val1=DiscoveryCustomEvent [customMsg=ServiceChangeBatchRequest 
[id=4b36d850371-e81ca58f-3ca7-42cc-8275-58fef1b3ce90, reqs=SingletonList 
[ServiceUndeploymentRequest []]], affTopVer=null, super=DiscoveryEvent 
[evtNode=51c9e7cc-c4c8-421d-bfc1-7e5f05220a0e, topVer=0, nodeId8=51c9e7cc, 
msg=null, type=DISCOVERY_CUSTOM_EVT, tstamp=1593526018992]], 
val2=AffinityTopologyVersion [topVer=3428967372149071837, minorTopVer=0]]] - 
PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite: 
ServiceDeploymentProcessIdSelfTest.requestId[Test event=IgniteBiTuple 
[val1=DiscoveryCustomEvent [customMsg=ServiceChangeBatchRequest 
[id=4b36d850371-e81ca58f-3ca7-42cc-8275-58fef1b3ce90, reqs=SingletonList 
[ServiceUndeploymentRequest []]], affTopVer=null, super=DiscoveryEvent 
[evtNode=51c9e7cc-c4c8-421d-bfc1-7e5f05220a0e, topVer=0, nodeId8=51c9e7cc, 
msg=null, type=DISCOVERY_CUSTOM_EVT,