[jira] [Commented] (IGNITE-13194) Fix testNodeWithIncompatibleMetadataIsProhibitedToJoinTheCluster()

2020-06-30 Thread Taras Ledkov (Jira) 


[ 
https://issues.apache.org/jira/browse/IGNITE-13194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17148521#comment-17148521
 ] 

Taras Ledkov commented on IGNITE-13194:
---

[~vladsz83], merged to 
[master|https://github.com/apache/ignite/commit/0e385f8883a98c0a9a9e03b715c10363198c8999]

> Fix testNodeWithIncompatibleMetadataIsProhibitedToJoinTheCluster()
> --
>
> Key: IGNITE-13194
> URL: https://issues.apache.org/jira/browse/IGNITE-13194
> Project: Ignite
>  Issue Type: Bug
>Reporter: Vladimir Steshin
>Assignee: Vladimir Steshin
>Priority: Critical
> Fix For: 2.9
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Test
> {code:java}
> IgnitePdsBinaryMetadataOnClusterRestartTest.testNodeWithIncompatibleMetadataIsProhibitedToJoinTheCluster()
> {code}
> fails in master. Changed error message is incorrectly checked in the test. 
> Became incorrect in IGNITE-13154.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (IGNITE-13194) Fix testNodeWithIncompatibleMetadataIsProhibitedToJoinTheCluster()

2020-06-30 Thread Taras Ledkov (Jira) 


[ 
https://issues.apache.org/jira/browse/IGNITE-13194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17148499#comment-17148499
 ] 

Taras Ledkov commented on IGNITE-13194:
---

[~vladsz83], thanks a lot for your patch. I've missed this test.
The patch is OK with me. May me the last *typeId* should be placed according 
with previous parameters (with String.format)

> Fix testNodeWithIncompatibleMetadataIsProhibitedToJoinTheCluster()
> --
>
> Key: IGNITE-13194
> URL: https://issues.apache.org/jira/browse/IGNITE-13194
> Project: Ignite
>  Issue Type: Bug
>Reporter: Vladimir Steshin
>Assignee: Vladimir Steshin
>Priority: Critical
> Fix For: 2.9
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Test
> {code:java}
> IgnitePdsBinaryMetadataOnClusterRestartTest.testNodeWithIncompatibleMetadataIsProhibitedToJoinTheCluster()
> {code}
> fails in master. Changed error message is incorrectly checked in the test. 
> Became incorrect in IGNITE-13154.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (IGNITE-13194) Fix testNodeWithIncompatibleMetadataIsProhibitedToJoinTheCluster()

2020-06-30 Thread Vladimir Steshin (Jira) 


[ 
https://issues.apache.org/jira/browse/IGNITE-13194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17148470#comment-17148470
 ] 

Vladimir Steshin commented on IGNITE-13194:
---

[~tledkov-gridgain], could you, please, take a look. Is the fix correct?

> Fix testNodeWithIncompatibleMetadataIsProhibitedToJoinTheCluster()
> --
>
> Key: IGNITE-13194
> URL: https://issues.apache.org/jira/browse/IGNITE-13194
> Project: Ignite
>  Issue Type: Bug
>Reporter: Vladimir Steshin
>Assignee: Vladimir Steshin
>Priority: Critical
> Fix For: 2.9
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Test
> {code:java}
> IgnitePdsBinaryMetadataOnClusterRestartTest.testNodeWithIncompatibleMetadataIsProhibitedToJoinTheCluster()
> {code}
> fails in master. Changed error message is incorrectly checked in the test. 
> Became incorrect in IGNITE-13154.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (IGNITE-13194) Fix testNodeWithIncompatibleMetadataIsProhibitedToJoinTheCluster()

2020-06-29 Thread Ignite TC Bot (Jira) 


[ 
https://issues.apache.org/jira/browse/IGNITE-13194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17148078#comment-17148078
 ] 

Ignite TC Bot commented on IGNITE-13194:


{panel:title=Branch: [pull/7969/head] Base: [master] : No blockers 
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
{panel:title=Branch: [pull/7969/head] Base: [master] : New Tests 
(8)|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}
{color:#8b}Service Grid{color} [tests 4]
* {color:#013220}IgniteServiceGridTestSuite: 
ServiceDeploymentProcessIdSelfTest.requestId[Test event=IgniteBiTuple 
[val1=DiscoveryCustomEvent [customMsg=ServiceChangeBatchRequest 
[id=e7534fff271-3894fd1b-8172-41e9-9fe8-844c72777061, reqs=SingletonList 
[ServiceUndeploymentRequest []]], affTopVer=null, super=DiscoveryEvent 
[evtNode=12f72d17-04b6-4281-8877-718db9b63902, topVer=0, nodeId8=12f72d17, 
msg=null, type=DISCOVERY_CUSTOM_EVT, tstamp=1593432094074]], 
val2=AffinityTopologyVersion [topVer=-6239499851066511036, minorTopVer=0]]] - 
PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite: 
ServiceDeploymentProcessIdSelfTest.topologyVersion[Test event=IgniteBiTuple 
[val1=DiscoveryEvent [evtNode=737f25d8-4a41-4b37-81a0-8639cb9d504c, topVer=0, 
nodeId8=d0f36d0d, msg=, type=NODE_JOINED, tstamp=1593432094074], 
val2=AffinityTopologyVersion [topVer=8837420793991566154, minorTopVer=0]]] - 
PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite: 
ServiceDeploymentProcessIdSelfTest.requestId[Test event=IgniteBiTuple 
[val1=DiscoveryEvent [evtNode=737f25d8-4a41-4b37-81a0-8639cb9d504c, topVer=0, 
nodeId8=d0f36d0d, msg=, type=NODE_JOINED, tstamp=1593432094074], 
val2=AffinityTopologyVersion [topVer=8837420793991566154, minorTopVer=0]]] - 
PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite: 
ServiceDeploymentProcessIdSelfTest.topologyVersion[Test event=IgniteBiTuple 
[val1=DiscoveryCustomEvent [customMsg=ServiceChangeBatchRequest 
[id=e7534fff271-3894fd1b-8172-41e9-9fe8-844c72777061, reqs=SingletonList 
[ServiceUndeploymentRequest []]], affTopVer=null, super=DiscoveryEvent 
[evtNode=12f72d17-04b6-4281-8877-718db9b63902, topVer=0, nodeId8=12f72d17, 
msg=null, type=DISCOVERY_CUSTOM_EVT, tstamp=1593432094074]], 
val2=AffinityTopologyVersion [topVer=-6239499851066511036, minorTopVer=0]]] - 
PASSED{color}

{color:#8b}Service Grid (legacy mode){color} [tests 4]
* {color:#013220}IgniteServiceGridTestSuite: 
ServiceDeploymentProcessIdSelfTest.topologyVersion[Test event=IgniteBiTuple 
[val1=DiscoveryEvent [evtNode=383873aa-7f2e-4f87-9241-2114b1ce4c42, topVer=0, 
nodeId8=d12741d9, msg=, type=NODE_JOINED, tstamp=1593431836269], 
val2=AffinityTopologyVersion [topVer=7262422483954622305, minorTopVer=0]]] - 
PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite: 
ServiceDeploymentProcessIdSelfTest.requestId[Test event=IgniteBiTuple 
[val1=DiscoveryEvent [evtNode=383873aa-7f2e-4f87-9241-2114b1ce4c42, topVer=0, 
nodeId8=d12741d9, msg=, type=NODE_JOINED, tstamp=1593431836269], 
val2=AffinityTopologyVersion [topVer=7262422483954622305, minorTopVer=0]]] - 
PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite: 
ServiceDeploymentProcessIdSelfTest.topologyVersion[Test event=IgniteBiTuple 
[val1=DiscoveryCustomEvent [customMsg=ServiceChangeBatchRequest 
[id=542c9fff271-bf04e62e-f2ad-45f3-a8ae-7e0c64f04a7f, reqs=SingletonList 
[ServiceUndeploymentRequest []]], affTopVer=null, super=DiscoveryEvent 
[evtNode=88961155-e1f0-478e-bf47-c5d11e4e2c85, topVer=0, nodeId8=88961155, 
msg=null, type=DISCOVERY_CUSTOM_EVT, tstamp=1593431836269]], 
val2=AffinityTopologyVersion [topVer=-4510207700847366825, minorTopVer=0]]] - 
PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite: 
ServiceDeploymentProcessIdSelfTest.requestId[Test event=IgniteBiTuple 
[val1=DiscoveryCustomEvent [customMsg=ServiceChangeBatchRequest 
[id=542c9fff271-bf04e62e-f2ad-45f3-a8ae-7e0c64f04a7f, reqs=SingletonList 
[ServiceUndeploymentRequest []]], affTopVer=null, super=DiscoveryEvent 
[evtNode=88961155-e1f0-478e-bf47-c5d11e4e2c85, topVer=0, nodeId8=88961155, 
msg=null, type=DISCOVERY_CUSTOM_EVT, tstamp=1593431836269]], 
val2=AffinityTopologyVersion [topVer=-4510207700847366825, minorTopVer=0]]] - 
PASSED{color}

{panel}
[TeamCity *--> Run :: All* 
Results|https://ci.ignite.apache.org/viewLog.html?buildId=5425238&buildTypeId=IgniteTests24Java8_RunAll]

> Fix testNodeWithIncompatibleMetadataIsProhibitedToJoinTheCluster()
> --
>
> Key: IGNITE-13194
> URL: https://issues.apache.org/jira/browse/IGNITE-13194
> Project: Ignite
>  Issue Type: Bug
>Reporter: Vladimir Steshin
>Assignee: Vladimir Steshin
>Priority: Critical
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Test
> {code:java}
> IgnitePdsBinaryMetadataOnClusterRestartTest.test