[jira] [Commented] (IGNITE-17267) Preparing a checkpoint for a DeltaFilePageStore
[ https://issues.apache.org/jira/browse/IGNITE-17267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17563624#comment-17563624 ] Vladislav Pyatkov commented on IGNITE-17267: [~ktkale...@gridgain.com] I merged the path f79bd4f3edac372962a3f43e414b8338c596d682 Thank you for the contribution. > Preparing a checkpoint for a DeltaFilePageStore > --- > > Key: IGNITE-17267 > URL: https://issues.apache.org/jira/browse/IGNITE-17267 > Project: Ignite > Issue Type: Improvement >Reporter: Kirill Tkalenko >Assignee: Kirill Tkalenko >Priority: Major > Labels: ignite-3 > Fix For: 3.0.0-alpha6 > > Time Spent: 5h > Remaining Estimate: 0h > > To implement the *DeltaFilePageStore*, we need to prepare a checkpoint for > their creation. > What should be done: > # Sort dirty pages (*FullPageId*) by *groupId*, *partitionId*, *pageIdx*; > # In several threads, write dirty pages in batches for each partition and > know the number of these pages. > What can we look at: > * > *org.apache.ignite.internal.pagememory.persistence.checkpoint.CheckpointWorkflow#beginCheckpoint* > * > *org.apache.ignite.internal.pagememory.persistence.checkpoint.CheckpointWorkflow#splitAndSortCheckpointPagesIfNeeded* > * > *org.apache.ignite.internal.pagememory.persistence.checkpoint.Checkpointer#writePages* > Some implementation notes: > * We can replace *CheckpointWorkflow#parallelSortThreshold* with a constant > at 40k, according to the > [paper|https://www.researchgate.net/publication/331742843_Threshold_Analysis_and_Comparison_of_Sequential_and_Parallel_Divide_and_Conquer_Sorting_Algorithms]. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (IGNITE-17267) Preparing a checkpoint for a DeltaFilePageStore
[ https://issues.apache.org/jira/browse/IGNITE-17267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17563352#comment-17563352 ] Roman Puchkovskiy commented on IGNITE-17267: The patch looks good to me, thank you for the contribution > Preparing a checkpoint for a DeltaFilePageStore > --- > > Key: IGNITE-17267 > URL: https://issues.apache.org/jira/browse/IGNITE-17267 > Project: Ignite > Issue Type: Improvement >Reporter: Kirill Tkalenko >Assignee: Kirill Tkalenko >Priority: Major > Labels: ignite-3 > Fix For: 3.0.0-alpha6 > > Time Spent: 4h 50m > Remaining Estimate: 0h > > To implement the *DeltaFilePageStore*, we need to prepare a checkpoint for > their creation. > What should be done: > # Sort dirty pages (*FullPageId*) by *groupId*, *partitionId*, *pageIdx*; > # In several threads, write dirty pages in batches for each partition and > know the number of these pages. > What can we look at: > * > *org.apache.ignite.internal.pagememory.persistence.checkpoint.CheckpointWorkflow#beginCheckpoint* > * > *org.apache.ignite.internal.pagememory.persistence.checkpoint.CheckpointWorkflow#splitAndSortCheckpointPagesIfNeeded* > * > *org.apache.ignite.internal.pagememory.persistence.checkpoint.Checkpointer#writePages* > Some implementation notes: > * We can replace *CheckpointWorkflow#parallelSortThreshold* with a constant > at 40k, according to the > [paper|https://www.researchgate.net/publication/331742843_Threshold_Analysis_and_Comparison_of_Sequential_and_Parallel_Divide_and_Conquer_Sorting_Algorithms]. -- This message was sent by Atlassian Jira (v8.20.10#820010)
