[jira] [Commented] (IGNITE-20216) Moving ML module to ignite-extensions
[ https://issues.apache.org/jira/browse/IGNITE-20216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763618#comment-17763618 ] Ivan Daschinsky commented on IGNITE-20216: -- [~zaleslaw] [~NSAmelchev] Thanks for review, guys. Both PRs merged to masters > Moving ML module to ignite-extensions > - > > Key: IGNITE-20216 > URL: https://issues.apache.org/jira/browse/IGNITE-20216 > Project: Ignite > Issue Type: Improvement >Reporter: Ivan Daschinsky >Assignee: Ivan Daschinsky >Priority: Major > Labels: ise > Fix For: 2.16 > > Time Spent: 1h > Remaining Estimate: 0h > > It is time to move this module to ignite extensions. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (IGNITE-20216) Moving ML module to ignite-extensions
[ https://issues.apache.org/jira/browse/IGNITE-20216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763612#comment-17763612 ] Alexey Zinoviev commented on IGNITE-20216: -- Everything is fine, could be merged > Moving ML module to ignite-extensions > - > > Key: IGNITE-20216 > URL: https://issues.apache.org/jira/browse/IGNITE-20216 > Project: Ignite > Issue Type: Improvement >Reporter: Ivan Daschinsky >Assignee: Ivan Daschinsky >Priority: Major > Labels: ise > Fix For: 2.16 > > Time Spent: 50m > Remaining Estimate: 0h > > It is time to move this module to ignite extensions. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (IGNITE-20216) Moving ML module to ignite-extensions
[ https://issues.apache.org/jira/browse/IGNITE-20216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763597#comment-17763597 ] Ivan Daschinsky commented on IGNITE-20216: -- [~zaleslaw] Hi, I've found that you've already reviewed my 2 PR's. Could you please write down here that everything is ok and patches are eligible for merging? > Moving ML module to ignite-extensions > - > > Key: IGNITE-20216 > URL: https://issues.apache.org/jira/browse/IGNITE-20216 > Project: Ignite > Issue Type: Improvement >Reporter: Ivan Daschinsky >Assignee: Ivan Daschinsky >Priority: Major > Labels: ise > Fix For: 2.16 > > Time Spent: 50m > Remaining Estimate: 0h > > It is time to move this module to ignite extensions. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (IGNITE-20216) Moving ML module to ignite-extensions
[ https://issues.apache.org/jira/browse/IGNITE-20216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17759055#comment-17759055 ] Nikita Amelchev commented on IGNITE-20216: -- [~ivandasch], LGTM. > Moving ML module to ignite-extensions > - > > Key: IGNITE-20216 > URL: https://issues.apache.org/jira/browse/IGNITE-20216 > Project: Ignite > Issue Type: Improvement >Reporter: Ivan Daschinsky >Assignee: Ivan Daschinsky >Priority: Major > Labels: ise > Fix For: 2.16 > > Time Spent: 50m > Remaining Estimate: 0h > > It is time to move this module to ignite extensions. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (IGNITE-20216) Moving ML module to ignite-extensions
[
https://issues.apache.org/jira/browse/IGNITE-20216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755154#comment-17755154
]
Ignite TC Bot commented on IGNITE-20216:
{panel:title=Branch: [pull/10897/head] Base: [master] : Possible Blockers
(2)|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}
{color:#d04437}Cache 5{color} [[tests
2|https://ci2.ignite.apache.org/viewLog.html?buildId=7303635]]
* IgniteCacheTestSuite5: testsuites.IgniteCacheTestSuite5 - History for base
branch is absent.
* IgniteCacheTestSuite5: testsuites.IgniteCacheTestSuite5 - New test duration
121s is more that 1 minute
{panel}
{panel:title=Branch: [pull/10897/head] Base: [master] : New Tests
(151)|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}
{color:#8b}Cache 5{color} [[tests
151|https://ci2.ignite.apache.org/viewLog.html?buildId=7303635]]
* {color:#013220}IgniteCacheTestSuite5: testsuites.IgniteCacheTestSuite5 -
PASSED{color}
* {color:#013220}IgniteCacheTestSuite5: testsuites.IgniteCacheTestSuite5 -
PASSED{color}
* {color:#013220}IgniteCacheTestSuite5: testsuites.IgniteCacheTestSuite5 -
PASSED{color}
* {color:#013220}IgniteCacheTestSuite5: testsuites.IgniteCacheTestSuite5 -
PASSED{color}
* {color:#013220}IgniteCacheTestSuite5: testsuites.IgniteCacheTestSuite5 -
PASSED{color}
* {color:#013220}IgniteCacheTestSuite5: testsuites.IgniteCacheTestSuite5 -
PASSED{color}
* {color:#013220}IgniteCacheTestSuite5: testsuites.IgniteCacheTestSuite5 -
PASSED{color}
* {color:#013220}IgniteCacheTestSuite5: testsuites.IgniteCacheTestSuite5 -
PASSED{color}
* {color:#013220}IgniteCacheTestSuite5: testsuites.IgniteCacheTestSuite5 -
PASSED{color}
* {color:#013220}IgniteCacheTestSuite5: testsuites.IgniteCacheTestSuite5 -
PASSED{color}
* {color:#013220}IgniteCacheTestSuite5: testsuites.IgniteCacheTestSuite5 -
PASSED{color}
... and 140 new tests
{panel}
[TeamCity *-- Run :: All*
Results|https://ci2.ignite.apache.org/viewLog.html?buildId=7303474buildTypeId=IgniteTests24Java8_RunAll]
> Moving ML module to ignite-extensions
> -
>
> Key: IGNITE-20216
> URL: https://issues.apache.org/jira/browse/IGNITE-20216
> Project: Ignite
> Issue Type: Improvement
>Reporter: Ivan Daschinsky
>Assignee: Ivan Daschinsky
>Priority: Major
> Labels: ise
> Fix For: 2.16
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> It is time to move this module to ignite extensions.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (IGNITE-20216) Moving ML module to ignite-extensions
[ https://issues.apache.org/jira/browse/IGNITE-20216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755098#comment-17755098 ] Ivan Daschinsky commented on IGNITE-20216: -- [~zaleslaw] Test suite also works > Moving ML module to ignite-extensions > - > > Key: IGNITE-20216 > URL: https://issues.apache.org/jira/browse/IGNITE-20216 > Project: Ignite > Issue Type: Improvement >Reporter: Ivan Daschinsky >Assignee: Ivan Daschinsky >Priority: Major > Labels: ise > Fix For: 2.16 > > Time Spent: 20m > Remaining Estimate: 0h > > It is time to move this module to ignite extensions. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (IGNITE-20216) Moving ML module to ignite-extensions
[ https://issues.apache.org/jira/browse/IGNITE-20216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17754973#comment-17754973 ] Ivan Daschinsky commented on IGNITE-20216: -- [~zaleslaw] If I showed you successful TC run on extensions with all tests and examples, would you approve the move? Since main code is not affected at all. > Moving ML module to ignite-extensions > - > > Key: IGNITE-20216 > URL: https://issues.apache.org/jira/browse/IGNITE-20216 > Project: Ignite > Issue Type: Improvement >Reporter: Ivan Daschinsky >Assignee: Ivan Daschinsky >Priority: Major > Labels: ise > Fix For: 2.16 > > Time Spent: 20m > Remaining Estimate: 0h > > It is time to move this module to ignite extensions. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (IGNITE-20216) Moving ML module to ignite-extensions
[ https://issues.apache.org/jira/browse/IGNITE-20216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17754971#comment-17754971 ] Ivan Daschinsky commented on IGNITE-20216: -- Peter Ivanov and Me are working on ML Extensions tests on TC, works is in progress, but is going to be finished soon > Moving ML module to ignite-extensions > - > > Key: IGNITE-20216 > URL: https://issues.apache.org/jira/browse/IGNITE-20216 > Project: Ignite > Issue Type: Improvement >Reporter: Ivan Daschinsky >Assignee: Ivan Daschinsky >Priority: Major > Labels: ise > Fix For: 2.16 > > Time Spent: 20m > Remaining Estimate: 0h > > It is time to move this module to ignite extensions. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (IGNITE-20216) Moving ML module to ignite-extensions
[ https://issues.apache.org/jira/browse/IGNITE-20216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17754970#comment-17754970 ] Ivan Daschinsky commented on IGNITE-20216: -- [~zaleslaw] I have prepared 2 PRs (to ignite-extensions and AI) 1. Updated dependencies 2. Changed java blas integration to [dev.ludovic.netlib|https://github.com/luhenry/netlib] (see details here. https://spark.apache.org/docs/latest/ml-linalg-guide.html). It loads blas using `dlopen`, doesn't have licence issues (MIT). Worked ok with Intel MKL (tested on ubuntu 22.04) Actually, nothing was changed and i've faced no difficulties except some minor chores with tests. > Moving ML module to ignite-extensions > - > > Key: IGNITE-20216 > URL: https://issues.apache.org/jira/browse/IGNITE-20216 > Project: Ignite > Issue Type: Improvement >Reporter: Ivan Daschinsky >Assignee: Ivan Daschinsky >Priority: Major > Labels: ise > Fix For: 2.16 > > Time Spent: 20m > Remaining Estimate: 0h > > It is time to move this module to ignite extensions. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (IGNITE-20216) Moving ML module to ignite-extensions
[ https://issues.apache.org/jira/browse/IGNITE-20216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17754952#comment-17754952 ] Alexey Zinoviev commented on IGNITE-20216: -- Hi, as PMC and maintainer of this module -1 for removal +1 for moving to an extension, if it is compatible with the Ignite and could be compiled separately from other extension modules Some facts: * nobody updates it for latest 3 years—it's true * classic ML algorithms are not changed in the latest 3 years (we have not supported DL as a part of the module, it's not a goal, Random Forest was not changed latest 20 years) as a CSV parsing or JDBC * Tensorflow integration was removed 3 years ago * some people contacted me a few weeks ago to fix or develop some features in the Ignite ML urgent, but I have no time to do it urgent * I met some companies who used IgniteML in 2021 and 2022 including my job interview:) * I agree with the blas issue, great if somebody could update it, again I could help with testing I could help with the review of the PR on the github with moving to an extension, please assign on me @zaleslaw, but now I am on vacation, could do it in September > Moving ML module to ignite-extensions > - > > Key: IGNITE-20216 > URL: https://issues.apache.org/jira/browse/IGNITE-20216 > Project: Ignite > Issue Type: Improvement >Reporter: Ivan Daschinsky >Assignee: Ivan Daschinsky >Priority: Major > Labels: ise > Fix For: 2.16 > > Time Spent: 20m > Remaining Estimate: 0h > > It is time to move this module to ignite extensions. -- This message was sent by Atlassian Jira (v8.20.10#820010)
