[
https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16579724#comment-16579724
]
Alexey Goncharuk commented on IGNITE-602:
-
Thanks, [~SomeFire], we will take a look at the fix
[
https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16579500#comment-16579500
]
Ryabov Dmitrii commented on IGNITE-602:
---
[~agoncharuk], I made the
[
https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576901#comment-16576901
]
Ryabov Dmitrii commented on IGNITE-602:
---
[~agoncharuk], yes, I noticed it too and created
[
https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576275#comment-16576275
]
Alexey Goncharuk commented on IGNITE-602:
-
[~SomeFire], this change breaks {{S.toString()}}
[
https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16545409#comment-16545409
]
ASF GitHub Bot commented on IGNITE-602:
---
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16545013#comment-16545013
]
Alexey Goncharuk commented on IGNITE-602:
-
Fair enough, will merge the PR shortly.
> [Test]
[
https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544954#comment-16544954
]
Aleksey Plekhanov commented on IGNITE-602:
--
[~agoncharuk], I agreed with [~SomeFire].
[
https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16543637#comment-16543637
]
Ryabov Dmitrii commented on IGNITE-602:
---
[~agoncharuk], I think combining them to another tuple
[
https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16543561#comment-16543561
]
Alexey Goncharuk commented on IGNITE-602:
-
[~SomeFire], [~alex_pl] changes look good to me.
Do
[
https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513837#comment-16513837
]
Aleksey Plekhanov commented on IGNITE-602:
--
[~SomeFire], I've looked at your patch, changes
[
https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512078#comment-16512078
]
Ryabov Dmitrii commented on IGNITE-602:
---
[~agura], I changed status to PA.
> [Test]
[
https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16511300#comment-16511300
]
Andrey Gura commented on IGNITE-602:
[~SomeFire] Could you please move ticket to "Patch available"
[
https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16511297#comment-16511297
]
Andrey Gura commented on IGNITE-602:
[~SomeFire] Seems ok. But it would be better to review somebody
[
https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16500933#comment-16500933
]
Ryabov Dmitrii commented on IGNITE-602:
---
[~agura], I have updated branch with fresh master less
[
https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16500595#comment-16500595
]
Andrey Gura commented on IGNITE-602:
This changes requires reintegration with master branch due to a
[
https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16500374#comment-16500374
]
Alexey Kuznetsov commented on IGNITE-602:
-
[~SomeFire] looks good to me
> [Test]
[
https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16333610#comment-16333610
]
Vladimir Ozerov commented on IGNITE-602:
Re-targeting for 2.5 release.
> [Test]
[
https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287397#comment-16287397
]
Andrey Gura commented on IGNITE-602:
[~SomeFire] We discussed early
[
https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16280670#comment-16280670
]
Andrey Gura commented on IGNITE-602:
[~SomeFire] I still see StackOverflowError in Ignite Basic suite.
[
https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16278683#comment-16278683
]
Andrey Gura commented on IGNITE-602:
Hi, unfortunately TC doesn't look good:
[
https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268759#comment-16268759
]
Ryabov Dmitrii commented on IGNITE-602:
---
[~agura], what is current status of tests and ticket?
>
[
https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16247648#comment-16247648
]
Andrey Gura commented on IGNITE-602:
[~SomeFire], I've fixed some minor issues and ran TC again.
[
https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194586#comment-16194586
]
Ryabov Dmitrii commented on IGNITE-602:
---
[~agura], that commit was for
[
https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16184246#comment-16184246
]
Ryabov Dmitrii commented on IGNITE-602:
---
Ok, I'll think about test changes.
> [Test]
[
https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16184222#comment-16184222
]
Andrey Gura commented on IGNITE-602:
I agree with fixes for particular test but I'm against change of
[
https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16184201#comment-16184201
]
Ryabov Dmitrii commented on IGNITE-602:
---
Tests fails because they are broken by overflowed
[
https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16184176#comment-16184176
]
Andrey Gura commented on IGNITE-602:
I don't agree with this fix. It's very strange that some logging
[
https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16180627#comment-16180627
]
Ryabov Dmitrii commented on IGNITE-602:
---
It fixes one test, as in
[
https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16180617#comment-16180617
]
Andrey Gura commented on IGNITE-602:
[~SomeFire] Could you please clarify this changes?
[
https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16180557#comment-16180557
]
Ryabov Dmitrii commented on IGNITE-602:
---
[~agura], I finished this change. Now it prints identity
[
https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16163105#comment-16163105
]
Andrey Gura commented on IGNITE-602:
[~SomeFire] As I wrote earlier, identity hash code should be
[
https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16162915#comment-16162915
]
Ryabov Dmitrii commented on IGNITE-602:
---
[~agura], do we really need it? Object's hashcode can be
[
https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16136701#comment-16136701
]
Andrey Gura commented on IGNITE-602:
I think that hash code neened only for repeated objects.
>
[
https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114310#comment-16114310
]
Ryabov Dmitrii commented on IGNITE-602:
---
Thx for answer, [~agura]. Should I add hashcode only when
[
https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114287#comment-16114287
]
Andrey Gura commented on IGNITE-602:
Hi, [~SomeFire]
I think we can improve a couple of things in
[
https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16062068#comment-16062068
]
Ryabov Dmitrii commented on IGNITE-602:
---
[~agura], I made this changes. Now there is
[
https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16012806#comment-16012806
]
Andrey Gura commented on IGNITE-602:
[~SomeFire], I don't like that for every reference type instance
[
https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15983080#comment-15983080
]
Ryabov Dmitrii commented on IGNITE-602:
---
[~agura], the main idea is to call
[
https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15974804#comment-15974804
]
Andrey Gura commented on IGNITE-602:
[~SomeFire], to be honest I can't understand the main idea of
[
https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15960526#comment-15960526
]
Ryabov Dmitrii commented on IGNITE-602:
---
[~agura], sorry for formatting, it was a habit to use
[
https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15960525#comment-15960525
]
Ryabov Dmitrii commented on IGNITE-602:
---
[~agura], sorry for formatting, it was a habit to use
[
https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15935287#comment-15935287
]
Andrey Gura commented on IGNITE-602:
[~SomeFire], this change doesn't fix the problem at all. The main
[
https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877697#comment-15877697
]
Ryabov Dmitrii commented on IGNITE-602:
---
How to unmute it on TC? Class contining this test is
43 matches
Mail list logo