[jira] [Commented] (IGNITE-602) [Test] GridToStringBuilder is vulnerable for StackOverflowError caused by infinite recursion

2018-08-14 Thread Alexey Goncharuk (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16579724#comment-16579724 ] Alexey Goncharuk commented on IGNITE-602: - Thanks, [~SomeFire], we will take a look at the fix

[jira] [Commented] (IGNITE-602) [Test] GridToStringBuilder is vulnerable for StackOverflowError caused by infinite recursion

2018-08-14 Thread Ryabov Dmitrii (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16579500#comment-16579500 ] Ryabov Dmitrii commented on IGNITE-602: --- [~agoncharuk], I made the

[jira] [Commented] (IGNITE-602) [Test] GridToStringBuilder is vulnerable for StackOverflowError caused by infinite recursion

2018-08-10 Thread Ryabov Dmitrii (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576901#comment-16576901 ] Ryabov Dmitrii commented on IGNITE-602: --- [~agoncharuk], yes, I noticed it too and created

[jira] [Commented] (IGNITE-602) [Test] GridToStringBuilder is vulnerable for StackOverflowError caused by infinite recursion

2018-08-10 Thread Alexey Goncharuk (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576275#comment-16576275 ] Alexey Goncharuk commented on IGNITE-602: - [~SomeFire], this change breaks {{S.toString()}}

[jira] [Commented] (IGNITE-602) [Test] GridToStringBuilder is vulnerable for StackOverflowError caused by infinite recursion

2018-07-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16545409#comment-16545409 ] ASF GitHub Bot commented on IGNITE-602: --- Github user asfgit closed the pull request at:

[jira] [Commented] (IGNITE-602) [Test] GridToStringBuilder is vulnerable for StackOverflowError caused by infinite recursion

2018-07-16 Thread Alexey Goncharuk (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16545013#comment-16545013 ] Alexey Goncharuk commented on IGNITE-602: - Fair enough, will merge the PR shortly. > [Test]

[jira] [Commented] (IGNITE-602) [Test] GridToStringBuilder is vulnerable for StackOverflowError caused by infinite recursion

2018-07-16 Thread Aleksey Plekhanov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544954#comment-16544954 ] Aleksey Plekhanov commented on IGNITE-602: -- [~agoncharuk], I agreed with [~SomeFire].

[jira] [Commented] (IGNITE-602) [Test] GridToStringBuilder is vulnerable for StackOverflowError caused by infinite recursion

2018-07-13 Thread Ryabov Dmitrii (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16543637#comment-16543637 ] Ryabov Dmitrii commented on IGNITE-602: --- [~agoncharuk], I think combining them to another tuple

[jira] [Commented] (IGNITE-602) [Test] GridToStringBuilder is vulnerable for StackOverflowError caused by infinite recursion

2018-07-13 Thread Alexey Goncharuk (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16543561#comment-16543561 ] Alexey Goncharuk commented on IGNITE-602: - [~SomeFire], [~alex_pl] changes look good to me. Do

[jira] [Commented] (IGNITE-602) [Test] GridToStringBuilder is vulnerable for StackOverflowError caused by infinite recursion

2018-06-15 Thread Aleksey Plekhanov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513837#comment-16513837 ] Aleksey Plekhanov commented on IGNITE-602: -- [~SomeFire], I've looked at your patch, changes

[jira] [Commented] (IGNITE-602) [Test] GridToStringBuilder is vulnerable for StackOverflowError caused by infinite recursion

2018-06-14 Thread Ryabov Dmitrii (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512078#comment-16512078 ] Ryabov Dmitrii commented on IGNITE-602: --- [~agura], I changed status to PA. > [Test]

[jira] [Commented] (IGNITE-602) [Test] GridToStringBuilder is vulnerable for StackOverflowError caused by infinite recursion

2018-06-13 Thread Andrey Gura (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16511300#comment-16511300 ] Andrey Gura commented on IGNITE-602: [~SomeFire] Could you please move ticket to "Patch available"

[jira] [Commented] (IGNITE-602) [Test] GridToStringBuilder is vulnerable for StackOverflowError caused by infinite recursion

2018-06-13 Thread Andrey Gura (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16511297#comment-16511297 ] Andrey Gura commented on IGNITE-602: [~SomeFire] Seems ok. But it would be better to review somebody

[jira] [Commented] (IGNITE-602) [Test] GridToStringBuilder is vulnerable for StackOverflowError caused by infinite recursion

2018-06-04 Thread Ryabov Dmitrii (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16500933#comment-16500933 ] Ryabov Dmitrii commented on IGNITE-602: --- [~agura], I have updated branch with fresh master less

[jira] [Commented] (IGNITE-602) [Test] GridToStringBuilder is vulnerable for StackOverflowError caused by infinite recursion

2018-06-04 Thread Andrey Gura (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16500595#comment-16500595 ] Andrey Gura commented on IGNITE-602: This changes requires reintegration with master branch due to a

[jira] [Commented] (IGNITE-602) [Test] GridToStringBuilder is vulnerable for StackOverflowError caused by infinite recursion

2018-06-04 Thread Alexey Kuznetsov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16500374#comment-16500374 ] Alexey Kuznetsov commented on IGNITE-602: - [~SomeFire] looks good to me > [Test]

[jira] [Commented] (IGNITE-602) [Test] GridToStringBuilder is vulnerable for StackOverflowError caused by infinite recursion

2018-01-21 Thread Vladimir Ozerov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16333610#comment-16333610 ] Vladimir Ozerov commented on IGNITE-602: Re-targeting for 2.5 release. > [Test]

[jira] [Commented] (IGNITE-602) [Test] GridToStringBuilder is vulnerable for StackOverflowError caused by infinite recursion

2017-12-12 Thread Andrey Gura (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287397#comment-16287397 ] Andrey Gura commented on IGNITE-602: [~SomeFire] We discussed early

[jira] [Commented] (IGNITE-602) [Test] GridToStringBuilder is vulnerable for StackOverflowError caused by infinite recursion

2017-12-06 Thread Andrey Gura (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16280670#comment-16280670 ] Andrey Gura commented on IGNITE-602: [~SomeFire] I still see StackOverflowError in Ignite Basic suite.

[jira] [Commented] (IGNITE-602) [Test] GridToStringBuilder is vulnerable for StackOverflowError caused by infinite recursion

2017-12-05 Thread Andrey Gura (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16278683#comment-16278683 ] Andrey Gura commented on IGNITE-602: Hi, unfortunately TC doesn't look good:

[jira] [Commented] (IGNITE-602) [Test] GridToStringBuilder is vulnerable for StackOverflowError caused by infinite recursion

2017-11-28 Thread Ryabov Dmitrii (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268759#comment-16268759 ] Ryabov Dmitrii commented on IGNITE-602: --- [~agura], what is current status of tests and ticket? >

[jira] [Commented] (IGNITE-602) [Test] GridToStringBuilder is vulnerable for StackOverflowError caused by infinite recursion

2017-11-10 Thread Andrey Gura (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16247648#comment-16247648 ] Andrey Gura commented on IGNITE-602: [~SomeFire], I've fixed some minor issues and ran TC again.

[jira] [Commented] (IGNITE-602) [Test] GridToStringBuilder is vulnerable for StackOverflowError caused by infinite recursion

2017-10-06 Thread Ryabov Dmitrii (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194586#comment-16194586 ] Ryabov Dmitrii commented on IGNITE-602: --- [~agura], that commit was for

[jira] [Commented] (IGNITE-602) [Test] GridToStringBuilder is vulnerable for StackOverflowError caused by infinite recursion

2017-09-28 Thread Ryabov Dmitrii (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16184246#comment-16184246 ] Ryabov Dmitrii commented on IGNITE-602: --- Ok, I'll think about test changes. > [Test]

[jira] [Commented] (IGNITE-602) [Test] GridToStringBuilder is vulnerable for StackOverflowError caused by infinite recursion

2017-09-28 Thread Andrey Gura (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16184222#comment-16184222 ] Andrey Gura commented on IGNITE-602: I agree with fixes for particular test but I'm against change of

[jira] [Commented] (IGNITE-602) [Test] GridToStringBuilder is vulnerable for StackOverflowError caused by infinite recursion

2017-09-28 Thread Ryabov Dmitrii (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16184201#comment-16184201 ] Ryabov Dmitrii commented on IGNITE-602: --- Tests fails because they are broken by overflowed

[jira] [Commented] (IGNITE-602) [Test] GridToStringBuilder is vulnerable for StackOverflowError caused by infinite recursion

2017-09-28 Thread Andrey Gura (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16184176#comment-16184176 ] Andrey Gura commented on IGNITE-602: I don't agree with this fix. It's very strange that some logging

[jira] [Commented] (IGNITE-602) [Test] GridToStringBuilder is vulnerable for StackOverflowError caused by infinite recursion

2017-09-26 Thread Ryabov Dmitrii (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16180627#comment-16180627 ] Ryabov Dmitrii commented on IGNITE-602: --- It fixes one test, as in

[jira] [Commented] (IGNITE-602) [Test] GridToStringBuilder is vulnerable for StackOverflowError caused by infinite recursion

2017-09-26 Thread Andrey Gura (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16180617#comment-16180617 ] Andrey Gura commented on IGNITE-602: [~SomeFire] Could you please clarify this changes?

[jira] [Commented] (IGNITE-602) [Test] GridToStringBuilder is vulnerable for StackOverflowError caused by infinite recursion

2017-09-26 Thread Ryabov Dmitrii (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16180557#comment-16180557 ] Ryabov Dmitrii commented on IGNITE-602: --- [~agura], I finished this change. Now it prints identity

[jira] [Commented] (IGNITE-602) [Test] GridToStringBuilder is vulnerable for StackOverflowError caused by infinite recursion

2017-09-12 Thread Andrey Gura (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16163105#comment-16163105 ] Andrey Gura commented on IGNITE-602: [~SomeFire] As I wrote earlier, identity hash code should be

[jira] [Commented] (IGNITE-602) [Test] GridToStringBuilder is vulnerable for StackOverflowError caused by infinite recursion

2017-09-12 Thread Ryabov Dmitrii (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16162915#comment-16162915 ] Ryabov Dmitrii commented on IGNITE-602: --- [~agura], do we really need it? Object's hashcode can be

[jira] [Commented] (IGNITE-602) [Test] GridToStringBuilder is vulnerable for StackOverflowError caused by infinite recursion

2017-08-22 Thread Andrey Gura (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16136701#comment-16136701 ] Andrey Gura commented on IGNITE-602: I think that hash code neened only for repeated objects. >

[jira] [Commented] (IGNITE-602) [Test] GridToStringBuilder is vulnerable for StackOverflowError caused by infinite recursion

2017-08-04 Thread Ryabov Dmitrii (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114310#comment-16114310 ] Ryabov Dmitrii commented on IGNITE-602: --- Thx for answer, [~agura]. Should I add hashcode only when

[jira] [Commented] (IGNITE-602) [Test] GridToStringBuilder is vulnerable for StackOverflowError caused by infinite recursion

2017-08-04 Thread Andrey Gura (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114287#comment-16114287 ] Andrey Gura commented on IGNITE-602: Hi, [~SomeFire] I think we can improve a couple of things in

[jira] [Commented] (IGNITE-602) [Test] GridToStringBuilder is vulnerable for StackOverflowError caused by infinite recursion

2017-06-24 Thread Ryabov Dmitrii (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16062068#comment-16062068 ] Ryabov Dmitrii commented on IGNITE-602: --- [~agura], I made this changes. Now there is

[jira] [Commented] (IGNITE-602) [Test] GridToStringBuilder is vulnerable for StackOverflowError caused by infinite recursion

2017-05-16 Thread Andrey Gura (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16012806#comment-16012806 ] Andrey Gura commented on IGNITE-602: [~SomeFire], I don't like that for every reference type instance

[jira] [Commented] (IGNITE-602) [Test] GridToStringBuilder is vulnerable for StackOverflowError caused by infinite recursion

2017-04-25 Thread Ryabov Dmitrii (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15983080#comment-15983080 ] Ryabov Dmitrii commented on IGNITE-602: --- [~agura], the main idea is to call

[jira] [Commented] (IGNITE-602) [Test] GridToStringBuilder is vulnerable for StackOverflowError caused by infinite recursion

2017-04-19 Thread Andrey Gura (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15974804#comment-15974804 ] Andrey Gura commented on IGNITE-602: [~SomeFire], to be honest I can't understand the main idea of

[jira] [Commented] (IGNITE-602) [Test] GridToStringBuilder is vulnerable for StackOverflowError caused by infinite recursion

2017-04-07 Thread Ryabov Dmitrii (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15960526#comment-15960526 ] Ryabov Dmitrii commented on IGNITE-602: --- [~agura], sorry for formatting, it was a habit to use

[jira] [Commented] (IGNITE-602) [Test] GridToStringBuilder is vulnerable for StackOverflowError caused by infinite recursion

2017-04-07 Thread Ryabov Dmitrii (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15960525#comment-15960525 ] Ryabov Dmitrii commented on IGNITE-602: --- [~agura], sorry for formatting, it was a habit to use

[jira] [Commented] (IGNITE-602) [Test] GridToStringBuilder is vulnerable for StackOverflowError caused by infinite recursion

2017-03-21 Thread Andrey Gura (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15935287#comment-15935287 ] Andrey Gura commented on IGNITE-602: [~SomeFire], this change doesn't fix the problem at all. The main

[jira] [Commented] (IGNITE-602) [Test] GridToStringBuilder is vulnerable for StackOverflowError caused by infinite recursion

2017-02-21 Thread Ryabov Dmitrii (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877697#comment-15877697 ] Ryabov Dmitrii commented on IGNITE-602: --- How to unmute it on TC? Class contining this test is