[jira] [Commented] (IGNITE-6868) Implement new JMX metrics for TcpCommunicationSpi monitoring

[ https://issues.apache.org/jira/browse/IGNITE-6868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16440418#comment-16440418 ] ASF GitHub Bot commented on IGNITE-6868: Github user alex-plekhanov closed the pull request at:

[jira] [Commented] (IGNITE-6868) Implement new JMX metrics for TcpCommunicationSpi monitoring

[ https://issues.apache.org/jira/browse/IGNITE-6868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16440413#comment-16440413 ] ASF GitHub Bot commented on IGNITE-6868: Github user alex-plekhanov closed the pull request at:

[jira] [Commented] (IGNITE-6868) Implement new JMX metrics for TcpCommunicationSpi monitoring

[ https://issues.apache.org/jira/browse/IGNITE-6868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380058#comment-16380058 ] ASF GitHub Bot commented on IGNITE-6868: Github user alex-plekhanov closed the pull request at:

[jira] [Commented] (IGNITE-6868) Implement new JMX metrics for TcpCommunicationSpi monitoring

[ https://issues.apache.org/jira/browse/IGNITE-6868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380057#comment-16380057 ] ASF GitHub Bot commented on IGNITE-6868: Github user alex-plekhanov closed the pull request at:

[jira] [Commented] (IGNITE-6868) Implement new JMX metrics for TcpCommunicationSpi monitoring

[ https://issues.apache.org/jira/browse/IGNITE-6868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379867#comment-16379867 ] ASF GitHub Bot commented on IGNITE-6868: GitHub user alex-plekhanov opened a pull request:

[jira] [Commented] (IGNITE-6868) Implement new JMX metrics for TcpCommunicationSpi monitoring

[ https://issues.apache.org/jira/browse/IGNITE-6868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379383#comment-16379383 ] ASF GitHub Bot commented on IGNITE-6868: GitHub user alex-plekhanov opened a pull request:

[jira] [Commented] (IGNITE-6868) Implement new JMX metrics for TcpCommunicationSpi monitoring

[ https://issues.apache.org/jira/browse/IGNITE-6868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16283274#comment-16283274 ] Anton Vinogradov commented on IGNITE-6868: -- [~alex_pl] Looks good to me. > Implement new JMX

[jira] [Commented] (IGNITE-6868) Implement new JMX metrics for TcpCommunicationSpi monitoring

[ https://issues.apache.org/jira/browse/IGNITE-6868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16280300#comment-16280300 ] Aleksey Plekhanov commented on IGNITE-6868: --- [~vozerov], I returned methods, make methods used

[jira] [Commented] (IGNITE-6868) Implement new JMX metrics for TcpCommunicationSpi monitoring

[ https://issues.apache.org/jira/browse/IGNITE-6868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16280020#comment-16280020 ] Vladimir Ozerov commented on IGNITE-6868: - If we bothered with binary compatibility of

[jira] [Commented] (IGNITE-6868) Implement new JMX metrics for TcpCommunicationSpi monitoring

[ https://issues.apache.org/jira/browse/IGNITE-6868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16280019#comment-16280019 ] Vladimir Ozerov commented on IGNITE-6868: - [~alex_pl], [~avinogradov], it is not very clear why

[jira] [Commented] (IGNITE-6868) Implement new JMX metrics for TcpCommunicationSpi monitoring

[ https://issues.apache.org/jira/browse/IGNITE-6868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16278422#comment-16278422 ] Anton Vinogradov commented on IGNITE-6868: -- [~alex_pl] Looks good to me. [~vozerov] Please

[jira] [Commented] (IGNITE-6868) Implement new JMX metrics for TcpCommunicationSpi monitoring

[ https://issues.apache.org/jira/browse/IGNITE-6868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277619#comment-16277619 ] Aleksey Plekhanov commented on IGNITE-6868: --- #3 is not fixed. As I write before, metricsLsnr is

[jira] [Commented] (IGNITE-6868) Implement new JMX metrics for TcpCommunicationSpi monitoring

[ https://issues.apache.org/jira/browse/IGNITE-6868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16276591#comment-16276591 ] Anton Vinogradov commented on IGNITE-6868: -- [~alex_pl] What about #3? > Implement new JMX

[jira] [Commented] (IGNITE-6868) Implement new JMX metrics for TcpCommunicationSpi monitoring

[ https://issues.apache.org/jira/browse/IGNITE-6868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16276512#comment-16276512 ] Aleksey Plekhanov commented on IGNITE-6868: --- [~vozerov], [~avinogradov], please review the

[jira] [Commented] (IGNITE-6868) Implement new JMX metrics for TcpCommunicationSpi monitoring

[ https://issues.apache.org/jira/browse/IGNITE-6868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16274455#comment-16274455 ] ASF GitHub Bot commented on IGNITE-6868: GitHub user alex-plekhanov opened a pull request:

[jira] [Commented] (IGNITE-6868) Implement new JMX metrics for TcpCommunicationSpi monitoring

[ https://issues.apache.org/jira/browse/IGNITE-6868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16274360#comment-16274360 ] Aleksey Plekhanov commented on IGNITE-6868: --- [~vozerov] 1) Will fix it. 2) Will fix it. 3)

[jira] [Commented] (IGNITE-6868) Implement new JMX metrics for TcpCommunicationSpi monitoring

[ https://issues.apache.org/jira/browse/IGNITE-6868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16274074#comment-16274074 ] Vladimir Ozerov commented on IGNITE-6868: - Last thing is {{reset}} handling. Instead of clearing

[jira] [Commented] (IGNITE-6868) Implement new JMX metrics for TcpCommunicationSpi monitoring

[ https://issues.apache.org/jira/browse/IGNITE-6868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16274070#comment-16274070 ] Vladimir Ozerov commented on IGNITE-6868: - Another question is why the following methods are not

[jira] [Commented] (IGNITE-6868) Implement new JMX metrics for TcpCommunicationSpi monitoring

[ https://issues.apache.org/jira/browse/IGNITE-6868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16274065#comment-16274065 ] Vladimir Ozerov commented on IGNITE-6868: - [~alex_pl], [~avinogradov], what was the reason of

[jira] [Commented] (IGNITE-6868) Implement new JMX metrics for TcpCommunicationSpi monitoring

[ https://issues.apache.org/jira/browse/IGNITE-6868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16257428#comment-16257428 ] Anton Vinogradov commented on IGNITE-6868: -- [~alex_pl] Please see codestyle and minor comments

[jira] [Commented] (IGNITE-6868) Implement new JMX metrics for TcpCommunicationSpi monitoring

[ https://issues.apache.org/jira/browse/IGNITE-6868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16251803#comment-16251803 ] ASF GitHub Bot commented on IGNITE-6868: GitHub user alex-plekhanov opened a pull request: