[jira] [Commented] (IGNITE-6949) Cleanup OLS code

2017-11-29 Thread Yury Babak (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-6949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16270632#comment-16270632
 ] 

Yury Babak commented on IGNITE-6949:


[~ntikhonov], This will be fixed in IGNITE-7007.

> Cleanup OLS code
> 
>
> Key: IGNITE-6949
> URL: https://issues.apache.org/jira/browse/IGNITE-6949
> Project: Ignite
>  Issue Type: Bug
>  Components: ml
>Reporter: Yury Babak
>Assignee: Aleksey Zinoviev
> Fix For: 2.4
>
>
> We want fix wrong styles like wildcards in imports, unnecessary empty lines, 
> missed empty lines and if-else blocks format in OLS related files.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-6949) Cleanup OLS code

2017-11-23 Thread Nikolay Tikhonov (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-6949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264405#comment-16264405
 ] 

Nikolay Tikhonov commented on IGNITE-6949:
--

[~zaleslaw],
Thank you for your contribution! I've merged the changes to master. 

Anyway, ML module needs to serious review. I've found code style issues and 
rude exception handling. For example
{{noformat}}
org.apache.ignite.ml.util.Utils#copy
...
catch (IOException | ClassNotFoundException e) {
e.printStackTrace();
}
{{noformat}}

[~chief], could you handle this?

> Cleanup OLS code
> 
>
> Key: IGNITE-6949
> URL: https://issues.apache.org/jira/browse/IGNITE-6949
> Project: Ignite
>  Issue Type: Bug
>  Components: ml
>Reporter: Yury Babak
>Assignee: Aleksey Zinoviev
> Fix For: 2.4
>
>
> We want fix wrong styles like wildcards in imports, unnecessary empty lines, 
> missed empty lines and if-else blocks format in OLS related files.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-6949) Cleanup OLS code

2017-11-23 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-6949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264393#comment-16264393
 ] 

ASF GitHub Bot commented on IGNITE-6949:


Github user asfgit closed the pull request at:

https://github.com/apache/ignite/pull/3063


> Cleanup OLS code
> 
>
> Key: IGNITE-6949
> URL: https://issues.apache.org/jira/browse/IGNITE-6949
> Project: Ignite
>  Issue Type: Bug
>  Components: ml
>Reporter: Yury Babak
>Assignee: Aleksey Zinoviev
> Fix For: 2.4
>
>
> We want fix wrong styles like wildcards in imports, unnecessary empty lines, 
> missed empty lines and if-else blocks format in OLS related files.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-6949) Cleanup OLS code

2017-11-23 Thread Yury Babak (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-6949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264249#comment-16264249
 ] 

Yury Babak commented on IGNITE-6949:


[~zaleslaw], reviewed, looks good for me.

> Cleanup OLS code
> 
>
> Key: IGNITE-6949
> URL: https://issues.apache.org/jira/browse/IGNITE-6949
> Project: Ignite
>  Issue Type: Bug
>  Components: ml
>Reporter: Yury Babak
>Assignee: Aleksey Zinoviev
> Fix For: 2.4
>
>
> We want fix wrong styles like wildcards in imports, unnecessary empty lines, 
> missed empty lines and if-else blocks format in OLS related files.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-6949) Cleanup OLS code

2017-11-21 Thread Aleksey Zinoviev (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-6949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16260859#comment-16260859
 ] 

Aleksey Zinoviev commented on IGNITE-6949:
--

[~chief] please review, I formatted changed files with codestyle file from 
ignite/idea

> Cleanup OLS code
> 
>
> Key: IGNITE-6949
> URL: https://issues.apache.org/jira/browse/IGNITE-6949
> Project: Ignite
>  Issue Type: Bug
>  Components: ml
>Reporter: Yury Babak
>Assignee: Aleksey Zinoviev
> Fix For: 2.4
>
>
> We want fix wrong styles like wildcards in imports, unnecessary empty lines, 
> missed empty lines and if-else blocks format in OLS related files.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-6949) Cleanup OLS code

2017-11-21 Thread Nikolay Tikhonov (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-6949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16260543#comment-16260543
 ] 

Nikolay Tikhonov commented on IGNITE-6949:
--

[~zaleslaw],
Thank you for your contribution! I've looked at the changes and still see some 
code style issues. For example 
* extra space in imports (SparseBlockDistributedMatrix file);
* CacheUtils#reduce has incorrect alignments;
[~chief],
Please, double check this changes again and help [~zaleslaw] with it. 

> Cleanup OLS code
> 
>
> Key: IGNITE-6949
> URL: https://issues.apache.org/jira/browse/IGNITE-6949
> Project: Ignite
>  Issue Type: Bug
>  Components: ml
>Reporter: Yury Babak
>Assignee: Aleksey Zinoviev
> Fix For: 2.4
>
>
> We want fix wrong styles like wildcards in imports, unnecessary empty lines, 
> missed empty lines and if-else blocks format in OLS related files.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-6949) Cleanup OLS code

2017-11-21 Thread Yury Babak (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-6949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16260498#comment-16260498
 ] 

Yury Babak commented on IGNITE-6949:


I reviewed this PR, looks good for me.

> Cleanup OLS code
> 
>
> Key: IGNITE-6949
> URL: https://issues.apache.org/jira/browse/IGNITE-6949
> Project: Ignite
>  Issue Type: Bug
>  Components: ml
>Reporter: Yury Babak
>Assignee: Aleksey Zinoviev
> Fix For: 2.4
>
>
> We want fix wrong styles like wildcards in imports, unnecessary empty lines, 
> missed empty lines and if-else blocks format in OLS related files.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-6949) Cleanup OLS code

2017-11-17 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-6949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16257156#comment-16257156
 ] 

ASF GitHub Bot commented on IGNITE-6949:


GitHub user zaleslaw opened a pull request:

https://github.com/apache/ignite/pull/3063

IGNITE-6949: Add support of distributed matrices for OLS regression



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gridgain/apache-ignite ignite-6949

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/3063.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3063


commit b84d1b6ae284edaa510f7eefa84f5594dd1cb83e
Author: zaleslaw 
Date:   2017-11-17T14:44:05Z

Removed incorrect patch

commit 401a464c6bde19bbf1f11d0d32a2aea9facc
Author: zaleslaw 
Date:   2017-11-17T15:11:09Z

Added OLS Distributed support

commit 9701adc7957ef20cc84eeef3394634dabb6a9af0
Author: zaleslaw 
Date:   2017-11-17T15:55:07Z

Fixed code style




> Cleanup OLS code
> 
>
> Key: IGNITE-6949
> URL: https://issues.apache.org/jira/browse/IGNITE-6949
> Project: Ignite
>  Issue Type: Bug
>  Security Level: Public(Viewable by anyone) 
>  Components: ml
>Reporter: Yury Babak
>Assignee: Aleksey Zinoviev
> Fix For: 2.4
>
>
> We want fix wrong styles like wildcards in imports, unnecessary empty lines, 
> missed empty lines and if-else blocks format in OLS related files.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)