[jira] [Commented] (IGNITE-7192) JDBC: support FQDN to multiple IPs during connection establishment
[ https://issues.apache.org/jira/browse/IGNITE-7192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16366799#comment-16366799 ] ASF GitHub Bot commented on IGNITE-7192: Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/3439 > JDBC: support FQDN to multiple IPs during connection establishment > -- > > Key: IGNITE-7192 > URL: https://issues.apache.org/jira/browse/IGNITE-7192 > Project: Ignite > Issue Type: Improvement > Components: jdbc >Affects Versions: 2.1 >Reporter: Alexey Popov >Assignee: Roman Guseinov >Priority: Major > Labels: pull-request-available > > Thin JDBC driver may have FQDN (host name) at a connection string. > Currently, it resolves this FQDN to one IP and tries to connect to this IP > only. > It is better to try to connect to multiple IPs one-by-one if DNS returns > multiple A-records (FQDN can be resolved to several IPs) until successful > connection. It could give a simple fallback option for the JDBC thin driver > users. > A similar functionality is already implemented in ODBC driver. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-7192) JDBC: support FQDN to multiple IPs during connection establishment
[ https://issues.apache.org/jira/browse/IGNITE-7192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16366704#comment-16366704 ] Roman Guseinov commented on IGNITE-7192: Latest tests results: https://ci.ignite.apache.org/viewLog.html?buildId=1096565; > JDBC: support FQDN to multiple IPs during connection establishment > -- > > Key: IGNITE-7192 > URL: https://issues.apache.org/jira/browse/IGNITE-7192 > Project: Ignite > Issue Type: Improvement > Components: jdbc >Affects Versions: 2.1 >Reporter: Alexey Popov >Assignee: Roman Guseinov >Priority: Major > Labels: pull-request-available > > Thin JDBC driver may have FQDN (host name) at a connection string. > Currently, it resolves this FQDN to one IP and tries to connect to this IP > only. > It is better to try to connect to multiple IPs one-by-one if DNS returns > multiple A-records (FQDN can be resolved to several IPs) until successful > connection. It could give a simple fallback option for the JDBC thin driver > users. > A similar functionality is already implemented in ODBC driver. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-7192) JDBC: support FQDN to multiple IPs during connection establishment
[ https://issues.apache.org/jira/browse/IGNITE-7192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16365782#comment-16365782 ] Roman Guseinov commented on IGNITE-7192: [~vozerov] , could you please review the PR ([https://github.com/apache/ignite/pull/3439])? Thanks. > JDBC: support FQDN to multiple IPs during connection establishment > -- > > Key: IGNITE-7192 > URL: https://issues.apache.org/jira/browse/IGNITE-7192 > Project: Ignite > Issue Type: Improvement > Components: jdbc >Affects Versions: 2.1 >Reporter: Alexey Popov >Assignee: Roman Guseinov >Priority: Major > Labels: pull-request-available > > Thin JDBC driver may have FQDN (host name) at a connection string. > Currently, it resolves this FQDN to one IP and tries to connect to this IP > only. > It is better to try to connect to multiple IPs one-by-one if DNS returns > multiple A-records (FQDN can be resolved to several IPs) until successful > connection. It could give a simple fallback option for the JDBC thin driver > users. > A similar functionality is already implemented in ODBC driver. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-7192) JDBC: support FQDN to multiple IPs during connection establishment
[ https://issues.apache.org/jira/browse/IGNITE-7192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355421#comment-16355421 ] Sergey Kalashnikov commented on IGNITE-7192: [~guseinov], looks good to me now. Thanks > JDBC: support FQDN to multiple IPs during connection establishment > -- > > Key: IGNITE-7192 > URL: https://issues.apache.org/jira/browse/IGNITE-7192 > Project: Ignite > Issue Type: Improvement > Components: jdbc >Affects Versions: 2.1 >Reporter: Alexey Popov >Assignee: Roman Guseinov >Priority: Major > Labels: pull-request-available > > Thin JDBC driver may have FQDN (host name) at a connection string. > Currently, it resolves this FQDN to one IP and tries to connect to this IP > only. > It is better to try to connect to multiple IPs one-by-one if DNS returns > multiple A-records (FQDN can be resolved to several IPs) until successful > connection. It could give a simple fallback option for the JDBC thin driver > users. > A similar functionality is already implemented in ODBC driver. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-7192) JDBC: support FQDN to multiple IPs during connection establishment
[ https://issues.apache.org/jira/browse/IGNITE-7192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349997#comment-16349997 ] Roman Guseinov commented on IGNITE-7192: [~skalashnikov], Thanks for your comments. Added one more commit to fix style violations. Please take a look. > JDBC: support FQDN to multiple IPs during connection establishment > -- > > Key: IGNITE-7192 > URL: https://issues.apache.org/jira/browse/IGNITE-7192 > Project: Ignite > Issue Type: Improvement > Components: jdbc >Affects Versions: 2.1 >Reporter: Alexey Popov >Assignee: Roman Guseinov >Priority: Major > Labels: pull-request-available > > Thin JDBC driver may have FQDN (host name) at a connection string. > Currently, it resolves this FQDN to one IP and tries to connect to this IP > only. > It is better to try to connect to multiple IPs one-by-one if DNS returns > multiple A-records (FQDN can be resolved to several IPs) until successful > connection. It could give a simple fallback option for the JDBC thin driver > users. > A similar functionality is already implemented in ODBC driver. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-7192) JDBC: support FQDN to multiple IPs during connection establishment
[ https://issues.apache.org/jira/browse/IGNITE-7192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16348297#comment-16348297 ] Sergey Kalashnikov commented on IGNITE-7192: [~guseinov], Please correct the coding style across code and tests (see https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines) I noticed multiple style violations: - Braces style in try/catch - Braces around multi- and single-line operators. - @Override must be on the same line as the function name. - No empty line between the function description and params in javadoc. - Use of empty lines between statements. > JDBC: support FQDN to multiple IPs during connection establishment > -- > > Key: IGNITE-7192 > URL: https://issues.apache.org/jira/browse/IGNITE-7192 > Project: Ignite > Issue Type: Improvement > Components: jdbc >Affects Versions: 2.1 >Reporter: Alexey Popov >Assignee: Roman Guseinov >Priority: Major > Labels: pull-request-available > > Thin JDBC driver may have FQDN (host name) at a connection string. > Currently, it resolves this FQDN to one IP and tries to connect to this IP > only. > It is better to try to connect to multiple IPs one-by-one if DNS returns > multiple A-records (FQDN can be resolved to several IPs) until successful > connection. It could give a simple fallback option for the JDBC thin driver > users. > A similar functionality is already implemented in ODBC driver. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-7192) JDBC: support FQDN to multiple IPs during connection establishment
[ https://issues.apache.org/jira/browse/IGNITE-7192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16345055#comment-16345055 ] Roman Guseinov commented on IGNITE-7192: [~tledkov-gridgain], thanks for your comments. Added necessary changes. Tests passed: [https://ci.ignite.apache.org/viewLog.html?buildId=1066468=buildResultsDiv=IgniteTests24Java8_IgniteJdbcDriver.] [~vozerov] and [~skalashnikov], could you take a look at PR [https://github.com/apache/ignite/pull/3439] please? > JDBC: support FQDN to multiple IPs during connection establishment > -- > > Key: IGNITE-7192 > URL: https://issues.apache.org/jira/browse/IGNITE-7192 > Project: Ignite > Issue Type: Improvement > Components: jdbc >Affects Versions: 2.1 >Reporter: Alexey Popov >Assignee: Roman Guseinov >Priority: Major > Labels: pull-request-available > > Thin JDBC driver may have FQDN (host name) at a connection string. > Currently, it resolves this FQDN to one IP and tries to connect to this IP > only. > It is better to try to connect to multiple IPs one-by-one if DNS returns > multiple A-records (FQDN can be resolved to several IPs) until successful > connection. It could give a simple fallback option for the JDBC thin driver > users. > A similar functionality is already implemented in ODBC driver. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-7192) JDBC: support FQDN to multiple IPs during connection establishment
[
https://issues.apache.org/jira/browse/IGNITE-7192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344740#comment-16344740
]
Taras Ledkov commented on IGNITE-7192:
--
[~guseinov], my comments:
1. Please fix javadoc for: {{JdbcThinTcpIo#getAllAddressesByHost}};
2. Now all connection exceptions are swallowed. Please collect the errors and
provide correct reason for {{SQLException}} in case all address are
inaccessible. e.g. you can use the {{Throwable#addSuppressed}} for it.
> JDBC: support FQDN to multiple IPs during connection establishment
> --
>
> Key: IGNITE-7192
> URL: https://issues.apache.org/jira/browse/IGNITE-7192
> Project: Ignite
> Issue Type: Improvement
> Components: jdbc
>Affects Versions: 2.1
>Reporter: Alexey Popov
>Assignee: Roman Guseinov
>Priority: Major
> Labels: pull-request-available
>
> Thin JDBC driver may have FQDN (host name) at a connection string.
> Currently, it resolves this FQDN to one IP and tries to connect to this IP
> only.
> It is better to try to connect to multiple IPs one-by-one if DNS returns
> multiple A-records (FQDN can be resolved to several IPs) until successful
> connection. It could give a simple fallback option for the JDBC thin driver
> users.
> A similar functionality is already implemented in ODBC driver.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-7192) JDBC: support FQDN to multiple IPs during connection establishment
[ https://issues.apache.org/jira/browse/IGNITE-7192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344720#comment-16344720 ] Roman Guseinov commented on IGNITE-7192: "Ignite JDBC Driver" tests results: https://ci.ignite.apache.org/viewLog.html?buildTypeId=IgniteTests24Java8_IgniteJdbcDriver=1065909_IgniteTests24Java8_IgniteJdbcDriver=pull/3439/head > JDBC: support FQDN to multiple IPs during connection establishment > -- > > Key: IGNITE-7192 > URL: https://issues.apache.org/jira/browse/IGNITE-7192 > Project: Ignite > Issue Type: Improvement > Components: jdbc >Affects Versions: 2.1 >Reporter: Alexey Popov >Assignee: Roman Guseinov >Priority: Major > Labels: pull-request-available > > Thin JDBC driver may have FQDN (host name) at a connection string. > Currently, it resolves this FQDN to one IP and tries to connect to this IP > only. > It is better to try to connect to multiple IPs one-by-one if DNS returns > multiple A-records (FQDN can be resolved to several IPs) until successful > connection. It could give a simple fallback option for the JDBC thin driver > users. > A similar functionality is already implemented in ODBC driver. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-7192) JDBC: support FQDN to multiple IPs during connection establishment
[ https://issues.apache.org/jira/browse/IGNITE-7192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16340659#comment-16340659 ] Roman Guseinov commented on IGNITE-7192: [~alexey.tank2], please review the PR (https://github.com/apache/ignite/pull/3439): * Implemented connection to host's IP-addresses one by one. * Added unit tests. Thanks. > JDBC: support FQDN to multiple IPs during connection establishment > -- > > Key: IGNITE-7192 > URL: https://issues.apache.org/jira/browse/IGNITE-7192 > Project: Ignite > Issue Type: Improvement > Components: jdbc >Affects Versions: 2.1 >Reporter: Alexey Popov >Assignee: Roman Guseinov >Priority: Major > > Thin JDBC driver may have FQDN (host name) at a connection string. > Currently, it resolves this FQDN to one IP and tries to connect to this IP > only. > It is better to try to connect to multiple IPs one-by-one if DNS returns > multiple A-records (FQDN can be resolved to several IPs) until successful > connection. It could give a simple fallback option for the JDBC thin driver > users. > A similar functionality is already implemented in ODBC driver. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
