[jira] [Commented] (IGNITE-7481) Suspended transaction rollbacs incorrectly

[Alexey Kuznetsov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-7481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16426772#comment-16426772
 ] 

Alexey Kuznetsov commented on IGNITE-7481:
--

[~NIzhikov] cool, thx

> Suspended transaction rollbacs incorrectly  
> 
>
> Key: IGNITE-7481
> URL: https://issues.apache.org/jira/browse/IGNITE-7481
> Project: Ignite
>  Issue Type: Bug
>Reporter: Alexey Kuznetsov
>Assignee: Alexey Kuznetsov
>Priority: Major
> Fix For: 2.5
>
>
> When we suspend transaction, and then timeout occures , transaction would be 
> rollbacked incorrectly.
> One of incorrect behaviors : rollback\end tx metrics are not incremented.
> Thre reason is that transactionMap is cleared when we suspend transaction.
> We need not clear transactionMap.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-7481) Suspended transaction rollbacs incorrectly

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-7481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16426762#comment-16426762
 ] 

ASF GitHub Bot commented on IGNITE-7481:


Github user asfgit closed the pull request at:

https://github.com/apache/ignite/pull/3514


> Suspended transaction rollbacs incorrectly  
> 
>
> Key: IGNITE-7481
> URL: https://issues.apache.org/jira/browse/IGNITE-7481
> Project: Ignite
>  Issue Type: Bug
>Reporter: Alexey Kuznetsov
>Assignee: Alexey Kuznetsov
>Priority: Major
> Fix For: 2.5
>
>
> When we suspend transaction, and then timeout occures , transaction would be 
> rollbacked incorrectly.
> One of incorrect behaviors : rollback\end tx metrics are not incremented.
> Thre reason is that transactionMap is cleared when we suspend transaction.
> We need not clear transactionMap.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-7481) Suspended transaction rollbacs incorrectly

[Nikolay Izhikov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-7481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16422939#comment-16422939
 ] 

Nikolay Izhikov commented on IGNITE-7481:
-

[~Alexey Kuznetsov] I don't like current implementation.

We have to fix the described issue as is.
>From my point of view, the root of the problem is next: Transaction doesn't 
>get resumed on timeout.
To fix a metric issue and all other possible issues we have to {{resume}} 
suspended transaction prior to other timeout actions.

Thoughts?

> Suspended transaction rollbacs incorrectly  
> 
>
> Key: IGNITE-7481
> URL: https://issues.apache.org/jira/browse/IGNITE-7481
> Project: Ignite
>  Issue Type: Bug
>Reporter: Alexey Kuznetsov
>Assignee: Alexey Kuznetsov
>Priority: Major
> Fix For: 2.5
>
>
> When we suspend transaction, and then timeout occures , transaction would be 
> rollbacked incorrectly.
> One of incorrect behaviors : rollback\end tx metrics are not incremented.
> Thre reason is that transactionMap is cleared when we suspend transaction.
> We need not clear transactionMap.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-7481) Suspended transaction rollbacs incorrectly

[Vitaliy Biryukov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-7481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16418707#comment-16418707
 ] 

Vitaliy Biryukov commented on IGNITE-7481:
--

[~Alexey Kuznetsov] LGTM.

> Suspended transaction rollbacs incorrectly  
> 
>
> Key: IGNITE-7481
> URL: https://issues.apache.org/jira/browse/IGNITE-7481
> Project: Ignite
>  Issue Type: Bug
>Reporter: Alexey Kuznetsov
>Assignee: Alexey Kuznetsov
>Priority: Major
> Fix For: 2.5
>
>
> When we suspend transaction, and then timeout occures , transaction would be 
> rollbacked incorrectly.
> One of incorrect behaviors : rollback\end tx metrics are not incremented.
> Thre reason is that transactionMap is cleared when we suspend transaction.
> We need not clear transactionMap.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-7481) Suspended transaction rollbacs incorrectly

[Aleksey Plekhanov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-7481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417310#comment-16417310
 ] 

Aleksey Plekhanov commented on IGNITE-7481:
---

[~Alexey Kuznetsov] looks good to me.

> Suspended transaction rollbacs incorrectly  
> 
>
> Key: IGNITE-7481
> URL: https://issues.apache.org/jira/browse/IGNITE-7481
> Project: Ignite
>  Issue Type: Bug
>Reporter: Alexey Kuznetsov
>Assignee: Alexey Kuznetsov
>Priority: Major
> Fix For: 2.5
>
>
> When we suspend transaction, and then timeout occures , transaction would be 
> rollbacked incorrectly.
> One of incorrect behaviors : rollback\end tx metrics are not incremented.
> Thre reason is that transactionMap is cleared when we suspend transaction.
> We need not clear transactionMap.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-7481) Suspended transaction rollbacs incorrectly

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-7481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362471#comment-16362471
 ] 

ASF GitHub Bot commented on IGNITE-7481:


GitHub user voipp opened a pull request:

https://github.com/apache/ignite/pull/3514

IGNITE-7481 suspended tx timeout rollback fix



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/voipp/ignite IGNITE-7481

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/3514.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3514


commit ef84639e627b3a7060da960dd61c21a6ffebdbf1
Author: voipp 
Date:   2018-02-13T15:15:00Z

IGNITE-7481 suspended tx timeout rollback fix




> Suspended transaction rollbacs incorrectly  
> 
>
> Key: IGNITE-7481
> URL: https://issues.apache.org/jira/browse/IGNITE-7481
> Project: Ignite
>  Issue Type: Bug
>Reporter: Alexey Kuznetsov
>Assignee: Alexey Kuznetsov
>Priority: Major
>
> When we suspend transaction, and then timeout occures , transaction would be 
> rollbacked incorrectly.
> One of incorrect behaviors : rollback\end tx metrics are not incremented.
> Thre reason is that transactionMap is cleared when we suspend transaction.
> We need not clear transactionMap.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)