[jira] [Commented] (IGNITE-7504) Decision tree documentation
[ https://issues.apache.org/jira/browse/IGNITE-7504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351075#comment-16351075 ] Denis Magda commented on IGNITE-7504: - [~oignatenko], [~amalykh] , thanks. All looks good to me. [~pgarg] , please do a final review and close the ticket: [https://dash.readme.io/project/apacheignite/v2.3/docs/decision-trees-24] > Decision tree documentation > --- > > Key: IGNITE-7504 > URL: https://issues.apache.org/jira/browse/IGNITE-7504 > Project: Ignite > Issue Type: Task > Components: documentation, ml >Reporter: Yury Babak >Assignee: Denis Magda >Priority: Major > Labels: documentation > Fix For: 2.4 > > > We want to add Decision tree documentation -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-7504) Decision tree documentation
[ https://issues.apache.org/jira/browse/IGNITE-7504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16347438#comment-16347438 ] Oleg Ignatenko commented on IGNITE-7504: Approach with adding dataset to examples directory doesn't look viable because of licensing considerations (discussed in a bit more details in IGNITE-7593). Because of that we picked a bit different way that still requires upload from external URL but decreases user involvement to absolute minimum, that is they need to just pick yes or no when prompted whether to download data. This is implemented in IGNITE-7590. In order to try further improve data used in this example I opened a dedicated ticket IGNITE-7593. I targeted this ticket for next release (2.5) because it looks rather time consuming and is unlikely to fit into timeframe of release 2.4. [~dmagda] I would appreciate if you take a look at considerations laid out above. If you have further questions or suggestions please let us know. > Decision tree documentation > --- > > Key: IGNITE-7504 > URL: https://issues.apache.org/jira/browse/IGNITE-7504 > Project: Ignite > Issue Type: Task > Components: documentation, ml >Reporter: Yury Babak >Assignee: Yury Babak >Priority: Major > Labels: documentation > Fix For: 2.4 > > > We want to add Decision tree documentation -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-7504) Decision tree documentation
[
https://issues.apache.org/jira/browse/IGNITE-7504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16340258#comment-16340258
]
Denis Magda commented on IGNITE-7504:
-
[~amalykh] , [~chief] :
* look for TODOs in the doc and help to fix the unclear parts.
* Why is the example class called {{MNISTExample}}? Let's rename it to
DecisionTreesExample. Otherwise, people won't get what's inside.
* The MNISTExampe has several problems itself:
** some of the lines' width takes more than 120 columns
([https://stackoverflow.com/questions/24355976/how-to-change-line-width-in-intellij-from-120-character)]
** {{cfg.setEvictionPolicy(null);}} is deprecated
**
{{cfg.setAtomicityMode(CacheAtomicityMode.ATOMIC);}}cfg.setCacheMode(CacheMode.PARTITIONED);
cfg.setBackups(0); - these are already default parameters! Clean the code
please.
> Decision tree documentation
> ---
>
> Key: IGNITE-7504
> URL: https://issues.apache.org/jira/browse/IGNITE-7504
> Project: Ignite
> Issue Type: Task
> Components: documentation, ml
>Reporter: Yury Babak
>Assignee: Denis Magda
>Priority: Major
> Labels: documentation
> Fix For: 2.4
>
>
> We want to add Decision tree documentation
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-7504) Decision tree documentation
[ https://issues.apache.org/jira/browse/IGNITE-7504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337662#comment-16337662 ] Artem Malykh commented on IGNITE-7504: -- [~dmagda] , please review the doc: [https://dash.readme.io/project/apacheignite/v2.3/docs/decision-trees-24] . > Decision tree documentation > --- > > Key: IGNITE-7504 > URL: https://issues.apache.org/jira/browse/IGNITE-7504 > Project: Ignite > Issue Type: Task > Components: documentation, ml >Reporter: Yury Babak >Assignee: Artem Malykh >Priority: Major > Labels: documentation > Fix For: 2.4 > > > We want to add Decision tree documentation -- This message was sent by Atlassian JIRA (v7.6.3#76005)
