[jira] [Commented] (IGNITE-7694) testActiveClientReconnectToInactiveCluster hangs because of an assertion

2018-02-16 Thread Alexey Goncharuk (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-7694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16366691#comment-16366691
 ] 

Alexey Goncharuk commented on IGNITE-7694:
--

Merged to master

> testActiveClientReconnectToInactiveCluster hangs because of an assertion
> 
>
> Key: IGNITE-7694
> URL: https://issues.apache.org/jira/browse/IGNITE-7694
> Project: Ignite
>  Issue Type: Bug
>  Components: persistence
>Affects Versions: 2.5
>Reporter: Alexey Goncharuk
>Assignee: Alexey Goncharuk
>Priority: Major
>  Labels: MakeTeamcityGreenAgain
> Fix For: 2.5
>
>
> This is a regression from
> The test hangs because there is an assertion happened after the client 
> reconnects to the cluster:
> {code}
> [2018-02-13 
> 19:36:33,559][ERROR][tcp-client-disco-msg-worker-#18%nodeClient%][TcpDiscoverySpi]
>  Failed to unmarshal discovery custom message.
> java.lang.AssertionError: lastAffVer=AffinityTopologyVersion [topVer=4, 
> minorTopVer=0], topVer=AffinityTopologyVersion [topVer=3, minorTopVer=1]
>   at 
> org.apache.ignite.internal.processors.cache.CacheAffinitySharedManager.onDiscoveryEvent(CacheAffinitySharedManager.java:185)
>   at 
> org.apache.ignite.internal.processors.cache.GridCacheProcessor.onDiscoveryEvent(GridCacheProcessor.java:3231)
>   at 
> org.apache.ignite.internal.managers.discovery.GridDiscoveryManager$4.onDiscovery0(GridDiscoveryManager.java:681)
>   at 
> org.apache.ignite.internal.managers.discovery.GridDiscoveryManager$4.onDiscovery(GridDiscoveryManager.java:576)
>   at 
> org.apache.ignite.spi.discovery.tcp.ClientImpl$MessageWorker.notifyDiscovery(ClientImpl.java:2414)
>   at 
> org.apache.ignite.spi.discovery.tcp.ClientImpl$MessageWorker.processCustomMessage(ClientImpl.java:2320)
>   at 
> org.apache.ignite.spi.discovery.tcp.ClientImpl$MessageWorker.processDiscoveryMessage(ClientImpl.java:1897)
>   at 
> org.apache.ignite.spi.discovery.tcp.ClientImpl$MessageWorker.body(ClientImpl.java:1781)
>   at org.apache.ignite.spi.IgniteSpiThread.run(IgniteSpiThread.java:62)
> {code}
> The reason for the assertion is that the client does not clear {{lastAffVer}} 
> field when disconnected, and cluster is restarted when the client is in the 
> disconnected state.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-7694) testActiveClientReconnectToInactiveCluster hangs because of an assertion

2018-02-15 Thread Ilya Lantukh (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-7694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16365963#comment-16365963
 ] 

Ilya Lantukh commented on IGNITE-7694:
--

Looks good.

> testActiveClientReconnectToInactiveCluster hangs because of an assertion
> 
>
> Key: IGNITE-7694
> URL: https://issues.apache.org/jira/browse/IGNITE-7694
> Project: Ignite
>  Issue Type: Bug
>  Components: persistence
>Affects Versions: 2.5
>Reporter: Alexey Goncharuk
>Assignee: Alexey Goncharuk
>Priority: Major
>  Labels: MakeTeamcityGreenAgain
> Fix For: 2.5
>
>
> This is a regression from
> The test hangs because there is an assertion happened after the client 
> reconnects to the cluster:
> {code}
> [2018-02-13 
> 19:36:33,559][ERROR][tcp-client-disco-msg-worker-#18%nodeClient%][TcpDiscoverySpi]
>  Failed to unmarshal discovery custom message.
> java.lang.AssertionError: lastAffVer=AffinityTopologyVersion [topVer=4, 
> minorTopVer=0], topVer=AffinityTopologyVersion [topVer=3, minorTopVer=1]
>   at 
> org.apache.ignite.internal.processors.cache.CacheAffinitySharedManager.onDiscoveryEvent(CacheAffinitySharedManager.java:185)
>   at 
> org.apache.ignite.internal.processors.cache.GridCacheProcessor.onDiscoveryEvent(GridCacheProcessor.java:3231)
>   at 
> org.apache.ignite.internal.managers.discovery.GridDiscoveryManager$4.onDiscovery0(GridDiscoveryManager.java:681)
>   at 
> org.apache.ignite.internal.managers.discovery.GridDiscoveryManager$4.onDiscovery(GridDiscoveryManager.java:576)
>   at 
> org.apache.ignite.spi.discovery.tcp.ClientImpl$MessageWorker.notifyDiscovery(ClientImpl.java:2414)
>   at 
> org.apache.ignite.spi.discovery.tcp.ClientImpl$MessageWorker.processCustomMessage(ClientImpl.java:2320)
>   at 
> org.apache.ignite.spi.discovery.tcp.ClientImpl$MessageWorker.processDiscoveryMessage(ClientImpl.java:1897)
>   at 
> org.apache.ignite.spi.discovery.tcp.ClientImpl$MessageWorker.body(ClientImpl.java:1781)
>   at org.apache.ignite.spi.IgniteSpiThread.run(IgniteSpiThread.java:62)
> {code}
> The reason for the assertion is that the client does not clear {{lastAffVer}} 
> field when disconnected, and cluster is restarted when the client is in the 
> disconnected state.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-7694) testActiveClientReconnectToInactiveCluster hangs because of an assertion

2018-02-14 Thread Alexey Goncharuk (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-7694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16363647#comment-16363647
 ] 

Alexey Goncharuk commented on IGNITE-7694:
--

[~ilantukh] Can you please review my changes?

The branch is ignite-7694.
TC Run: 
https://ci.ignite.apache.org/project.html?projectId=IgniteTests24Java8_IgniteTests24Java8=ignite-7694

> testActiveClientReconnectToInactiveCluster hangs because of an assertion
> 
>
> Key: IGNITE-7694
> URL: https://issues.apache.org/jira/browse/IGNITE-7694
> Project: Ignite
>  Issue Type: Bug
>  Components: persistence
>Affects Versions: 2.5
>Reporter: Alexey Goncharuk
>Assignee: Alexey Goncharuk
>Priority: Major
>  Labels: MakeTeamcityGreenAgain
> Fix For: 2.5
>
>
> This is a regression from
> The test hangs because there is an assertion happened after the client 
> reconnects to the cluster:
> {code}
> [2018-02-13 
> 19:36:33,559][ERROR][tcp-client-disco-msg-worker-#18%nodeClient%][TcpDiscoverySpi]
>  Failed to unmarshal discovery custom message.
> java.lang.AssertionError: lastAffVer=AffinityTopologyVersion [topVer=4, 
> minorTopVer=0], topVer=AffinityTopologyVersion [topVer=3, minorTopVer=1]
>   at 
> org.apache.ignite.internal.processors.cache.CacheAffinitySharedManager.onDiscoveryEvent(CacheAffinitySharedManager.java:185)
>   at 
> org.apache.ignite.internal.processors.cache.GridCacheProcessor.onDiscoveryEvent(GridCacheProcessor.java:3231)
>   at 
> org.apache.ignite.internal.managers.discovery.GridDiscoveryManager$4.onDiscovery0(GridDiscoveryManager.java:681)
>   at 
> org.apache.ignite.internal.managers.discovery.GridDiscoveryManager$4.onDiscovery(GridDiscoveryManager.java:576)
>   at 
> org.apache.ignite.spi.discovery.tcp.ClientImpl$MessageWorker.notifyDiscovery(ClientImpl.java:2414)
>   at 
> org.apache.ignite.spi.discovery.tcp.ClientImpl$MessageWorker.processCustomMessage(ClientImpl.java:2320)
>   at 
> org.apache.ignite.spi.discovery.tcp.ClientImpl$MessageWorker.processDiscoveryMessage(ClientImpl.java:1897)
>   at 
> org.apache.ignite.spi.discovery.tcp.ClientImpl$MessageWorker.body(ClientImpl.java:1781)
>   at org.apache.ignite.spi.IgniteSpiThread.run(IgniteSpiThread.java:62)
> {code}
> The reason for the assertion is that the client does not clear {{lastAffVer}} 
> field when disconnected, and cluster is restarted when the client is in the 
> disconnected state.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-7694) testActiveClientReconnectToInactiveCluster hangs because of an assertion

2018-02-13 Thread Alexey Goncharuk (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-7694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362611#comment-16362611
 ] 

Alexey Goncharuk commented on IGNITE-7694:
--

At the first glance, setting lastAffVer to null in the onDisconnected callback 
fixes the issue.

> testActiveClientReconnectToInactiveCluster hangs because of an assertion
> 
>
> Key: IGNITE-7694
> URL: https://issues.apache.org/jira/browse/IGNITE-7694
> Project: Ignite
>  Issue Type: Bug
>  Components: persistence
>Affects Versions: 2.5
>Reporter: Alexey Goncharuk
>Assignee: Alexey Goncharuk
>Priority: Major
> Fix For: 2.5
>
>
> This is a regression from
> The test hangs because there is an assertion happened after the client 
> reconnects to the cluster:
> {code}
> [2018-02-13 
> 19:36:33,559][ERROR][tcp-client-disco-msg-worker-#18%nodeClient%][TcpDiscoverySpi]
>  Failed to unmarshal discovery custom message.
> java.lang.AssertionError: lastAffVer=AffinityTopologyVersion [topVer=4, 
> minorTopVer=0], topVer=AffinityTopologyVersion [topVer=3, minorTopVer=1]
>   at 
> org.apache.ignite.internal.processors.cache.CacheAffinitySharedManager.onDiscoveryEvent(CacheAffinitySharedManager.java:185)
>   at 
> org.apache.ignite.internal.processors.cache.GridCacheProcessor.onDiscoveryEvent(GridCacheProcessor.java:3231)
>   at 
> org.apache.ignite.internal.managers.discovery.GridDiscoveryManager$4.onDiscovery0(GridDiscoveryManager.java:681)
>   at 
> org.apache.ignite.internal.managers.discovery.GridDiscoveryManager$4.onDiscovery(GridDiscoveryManager.java:576)
>   at 
> org.apache.ignite.spi.discovery.tcp.ClientImpl$MessageWorker.notifyDiscovery(ClientImpl.java:2414)
>   at 
> org.apache.ignite.spi.discovery.tcp.ClientImpl$MessageWorker.processCustomMessage(ClientImpl.java:2320)
>   at 
> org.apache.ignite.spi.discovery.tcp.ClientImpl$MessageWorker.processDiscoveryMessage(ClientImpl.java:1897)
>   at 
> org.apache.ignite.spi.discovery.tcp.ClientImpl$MessageWorker.body(ClientImpl.java:1781)
>   at org.apache.ignite.spi.IgniteSpiThread.run(IgniteSpiThread.java:62)
> {code}
> The reason for the assertion is that the client does not clear {{lastAffVer}} 
> field when disconnected, and cluster is restarted when the client is in the 
> disconnected state.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)