[jira] [Commented] (IGNITE-8097) Java thin client: throw handshake exception on connect phase

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16439144#comment-16439144
 ] 

ASF GitHub Bot commented on IGNITE-8097:


Github user asfgit closed the pull request at:

https://github.com/apache/ignite/pull/3822


> Java thin client: throw handshake exception on connect phase
> 
>
> Key: IGNITE-8097
> URL: https://issues.apache.org/jira/browse/IGNITE-8097
> Project: Ignite
>  Issue Type: Task
>  Components: thin client
>Reporter: Vladimir Ozerov
>Assignee: Alexey Kukushkin
>Priority: Major
> Fix For: 2.5
>
>
> Currently a call to {{Ignition.startClient}} return client instance even if 
> we know for sure that connection is not usable. Real exception (e.g. protocol 
> mismatch, auth error, etc.) is thrown on attempt to execute first operation 
> on the client. This is bad UX - use may think that everything is OK for a 
> long time.
> Instead, connection should be established eagerly in {{startClient}}, any 
> exception should be propagated to the user immediately.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-8097) Java thin client: throw handshake exception on connect phase

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16437550#comment-16437550
 ] 

ASF GitHub Bot commented on IGNITE-8097:


GitHub user kukushal opened a pull request:

https://github.com/apache/ignite/pull/3822

IGNITE-8097 Java thin client: throw handshake exception on connect phase



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gridgain/apache-ignite ignite-8097

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/3822.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3822


commit 2286c06b8140cd2f86b404da2271e24b0a8fe26f
Author: Alexey Kukushkin 
Date:   2018-04-13T16:39:15Z

IGNITE-8097 Java thin client: throw handshake exception on connect phase




> Java thin client: throw handshake exception on connect phase
> 
>
> Key: IGNITE-8097
> URL: https://issues.apache.org/jira/browse/IGNITE-8097
> Project: Ignite
>  Issue Type: Task
>  Components: thin client
>Reporter: Vladimir Ozerov
>Assignee: Alexey Kukushkin
>Priority: Major
> Fix For: 2.5
>
>
> Currently a call to {{Ignition.startClient}} return client instance even if 
> we know for sure that connection is not usable. Real exception (e.g. protocol 
> mismatch, auth error, etc.) is thrown on attempt to execute first operation 
> on the client. This is bad UX - use may think that everything is OK for a 
> long time.
> Instead, connection should be established eagerly in {{startClient}}, any 
> exception should be propagated to the user immediately.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)