[jira] [Commented] (IGNITE-9815) [TC Bot] Muted tests shouldn't considered as blocker
[
https://issues.apache.org/jira/browse/IGNITE-9815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16644790#comment-16644790
]
ASF GitHub Bot commented on IGNITE-9815:
asfgit closed pull request #29: IGNITE-9815: Muted tests shouldn't considered
as blocker
URL: https://github.com/apache/ignite-teamcity-bot/pull/29
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/model/current/TestFailure.java
b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/model/current/TestFailure.java
index dcd18fb..7e49ec0 100644
---
a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/model/current/TestFailure.java
+++
b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/model/current/TestFailure.java
@@ -241,6 +241,9 @@ public void initStat(@Nullable final Function runStatSupp
public boolean isNewFailedTest() {
FailureSummary recent = histBaseBranch.recent;
+if (!Strings.isNullOrEmpty(webIssueUrl))
+return false;
+
boolean lowFailureRate = recent != null && recent.failureRate != null
&&
Float.valueOf(recent.failureRate.replace(',', '.')) < 4.;
diff --git a/ignite-tc-helper-web/src/main/webapp/js/testfails-2.1.js
b/ignite-tc-helper-web/src/main/webapp/js/testfails-2.1.js
index b61189b..e1c995c 100644
--- a/ignite-tc-helper-web/src/main/webapp/js/testfails-2.1.js
+++ b/ignite-tc-helper-web/src/main/webapp/js/testfails-2.1.js
@@ -627,8 +627,12 @@ function isNewFailedTest(testFail) {
if(!isDefinedAndFilled(testFail.histBaseBranch))
return true;
+if (testFail.webIssueUrl)
+return false;
+
var hist = testFail.histBaseBranch;
-if(!isDefinedAndFilled(hist.recent))
+
+if (!isDefinedAndFilled(hist.recent))
return true;
var flakyCommentsInBase =
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [TC Bot] Muted tests shouldn't considered as blocker
>
>
> Key: IGNITE-9815
> URL: https://issues.apache.org/jira/browse/IGNITE-9815
> Project: Ignite
> Issue Type: Bug
>Reporter: Nikolay Izhikov
>Assignee: Ryabov Dmitrii
>Priority: Major
>
> Currently, TC bot doesn't analyze stack trace of test fail [1].
> If some test failed with the link to Ignite ticket it shouldn't be considered
> as a blocker.
> Link with examples of such behaviour:
> {noformat}
> IgniteCacheMvccTestSuite: DataStreamProcessorMvccSelfTest.testColocated -
> 0,0% fails in last 100 master runs.
> IgniteCacheMvccTestSuite: DataStreamProcessorMvccSelfTest.testPartitioned -
> 0,0% fails in last 100 master runs.
> IgniteCacheMvccTestSuite: DataStreamProcessorMvccSelfTest.testReplicated -
> 0,0% fails in last 100 master runs.
> {noformat}
> stack trace:
> {noformat}
> unit.framework.AssertionFailedError:
> https://issues.apache.org/jira/browse/IGNITE-9722
> at
> org.apache.ignite.internal.processors.cache.mvcc.CacheMvccTransactionsTest.testMvccCoordinatorChangeSimple(CacheMvccTransactionsTest.java:2387)
> {noformat}
> https://issues.apache.org/jira/browse/IGNITE-9272?focusedCommentId=16641617=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16641617
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-9815) [TC Bot] Muted tests shouldn't considered as blocker
[
https://issues.apache.org/jira/browse/IGNITE-9815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16643125#comment-16643125
]
ASF GitHub Bot commented on IGNITE-9815:
SomeFire opened a new pull request #29: IGNITE-9815: Muted tests shouldn't
considered as blocker
URL: https://github.com/apache/ignite-teamcity-bot/pull/29
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [TC Bot] Muted tests shouldn't considered as blocker
>
>
> Key: IGNITE-9815
> URL: https://issues.apache.org/jira/browse/IGNITE-9815
> Project: Ignite
> Issue Type: Bug
>Reporter: Nikolay Izhikov
>Assignee: Ryabov Dmitrii
>Priority: Major
>
> Currently, TC bot doesn't analyze stack trace of test fail [1].
> If some test failed with the link to Ignite ticket it shouldn't be considered
> as a blocker.
> Link with examples of such behaviour:
> {noformat}
> IgniteCacheMvccTestSuite: DataStreamProcessorMvccSelfTest.testColocated -
> 0,0% fails in last 100 master runs.
> IgniteCacheMvccTestSuite: DataStreamProcessorMvccSelfTest.testPartitioned -
> 0,0% fails in last 100 master runs.
> IgniteCacheMvccTestSuite: DataStreamProcessorMvccSelfTest.testReplicated -
> 0,0% fails in last 100 master runs.
> {noformat}
> stack trace:
> {noformat}
> unit.framework.AssertionFailedError:
> https://issues.apache.org/jira/browse/IGNITE-9722
> at
> org.apache.ignite.internal.processors.cache.mvcc.CacheMvccTransactionsTest.testMvccCoordinatorChangeSimple(CacheMvccTransactionsTest.java:2387)
> {noformat}
> https://issues.apache.org/jira/browse/IGNITE-9272?focusedCommentId=16641617=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16641617
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-9815) [TC Bot] Muted tests shouldn't considered as blocker
[
https://issues.apache.org/jira/browse/IGNITE-9815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641882#comment-16641882
]
Ryabov Dmitrii commented on IGNITE-9815:
I think we can find such errors and ignore them for possible blockers. This can
be done as part of
[IGNITE-9640|https://issues.apache.org/jira/browse/IGNITE-9640].
> [TC Bot] Muted tests shouldn't considered as blocker
>
>
> Key: IGNITE-9815
> URL: https://issues.apache.org/jira/browse/IGNITE-9815
> Project: Ignite
> Issue Type: Bug
>Reporter: Nikolay Izhikov
>Priority: Major
>
> Currently, TC bot doesn't analyze stack trace of test fail [1].
> If some test failed with the link to Ignite ticket it shouldn't be considered
> as a blocker.
> Link with examples of such behaviour:
> {noformat}
> IgniteCacheMvccTestSuite: DataStreamProcessorMvccSelfTest.testColocated -
> 0,0% fails in last 100 master runs.
> IgniteCacheMvccTestSuite: DataStreamProcessorMvccSelfTest.testPartitioned -
> 0,0% fails in last 100 master runs.
> IgniteCacheMvccTestSuite: DataStreamProcessorMvccSelfTest.testReplicated -
> 0,0% fails in last 100 master runs.
> {noformat}
> stack trace:
> {noformat}
> unit.framework.AssertionFailedError:
> https://issues.apache.org/jira/browse/IGNITE-9722
> at
> org.apache.ignite.internal.processors.cache.mvcc.CacheMvccTransactionsTest.testMvccCoordinatorChangeSimple(CacheMvccTransactionsTest.java:2387)
> {noformat}
> https://issues.apache.org/jira/browse/IGNITE-9272?focusedCommentId=16641617=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16641617
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-9815) [TC Bot] Muted tests shouldn't considered as blocker
[
https://issues.apache.org/jira/browse/IGNITE-9815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641811#comment-16641811
]
Ryabov Dmitrii commented on IGNITE-9815:
[~NIzhikov], tests you are talking about are not muted. They are fails by the
code, but TeamCity know nothing about the code. Muted test means it is muted in
the TeamCity.
> [TC Bot] Muted tests shouldn't considered as blocker
>
>
> Key: IGNITE-9815
> URL: https://issues.apache.org/jira/browse/IGNITE-9815
> Project: Ignite
> Issue Type: Bug
>Reporter: Nikolay Izhikov
>Priority: Major
>
> Currently, TC bot doesn't analyze stack trace of test fail [1].
> If some test failed with the link to Ignite ticket it shouldn't be considered
> as a blocker.
> Link with examples of such behaviour:
> {noformat}
> IgniteCacheMvccTestSuite: DataStreamProcessorMvccSelfTest.testColocated -
> 0,0% fails in last 100 master runs.
> IgniteCacheMvccTestSuite: DataStreamProcessorMvccSelfTest.testPartitioned -
> 0,0% fails in last 100 master runs.
> IgniteCacheMvccTestSuite: DataStreamProcessorMvccSelfTest.testReplicated -
> 0,0% fails in last 100 master runs.
> {noformat}
> stack trace:
> {noformat}
> unit.framework.AssertionFailedError:
> https://issues.apache.org/jira/browse/IGNITE-9722
> at
> org.apache.ignite.internal.processors.cache.mvcc.CacheMvccTransactionsTest.testMvccCoordinatorChangeSimple(CacheMvccTransactionsTest.java:2387)
> {noformat}
> https://issues.apache.org/jira/browse/IGNITE-9272?focusedCommentId=16641617=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16641617
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-9815) [TC Bot] Muted tests shouldn't considered as blocker
[
https://issues.apache.org/jira/browse/IGNITE-9815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641790#comment-16641790
]
Nikolay Izhikov commented on IGNITE-9815:
-
[~dpavlov] Bot should reflect real-world situation. For now, it is not.
Please, look at links I provide.
> [TC Bot] Muted tests shouldn't considered as blocker
>
>
> Key: IGNITE-9815
> URL: https://issues.apache.org/jira/browse/IGNITE-9815
> Project: Ignite
> Issue Type: Bug
>Reporter: Nikolay Izhikov
>Priority: Major
>
> Currently, TC bot doesn't analyze stack trace of test fail [1].
> If some test failed with the link to Ignite ticket it shouldn't be considered
> as a blocker.
> Link with examples of such behaviour:
> {noformat}
> IgniteCacheMvccTestSuite: DataStreamProcessorMvccSelfTest.testColocated -
> 0,0% fails in last 100 master runs.
> IgniteCacheMvccTestSuite: DataStreamProcessorMvccSelfTest.testPartitioned -
> 0,0% fails in last 100 master runs.
> IgniteCacheMvccTestSuite: DataStreamProcessorMvccSelfTest.testReplicated -
> 0,0% fails in last 100 master runs.
> {noformat}
> stack trace:
> {noformat}
> unit.framework.AssertionFailedError:
> https://issues.apache.org/jira/browse/IGNITE-9722
> at
> org.apache.ignite.internal.processors.cache.mvcc.CacheMvccTransactionsTest.testMvccCoordinatorChangeSimple(CacheMvccTransactionsTest.java:2387)
> {noformat}
> https://issues.apache.org/jira/browse/IGNITE-9272?focusedCommentId=16641617=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16641617
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-9815) [TC Bot] Muted tests shouldn't considered as blocker
[
https://issues.apache.org/jira/browse/IGNITE-9815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641764#comment-16641764
]
Dmitriy Pavlov commented on IGNITE-9815:
Bot never shows muted test. Do you mean failed from code e.g fail(IGNITE-)?
If yes, from the point of view of the bot (as well as TC), it is still
test-failure, which should be muted using TC interface.
Please note there is Ignored test opportunity presented in JUnit4+, but
currently, Grid Test Framework still uses JUnit3 API.
> [TC Bot] Muted tests shouldn't considered as blocker
>
>
> Key: IGNITE-9815
> URL: https://issues.apache.org/jira/browse/IGNITE-9815
> Project: Ignite
> Issue Type: Bug
>Reporter: Nikolay Izhikov
>Priority: Major
>
> Currently, TC bot doesn't analyze stack trace of test fail [1].
> If some test failed with the link to Ignite ticket it shouldn't be considered
> as a blocker.
> Link with examples of such behaviour:
> {noformat}
> IgniteCacheMvccTestSuite: DataStreamProcessorMvccSelfTest.testColocated -
> 0,0% fails in last 100 master runs.
> IgniteCacheMvccTestSuite: DataStreamProcessorMvccSelfTest.testPartitioned -
> 0,0% fails in last 100 master runs.
> IgniteCacheMvccTestSuite: DataStreamProcessorMvccSelfTest.testReplicated -
> 0,0% fails in last 100 master runs.
> {noformat}
> stack trace:
> {noformat}
> unit.framework.AssertionFailedError:
> https://issues.apache.org/jira/browse/IGNITE-9722
> at
> org.apache.ignite.internal.processors.cache.mvcc.CacheMvccTransactionsTest.testMvccCoordinatorChangeSimple(CacheMvccTransactionsTest.java:2387)
> {noformat}
> https://issues.apache.org/jira/browse/IGNITE-9272?focusedCommentId=16641617=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16641617
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
