[jira] [Updated] (IGNITE-15287) Yardstick's -cwd params does not clean persistence and wal directories
[ https://issues.apache.org/jira/browse/IGNITE-15287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim Muzafarov updated IGNITE-15287: - Fix Version/s: (was: 2.10) > Yardstick's -cwd params does not clean persistence and wal directories > -- > > Key: IGNITE-15287 > URL: https://issues.apache.org/jira/browse/IGNITE-15287 > Project: Ignite > Issue Type: Bug > Environment: - >Reporter: Anton Vinogradov >Priority: Major > > The current code at IgniteNode.java is > {noformat} > if (args.cleanWorkDirectory() && !clientMode) > FileUtils.cleanDirectory(U.workDirectory(c.getWorkDirectory(), > c.getIgniteHome())); > {noformat} > and we should append {{dataStorageConfiguration#storagePath}} and > {{dataStorageConfiguration#walPath}} clean-up as well. > Why it's important: > For example, hawing following configuration > {noformat} > class="org.apache.ignite.configuration.DataStorageConfiguration"> > > > > > > > > > > > > > > {noformat} > We will use same persistence each time we running benchmarks, this means > we'll gain different numbers each time :( > {{/mnt/ssd/wal}} will grow until possible, and {{/mnt/ssd/persistence}} will > be different before each benchmark start. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (IGNITE-15287) Yardstick's -cwd params does not clean persistence and wal directories
[ https://issues.apache.org/jira/browse/IGNITE-15287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anton Vinogradov updated IGNITE-15287: -- Description: The current code at IgniteNode.java is {noformat} if (args.cleanWorkDirectory() && !clientMode) FileUtils.cleanDirectory(U.workDirectory(c.getWorkDirectory(), c.getIgniteHome())); {noformat} and we should append {{dataStorageConfiguration#storagePath}} and {{dataStorageConfiguration#walPath}} clean-up as well. Why it's important: For example, hawing following configuration {noformat} {noformat} We will use same persistence each time we running benchmarks, this means we'll gain different numbers each time :( {{/mnt/ssd/wal}} will grow until possible, and {{/mnt/ssd/persistence}} will be different before each benchmark start. was: The current code at IgniteNode.java is {noformat} if (args.cleanWorkDirectory() && !clientMode) FileUtils.cleanDirectory(U.workDirectory(c.getWorkDirectory(), c.getIgniteHome())); {noformat} and we should append {{dataStorageConfiguration#storagePath}} and {{dataStorageConfiguration#walPath}} clean-up as well. > Yardstick's -cwd params does not clean persistence and wal directories > -- > > Key: IGNITE-15287 > URL: https://issues.apache.org/jira/browse/IGNITE-15287 > Project: Ignite > Issue Type: Bug > Environment: - >Reporter: Anton Vinogradov >Priority: Major > Fix For: 2.10 > > > The current code at IgniteNode.java is > {noformat} > if (args.cleanWorkDirectory() && !clientMode) > FileUtils.cleanDirectory(U.workDirectory(c.getWorkDirectory(), > c.getIgniteHome())); > {noformat} > and we should append {{dataStorageConfiguration#storagePath}} and > {{dataStorageConfiguration#walPath}} clean-up as well. > Why it's important: > For example, hawing following configuration > {noformat} > class="org.apache.ignite.configuration.DataStorageConfiguration"> > > > > > > > > > > > > > > {noformat} > We will use same persistence each time we running benchmarks, this means > we'll gain different numbers each time :( > {{/mnt/ssd/wal}} will grow until possible, and {{/mnt/ssd/persistence}} will > be different before each benchmark start. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (IGNITE-15287) Yardstick's -cwd params does not clean persistence and wal directories
[ https://issues.apache.org/jira/browse/IGNITE-15287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anton Vinogradov updated IGNITE-15287: -- Description: The current code at IgniteNode.java is {noformat} if (args.cleanWorkDirectory() && !clientMode) FileUtils.cleanDirectory(U.workDirectory(c.getWorkDirectory(), c.getIgniteHome())); {noformat} and we should append {{dataStorageConfiguration#storagePath}} and {{dataStorageConfiguration#walPath}} clean-up as well. was: The current code at IgniteNode.java is {noformat} if (args.cleanWorkDirectory() && !clientMode) FileUtils.cleanDirectory(U.workDirectory(c.getWorkDirectory(), c.getIgniteHome())); {noformat} and we should append {{dataStorageConfiguration#storagePath}} and {{dataStorageConfiguration#walPath}} clean-up as well. > Yardstick's -cwd params does not clean persistence and wal directories > -- > > Key: IGNITE-15287 > URL: https://issues.apache.org/jira/browse/IGNITE-15287 > Project: Ignite > Issue Type: Bug > Environment: - >Reporter: Anton Vinogradov >Priority: Major > Fix For: 2.10 > > > The current code at IgniteNode.java is > {noformat} > if (args.cleanWorkDirectory() && !clientMode) > FileUtils.cleanDirectory(U.workDirectory(c.getWorkDirectory(), > c.getIgniteHome())); > {noformat} > and we should append {{dataStorageConfiguration#storagePath}} and > {{dataStorageConfiguration#walPath}} clean-up as well. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (IGNITE-15287) Yardstick's -cwd params does not clean persistence and wal directories
[ https://issues.apache.org/jira/browse/IGNITE-15287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anton Vinogradov updated IGNITE-15287: -- Description: The current code at IgniteNode.java is {noformat} if (args.cleanWorkDirectory() && !clientMode) FileUtils.cleanDirectory(U.workDirectory(c.getWorkDirectory(), c.getIgniteHome())); {noformat} and we should append {{dataStorageConfiguration#storagePath}} and {{dataStorageConfiguration#walPath}} clean-up as well. was: The current code at IgniteNode.java is {noformat} if (args.cleanWorkDirectory() && !clientMode) FileUtils.cleanDirectory(U.workDirectory(c.getWorkDirectory(), c.getIgniteHome())); {noformat} and we should append {dataStorageConfiguration#storagePath} and {dataStorageConfiguration#walPath} clean-up as well. > Yardstick's -cwd params does not clean persistence and wal directories > -- > > Key: IGNITE-15287 > URL: https://issues.apache.org/jira/browse/IGNITE-15287 > Project: Ignite > Issue Type: Bug > Environment: - >Reporter: Anton Vinogradov >Priority: Major > Fix For: 2.10 > > > The current code at IgniteNode.java is > {noformat} > if (args.cleanWorkDirectory() && !clientMode) > FileUtils.cleanDirectory(U.workDirectory(c.getWorkDirectory(), > c.getIgniteHome())); > {noformat} > and we should append {{dataStorageConfiguration#storagePath}} and > {{dataStorageConfiguration#walPath}} clean-up as well. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (IGNITE-15287) Yardstick's -cwd params does not clean persistence and wal directories
[ https://issues.apache.org/jira/browse/IGNITE-15287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anton Vinogradov updated IGNITE-15287: -- Description: The current code at IgniteNode.java is {noformat} if (args.cleanWorkDirectory() && !clientMode) FileUtils.cleanDirectory(U.workDirectory(c.getWorkDirectory(), c.getIgniteHome())); {noformat} and we should append {dataStorageConfiguration#storagePath} and {dataStorageConfiguration#walPath} clean-up as well. was: The current code at IgniteNode.java is {noformat} if (args.cleanWorkDirectory()) FileUtils.cleanDirectory(U.workDirectory(c.getWorkDirectory(), c.getIgniteHome())); {noformat} and we should append {dataStorageConfiguration#storagePath} and {dataStorageConfiguration#walPath} clean-up as well. > Yardstick's -cwd params does not clean persistence and wal directories > -- > > Key: IGNITE-15287 > URL: https://issues.apache.org/jira/browse/IGNITE-15287 > Project: Ignite > Issue Type: Bug > Environment: - >Reporter: Anton Vinogradov >Priority: Major > Fix For: 2.10 > > > The current code at IgniteNode.java is > {noformat} > if (args.cleanWorkDirectory() && !clientMode) > FileUtils.cleanDirectory(U.workDirectory(c.getWorkDirectory(), > c.getIgniteHome())); > {noformat} > and we should append {dataStorageConfiguration#storagePath} and > {dataStorageConfiguration#walPath} clean-up as well. -- This message was sent by Atlassian Jira (v8.3.4#803005)