[Bug 62887] Customized SampleLabel is ignored and overwritten by JMeter 5.0
https://bz.apache.org/bugzilla/show_bug.cgi?id=62887 --- Comment #10 from Philippe Mouawad --- (In reply to Alan Silva from comment #9) > Oh yes. You're absolutely right @Philippe Mouawad. > > The patch should haven been an if/else. My mistake. > > In any case, as I said in my previous comment: > > Calling addSubResult(SampleResult subResult, false) is good enough I think. > > That's what I ended up doing and I would presume that it's what other Jmeter > users that upgraded to 5.0 and use custom result labels did as well. Hello Alan, Thanks for your feedback. So In your opinion, is it ok to do nothing ? or should we do something. Of course we should add a note on this in release notes. Thanks -- You are receiving this mail because: You are the assignee for the bug.
[Bug 62894] Report / Dashboard : Throughput is in wrong column which is confusing as unit it ms
https://bz.apache.org/bugzilla/show_bug.cgi?id=62894 Philippe Mouawad changed: What|Removed |Added Hardware|PC |All OS|Mac OS X 10.1 |All CC||p.mouawad@ubik-ingenierie.c ||om -- You are receiving this mail because: You are the assignee for the bug.
[Bug 61830] JMS : GUIs should be normalized and improved
https://bz.apache.org/bugzilla/show_bug.cgi?id=61830 Philippe Mouawad changed: What|Removed |Added CC||s...@apache.org --- Comment #2 from Philippe Mouawad --- *** Bug 56963 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Bug 56963] JMS GUIs could be made more consistent
https://bz.apache.org/bugzilla/show_bug.cgi?id=56963 Philippe Mouawad changed: What|Removed |Added Status|NEW |RESOLVED CC||p.mouawad@ubik-ingenierie.c ||om Resolution|--- |DUPLICATE --- Comment #2 from Philippe Mouawad --- Closing this one as Bug 61830 is more precise. *** This bug has been marked as a duplicate of bug 61830 *** -- You are receiving this mail because: You are the assignee for the bug.
[Bug 56963] JMS GUIs could be made more consistent
https://bz.apache.org/bugzilla/show_bug.cgi?id=56963 --- Comment #4 from Andrew Burton --- That's right - Bugzilla skipped to the next item in the list and I accidentally copied that URL. #59047 is completely different :) -- You are receiving this mail because: You are the assignee for the bug.
[Bug 62894] Report / Dashboard : Throughput is in wrong column which is confusing as unit is milliseconds
https://bz.apache.org/bugzilla/show_bug.cgi?id=62894 Philippe Mouawad changed: What|Removed |Added Keywords||FixedInTrunk Resolution|--- |FIXED Status|NEW |RESOLVED Summary|Report / Dashboard :|Report / Dashboard : |Throughput is in wrong |Throughput is in wrong |column which is confusing |column which is confusing |as unit it ms |as unit is milliseconds --- Comment #1 from Philippe Mouawad --- Author: pmouawad Date: Thu Nov 8 22:22:17 2018 New Revision: 1846204 URL: http://svn.apache.org/viewvc?rev=1846204=rev Log: Bug 62894 : Report / Dashboard : Throughput is in wrong column which is confusing as unit is milliseconds Bugzilla Id: 62894 Modified: jmeter/trunk/bin/report-template/content/js/dashboard.js.fmkr jmeter/trunk/xdocs/changes.xml -- You are receiving this mail because: You are the assignee for the bug.
[Bug 62887] Customized SampleLabel is ignored and overwritten by JMeter 5.0
https://bz.apache.org/bugzilla/show_bug.cgi?id=62887 --- Comment #9 from Alan Silva --- Oh yes. You're absolutely right @Philippe Mouawad. The patch should haven been an if/else. My mistake. In any case, as I said in my previous comment: Calling addSubResult(SampleResult subResult, false) is good enough I think. That's what I ended up doing and I would presume that it's what other Jmeter users that upgraded to 5.0 and use custom result labels did as well. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 62894] New: Report / Dashboard : Throughput is in wrong column which is confusing as unit it ms
https://bz.apache.org/bugzilla/show_bug.cgi?id=62894 Bug ID: 62894 Summary: Report / Dashboard : Throughput is in wrong column which is confusing as unit it ms Product: JMeter Version: 5.0 Hardware: PC OS: Mac OS X 10.1 Status: NEW Severity: normal Priority: P2 Component: Main Assignee: issues@jmeter.apache.org Reporter: p.moua...@ubik-ingenierie.com Target Milestone: JMETER_5.1 Created attachment 36254 --> https://bz.apache.org/bugzilla/attachment.cgi?id=36254=edit Screenshot Issues: - The column is in Response Times (ms). - Throughput should have a unit -- You are receiving this mail because: You are the assignee for the bug.
[Bug 56963] JMS GUIs could be made more consistent
https://bz.apache.org/bugzilla/show_bug.cgi?id=56963 --- Comment #3 from Philippe Mouawad --- (In reply to Andrew Burton from comment #1) > Similar to https://bz.apache.org/bugzilla/show_bug.cgi?id=59047 I guess this was a mistake that you fixed few minutes ago no ? -- You are receiving this mail because: You are the assignee for the bug.
[Bug 62885] AccessLogSampler Parser for AWS load balancer
https://bz.apache.org/bugzilla/show_bug.cgi?id=62885 --- Comment #4 from Philippe Mouawad --- Hi Felix, Thanks for the patch. Wouldn't it be an occasion to rename the TCLogParser so that they respect naming conventions ? Maybe before applying the patch so that it's clear ? Thanks -- You are receiving this mail because: You are the assignee for the bug.
[Bug 62887] Customized SampleLabel is ignored and overwritten by JMeter 5.0
https://bz.apache.org/bugzilla/show_bug.cgi?id=62887
--- Comment #8 from Philippe Mouawad ---
(In reply to Artem Fedorov from comment #7)
> Hi all,
>
> I agree with attached fix, but it can throw NPE, because it skip check for
> null
>
>
> if(subResult == null) {
> // see https://bz.apache.org/bugzilla/show_bug.cgi?id=54778
> return;
> }
>
> The other suggestion is add jmeter.property for enable/disable subResults
> rename option.
Hello Artem,
1/ IMO, having a property that can break report is a bit weird no ? And it's
another option for a requirement that is a edgy.
2/ Regarding the patch , I don't understand why addSubResult is called twice.
Am I missing something ? Should the second addSubResults be in an else ?
Same issue for other methods unless I am wrong.
3/ Also wouldn't this patch have an impact on JMeter performances by adding a
String comparison for every Sub result addition .
Thanks
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 62715] CSVDataSet tries to convert slashes to backslashes in Filename path
https://bz.apache.org/bugzilla/show_bug.cgi?id=62715 Philippe Mouawad changed: What|Removed |Added CC||p.mouawad@ubik-ingenierie.c ||om Target Milestone|--- |JMETER_5.0 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 62887] Customized SampleLabel is ignored and overwritten by JMeter 5.0
https://bz.apache.org/bugzilla/show_bug.cgi?id=62887
--- Comment #7 from Artem Fedorov ---
Hi all,
I agree with attached fix, but it can throw NPE, because it skip check for null
if(subResult == null) {
// see https://bz.apache.org/bugzilla/show_bug.cgi?id=54778
return;
}
The other suggestion is add jmeter.property for enable/disable subResults
rename option.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 62893] Deprecation warning: StringEscapeUtils
https://bz.apache.org/bugzilla/show_bug.cgi?id=62893 --- Comment #1 from Felix Schumacher --- Created attachment 36253 --> https://bz.apache.org/bugzilla/attachment.cgi?id=36253=edit Use StringEscapeUtils from commons-text -- You are receiving this mail because: You are the assignee for the bug.
[Bug 62885] AccessLogSampler Parser for AWS load balancer
https://bz.apache.org/bugzilla/show_bug.cgi?id=62885 --- Comment #3 from Felix Schumacher --- Created attachment 36252 --> https://bz.apache.org/bugzilla/attachment.cgi?id=36252=edit Add more http methods for parsing log files The attached patch adds all the http methods, that are available in the HTTPSamplerBase. OPTIONS is one of them, so the AWS log files should be parseable with this patch. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 62885] AccessLogSampler Parser for AWS load balancer
https://bz.apache.org/bugzilla/show_bug.cgi?id=62885 Felix Schumacher changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #2 from Felix Schumacher --- Can you elaborate a bit more on what is not working for you? Is it the OPTIONS http verb or something entirely different? -- You are receiving this mail because: You are the assignee for the bug.
[Bug 62715] CSVDataSet tries to convert slashes to backslashes in Filename path
https://bz.apache.org/bugzilla/show_bug.cgi?id=62715 Felix Schumacher changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #2 from Felix Schumacher --- *** This bug has been marked as a duplicate of bug 62127 *** -- You are receiving this mail because: You are the assignee for the bug.
[Bug 62127] CSV Data Set Config changes slash in filename path into backslash
https://bz.apache.org/bugzilla/show_bug.cgi?id=62127 Felix Schumacher changed: What|Removed |Added CC||toh2...@msn.com --- Comment #13 from Felix Schumacher --- *** Bug 62715 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Bug 62715] CSVDataSet tries to convert slashes to backslashes in Filename path
https://bz.apache.org/bugzilla/show_bug.cgi?id=62715 Andrew Burton changed: What|Removed |Added OS||All --- Comment #1 from Andrew Burton --- I was able to reproduce this in JMeter 4.0, was unable to reproduce in JMeter 5.0 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 62893] New: Deprecation warning: StringEscapeUtils
https://bz.apache.org/bugzilla/show_bug.cgi?id=62893 Bug ID: 62893 Summary: Deprecation warning: StringEscapeUtils Product: JMeter Version: unspecified Hardware: PC OS: Mac OS X 10.1 Status: NEW Severity: minor Priority: P2 Component: Main Assignee: issues@jmeter.apache.org Reporter: ad...@hotmail.com Target Milestone: JMETER_5.1 StringEscapeUtils has deprecation warnings in trunk. The class has moved from org.apache.commons.lang3 to org.apache.commons.text since 3.6 (ref https://commons.apache.org/proper/commons-lang/apidocs/org/apache/commons/lang3/StringEscapeUtils.html) -- You are receiving this mail because: You are the assignee for the bug.
[Bug 61830] JMS : GUIs should be normalized and improved
https://bz.apache.org/bugzilla/show_bug.cgi?id=61830 --- Comment #1 from Andrew Burton --- Similar to https://bz.apache.org/bugzilla/show_bug.cgi?id=56963 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 56963] JMS GUIs could be made more consistent
https://bz.apache.org/bugzilla/show_bug.cgi?id=56963 --- Comment #1 from Andrew Burton --- Similar to https://bz.apache.org/bugzilla/show_bug.cgi?id=59047 -- You are receiving this mail because: You are the assignee for the bug.
