https://issues.apache.org/bugzilla/show_bug.cgi?id=53804
Priority: P2
Bug ID: 53804
Assignee: issues@jmeter.apache.org
Summary: FileServer should fix hasHeader setting when creating
an alias
Severity: normal
Classification: Unclassified
OS: All
Reporter: s...@apache.org
Hardware: All
Status: NEW
Version: unspecified
Component: Main
Product: JMeter
One of the FileServer#reserveFile() methods allows the user to specify that a
file has a header line, in which case it is returned. [The others don't allow a
header]
However, when reading a headed file later, the user has to remember to provide
the correct parameter to readLine.
This is a recipe for confusion.
The reserveFile() methods should save the header status of the file entry when
it is created.
This should then be used by the the readLine() methods, which should not need
to be told the header status.
However, changing this might possibly break some 3rd party code.
So perhaps the safest would be to deprecate the following method:
readLine(String filename, boolean recycle, boolean firstLineIsNames)
and log a warning (or error?) if the reading mode disagrees with the
reservation mode.
--
You are receiving this mail because:
You are the assignee for the bug.
