[jira] [Commented] (KARAF-6057) karaf-plugin breaks with maven-install-plugin-2.5.2

2018-12-21 Thread Robert Varga (JIRA)


[ 
https://issues.apache.org/jira/browse/KARAF-6057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16726925#comment-16726925
 ] 

Robert Varga commented on KARAF-6057:
-

Thanks [~jbonofre] . Another data point: this seems to happen only for the 
distribution, generated features seem to work okay:
{noformat}
00:04:48.396 [INFO] --- karaf-maven-plugin:4.2.2:features-generate-descriptor 
(default-features-generate-descriptor) @ odl-apache-commons-codec ---
00:04:48.455 [INFO] Generating feature descriptor file 
/w/workspace/odlparent-maven-verify-master-mvn35-openjdk8/features/odl-apache-commons-codec/target/feature/feature.xml
00:04:48.468 [INFO] Tree listing is saved here: 
/w/workspace/odlparent-maven-verify-master-mvn35-openjdk8/features/odl-apache-commons-codec/target/history/treeListing.txt
00:04:48.468 
00:04:48.468 [INFO] ...done!
00:04:48.468 [INFO] Attaching features XML
00:04:48.468 [INFO] 
00:04:48.468 [INFO] --- karaf-maven-plugin:4.2.2:verify (default-verify) @ 
odl-apache-commons-codec ---
00:04:48.468 [INFO] Using repositories: 
https://nexus.opendaylight.org/content/repositories/opendaylight.snapshot/@id=opendaylight-snapshot@noreleases@snapshots,https://nexus.opendaylight.org/content/repositories/public/@id=opendaylight-mirror,https://nexus.opendaylight.org/content/repositories/public/@id=opendaylight-release-mirror
00:04:48.507 [INFO] Features verified: 0, failures: 0, ignored: 0
00:04:48.507 [INFO] 
00:04:48.507 [INFO] --- maven-surefire-plugin:2.22.1:test (default) @ 
odl-apache-commons-codec ---
00:04:48.510 [INFO] Surefire report directory: 
/w/workspace/odlparent-maven-verify-master-mvn35-openjdk8/features/odl-apache-commons-codec/target/surefire-reports
00:04:48.513 [INFO] 
00:04:48.513 [INFO] ---
00:04:48.513 [INFO]  T E S T S
00:04:48.513 [INFO] ---
00:04:49.114 [INFO] Running 
org.opendaylight.odlparent.featuretest.SingleFeatureTest
00:05:09.696 [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time 
elapsed: 20.564 s - in org.opendaylight.odlparent.featuretest.SingleFeatureTest
00:05:39.748 [INFO] 
00:05:39.748 [INFO] Results:
00:05:39.749 [INFO] 
00:05:39.749 [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
00:05:39.750 [INFO] 
00:05:39.760 [INFO] 
00:05:39.760 [INFO] --- script-maven-plugin:1.0.0:execute (default) @ 
odl-apache-commons-codec ---
00:05:39.779 [INFO] executing beanshell script
00:05:39.824 [INFO] 
00:05:39.824 [INFO] --- maven-javadoc-plugin:3.0.1:jar (attach-javadocs) @ 
odl-apache-commons-codec ---
00:05:39.856 [INFO] 
00:05:39.856 [INFO] --- duplicate-finder-maven-plugin:1.3.0:check 
(find-duplicate-classpath-entries) @ odl-apache-commons-codec ---
00:05:39.863 [INFO] 
00:05:39.863 [INFO] --- maven-source-plugin:3.0.1:jar-no-fork (attach-sources) 
@ odl-apache-commons-codec ---
00:05:39.866 [INFO] No sources in project. Archive not created.
00:05:39.866 [INFO] 
00:05:39.866 [INFO] --- maven-install-plugin:2.5.2:install (default-install) @ 
odl-apache-commons-codec ---
00:05:39.874 [INFO] No primary artifact to install, installing attached 
artifacts instead.
00:05:39.874 [INFO] Installing 
/w/workspace/odlparent-maven-verify-master-mvn35-openjdk8/features/odl-apache-commons-codec/pom.xml
 to 
/tmp/r/org/opendaylight/odlparent/odl-apache-commons-codec/4.0.5-SNAPSHOT/odl-apache-commons-codec-4.0.5-SNAPSHOT.pom
00:05:39.879 [INFO] Installing 
/w/workspace/odlparent-maven-verify-master-mvn35-openjdk8/features/odl-apache-commons-codec/target/feature/feature.xml
 to 
/tmp/r/org/opendaylight/odlparent/odl-apache-commons-codec/4.0.5-SNAPSHOT/odl-apache-commons-codec-4.0.5-SNAPSHOT-features.xml{noformat}

> karaf-plugin breaks with maven-install-plugin-2.5.2
> ---
>
> Key: KARAF-6057
> URL: https://issues.apache.org/jira/browse/KARAF-6057
> Project: Karaf
>  Issue Type: Bug
>  Components: karaf
>Affects Versions: 4.2.2, 4.1.7
>Reporter: Robert Varga
>Assignee: Jean-Baptiste Onofré
>Priority: Major
>  Labels: maven, tooling
> Fix For: 4.2.3
>
>
> KARAF-5939 added handling to support m-i-p-3.0.0-M1, but as a side-effect it 
> broke usage in OpenDaylight.
> There, in 
> [https://github.com/opendaylight/odlparent/tree/master/karaf/karaf4-parent] 
> we are using packaging=pom explicitly to allow this artifact to be consumed 
> by other projects, who then provide just a few overrides like this: 
> [https://github.com/opendaylight/aaa/blob/master/karaf/pom.xml]
> Unfortunately that change means that if coupled with m-i-p-2.5.2, the pom.xml 
> file ends up being installed as a zip:
> {noformat}
> [INFO] --- maven-install-plugin:2.5.2:install (default-install) @ 
> karaf4-parent ---
> [INFO] Installing 
> 

[jira] [Commented] (KARAF-6057) karaf-plugin breaks with maven-install-plugin-2.5.2

2018-12-21 Thread JIRA


[ 
https://issues.apache.org/jira/browse/KARAF-6057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16726908#comment-16726908
 ] 

Jean-Baptiste Onofré commented on KARAF-6057:
-

That's weird. Let me fix that.

> karaf-plugin breaks with maven-install-plugin-2.5.2
> ---
>
> Key: KARAF-6057
> URL: https://issues.apache.org/jira/browse/KARAF-6057
> Project: Karaf
>  Issue Type: Bug
>  Components: karaf
>Affects Versions: 4.2.2
>Reporter: Robert Varga
>Priority: Major
>  Labels: maven, tooling
> Fix For: 4.2.3
>
>
> KARAF-5939 added handling to support m-i-p-3.0.0-M1, but as a side-effect it 
> broke usage in OpenDaylight.
> There, in 
> [https://github.com/opendaylight/odlparent/tree/master/karaf/karaf4-parent] 
> we are using packaging=pom explicitly to allow this artifact to be consumed 
> by other projects, who then provide just a few overrides like this: 
> [https://github.com/opendaylight/aaa/blob/master/karaf/pom.xml]
> Unfortunately that change means that if coupled with m-i-p-2.5.2, the pom.xml 
> file ends up being installed as a zip:
> {noformat}
> [INFO] --- maven-install-plugin:2.5.2:install (default-install) @ 
> karaf4-parent ---
> [INFO] Installing 
> /w/workspace/odlparent-maven-stage-master/karaf/karaf4-parent/pom.xml to 
> /tmp/r/org/opendaylight/odlparent/karaf4-parent/4.0.5/karaf4-parent-4.0.5.zip
> [INFO] Installing 
> /w/workspace/odlparent-maven-stage-master/karaf/karaf4-parent/target/karaf4-parent-4.0.5.tar.gz
>  to 
> /tmp/r/org/opendaylight/odlparent/karaf4-parent/4.0.5/karaf4-parent-4.0.5.tar.gz
> [INFO] Installing 
> /w/workspace/odlparent-maven-stage-master/karaf/karaf4-parent/target/karaf4-parent-4.0.5.zip
>  to 
> /tmp/r/org/opendaylight/odlparent/karaf4-parent/4.0.5/karaf4-parent-4.0.5.zip
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (KARAF-6057) karaf-plugin breaks with maven-install-plugin-2.5.2

2018-12-21 Thread Robert Varga (JIRA)


 [ 
https://issues.apache.org/jira/browse/KARAF-6057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Varga updated KARAF-6057:

Affects Version/s: 4.1.7

> karaf-plugin breaks with maven-install-plugin-2.5.2
> ---
>
> Key: KARAF-6057
> URL: https://issues.apache.org/jira/browse/KARAF-6057
> Project: Karaf
>  Issue Type: Bug
>  Components: karaf
>Affects Versions: 4.2.2, 4.1.7
>Reporter: Robert Varga
>Assignee: Jean-Baptiste Onofré
>Priority: Major
>  Labels: maven, tooling
> Fix For: 4.2.3
>
>
> KARAF-5939 added handling to support m-i-p-3.0.0-M1, but as a side-effect it 
> broke usage in OpenDaylight.
> There, in 
> [https://github.com/opendaylight/odlparent/tree/master/karaf/karaf4-parent] 
> we are using packaging=pom explicitly to allow this artifact to be consumed 
> by other projects, who then provide just a few overrides like this: 
> [https://github.com/opendaylight/aaa/blob/master/karaf/pom.xml]
> Unfortunately that change means that if coupled with m-i-p-2.5.2, the pom.xml 
> file ends up being installed as a zip:
> {noformat}
> [INFO] --- maven-install-plugin:2.5.2:install (default-install) @ 
> karaf4-parent ---
> [INFO] Installing 
> /w/workspace/odlparent-maven-stage-master/karaf/karaf4-parent/pom.xml to 
> /tmp/r/org/opendaylight/odlparent/karaf4-parent/4.0.5/karaf4-parent-4.0.5.zip
> [INFO] Installing 
> /w/workspace/odlparent-maven-stage-master/karaf/karaf4-parent/target/karaf4-parent-4.0.5.tar.gz
>  to 
> /tmp/r/org/opendaylight/odlparent/karaf4-parent/4.0.5/karaf4-parent-4.0.5.tar.gz
> [INFO] Installing 
> /w/workspace/odlparent-maven-stage-master/karaf/karaf4-parent/target/karaf4-parent-4.0.5.zip
>  to 
> /tmp/r/org/opendaylight/odlparent/karaf4-parent/4.0.5/karaf4-parent-4.0.5.zip
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (KARAF-6057) karaf-plugin breaks with maven-install-plugin-2.5.2

2018-12-21 Thread JIRA


 [ 
https://issues.apache.org/jira/browse/KARAF-6057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jean-Baptiste Onofré reassigned KARAF-6057:
---

Assignee: Jean-Baptiste Onofré

> karaf-plugin breaks with maven-install-plugin-2.5.2
> ---
>
> Key: KARAF-6057
> URL: https://issues.apache.org/jira/browse/KARAF-6057
> Project: Karaf
>  Issue Type: Bug
>  Components: karaf
>Affects Versions: 4.2.2
>Reporter: Robert Varga
>Assignee: Jean-Baptiste Onofré
>Priority: Major
>  Labels: maven, tooling
> Fix For: 4.2.3
>
>
> KARAF-5939 added handling to support m-i-p-3.0.0-M1, but as a side-effect it 
> broke usage in OpenDaylight.
> There, in 
> [https://github.com/opendaylight/odlparent/tree/master/karaf/karaf4-parent] 
> we are using packaging=pom explicitly to allow this artifact to be consumed 
> by other projects, who then provide just a few overrides like this: 
> [https://github.com/opendaylight/aaa/blob/master/karaf/pom.xml]
> Unfortunately that change means that if coupled with m-i-p-2.5.2, the pom.xml 
> file ends up being installed as a zip:
> {noformat}
> [INFO] --- maven-install-plugin:2.5.2:install (default-install) @ 
> karaf4-parent ---
> [INFO] Installing 
> /w/workspace/odlparent-maven-stage-master/karaf/karaf4-parent/pom.xml to 
> /tmp/r/org/opendaylight/odlparent/karaf4-parent/4.0.5/karaf4-parent-4.0.5.zip
> [INFO] Installing 
> /w/workspace/odlparent-maven-stage-master/karaf/karaf4-parent/target/karaf4-parent-4.0.5.tar.gz
>  to 
> /tmp/r/org/opendaylight/odlparent/karaf4-parent/4.0.5/karaf4-parent-4.0.5.tar.gz
> [INFO] Installing 
> /w/workspace/odlparent-maven-stage-master/karaf/karaf4-parent/target/karaf4-parent-4.0.5.zip
>  to 
> /tmp/r/org/opendaylight/odlparent/karaf4-parent/4.0.5/karaf4-parent-4.0.5.zip
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KARAF-6057) karaf-plugin breaks with maven-install-plugin-2.5.2

2018-12-21 Thread Robert Varga (JIRA)


[ 
https://issues.apache.org/jira/browse/KARAF-6057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16726911#comment-16726911
 ] 

Robert Varga commented on KARAF-6057:
-

FWIW, bumping install-plugin in that pom.xml 
(https://git.opendaylight.org/gerrit/#/c/78960/) seems to fix the issue:
{noformat}
00:04:53.318 [INFO] --- maven-install-plugin:3.0.0-M1:install (default-install) 
@ karaf4-parent ---
00:04:53.319 [INFO] Installing 
/w/workspace/odlparent-maven-verify-master-mvn35-openjdk8/karaf/karaf4-parent/pom.xml
 to 
/tmp/r/org/opendaylight/odlparent/karaf4-parent/4.0.5-SNAPSHOT/karaf4-parent-4.0.5-SNAPSHOT.pom
00:04:53.319 [INFO] Installing 
/w/workspace/odlparent-maven-verify-master-mvn35-openjdk8/karaf/karaf4-parent/target/karaf4-parent-4.0.5-SNAPSHOT.tar.gz
 to 
/tmp/r/org/opendaylight/odlparent/karaf4-parent/4.0.5-SNAPSHOT/karaf4-parent-4.0.5-SNAPSHOT.tar.gz
00:04:53.741 [INFO] Installing 
/w/workspace/odlparent-maven-verify-master-mvn35-openjdk8/karaf/karaf4-parent/target/karaf4-parent-4.0.5-SNAPSHOT.zip
 to 
/tmp/r/org/opendaylight/odlparent/karaf4-parent/4.0.5-SNAPSHOT/karaf4-parent-4.0.5-SNAPSHOT.zip{noformat}

> karaf-plugin breaks with maven-install-plugin-2.5.2
> ---
>
> Key: KARAF-6057
> URL: https://issues.apache.org/jira/browse/KARAF-6057
> Project: Karaf
>  Issue Type: Bug
>  Components: karaf
>Affects Versions: 4.2.2
>Reporter: Robert Varga
>Assignee: Jean-Baptiste Onofré
>Priority: Major
>  Labels: maven, tooling
> Fix For: 4.2.3
>
>
> KARAF-5939 added handling to support m-i-p-3.0.0-M1, but as a side-effect it 
> broke usage in OpenDaylight.
> There, in 
> [https://github.com/opendaylight/odlparent/tree/master/karaf/karaf4-parent] 
> we are using packaging=pom explicitly to allow this artifact to be consumed 
> by other projects, who then provide just a few overrides like this: 
> [https://github.com/opendaylight/aaa/blob/master/karaf/pom.xml]
> Unfortunately that change means that if coupled with m-i-p-2.5.2, the pom.xml 
> file ends up being installed as a zip:
> {noformat}
> [INFO] --- maven-install-plugin:2.5.2:install (default-install) @ 
> karaf4-parent ---
> [INFO] Installing 
> /w/workspace/odlparent-maven-stage-master/karaf/karaf4-parent/pom.xml to 
> /tmp/r/org/opendaylight/odlparent/karaf4-parent/4.0.5/karaf4-parent-4.0.5.zip
> [INFO] Installing 
> /w/workspace/odlparent-maven-stage-master/karaf/karaf4-parent/target/karaf4-parent-4.0.5.tar.gz
>  to 
> /tmp/r/org/opendaylight/odlparent/karaf4-parent/4.0.5/karaf4-parent-4.0.5.tar.gz
> [INFO] Installing 
> /w/workspace/odlparent-maven-stage-master/karaf/karaf4-parent/target/karaf4-parent-4.0.5.zip
>  to 
> /tmp/r/org/opendaylight/odlparent/karaf4-parent/4.0.5/karaf4-parent-4.0.5.zip
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KARAF-6057) karaf-plugin breaks with maven-install-plugin-2.5.2

2018-12-21 Thread JIRA


[ 
https://issues.apache.org/jira/browse/KARAF-6057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16726909#comment-16726909
 ] 

Jean-Baptiste Onofré commented on KARAF-6057:
-

Anyway, as workaround, you can still use karaf-maven-plugin 4.2.1 with Karaf 
4.2.2 distribution.

> karaf-plugin breaks with maven-install-plugin-2.5.2
> ---
>
> Key: KARAF-6057
> URL: https://issues.apache.org/jira/browse/KARAF-6057
> Project: Karaf
>  Issue Type: Bug
>  Components: karaf
>Affects Versions: 4.2.2
>Reporter: Robert Varga
>Assignee: Jean-Baptiste Onofré
>Priority: Major
>  Labels: maven, tooling
> Fix For: 4.2.3
>
>
> KARAF-5939 added handling to support m-i-p-3.0.0-M1, but as a side-effect it 
> broke usage in OpenDaylight.
> There, in 
> [https://github.com/opendaylight/odlparent/tree/master/karaf/karaf4-parent] 
> we are using packaging=pom explicitly to allow this artifact to be consumed 
> by other projects, who then provide just a few overrides like this: 
> [https://github.com/opendaylight/aaa/blob/master/karaf/pom.xml]
> Unfortunately that change means that if coupled with m-i-p-2.5.2, the pom.xml 
> file ends up being installed as a zip:
> {noformat}
> [INFO] --- maven-install-plugin:2.5.2:install (default-install) @ 
> karaf4-parent ---
> [INFO] Installing 
> /w/workspace/odlparent-maven-stage-master/karaf/karaf4-parent/pom.xml to 
> /tmp/r/org/opendaylight/odlparent/karaf4-parent/4.0.5/karaf4-parent-4.0.5.zip
> [INFO] Installing 
> /w/workspace/odlparent-maven-stage-master/karaf/karaf4-parent/target/karaf4-parent-4.0.5.tar.gz
>  to 
> /tmp/r/org/opendaylight/odlparent/karaf4-parent/4.0.5/karaf4-parent-4.0.5.tar.gz
> [INFO] Installing 
> /w/workspace/odlparent-maven-stage-master/karaf/karaf4-parent/target/karaf4-parent-4.0.5.zip
>  to 
> /tmp/r/org/opendaylight/odlparent/karaf4-parent/4.0.5/karaf4-parent-4.0.5.zip
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (KARAF-6057) karaf-plugin breaks with maven-install-plugin-2.5.2

2018-12-21 Thread JIRA


 [ 
https://issues.apache.org/jira/browse/KARAF-6057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jean-Baptiste Onofré updated KARAF-6057:

Fix Version/s: 4.2.3

> karaf-plugin breaks with maven-install-plugin-2.5.2
> ---
>
> Key: KARAF-6057
> URL: https://issues.apache.org/jira/browse/KARAF-6057
> Project: Karaf
>  Issue Type: Bug
>  Components: karaf
>Affects Versions: 4.2.2
>Reporter: Robert Varga
>Assignee: Jean-Baptiste Onofré
>Priority: Major
>  Labels: maven, tooling
> Fix For: 4.2.3
>
>
> KARAF-5939 added handling to support m-i-p-3.0.0-M1, but as a side-effect it 
> broke usage in OpenDaylight.
> There, in 
> [https://github.com/opendaylight/odlparent/tree/master/karaf/karaf4-parent] 
> we are using packaging=pom explicitly to allow this artifact to be consumed 
> by other projects, who then provide just a few overrides like this: 
> [https://github.com/opendaylight/aaa/blob/master/karaf/pom.xml]
> Unfortunately that change means that if coupled with m-i-p-2.5.2, the pom.xml 
> file ends up being installed as a zip:
> {noformat}
> [INFO] --- maven-install-plugin:2.5.2:install (default-install) @ 
> karaf4-parent ---
> [INFO] Installing 
> /w/workspace/odlparent-maven-stage-master/karaf/karaf4-parent/pom.xml to 
> /tmp/r/org/opendaylight/odlparent/karaf4-parent/4.0.5/karaf4-parent-4.0.5.zip
> [INFO] Installing 
> /w/workspace/odlparent-maven-stage-master/karaf/karaf4-parent/target/karaf4-parent-4.0.5.tar.gz
>  to 
> /tmp/r/org/opendaylight/odlparent/karaf4-parent/4.0.5/karaf4-parent-4.0.5.tar.gz
> [INFO] Installing 
> /w/workspace/odlparent-maven-stage-master/karaf/karaf4-parent/target/karaf4-parent-4.0.5.zip
>  to 
> /tmp/r/org/opendaylight/odlparent/karaf4-parent/4.0.5/karaf4-parent-4.0.5.zip
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (KARAF-6057) karaf-plugin breaks with maven-install-plugin-2.5.2

2018-12-21 Thread JIRA


 [ 
https://issues.apache.org/jira/browse/KARAF-6057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jean-Baptiste Onofré updated KARAF-6057:

Labels: maven tooling  (was: )

> karaf-plugin breaks with maven-install-plugin-2.5.2
> ---
>
> Key: KARAF-6057
> URL: https://issues.apache.org/jira/browse/KARAF-6057
> Project: Karaf
>  Issue Type: Bug
>  Components: karaf
>Affects Versions: 4.2.2
>Reporter: Robert Varga
>Assignee: Jean-Baptiste Onofré
>Priority: Major
>  Labels: maven, tooling
> Fix For: 4.2.3
>
>
> KARAF-5939 added handling to support m-i-p-3.0.0-M1, but as a side-effect it 
> broke usage in OpenDaylight.
> There, in 
> [https://github.com/opendaylight/odlparent/tree/master/karaf/karaf4-parent] 
> we are using packaging=pom explicitly to allow this artifact to be consumed 
> by other projects, who then provide just a few overrides like this: 
> [https://github.com/opendaylight/aaa/blob/master/karaf/pom.xml]
> Unfortunately that change means that if coupled with m-i-p-2.5.2, the pom.xml 
> file ends up being installed as a zip:
> {noformat}
> [INFO] --- maven-install-plugin:2.5.2:install (default-install) @ 
> karaf4-parent ---
> [INFO] Installing 
> /w/workspace/odlparent-maven-stage-master/karaf/karaf4-parent/pom.xml to 
> /tmp/r/org/opendaylight/odlparent/karaf4-parent/4.0.5/karaf4-parent-4.0.5.zip
> [INFO] Installing 
> /w/workspace/odlparent-maven-stage-master/karaf/karaf4-parent/target/karaf4-parent-4.0.5.tar.gz
>  to 
> /tmp/r/org/opendaylight/odlparent/karaf4-parent/4.0.5/karaf4-parent-4.0.5.tar.gz
> [INFO] Installing 
> /w/workspace/odlparent-maven-stage-master/karaf/karaf4-parent/target/karaf4-parent-4.0.5.zip
>  to 
> /tmp/r/org/opendaylight/odlparent/karaf4-parent/4.0.5/karaf4-parent-4.0.5.zip
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (KARAF-6057) karaf-plugin breaks with maven-install-plugin-2.5.2

2018-12-21 Thread Robert Varga (JIRA)
Robert Varga created KARAF-6057:
---

 Summary: karaf-plugin breaks with maven-install-plugin-2.5.2
 Key: KARAF-6057
 URL: https://issues.apache.org/jira/browse/KARAF-6057
 Project: Karaf
  Issue Type: Bug
  Components: karaf
Affects Versions: 4.2.2
Reporter: Robert Varga


KARAF-5939 added handling to support m-i-p-3.0.0-M1, but as a side-effect it 
broke usage in OpenDaylight.

There, in 
[https://github.com/opendaylight/odlparent/tree/master/karaf/karaf4-parent] we 
are using packaging=pom explicitly to allow this artifact to be consumed by 
other projects, who then provide just a few overrides like this: 
[https://github.com/opendaylight/aaa/blob/master/karaf/pom.xml]

Unfortunately that change means that if coupled with m-i-p-2.5.2, the pom.xml 
file ends up being installed as a zip:
{noformat}
[INFO] --- maven-install-plugin:2.5.2:install (default-install) @ karaf4-parent 
---
[INFO] Installing 
/w/workspace/odlparent-maven-stage-master/karaf/karaf4-parent/pom.xml to 
/tmp/r/org/opendaylight/odlparent/karaf4-parent/4.0.5/karaf4-parent-4.0.5.zip
[INFO] Installing 
/w/workspace/odlparent-maven-stage-master/karaf/karaf4-parent/target/karaf4-parent-4.0.5.tar.gz
 to 
/tmp/r/org/opendaylight/odlparent/karaf4-parent/4.0.5/karaf4-parent-4.0.5.tar.gz
[INFO] Installing 
/w/workspace/odlparent-maven-stage-master/karaf/karaf4-parent/target/karaf4-parent-4.0.5.zip
 to 
/tmp/r/org/opendaylight/odlparent/karaf4-parent/4.0.5/karaf4-parent-4.0.5.zip
{noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KARAF-4609) Be able to override ConfigAdmin properties with System/JVM properties

2018-12-21 Thread JIRA


[ 
https://issues.apache.org/jira/browse/KARAF-4609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16726906#comment-16726906
 ] 

Jean-Baptiste Onofré commented on KARAF-4609:
-

Agree, I will do the improvement.

> Be able to override ConfigAdmin properties with System/JVM properties
> -
>
> Key: KARAF-4609
> URL: https://issues.apache.org/jira/browse/KARAF-4609
> Project: Karaf
>  Issue Type: Improvement
>  Components: karaf
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Minor
> Fix For: 4.3.0, 4.2.3
>
>
> It would be great to be able to override some ConfigAdmin properties using 
> '-Dconfig.myproperty=' at startup.
> It's especially interesting when using Karaf in Docker.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (KARAF-4609) Be able to override ConfigAdmin properties with System/JVM properties

2018-12-21 Thread JIRA


 [ 
https://issues.apache.org/jira/browse/KARAF-4609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jean-Baptiste Onofré updated KARAF-4609:

Fix Version/s: 4.2.3
   4.3.0

> Be able to override ConfigAdmin properties with System/JVM properties
> -
>
> Key: KARAF-4609
> URL: https://issues.apache.org/jira/browse/KARAF-4609
> Project: Karaf
>  Issue Type: Improvement
>  Components: karaf
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Minor
> Fix For: 4.3.0, 4.2.3
>
>
> It would be great to be able to override some ConfigAdmin properties using 
> '-Dconfig.myproperty=' at startup.
> It's especially interesting when using Karaf in Docker.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Reopened] (KARAF-4609) Be able to override ConfigAdmin properties with System/JVM properties

2018-12-21 Thread JIRA


 [ 
https://issues.apache.org/jira/browse/KARAF-4609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jean-Baptiste Onofré reopened KARAF-4609:
-

> Be able to override ConfigAdmin properties with System/JVM properties
> -
>
> Key: KARAF-4609
> URL: https://issues.apache.org/jira/browse/KARAF-4609
> Project: Karaf
>  Issue Type: Improvement
>  Components: karaf
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Minor
>
> It would be great to be able to override some ConfigAdmin properties using 
> '-Dconfig.myproperty=' at startup.
> It's especially interesting when using Karaf in Docker.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KARAF-4609) Be able to override ConfigAdmin properties with System/JVM properties

2018-12-21 Thread Serge Huber (JIRA)


[ 
https://issues.apache.org/jira/browse/KARAF-4609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16726844#comment-16726844
 ] 

Serge Huber commented on KARAF-4609:


Hmm... I'm not that fond of having to prepare the image because that forces to 
put placeholder for lots of properties "just in case" you can to override them. 

Because of no other option I did this in this commit for Apache Unomi:
https://github.com/apache/incubator-unomi/commit/b873b35a208a53b607d3e0928ec46c975d2024ff

As you can see in that commit it also means that you need to override default 
cfg files which is also a problem when upgrading the packaged Karaf.

It would probably be better to have an override mechanism as proposed initially 
in this ticket to avoid having to go to these measures.


> Be able to override ConfigAdmin properties with System/JVM properties
> -
>
> Key: KARAF-4609
> URL: https://issues.apache.org/jira/browse/KARAF-4609
> Project: Karaf
>  Issue Type: Improvement
>  Components: karaf
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Minor
>
> It would be great to be able to override some ConfigAdmin properties using 
> '-Dconfig.myproperty=' at startup.
> It's especially interesting when using Karaf in Docker.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KARAF-6055) Kafka appender should perform send().get()

2018-12-21 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/KARAF-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16726714#comment-16726714
 ] 

ASF subversion and git services commented on KARAF-6055:


Commit 8825222f0b1325f43617af26e44f593f8e9560cd in karaf-decanter's branch 
refs/heads/master from Jean-Baptiste Onofré
[ https://gitbox.apache.org/repos/asf?p=karaf-decanter.git;h=8825222 ]

Merge pull request #68 from jbonofre/KARAF-6055

[KARAF-6055] Use Kafka almost sync producer

> Kafka appender should perform send().get()
> --
>
> Key: KARAF-6055
> URL: https://issues.apache.org/jira/browse/KARAF-6055
> Project: Karaf
>  Issue Type: Improvement
>  Components: decanter
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: decanter-2.2.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KARAF-6055) Kafka appender should perform send().get()

2018-12-21 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/KARAF-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16726715#comment-16726715
 ] 

ASF subversion and git services commented on KARAF-6055:


Commit 8825222f0b1325f43617af26e44f593f8e9560cd in karaf-decanter's branch 
refs/heads/master from Jean-Baptiste Onofré
[ https://gitbox.apache.org/repos/asf?p=karaf-decanter.git;h=8825222 ]

Merge pull request #68 from jbonofre/KARAF-6055

[KARAF-6055] Use Kafka almost sync producer

> Kafka appender should perform send().get()
> --
>
> Key: KARAF-6055
> URL: https://issues.apache.org/jira/browse/KARAF-6055
> Project: Karaf
>  Issue Type: Improvement
>  Components: decanter
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: decanter-2.2.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (KARAF-6055) Kafka appender should perform send().get()

2018-12-21 Thread JIRA


 [ 
https://issues.apache.org/jira/browse/KARAF-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jean-Baptiste Onofré resolved KARAF-6055.
-
Resolution: Fixed

> Kafka appender should perform send().get()
> --
>
> Key: KARAF-6055
> URL: https://issues.apache.org/jira/browse/KARAF-6055
> Project: Karaf
>  Issue Type: Improvement
>  Components: decanter
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: decanter-2.2.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KARAF-6055) Kafka appender should perform send().get()

2018-12-21 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KARAF-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16726712#comment-16726712
 ] 

ASF GitHub Bot commented on KARAF-6055:
---

jbonofre closed pull request #68: [KARAF-6055] Use Kafka almost sync producer
URL: https://github.com/apache/karaf-decanter/pull/68
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/appender/kafka/src/main/java/org/apache/karaf/decanter/appender/kafka/KafkaAppender.java
 
b/appender/kafka/src/main/java/org/apache/karaf/decanter/appender/kafka/KafkaAppender.java
index 2d4f865..c09dd66 100644
--- 
a/appender/kafka/src/main/java/org/apache/karaf/decanter/appender/kafka/KafkaAppender.java
+++ 
b/appender/kafka/src/main/java/org/apache/karaf/decanter/appender/kafka/KafkaAppender.java
@@ -81,9 +81,9 @@ public void onCompletion(RecordMetadata recordMetadata, 
Exception e) {
 LOGGER.warn("Can't send event to Kafka broker", e);
 }
 }
-});
+}).get();
 producer.flush();
-} catch (RuntimeException e) {
+} catch (Exception e) {
 LOGGER.warn("Error sending event to kafka", e);
 }
 }
diff --git a/pom.xml b/pom.xml
index 8634927..63e4edb 100644
--- a/pom.xml
+++ b/pom.xml
@@ -527,6 +527,7 @@
 **/META-INF/spring.factories
 
**/META-INF/decanter.bundles.default
 **/bundle8/**/*
+**/test.cfg
 
 true
 


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Kafka appender should perform send().get()
> --
>
> Key: KARAF-6055
> URL: https://issues.apache.org/jira/browse/KARAF-6055
> Project: Karaf
>  Issue Type: Improvement
>  Components: decanter
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: decanter-2.2.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KARAF-6055) Kafka appender should perform send().get()

2018-12-21 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/KARAF-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16726713#comment-16726713
 ] 

ASF subversion and git services commented on KARAF-6055:


Commit 597a6b534a5d7aed9f65f844557162368b4b4050 in karaf-decanter's branch 
refs/heads/master from Jean-Baptiste Onofré
[ https://gitbox.apache.org/repos/asf?p=karaf-decanter.git;h=597a6b5 ]

[KARAF-6055] Use Kafka almost sync producer


> Kafka appender should perform send().get()
> --
>
> Key: KARAF-6055
> URL: https://issues.apache.org/jira/browse/KARAF-6055
> Project: Karaf
>  Issue Type: Improvement
>  Components: decanter
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: decanter-2.2.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)