[jira] [Commented] (KARAF-5693) Incomplete config.properties file in built assemblies

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/KARAF-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17295876#comment-17295876
 ] 

ASF GitHub Bot commented on KARAF-5693:
---

gnodet closed pull request #511:
URL: https://github.com/apache/karaf/pull/511


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Incomplete config.properties file in built assemblies
> -
>
> Key: KARAF-5693
> URL: https://issues.apache.org/jira/browse/KARAF-5693
> Project: Karaf
>  Issue Type: Bug
>Affects Versions: 4.0.10
>Reporter: Greg Logan
>Assignee: Guillaume Nodet
>Priority: Major
> Attachments: broken.log, broken.properties, working.log, 
> working.properties
>
>
> Over at the Opencast project (https://github.com/opencast/opencast) we rarely 
> (1/20 or so) have assemblies seem to build correctly, but a number of 
> libraries required for the assembly to boot with all installed modules will 
> be missing from config.properties.  A repackage of the same codebase and 
> built artifacts resolves the issue, so this seems to be related to the 
> assembly itself rather than the underlying modules.  This also seems to be 
> independent of our branches, and versions - we've been observing this 
> off-and-on for more than a year but I've just never gotten around to filing 
> this.
>  
> Things attached:
>  * working and broken.log: full build outputs (including component 
> compilation) of the working and failing builds, respectively
>  * working and broken.properties: the config.properties generated in the 
> working, and failing builds, respectively.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (KARAF-5693) Incomplete config.properties file in built assemblies

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/KARAF-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17205521#comment-17205521
 ] 

ASF GitHub Bot commented on KARAF-5693:
---

jbonofre commented on pull request #511:
URL: https://github.com/apache/karaf/pull/511#issuecomment-702142724


   This PR actually breaks resolver verify due to concurrent modification in in 
the await method (on the callback hashmap). I tried to use a 
`ConcurrentHashMap` in this time the resolver behavior is not correct. I will 
take a deeper look.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Incomplete config.properties file in built assemblies
> -
>
> Key: KARAF-5693
> URL: https://issues.apache.org/jira/browse/KARAF-5693
> Project: Karaf
>  Issue Type: Bug
>Affects Versions: 4.0.10
>Reporter: Greg Logan
>Assignee: Guillaume Nodet
>Priority: Major
> Attachments: broken.log, broken.properties, working.log, 
> working.properties
>
>
> Over at the Opencast project (https://github.com/opencast/opencast) we rarely 
> (1/20 or so) have assemblies seem to build correctly, but a number of 
> libraries required for the assembly to boot with all installed modules will 
> be missing from config.properties.  A repackage of the same codebase and 
> built artifacts resolves the issue, so this seems to be related to the 
> assembly itself rather than the underlying modules.  This also seems to be 
> independent of our branches, and versions - we've been observing this 
> off-and-on for more than a year but I've just never gotten around to filing 
> this.
>  
> Things attached:
>  * working and broken.log: full build outputs (including component 
> compilation) of the working and failing builds, respectively
>  * working and broken.properties: the config.properties generated in the 
> working, and failing builds, respectively.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (KARAF-5693) Incomplete config.properties file in built assemblies

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/KARAF-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16483707#comment-16483707
 ] 

ASF GitHub Bot commented on KARAF-5693:
---

gnodet opened a new pull request #511: [KARAF-5693] Run the processing 
synchronously after downloads
URL: https://github.com/apache/karaf/pull/511
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Incomplete config.properties file in built assemblies
> -
>
> Key: KARAF-5693
> URL: https://issues.apache.org/jira/browse/KARAF-5693
> Project: Karaf
>  Issue Type: Bug
>Affects Versions: 4.0.10
>Reporter: Greg Logan
>Assignee: Guillaume Nodet
>Priority: Major
> Attachments: broken.log, broken.properties, working.log, 
> working.properties
>
>
> Over at the Opencast project (https://github.com/opencast/opencast) we rarely 
> (1/20 or so) have assemblies seem to build correctly, but a number of 
> libraries required for the assembly to boot with all installed modules will 
> be missing from config.properties.  A repackage of the same codebase and 
> built artifacts resolves the issue, so this seems to be related to the 
> assembly itself rather than the underlying modules.  This also seems to be 
> independent of our branches, and versions - we've been observing this 
> off-and-on for more than a year but I've just never gotten around to filing 
> this.
>  
> Things attached:
>  * working and broken.log: full build outputs (including component 
> compilation) of the working and failing builds, respectively
>  * working and broken.properties: the config.properties generated in the 
> working, and failing builds, respectively.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (KARAF-5693) Incomplete config.properties file in built assemblies

[Karen (JIRA)]

[ 
https://issues.apache.org/jira/browse/KARAF-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16482804#comment-16482804
 ] 

Karen commented on KARAF-5693:
--

The Builder.downloadLibraries() iterates through the set of assemblies/pom.xml 
libraries and launches a download thread for each one. When one of the 
libraries download, the thread extracts the 
"org.osgi.framework.system.packages.extra" value from the shared config 
Collection and appended to locally. Then it saves teh entire updated  
"org.osgi.framework.system.packages.extra" value back to the shared config 
Collection. The asynchronous nature of appending to the 
"org.osgi.framework.system.packages.extra" explains why the list is usually 
different after each build. But, there doesn't appear to be a synchronize on 
the shared config Collection when it is being updated locally by a the 
asynchronous thread.

> Incomplete config.properties file in built assemblies
> -
>
> Key: KARAF-5693
> URL: https://issues.apache.org/jira/browse/KARAF-5693
> Project: Karaf
>  Issue Type: Bug
>Affects Versions: 4.0.10
>Reporter: Greg Logan
>Priority: Major
> Attachments: broken.log, broken.properties, working.log, 
> working.properties
>
>
> Over at the Opencast project (https://github.com/opencast/opencast) we rarely 
> (1/20 or so) have assemblies seem to build correctly, but a number of 
> libraries required for the assembly to boot with all installed modules will 
> be missing from config.properties.  A repackage of the same codebase and 
> built artifacts resolves the issue, so this seems to be related to the 
> assembly itself rather than the underlying modules.  This also seems to be 
> independent of our branches, and versions - we've been observing this 
> off-and-on for more than a year but I've just never gotten around to filing 
> this.
>  
> Things attached:
>  * working and broken.log: full build outputs (including component 
> compilation) of the working and failing builds, respectively
>  * working and broken.properties: the config.properties generated in the 
> working, and failing builds, respectively.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (KARAF-5693) Incomplete config.properties file in built assemblies

[Karen (JIRA)]

[ 
https://issues.apache.org/jira/browse/KARAF-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16482585#comment-16482585
 ] 

Karen commented on KARAF-5693:
--

This commit possibly threw out the baby with the bathwater? 
[https://github.com/apache/karaf/commit/59c11e4deebd6940136149a44f8485a941653e28]

It does at lot more than revert KARAF-3956. It also reverted KARAF-3791

commit 61f2436fc15b71afdec896873bb764c60d69b94a
Author: Jean-Baptiste Onofré 
Date:   Fri Jun 19 13:33:32 2015 +0200

    [KARAF-3791] Fix etc/config.properties, especially used by instances

> Incomplete config.properties file in built assemblies
> -
>
> Key: KARAF-5693
> URL: https://issues.apache.org/jira/browse/KARAF-5693
> Project: Karaf
>  Issue Type: Bug
>Affects Versions: 4.0.10
>Reporter: Greg Logan
>Priority: Major
> Attachments: broken.log, broken.properties, working.log, 
> working.properties
>
>
> Over at the Opencast project (https://github.com/opencast/opencast) we rarely 
> (1/20 or so) have assemblies seem to build correctly, but a number of 
> libraries required for the assembly to boot with all installed modules will 
> be missing from config.properties.  A repackage of the same codebase and 
> built artifacts resolves the issue, so this seems to be related to the 
> assembly itself rather than the underlying modules.  This also seems to be 
> independent of our branches, and versions - we've been observing this 
> off-and-on for more than a year but I've just never gotten around to filing 
> this.
>  
> Things attached:
>  * working and broken.log: full build outputs (including component 
> compilation) of the working and failing builds, respectively
>  * working and broken.properties: the config.properties generated in the 
> working, and failing builds, respectively.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (KARAF-5693) Incomplete config.properties file in built assemblies

[Karen (JIRA)]

[ 
https://issues.apache.org/jira/browse/KARAF-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16482405#comment-16482405
 ] 

Karen commented on KARAF-5693:
--

The race condition in the KARAF maven assembly that occasionally (less than 
40%) omits the 

javax.annotation packages from the config.properties in the 

org.osgi.framework.system.packages.extra area appears to be the same/similar to 
KARAF-4996

> Incomplete config.properties file in built assemblies
> -
>
> Key: KARAF-5693
> URL: https://issues.apache.org/jira/browse/KARAF-5693
> Project: Karaf
>  Issue Type: Bug
>Affects Versions: 4.0.10
>Reporter: Greg Logan
>Priority: Major
> Attachments: broken.log, broken.properties, working.log, 
> working.properties
>
>
> Over at the Opencast project (https://github.com/opencast/opencast) we rarely 
> (1/20 or so) have assemblies seem to build correctly, but a number of 
> libraries required for the assembly to boot with all installed modules will 
> be missing from config.properties.  A repackage of the same codebase and 
> built artifacts resolves the issue, so this seems to be related to the 
> assembly itself rather than the underlying modules.  This also seems to be 
> independent of our branches, and versions - we've been observing this 
> off-and-on for more than a year but I've just never gotten around to filing 
> this.
>  
> Things attached:
>  * working and broken.log: full build outputs (including component 
> compilation) of the working and failing builds, respectively
>  * working and broken.properties: the config.properties generated in the 
> working, and failing builds, respectively.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (KARAF-5693) Incomplete config.properties file in built assemblies

[Greg Logan (JIRA)]

[ 
https://issues.apache.org/jira/browse/KARAF-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16431436#comment-16431436
 ] 

Greg Logan commented on KARAF-5693:
---

Per discussion on the mailing list, this also appears to be independent of the 
assembly itself as well - we've noticed it in all of them but it's mainly the 
allinone that gets noticed because it is used for testing.

> Incomplete config.properties file in built assemblies
> -
>
> Key: KARAF-5693
> URL: https://issues.apache.org/jira/browse/KARAF-5693
> Project: Karaf
>  Issue Type: Bug
>Affects Versions: 4.0.10
>Reporter: Greg Logan
>Priority: Major
> Attachments: broken.log, broken.properties, working.log, 
> working.properties
>
>
> Over at the Opencast project (https://github.com/opencast/opencast) we rarely 
> (1/20 or so) have assemblies seem to build correctly, but a number of 
> libraries required for the assembly to boot with all installed modules will 
> be missing from config.properties.  A repackage of the same codebase and 
> built artifacts resolves the issue, so this seems to be related to the 
> assembly itself rather than the underlying modules.  This also seems to be 
> independent of our branches, and versions - we've been observing this 
> off-and-on for more than a year but I've just never gotten around to filing 
> this.
>  
> Things attached:
>  * working and broken.log: full build outputs (including component 
> compilation) of the working and failing builds, respectively
>  * working and broken.properties: the config.properties generated in the 
> working, and failing builds, respectively.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)