[jira] [Comment Edited] (KYLIN-2898) Introduce memcached as a distributed cache for queries

2018-11-04 Thread Jiatao Tao (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-2898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16674747#comment-16674747 ] Jiatao Tao edited comment on KYLIN-2898 at 11/5/18 7:06 AM: Hi [~Wang Ken],

[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues

2018-11-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16674752#comment-16674752 ] ASF GitHub Bot commented on KYLIN-3597: --- Aaron edited a comment on issue #326: KYLIN-3597, fix

[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues

2018-11-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16674753#comment-16674753 ] ASF GitHub Bot commented on KYLIN-3597: --- Aaron edited a comment on issue #326: KYLIN-3597, fix

[GitHub] Aaaaaaron edited a comment on issue #326: KYLIN-3597, fix the critical bug reported by sonar: Make sure this ex…

2018-11-04 Thread GitBox
Aaron edited a comment on issue #326: KYLIN-3597, fix the critical bug reported by sonar: Make sure this ex… URL: https://github.com/apache/kylin/pull/326#issuecomment-43496 Hi @mingmwang, there's a critical bug reported by sonar, and I offer a fix, can you take a look and confirm

[GitHub] Aaaaaaron edited a comment on issue #326: KYLIN-3597, fix the critical bug reported by sonar: Make sure this ex…

2018-11-04 Thread GitBox
Aaron edited a comment on issue #326: KYLIN-3597, fix the critical bug reported by sonar: Make sure this ex… URL: https://github.com/apache/kylin/pull/326#issuecomment-43496 Hi @mingmwang, there's a problem reported by sonar, and I offer a fix, can you take a look and confirm the

[jira] [Commented] (KYLIN-2898) Introduce memcached as a distributed cache for queries

2018-11-04 Thread Jiatao Tao (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-2898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16674747#comment-16674747 ] Jiatao Tao commented on KYLIN-2898: --- Hi [~Wang Ken], there's a problem reported by sonar, and I offer a

[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues

2018-11-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16674739#comment-16674739 ] ASF GitHub Bot commented on KYLIN-3597: --- coveralls edited a comment on issue #326: KYLIN-3597, fix

[GitHub] coveralls edited a comment on issue #326: KYLIN-3597, fix the critical bug reported by sonar: Make sure this ex…

2018-11-04 Thread GitBox
coveralls edited a comment on issue #326: KYLIN-3597, fix the critical bug reported by sonar: Make sure this ex… URL: https://github.com/apache/kylin/pull/326#issuecomment-435556355 ## Pull Request Test Coverage Report for [Build 3836](https://coveralls.io/builds/19905348) * **0**

[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues

2018-11-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16674737#comment-16674737 ] ASF GitHub Bot commented on KYLIN-3597: --- codecov-io edited a comment on issue #326: KYLIN-3597, fix

[GitHub] codecov-io edited a comment on issue #326: KYLIN-3597, fix the critical bug reported by sonar: Make sure this ex…

2018-11-04 Thread GitBox
codecov-io edited a comment on issue #326: KYLIN-3597, fix the critical bug reported by sonar: Make sure this ex… URL: https://github.com/apache/kylin/pull/326#issuecomment-435556421 # [Codecov](https://codecov.io/gh/apache/kylin/pull/326?src=pr=h1) Report > Merging

[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues

2018-11-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16674717#comment-16674717 ] ASF GitHub Bot commented on KYLIN-3597: --- Aaron commented on issue #326: KYLIN-3597, fix the

[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues

2018-11-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16674716#comment-16674716 ] ASF GitHub Bot commented on KYLIN-3597: --- Aaron edited a comment on issue #326: KYLIN-3597, fix

[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues

2018-11-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16674715#comment-16674715 ] ASF GitHub Bot commented on KYLIN-3597: --- Aaron edited a comment on issue #326: KYLIN-3597, fix

[GitHub] Aaaaaaron edited a comment on issue #326: KYLIN-3597, fix the critical bug reported by sonar: Make sure this ex…

2018-11-04 Thread GitBox
Aaron edited a comment on issue #326: KYLIN-3597, fix the critical bug reported by sonar: Make sure this ex… URL: https://github.com/apache/kylin/pull/326#issuecomment-43496 Hi @shaofengshi, I do a simple modify just change the init value, could you assess if this change is

[GitHub] Aaaaaaron commented on issue #326: KYLIN-3597, fix the critical bug reported by sonar: Make sure this ex…

2018-11-04 Thread GitBox
Aaron commented on issue #326: KYLIN-3597, fix the critical bug reported by sonar: Make sure this ex… URL: https://github.com/apache/kylin/pull/326#issuecomment-435768040 When "totalWeight" is 0, means there are no nodes, so "thisWeight" is 0 too.

[GitHub] Aaaaaaron edited a comment on issue #326: KYLIN-3597, fix the critical bug reported by sonar: Make sure this ex…

2018-11-04 Thread GitBox
Aaron edited a comment on issue #326: KYLIN-3597, fix the critical bug reported by sonar: Make sure this ex… URL: https://github.com/apache/kylin/pull/326#issuecomment-43496 Hi @shaofengshi, I do a simple modify just change the init value, could you assess if this change is

[jira] [Commented] (KYLIN-3552) Data Source SDK to ingest data from different JDBC sources

2018-11-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-3552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16674618#comment-16674618 ] ASF GitHub Bot commented on KYLIN-3552: --- edouardzyc opened a new pull request #327: KYLIN-3552 add

[jira] [Commented] (KYLIN-3552) Data Source SDK to ingest data from different JDBC sources

2018-11-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-3552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16674619#comment-16674619 ] ASF GitHub Bot commented on KYLIN-3552: --- asfgit commented on issue #327: KYLIN-3552 add doc and

[GitHub] asfgit commented on issue #327: KYLIN-3552 add doc and blog

2018-11-04 Thread GitBox
asfgit commented on issue #327: KYLIN-3552 add doc and blog URL: https://github.com/apache/kylin/pull/327#issuecomment-435741132 Can one of the admins verify this patch? This is an automated message from the Apache Git

[GitHub] edouardzyc opened a new pull request #327: KYLIN-3552 add doc and blog

2018-11-04 Thread GitBox
edouardzyc opened a new pull request #327: KYLIN-3552 add doc and blog URL: https://github.com/apache/kylin/pull/327 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[jira] [Commented] (KYLIN-3663) Failed to delete project when project has more than one table

2018-11-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-3663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16674581#comment-16674581 ] ASF GitHub Bot commented on KYLIN-3663: --- woyumen4597 commented on a change in pull request #325:

[GitHub] woyumen4597 commented on a change in pull request #325: KYLIN-3663 fix deleting project error when project has more than one …

2018-11-04 Thread GitBox
woyumen4597 commented on a change in pull request #325: KYLIN-3663 fix deleting project error when project has more than one … URL: https://github.com/apache/kylin/pull/325#discussion_r230617173 ## File path:

[jira] [Commented] (KYLIN-3663) Failed to delete project when project has more than one table

2018-11-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-3663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16674409#comment-16674409 ] ASF GitHub Bot commented on KYLIN-3663: --- shaofengshi commented on a change in pull request #325:

[GitHub] shaofengshi commented on a change in pull request #325: KYLIN-3663 fix deleting project error when project has more than one …

2018-11-04 Thread GitBox
shaofengshi commented on a change in pull request #325: KYLIN-3663 fix deleting project error when project has more than one … URL: https://github.com/apache/kylin/pull/325#discussion_r230588909 ## File path:

[GitHub] shaofengshi commented on issue #313: draft for kylin doc spec and modified installation guide

2018-11-04 Thread GitBox
shaofengshi commented on issue #313: draft for kylin doc spec and modified installation guide URL: https://github.com/apache/kylin/pull/313#issuecomment-435667800 Merged with git rebase after resolving the conflict. Thank you!

[GitHub] shaofengshi closed pull request #313: draft for kylin doc spec and modified installation guide

2018-11-04 Thread GitBox
shaofengshi closed pull request #313: draft for kylin doc spec and modified installation guide URL: https://github.com/apache/kylin/pull/313 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As