[GitHub] [kylin] guangxuCheng commented on pull request #1254: KYLIN-4556 improve job service

2020-08-23 Thread GitBox
guangxuCheng commented on pull request #1254: URL: https://github.com/apache/kylin/pull/1254#issuecomment-678889759 @hit-lacus Thanks for commiting. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kylin] guangxuCheng commented on pull request #1254: KYLIN-4556 improve job service

2020-08-12 Thread GitBox
guangxuCheng commented on pull request #1254: URL: https://github.com/apache/kylin/pull/1254#issuecomment-672690026 The failed check is caused by #1349, I have open a new pr #1356 to fix it This is an automated message from

[GitHub] [kylin] guangxuCheng commented on pull request #1254: KYLIN-4556 improve job service

2020-08-11 Thread GitBox
guangxuCheng commented on pull request #1254: URL: https://github.com/apache/kylin/pull/1254#issuecomment-672557732 @zhangayqian @shaofengshi I had fixed conflicts, can you take a look again? Thanks This is an automated

[GitHub] [kylin] guangxuCheng commented on pull request #1254: KYLIN-4556 improve job service

2020-06-11 Thread GitBox
guangxuCheng commented on pull request #1254: URL: https://github.com/apache/kylin/pull/1254#issuecomment-642484698 To facilitate review, I split the task to 5 subtasks. @shaofengshi @nichunen @hit-lacus can you take a look? Thanks