[GitHub] [kylin] hit-lacus commented on pull request #1354: KYLIN-4662 Migrate from third-party Spark to offical Apache Spark

2020-08-12 Thread GitBox
hit-lacus commented on pull request #1354: URL: https://github.com/apache/kylin/pull/1354#issuecomment-672890438 In general, this look good to me. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kylin] hit-lacus commented on pull request #1354: KYLIN-4662 Migrate from third-party Spark to offical Apache Spark

2020-08-12 Thread GitBox
hit-lacus commented on pull request #1354: URL: https://github.com/apache/kylin/pull/1354#issuecomment-672888369 This patch has some unpredictable performance lose impact on both build engine and query engine. But I think we can merge it and do a benchmark to analyse the difference .