[GitHub] [kylin] nichunen commented on issue #640: Add unit tests four

2019-05-18 Thread GitBox
nichunen commented on issue #640: Add unit tests four URL: https://github.com/apache/kylin/pull/640#issuecomment-493729482 @TheRealHaui I've reviewed and merged. Thanks This is an automated message from the Apache Git

[GitHub] [kylin] nichunen commented on issue #640: Add unit tests four

2019-05-17 Thread GitBox
nichunen commented on issue #640: Add unit tests four URL: https://github.com/apache/kylin/pull/640#issuecomment-493449216 @TheRealHaui Hi, absolutely! Kylin's code coverage is growing with your contribution. This is an

[GitHub] [kylin] nichunen commented on issue #640: Add unit tests four

2019-05-15 Thread GitBox
nichunen commented on issue #640: Add unit tests four URL: https://github.com/apache/kylin/pull/640#issuecomment-492676891 Hi @TheRealHaui It seems that you do not set "import order" in your IDE with file "core-common/.settings/org.eclipse.jdt.core.prefs", with this setting, java.*