[GitHub] [kylin] zzcclp commented on pull request #1588: KYLIN-4908 Segment pruner support integer partition col in spark query engine

2021-03-02 Thread GitBox
zzcclp commented on pull request #1588: URL: https://github.com/apache/kylin/pull/1588#issuecomment-788972359 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kylin] zzcclp commented on pull request #1588: KYLIN-4908 Segment pruner support integer partition col in spark query engine

2021-03-02 Thread GitBox
zzcclp commented on pull request #1588: URL: https://github.com/apache/kylin/pull/1588#issuecomment-788830057 @zhengshengjun Please rebase and resolve the conflict. This is an automated message from the Apache Git Service.

[GitHub] [kylin] zzcclp commented on pull request #1588: KYLIN-4908 Segment pruner support integer partition col in spark query engine

2021-02-22 Thread GitBox
zzcclp commented on pull request #1588: URL: https://github.com/apache/kylin/pull/1588#issuecomment-783963391 @zhengshengjun Please add a test case, for example, add a test case sql in kylin-it/src/test/resources/query/sql.