[
https://issues.apache.org/jira/browse/KYLIN-2135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15861001#comment-15861001
]
kangkaisen commented on KYLIN-2135:
---
The IT has covered KYLIN-2135.
> Enlarge FactDistinctColumns
[
https://issues.apache.org/jira/browse/KYLIN-2135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15829685#comment-15829685
]
kangkaisen commented on KYLIN-2135:
---
I see. KYLIN-2135 and KYLIN-2217 don't conflict itself. but the IT
[
https://issues.apache.org/jira/browse/KYLIN-2135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15829672#comment-15829672
]
Shaofeng SHI commented on KYLIN-2135:
-
I discussed this with xiefan, when multiple reducers are used
[
https://issues.apache.org/jira/browse/KYLIN-2135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15820909#comment-15820909
]
kangkaisen commented on KYLIN-2135:
---
Hi, Shaofeng.
I think It is maybe unlikely add UT for this feature
[
https://issues.apache.org/jira/browse/KYLIN-2135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15731733#comment-15731733
]
kangkaisen commented on KYLIN-2135:
---
Hi，Shaofeng. I am sorry to delay to add the test. Do you think how
[
https://issues.apache.org/jira/browse/KYLIN-2135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15673396#comment-15673396
]
XIE FAN commented on KYLIN-2135:
Oh,I see. Thank you.
> Enlarge FactDistinctColumns reducer number
>
[
https://issues.apache.org/jira/browse/KYLIN-2135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15672686#comment-15672686
]
kangkaisen commented on KYLIN-2135:
---
Hi, [~xiefan46]. We only enlarge the reducer number for
[
https://issues.apache.org/jira/browse/KYLIN-2135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15669277#comment-15669277
]
XIE FAN commented on KYLIN-2135:
Can we specify different reducers number for different columns? Or we
[
https://issues.apache.org/jira/browse/KYLIN-2135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15647678#comment-15647678
]
kangkaisen commented on KYLIN-2135:
---
OK，thanks you. I will add test case later.
> Enlarge
[
https://issues.apache.org/jira/browse/KYLIN-2135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15647584#comment-15647584
]
Shaofeng SHI commented on KYLIN-2135:
-
CI passed, merged into master (after resovling conflict with
[
https://issues.apache.org/jira/browse/KYLIN-2135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15632361#comment-15632361
]
Shaofeng SHI commented on KYLIN-2135:
-
Looks good; will run a full regression test for it; if no
[
https://issues.apache.org/jira/browse/KYLIN-2135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15624655#comment-15624655
]
kangkaisen commented on KYLIN-2135:
---
OK, I see it. Thanks you.
> Enlarge FactDistinctColumns reducer
[
https://issues.apache.org/jira/browse/KYLIN-2135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15624616#comment-15624616
]
Shaofeng SHI commented on KYLIN-2135:
-
Hi Kaisen,
1. The UHC column is very common; today there is no
[
https://issues.apache.org/jira/browse/KYLIN-2135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15624163#comment-15624163
]
Shaofeng SHI commented on KYLIN-2135:
-
Thanks, I retried and this time it got success
> Enlarge
[
https://issues.apache.org/jira/browse/KYLIN-2135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15624112#comment-15624112
]
kangkaisen commented on KYLIN-2135:
---
This patch is created from master branch. I use {{git am -s -3
[
https://issues.apache.org/jira/browse/KYLIN-2135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15624044#comment-15624044
]
Shaofeng SHI commented on KYLIN-2135:
-
I have couple of comments for the patch:
1. this function will
[
https://issues.apache.org/jira/browse/KYLIN-2135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15624018#comment-15624018
]
Shaofeng SHI commented on KYLIN-2135:
-
which is the base version that making the patch? I tried to
[
https://issues.apache.org/jira/browse/KYLIN-2135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15621315#comment-15621315
]
Shaofeng SHI commented on KYLIN-2135:
-
thanks Kaisen, I'm reviewing this, will update a little bit
[
https://issues.apache.org/jira/browse/KYLIN-2135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15612068#comment-15612068
]
Shaofeng SHI commented on KYLIN-2135:
-
hi kaisen, what's the cardinality of the largest column in this
19 matches
Mail list logo
