[jira] [Commented] (KYLIN-3135) Fix regular expression bug in SQL comments

2018-02-10 Thread hahayuan (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-3135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359777#comment-16359777 ] hahayuan commented on KYLIN-3135: - Please revert the first {code:java} --.*?[\r\n] {code} too. if the

[jira] [Commented] (KYLIN-3135) Fix regular expression bug in SQL comments

2018-02-10 Thread peng.jianhua (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-3135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359776#comment-16359776 ] peng.jianhua commented on KYLIN-3135: - Please revert the first {code:java} --.*?[\r\n] {code} too. if

[jira] [Commented] (KYLIN-3135) Fix regular expression bug in SQL comments

2018-02-10 Thread Kaige Liu (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-3135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359768#comment-16359768 ] Kaige Liu commented on KYLIN-3135: --- As commented above, I will revert the change in  

[jira] [Commented] (KYLIN-3135) Fix regular expression bug in SQL comments

2018-01-30 Thread Kaige Liu (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-3135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346156#comment-16346156 ] Kaige Liu commented on KYLIN-3135: --- Hi [~hahayuan], you are right. The commit is not correct according

[jira] [Commented] (KYLIN-3135) Fix regular expression bug in SQL comments

2018-01-30 Thread hahayuan (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-3135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346139#comment-16346139 ] hahayuan commented on KYLIN-3135: - !one_line_comments.PNG! > Fix regular expression bug in SQL comments >

[jira] [Commented] (KYLIN-3135) Fix regular expression bug in SQL comments

2018-01-30 Thread hahayuan (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-3135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346092#comment-16346092 ] hahayuan commented on KYLIN-3135: - [~yimingliu],this commit : 

[jira] [Commented] (KYLIN-3135) Fix regular expression bug in SQL comments

2018-01-27 Thread Billy Liu (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-3135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16342187#comment-16342187 ] Billy Liu commented on KYLIN-3135: -- One more commit on this issue: