[jira] [Commented] (KYLIN-3310) Use lint for maven-compiler-plugin
[
https://issues.apache.org/jira/browse/KYLIN-3310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16543937#comment-16543937
]
jiatao.tao commented on KYLIN-3310:
---
NIce! I'll give a try! Thanks.
> Use lint for maven-compiler-plugin
> --
>
> Key: KYLIN-3310
> URL: https://issues.apache.org/jira/browse/KYLIN-3310
> Project: Kylin
> Issue Type: Improvement
> Components: Tools, Build and Test
>Reporter: Ted Yu
>Assignee: jiatao.tao
>Priority: Major
>
> lint helps identify structural problems.
> We should enable lint for maven-compiler-plugin
> {code}
> maven-compiler-plugin
> ${maven-compiler-plugin.version}
>
> 1.8
> 1.8
>
> -Xlint:all
> ${compiler.error.flag}
>
> -Xlint:-options
>
> -Xlint:-cast
> -Xlint:-deprecation
> -Xlint:-processing
> -Xlint:-rawtypes
> -Xlint:-serial
> -Xlint:-try
> -Xlint:-unchecked
> -Xlint:-varargs
>
>
>
>
> true
>
> false
>
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (KYLIN-3310) Use lint for maven-compiler-plugin
[
https://issues.apache.org/jira/browse/KYLIN-3310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
jiatao.tao reassigned KYLIN-3310:
-
Assignee: jiatao.tao
> Use lint for maven-compiler-plugin
> --
>
> Key: KYLIN-3310
> URL: https://issues.apache.org/jira/browse/KYLIN-3310
> Project: Kylin
> Issue Type: Improvement
> Components: Tools, Build and Test
>Reporter: Ted Yu
>Assignee: jiatao.tao
>Priority: Major
>
> lint helps identify structural problems.
> We should enable lint for maven-compiler-plugin
> {code}
> maven-compiler-plugin
> ${maven-compiler-plugin.version}
>
> 1.8
> 1.8
>
> -Xlint:all
> ${compiler.error.flag}
>
> -Xlint:-options
>
> -Xlint:-cast
> -Xlint:-deprecation
> -Xlint:-processing
> -Xlint:-rawtypes
> -Xlint:-serial
> -Xlint:-try
> -Xlint:-unchecked
> -Xlint:-varargs
>
>
>
>
> true
>
> false
>
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (KYLIN-3417) Consider replacing ReentrantReadWriteLock with StampedLock
[
https://issues.apache.org/jira/browse/KYLIN-3417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16543935#comment-16543935
]
jiatao.tao commented on KYLIN-3417:
---
Thanks Ted, I will take a glance! Nice to see all these interesting usage.
> Consider replacing ReentrantReadWriteLock with StampedLock
> --
>
> Key: KYLIN-3417
> URL: https://issues.apache.org/jira/browse/KYLIN-3417
> Project: Kylin
> Issue Type: Improvement
>Reporter: Ted Yu
>Priority: Major
> Fix For: v2.5.0
>
>
> ReentrantReadWriteLock's are only the right solution when there is long hold
> time due to expensive I/O.
> It is expensive for readers.
> We should see if the lighter {{StampedLock}} can be used instead.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (KYLIN-3417) Consider replacing ReentrantReadWriteLock with StampedLock
[
https://issues.apache.org/jira/browse/KYLIN-3417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
jiatao.tao reassigned KYLIN-3417:
-
Assignee: jiatao.tao
> Consider replacing ReentrantReadWriteLock with StampedLock
> --
>
> Key: KYLIN-3417
> URL: https://issues.apache.org/jira/browse/KYLIN-3417
> Project: Kylin
> Issue Type: Improvement
>Reporter: Ted Yu
>Assignee: jiatao.tao
>Priority: Major
> Fix For: v2.5.0
>
>
> ReentrantReadWriteLock's are only the right solution when there is long hold
> time due to expensive I/O.
> It is expensive for readers.
> We should see if the lighter {{StampedLock}} can be used instead.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (KYLIN-3450) Consider using google re2j
[ https://issues.apache.org/jira/browse/KYLIN-3450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16543933#comment-16543933 ] jiatao.tao commented on KYLIN-3450: --- Nice advice! Thanks Ted! > Consider using google re2j > -- > > Key: KYLIN-3450 > URL: https://issues.apache.org/jira/browse/KYLIN-3450 > Project: Kylin > Issue Type: Improvement >Reporter: Ted Yu >Priority: Minor > > RE2J : https://github.com/google/re2j > For regular expression patterns with a high degree of alternation, using RE2J > would exhibit higher performance. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (KYLIN-3450) Consider using google re2j
Ted Yu created KYLIN-3450: - Summary: Consider using google re2j Key: KYLIN-3450 URL: https://issues.apache.org/jira/browse/KYLIN-3450 Project: Kylin Issue Type: Improvement Reporter: Ted Yu RE2J : https://github.com/google/re2j For regular expression patterns with a high degree of alternation, using RE2J would exhibit higher performance. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3426) visualization charts were not showing up in the insight page
[ https://issues.apache.org/jira/browse/KYLIN-3426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16542789#comment-16542789 ] Hubert STEFANI commented on KYLIN-3426: --- Same behaviour on Chrome And Firefox, the issue is related to this message in the Web Console : "ReferenceError: queryConfig is not defined at Scope.$scope.refreshGraphData (scripts.min.20180324172038.js:51055) at Scope.$scope.resetGraph (scripts.min.20180324172038.js:51011) at scripts.min.20180324172038.js:10955 at scripts.min.20180324172038.js:10730" > visualization charts were not showing up in the insight page > > > Key: KYLIN-3426 > URL: https://issues.apache.org/jira/browse/KYLIN-3426 > Project: Kylin > Issue Type: Bug > Components: Web >Affects Versions: v2.3.1 >Reporter: Jayaraj >Priority: Major > Attachments: visualization_missing.png > > > created model and cube in kylin using sample dataset. In insight tab, able to > query the cubes, but all the visualization charts were not showing up for the > query result. Please find the attached screen shot and suggest on this. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (KYLIN-3449) Should allow deleting a segment in NEW status
Shaofeng SHI created KYLIN-3449: --- Summary: Should allow deleting a segment in NEW status Key: KYLIN-3449 URL: https://issues.apache.org/jira/browse/KYLIN-3449 Project: Kylin Issue Type: Improvement Reporter: Shaofeng SHI Sometimes the job is dropped or not successfully created, then the new segment becomes orphan. So far Kylin doesn't allow deleting a NEW status segment, that is bad. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
