[jira] [Commented] (KYLIN-3187) JDK APIs using the default locale, time zone or character set should be avoided
[
https://issues.apache.org/jira/browse/KYLIN-3187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16598737#comment-16598737
]
ASF GitHub Bot commented on KYLIN-3187:
---
etherge commented on issue #217: KYLIN-3187 Forbid calls to JDK APIs that use
the default locale, time…
URL: https://github.com/apache/kylin/pull/217#issuecomment-417666948
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> JDK APIs using the default locale, time zone or character set should be
> avoided
> ---
>
> Key: KYLIN-3187
> URL: https://issues.apache.org/jira/browse/KYLIN-3187
> Project: Kylin
> Issue Type: Bug
> Components: REST Service
>Reporter: Ted Yu
>Assignee: Kaige Liu
>Priority: Major
> Labels: usability
> Fix For: v2.5.0
>
>
> Here are a few examples:
> {code}
> server-base/src/main/java/org/apache/kylin/rest/service/JobService.java:
> Calendar calendar = Calendar.getInstance();
> storage-hbase/src/main/java/org/apache/kylin/storage/hbase/util/HbaseStreamingInput.java:
> Calendar cal = Calendar.getInstance();
> {code}
> Locale should be specified.
> See CALCITE-1667 for related information.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (KYLIN-3522) PrepareStatement cache issue
[ https://issues.apache.org/jira/browse/KYLIN-3522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16598543#comment-16598543 ] Ma Gang commented on KYLIN-3522: Patch uploaded, please help to review, the fix is to clear the filter's previous variable values before bind it. > PrepareStatement cache issue > > > Key: KYLIN-3522 > URL: https://issues.apache.org/jira/browse/KYLIN-3522 > Project: Kylin > Issue Type: Improvement > Components: Query Engine >Reporter: Ma Gang >Assignee: Ma Gang >Priority: Minor > Attachments: KYLIN-3522.patch > > > When enable server side prepareStatement cache, OLAPContext is cached with > prepareStatement object, because filter is also in the OLAPContext, so the > condition values in the comparedFilter is also cached, that may cause problem > in some cases. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (KYLIN-3522) PrepareStatement cache issue
[ https://issues.apache.org/jira/browse/KYLIN-3522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ma Gang updated KYLIN-3522: --- Attachment: KYLIN-3522.patch > PrepareStatement cache issue > > > Key: KYLIN-3522 > URL: https://issues.apache.org/jira/browse/KYLIN-3522 > Project: Kylin > Issue Type: Improvement > Components: Query Engine >Reporter: Ma Gang >Assignee: Ma Gang >Priority: Minor > Attachments: KYLIN-3522.patch > > > When enable server side prepareStatement cache, OLAPContext is cached with > prepareStatement object, because filter is also in the OLAPContext, so the > condition values in the comparedFilter is also cached, that may cause problem > in some cases. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (KYLIN-3522) PrepareStatement cache issue
Ma Gang created KYLIN-3522: -- Summary: PrepareStatement cache issue Key: KYLIN-3522 URL: https://issues.apache.org/jira/browse/KYLIN-3522 Project: Kylin Issue Type: Improvement Components: Query Engine Reporter: Ma Gang Assignee: Ma Gang When enable server side prepareStatement cache, OLAPContext is cached with prepareStatement object, because filter is also in the OLAPContext, so the condition values in the comparedFilter is also cached, that may cause problem in some cases. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3488) Support MySQL as Kylin metadata storage
[ https://issues.apache.org/jira/browse/KYLIN-3488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16598417#comment-16598417 ] ASF GitHub Bot commented on KYLIN-3488: --- coveralls edited a comment on issue #216: KYLIN-3488 Support MySQL as Kylin metadata storage URL: https://github.com/apache/kylin/pull/216#issuecomment-417178965 ## Pull Request Test Coverage Report for [Build 3500](https://coveralls.io/builds/18769294) * **1** of **622** **(0.16%)** changed or added relevant lines in **12** files are covered. * **2** unchanged lines in **1** file lost coverage. * Overall coverage decreased (**-0.2%**) to **22.765%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [core-common/src/main/java/org/apache/kylin/common/persistence/ResourceStore.java](https://coveralls.io/builds/18769294/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Fpersistence%2FResourceStore.java#L236) | 0 | 1 | 0.0% | [core-common/src/main/java/org/apache/kylin/common/util/HadoopUtil.java](https://coveralls.io/builds/18769294/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Futil%2FHadoopUtil.java#L88) | 0 | 4 | 0.0% | [core-common/src/main/java/org/apache/kylin/common/KylinConfig.java](https://coveralls.io/builds/18769294/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2FKylinConfig.java#L538) | 0 | 7 | 0.0% | [core-common/src/main/java/org/apache/kylin/common/persistence/BrokenEntity.java](https://coveralls.io/builds/18769294/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Fpersistence%2FBrokenEntity.java#L25) | 0 | 13 | 0.0% | [core-common/src/main/java/org/apache/kylin/common/persistence/BrokenInputStream.java](https://coveralls.io/builds/18769294/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Fpersistence%2FBrokenInputStream.java#L32) | 0 | 15 | 0.0% | [core-common/src/main/java/org/apache/kylin/common/persistence/JDBCSqlQueryFormatProvider.java](https://coveralls.io/builds/18769294/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Fpersistence%2FJDBCSqlQueryFormatProvider.java#L28) | 0 | 15 | 0.0% | [core-common/src/main/java/org/apache/kylin/common/persistence/JDBCResource.java](https://coveralls.io/builds/18769294/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Fpersistence%2FJDBCResource.java#L31) | 0 | 16 | 0.0% | [core-common/src/main/java/org/apache/kylin/common/persistence/JDBCSqlQueryFormat.java](https://coveralls.io/builds/18769294/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Fpersistence%2FJDBCSqlQueryFormat.java#L26) | 0 | 22 | 0.0% | [core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java](https://coveralls.io/builds/18769294/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2FKylinConfigBase.java#L266) | 1 | 41 | 2.44% | [core-common/src/main/java/org/apache/kylin/common/persistence/JDBCConnectionManager.java](https://coveralls.io/builds/18769294/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Fpersistence%2FJDBCConnectionManager.java#L41) | 0 | 60 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://coveralls.io/builds/18769294/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcuboid%2FTreeCuboidScheduler.java#L124) | 2 | 68.46% | | Totals | [](https://coveralls.io/builds/18769294) | | :-- | --: | | Change from base [Build 3497](https://coveralls.io/builds/18752699): | -0.2% | | Covered Lines: | 15861 | | Relevant Lines: | 69672 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Support MySQL as Kylin metadata storage > --- > > Key: KYLIN-3488 > URL: https://issues.apache.org/jira/browse/KYLIN-3488 > Project: Kylin > Issue Type: New Feature > Components: Metadata >Reporter: Shaofeng SHI >Priority: Major > > Kylin uses HBase as the metastore; But in some cases user expects the > metadata not in HBase. > Sonny Heer from mailing list mentioned:
[jira] [Commented] (KYLIN-3488) Support MySQL as Kylin metadata storage
[ https://issues.apache.org/jira/browse/KYLIN-3488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16598416#comment-16598416 ] ASF GitHub Bot commented on KYLIN-3488: --- codecov-io edited a comment on issue #216: KYLIN-3488 Support MySQL as Kylin metadata storage URL: https://github.com/apache/kylin/pull/216#issuecomment-417178593 # [Codecov](https://codecov.io/gh/apache/kylin/pull/216?src=pr=h1) Report > Merging [#216](https://codecov.io/gh/apache/kylin/pull/216?src=pr=desc) into [master](https://codecov.io/gh/apache/kylin/commit/f1d2ee46493fb9dd37ca8f8e2e6a8b5f5ad494ab?src=pr=desc) will **decrease** coverage by `0.17%`. > The diff coverage is `0.16%`. [](https://codecov.io/gh/apache/kylin/pull/216?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #216 +/- ## - Coverage 20.94% 20.77% -0.18% Complexity 4337 4337 Files 1079 1087 +8 Lines 6905069672 +622 Branches 1000810076 +68 + Hits 1446514476 +11 - Misses5320353813 +610 - Partials 1382 1383 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/216?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...he/kylin/common/persistence/BrokenInputStream.java](https://codecov.io/gh/apache/kylin/pull/216/diff?src=pr=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9wZXJzaXN0ZW5jZS9Ccm9rZW5JbnB1dFN0cmVhbS5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...apache/kylin/common/persistence/ResourceStore.java](https://codecov.io/gh/apache/kylin/pull/216/diff?src=pr=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9wZXJzaXN0ZW5jZS9SZXNvdXJjZVN0b3JlLmphdmE=) | `62.18% <0%> (-0.32%)` | `29 <0> (ø)` | | | [.../java/org/apache/kylin/common/util/HadoopUtil.java](https://codecov.io/gh/apache/kylin/pull/216/diff?src=pr=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi91dGlsL0hhZG9vcFV0aWwuamF2YQ==) | `17.44% <0%> (-0.86%)` | `10 <0> (ø)` | | | [...e/kylin/common/persistence/JDBCSqlQueryFormat.java](https://codecov.io/gh/apache/kylin/pull/216/diff?src=pr=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9wZXJzaXN0ZW5jZS9KREJDU3FsUXVlcnlGb3JtYXQuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | | | [.../apache/kylin/common/persistence/BrokenEntity.java](https://codecov.io/gh/apache/kylin/pull/216/diff?src=pr=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9wZXJzaXN0ZW5jZS9Ccm9rZW5FbnRpdHkuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...he/kylin/common/persistence/JDBCResourceStore.java](https://codecov.io/gh/apache/kylin/pull/216/diff?src=pr=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9wZXJzaXN0ZW5jZS9KREJDUmVzb3VyY2VTdG9yZS5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...ache/kylin/common/persistence/JDBCResourceDAO.java](https://codecov.io/gh/apache/kylin/pull/216/diff?src=pr=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9wZXJzaXN0ZW5jZS9KREJDUmVzb3VyY2VEQU8uamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...common/persistence/JDBCSqlQueryFormatProvider.java](https://codecov.io/gh/apache/kylin/pull/216/diff?src=pr=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9wZXJzaXN0ZW5jZS9KREJDU3FsUXVlcnlGb3JtYXRQcm92aWRlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | | | [.../apache/kylin/common/persistence/JDBCResource.java](https://codecov.io/gh/apache/kylin/pull/216/diff?src=pr=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9wZXJzaXN0ZW5jZS9KREJDUmVzb3VyY2UuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...main/java/org/apache/kylin/common/KylinConfig.java](https://codecov.io/gh/apache/kylin/pull/216/diff?src=pr=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZy5qYXZh) | `33.73% <0%> (-0.97%)` | `22 <0> (ø)` | | | ... and [13 more](https://codecov.io/gh/apache/kylin/pull/216/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/216?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/216?src=pr=footer). Last update
[jira] [Commented] (KYLIN-3521) Enable Cube Planner by default
[ https://issues.apache.org/jira/browse/KYLIN-3521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16598408#comment-16598408 ] Yichen Zhou commented on KYLIN-3521: +1 Good feature! And maybe we can make it easier to understand and use in phase two. > Enable Cube Planner by default > -- > > Key: KYLIN-3521 > URL: https://issues.apache.org/jira/browse/KYLIN-3521 > Project: Kylin > Issue Type: Improvement >Affects Versions: v2.5.0 >Reporter: Shaofeng SHI >Priority: Minor > > Cube planner can significantly reduce the cuboid number that to build. As it > wasn't enabled by default in 2.3 and 2.4, many users don't know that. > > To let more user to start using it, I suggest to enable it by default. As > Cube planner only works when build the first segment, it only affect the > cuboid scheduler of a new Cube. Old cubes will not be affected. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3521) Enable Cube Planner by default
[ https://issues.apache.org/jira/browse/KYLIN-3521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16598396#comment-16598396 ] Pan, Julian commented on KYLIN-3521: +1 > Enable Cube Planner by default > -- > > Key: KYLIN-3521 > URL: https://issues.apache.org/jira/browse/KYLIN-3521 > Project: Kylin > Issue Type: Improvement >Affects Versions: v2.5.0 >Reporter: Shaofeng SHI >Priority: Minor > > Cube planner can significantly reduce the cuboid number that to build. As it > wasn't enabled by default in 2.3 and 2.4, many users don't know that. > > To let more user to start using it, I suggest to enable it by default. As > Cube planner only works when build the first segment, it only affect the > cuboid scheduler of a new Cube. Old cubes will not be affected. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3488) Support MySQL as Kylin metadata storage
[ https://issues.apache.org/jira/browse/KYLIN-3488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16598395#comment-16598395 ] ASF GitHub Bot commented on KYLIN-3488: --- asfgit commented on issue #216: KYLIN-3488 Support MySQL as Kylin metadata storage URL: https://github.com/apache/kylin/pull/216#issuecomment-417585608 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Support MySQL as Kylin metadata storage > --- > > Key: KYLIN-3488 > URL: https://issues.apache.org/jira/browse/KYLIN-3488 > Project: Kylin > Issue Type: New Feature > Components: Metadata >Reporter: Shaofeng SHI >Priority: Major > > Kylin uses HBase as the metastore; But in some cases user expects the > metadata not in HBase. > Sonny Heer from mailing list mentioned: > "I'm fairly certain anyone using Kylin with AWS EMR will benefit from this. > Having multiple hbase clusters across AZs is a huge benefit. BTW only thing > blocking at the moment is write operations happening from kylin query nodes." -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3521) Enable Cube Planner by default
[ https://issues.apache.org/jira/browse/KYLIN-3521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16598387#comment-16598387 ] Ma Gang commented on KYLIN-3521: +1 > Enable Cube Planner by default > -- > > Key: KYLIN-3521 > URL: https://issues.apache.org/jira/browse/KYLIN-3521 > Project: Kylin > Issue Type: Improvement >Affects Versions: v2.5.0 >Reporter: Shaofeng SHI >Priority: Minor > > Cube planner can significantly reduce the cuboid number that to build. As it > wasn't enabled by default in 2.3 and 2.4, many users don't know that. > > To let more user to start using it, I suggest to enable it by default. As > Cube planner only works when build the first segment, it only affect the > cuboid scheduler of a new Cube. Old cubes will not be affected. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3521) Enable Cube Planner by default
[ https://issues.apache.org/jira/browse/KYLIN-3521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16598383#comment-16598383 ] Billy Liu commented on KYLIN-3521: -- +1 > Enable Cube Planner by default > -- > > Key: KYLIN-3521 > URL: https://issues.apache.org/jira/browse/KYLIN-3521 > Project: Kylin > Issue Type: Improvement >Affects Versions: v2.5.0 >Reporter: Shaofeng SHI >Priority: Minor > > Cube planner can significantly reduce the cuboid number that to build. As it > wasn't enabled by default in 2.3 and 2.4, many users don't know that. > > To let more user to start using it, I suggest to enable it by default. As > Cube planner only works when build the first segment, it only affect the > cuboid scheduler of a new Cube. Old cubes will not be affected. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3521) Enable Cube Planner by default
[ https://issues.apache.org/jira/browse/KYLIN-3521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16598381#comment-16598381 ] Zhong Yanghong commented on KYLIN-3521: --- +1 for enabling cube planner phase one by default. To enable phase two, currently system cubes need to be setup. > Enable Cube Planner by default > -- > > Key: KYLIN-3521 > URL: https://issues.apache.org/jira/browse/KYLIN-3521 > Project: Kylin > Issue Type: Improvement >Affects Versions: v2.5.0 >Reporter: Shaofeng SHI >Priority: Minor > > Cube planner can significantly reduce the cuboid number that to build. As it > wasn't enabled by default in 2.3 and 2.4, many users don't know that. > > To let more user to start using it, I suggest to enable it by default. As > Cube planner only works when build the first segment, it only affect the > cuboid scheduler of a new Cube. Old cubes will not be affected. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (KYLIN-3521) Enable Cube Planner by default
Shaofeng SHI created KYLIN-3521: --- Summary: Enable Cube Planner by default Key: KYLIN-3521 URL: https://issues.apache.org/jira/browse/KYLIN-3521 Project: Kylin Issue Type: Improvement Affects Versions: v2.5.0 Reporter: Shaofeng SHI Cube planner can significantly reduce the cuboid number that to build. As it wasn't enabled by default in 2.3 and 2.4, many users don't know that. To let more user to start using it, I suggest to enable it by default. As Cube planner only works when build the first segment, it only affect the cuboid scheduler of a new Cube. Old cubes will not be affected. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
