date:20181008

[jira] [Commented] (KYLIN-2924) Utilize error-prone to discover common coding mistakes

2018-10-08 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/KYLIN-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642696#comment-16642696
 ] 

ASF GitHub Bot commented on KYLIN-2924:
---

shaofengshi closed pull request #281: KYLIN-2924 disable google error-prone for 
travis-ci
URL: https://github.com/apache/kylin/pull/281
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/pom.xml b/pom.xml
index f35191f55b..c973d1abce 100644
--- a/pom.xml
+++ b/pom.xml
@@ -1303,27 +1303,7 @@
   true
   1024m
   2048m
-  javac-with-errorprone
-  true
-  
-  ${javaVersion}
-  ${javaVersion}
-  
--XepDisableWarningsInGeneratedCode
-  
 
-
-  
-org.codehaus.plexus
-plexus-compiler-javac-errorprone
-2.8.5
-  
-  
-com.google.errorprone
-error_prone_core
-2.3.1
-  
-
   
 
   
@@ -1470,115 +1450,95 @@
   true
   1024m
   2048m
-  javac-with-errorprone
-  true
-  
-  ${javaVersion}
-  ${javaVersion}
-  
--XepDisableWarningsInGeneratedCode
-  
 
-
-  
-org.codehaus.plexus
-plexus-compiler-javac-errorprone
-2.8.5
-  
-  
-com.google.errorprone
-error_prone_core
-2.3.1
-  
-
-  
-
-  
-org.apache.maven.plugins
-maven-dependency-plugin
-
-  
-copy-jamm
-
-  copy
-
-generate-test-resources
-
-  
-
-  com.github.jbellis
-  jamm
-  ${project.build.testOutputDirectory}
-  
-  jamm.jar
-
-  
-
-  
-
   
 
-  
-org.jacoco
-jacoco-maven-plugin
-
-  true
-  
-${sonar.jacoco.reportPaths}
-  
-
-
-  
-pre-test
-
-  prepare-agent
-
-
-  surefireArgLine
-
-  
-  
-post-test
-test
-
-  report
-
-  
-
-  
-  
-org.apache.maven.plugins
-maven-surefire-plugin
-2.21.0
-
-  ${project.basedir}/../target/surefire-reports
-  
-  
-**/IT*.java
-  
-  
-
-  buildCubeUsingProvidedData
-  false
-
-
-  log4j.configuration
-  
-
file:${project.basedir}/../build/conf/kylin-tools-log4j.properties
-  
-
-  
-  -javaagent:${project.build.testOutputDirectory}/jamm.jar
-${argLine} ${surefireArgLine}
-  
-
-  
-
-  
-
-
-  
+
+  org.apache.maven.plugins
+  maven-dependency-plugin
+  
+
+  copy-jamm
+  
+copy
+  
+  generate-test-resources
+  
+
+  
+com.github.jbellis
+jamm
+${project.build.testOutputDirectory}
+
+jamm.jar
+  
+
+  
+
+  
+
+
+
+  org.jacoco
+  jacoco-maven-plugin
+  
+true
+
+  ${sonar.jacoco.reportPaths}
+
+  
+  
+
+  pre-test
+  
+prepare-agent
+  
+  
+surefireArgLine
+  
+
+
+  post-test
+  test
+  
+report
+  
+
+  
+
+
+  org.apache.maven.plugins
+  maven-surefire-plugin
+  2.21.0
+  
+${project.basedir}/../target/surefire-reports
+

[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues

2018-10-08 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642688#comment-16642688
 ] 

ASF GitHub Bot commented on KYLIN-3597:
---

shaofengshi closed pull request #282: KYLIN-3597 Close resources after they are 
used.
URL: https://github.com/apache/kylin/pull/282
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/core-common/src/main/java/org/apache/kylin/common/persistence/JDBCResourceDAO.java
 
b/core-common/src/main/java/org/apache/kylin/common/persistence/JDBCResourceDAO.java
index dce0894a39..70a049b8a7 100644
--- 
a/core-common/src/main/java/org/apache/kylin/common/persistence/JDBCResourceDAO.java
+++ 
b/core-common/src/main/java/org/apache/kylin/common/persistence/JDBCResourceDAO.java
@@ -442,9 +442,11 @@ public void execute(Connection connection) throws 
SQLException {
 }
 
 private boolean checkTableExists(final String tableName, final 
Connection connection) throws SQLException {
-final PreparedStatement ps = 
connection.prepareStatement(getCheckTableExistsSql(tableName));
-final ResultSet rs = ps.executeQuery();
+PreparedStatement ps = null;
+ResultSet rs = null;
 try {
+ps = 
connection.prepareStatement(getCheckTableExistsSql(tableName));
+rs = ps.executeQuery();
 while (rs.next()) {
 if (tableName.equals(rs.getString(1))) {
 return true;
diff --git 
a/storage-hbase/src/main/java/org/apache/kylin/storage/hbase/steps/SparkCubeHFile.java
 
b/storage-hbase/src/main/java/org/apache/kylin/storage/hbase/steps/SparkCubeHFile.java
index 96690d00de..fd32db5e70 100644
--- 
a/storage-hbase/src/main/java/org/apache/kylin/storage/hbase/steps/SparkCubeHFile.java
+++ 
b/storage-hbase/src/main/java/org/apache/kylin/storage/hbase/steps/SparkCubeHFile.java
@@ -180,58 +180,59 @@ protected void execute(OptionsHelper optionsHelper) 
throws Exception {
 
 //HBase conf
 logger.info("Loading HBase configuration from:{}", hbaseConfFile);
-FSDataInputStream confInput = fs.open(new Path(hbaseConfFile));
-
-Configuration hbaseJobConf = new Configuration();
-hbaseJobConf.addResource(confInput);
-hbaseJobConf.set("spark.hadoop.dfs.replication", "3"); // HFile, 
replication=3
-Job job = Job.getInstance(hbaseJobConf, 
cubeSegment.getStorageLocationIdentifier());
-
-FileOutputFormat.setOutputPath(job, new Path(outputPath));
-
-JavaPairRDD inputRDDs = 
SparkUtil.parseInputPath(inputPath, fs, sc, Text.class, Text.class);
-final JavaPairRDD hfilerdd;
-if (quickPath) {
-hfilerdd = inputRDDs.mapToPair(new PairFunction, RowKeyWritable, KeyValue>() {
-@Override
-public Tuple2 call(Tuple2 textTextTuple2) throws Exception {
-KeyValue outputValue = 
keyValueCreators.get(0).create(textTextTuple2._1,
-textTextTuple2._2.getBytes(), 0, 
textTextTuple2._2.getLength());
-return new Tuple2<>(new 
RowKeyWritable(outputValue.createKeyOnly(false).getKey()), outputValue);
-}
-});
-} else {
-hfilerdd = inputRDDs.flatMapToPair(new 
PairFlatMapFunction, RowKeyWritable, KeyValue>() {
-@Override
-public Iterator> 
call(Tuple2 textTextTuple2)
-throws Exception {
-
-List> result = 
Lists.newArrayListWithExpectedSize(cfNum);
-Object[] inputMeasures = new 
Object[cubeDesc.getMeasures().size()];
-
inputCodec.decode(ByteBuffer.wrap(textTextTuple2._2.getBytes(), 0, 
textTextTuple2._2.getLength()),
-inputMeasures);
-
-for (int i = 0; i < cfNum; i++) {
-KeyValue outputValue = 
keyValueCreators.get(i).create(textTextTuple2._1, inputMeasures);
-result.add(new Tuple2<>(new 
RowKeyWritable(outputValue.createKeyOnly(false).getKey()),
-outputValue));
-}
 
-return result.iterator();
-}
-});
-}
+try (FSDataInputStream confInput = fs.open(new 
Path(hbaseConfFile))) {
+Configuration hbaseJobConf = new Configuration();
+hbaseJobConf.addResource(confInput);
+

[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues

2018-10-08 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642685#comment-16642685
 ] 

ASF GitHub Bot commented on KYLIN-3597:
---

shaofengshi closed pull request #283: KYLIN-3597 fix code smells
URL: https://github.com/apache/kylin/pull/283
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/core-common/src/main/java/org/apache/kylin/common/persistence/BrokenEntity.java
 
b/core-common/src/main/java/org/apache/kylin/common/persistence/BrokenEntity.java
index 6e1b4c28e6..b86b0d984d 100644
--- 
a/core-common/src/main/java/org/apache/kylin/common/persistence/BrokenEntity.java
+++ 
b/core-common/src/main/java/org/apache/kylin/common/persistence/BrokenEntity.java
@@ -22,7 +22,7 @@
 
 public class BrokenEntity extends RootPersistentEntity {
 
-public static final byte[] MAGIC = new byte[]{'B', 'R', 'O', 'K', 'E', 
'N'};
+protected static final byte[] MAGIC = new byte[]{'B', 'R', 'O', 'K', 'E', 
'N'};
 
 @JsonProperty("resPath")
 private String resPath;
diff --git 
a/core-common/src/main/java/org/apache/kylin/common/persistence/FileResourceStore.java
 
b/core-common/src/main/java/org/apache/kylin/common/persistence/FileResourceStore.java
index 18ffd473d0..99e85dc315 100644
--- 
a/core-common/src/main/java/org/apache/kylin/common/persistence/FileResourceStore.java
+++ 
b/core-common/src/main/java/org/apache/kylin/common/persistence/FileResourceStore.java
@@ -161,6 +161,7 @@ protected void putResourceImpl(String resPath, InputStream 
content, long ts) thr
 IOUtils.copy(content, out);
 } finally {
 IOUtils.closeQuietly(out);
+IOUtils.closeQuietly(content);
 }
 
 f.setLastModified(ts);
diff --git 
a/core-common/src/main/java/org/apache/kylin/common/persistence/HDFSResourceStore.java
 
b/core-common/src/main/java/org/apache/kylin/common/persistence/HDFSResourceStore.java
index e5bef40e77..c8819de17f 100644
--- 
a/core-common/src/main/java/org/apache/kylin/common/persistence/HDFSResourceStore.java
+++ 
b/core-common/src/main/java/org/apache/kylin/common/persistence/HDFSResourceStore.java
@@ -65,28 +65,28 @@ public HDFSResourceStore(KylinConfig kylinConfig, 
StorageURL metadataUrl) throws
 if (path == null) {
 // missing path is not expected, but don't fail it
 path = kylinConfig.getHdfsWorkingDirectory() + "tmp_metadata";
-logger.warn("Missing path, fall back to {0}", path);
+logger.warn("Missing path, fall back to %s", path);
 }
 
 fs = HadoopUtil.getFileSystem(path);
 Path metadataPath = new Path(path);
 if (fs.exists(metadataPath) == false) {
-logger.warn("Path not exist in HDFS, create it: {0}", path);
+logger.warn("Path not exist in HDFS, create it: %s", path);
 createMetaFolder(metadataPath);
 }
 
 hdfsMetaPath = metadataPath;
-logger.info("hdfs meta path : {0}", hdfsMetaPath.toString());
+logger.info("hdfs meta path : %s", hdfsMetaPath);
 
 }
 
-private void createMetaFolder(Path metaDirName) throws Exception {
+private void createMetaFolder(Path metaDirName) throws IOException {
 //create hdfs meta path
 if (!fs.exists(metaDirName)) {
 fs.mkdirs(metaDirName);
 }
 
-logger.info("hdfs meta path created: {0}", metaDirName.toString());
+logger.info("hdfs meta path created: %s", metaDirName);
 }
 
 @Override
@@ -175,17 +175,10 @@ protected long getResourceTimestampImpl(String resPath) 
throws IOException {
 if (!fs.exists(p) || !fs.isFile(p)) {
 return 0;
 }
-FSDataInputStream in = null;
-try {
-in = fs.open(p);
+try (FSDataInputStream in = fs.open(p)) {
 long t = in.readLong();
 return t;
-} catch (Exception e) {
-throw new IOException("Put resource fail", e);
-} finally {
-IOUtils.closeQuietly(in);
 }
-
 }
 
 @Override
@@ -193,16 +186,11 @@ protected void putResourceImpl(String resPath, 
InputStream content, long ts) thr
 logger.trace("res path : {0}", resPath);
 Path p = getRealHDFSPath(resPath);
 logger.trace("put resource : {0}", p.toUri());
-FSDataOutputStream out = null;
-try {
-out = fs.create(p, true);
+try (FSDataOutputStream out = fs.create(p, true)) {
 out.writeLong(ts);
 IOUtils.copy(content, out);
-
-} catch (Exception e) {
-throw new IOException("Put resource fail", e);
 }

[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues

2018-10-08 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642659#comment-16642659
 ] 

ASF GitHub Bot commented on KYLIN-3597:
---

codecov-io edited a comment on issue #283: KYLIN-3597 fix code smells
URL: https://github.com/apache/kylin/pull/283#issuecomment-427846885
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/283?src=pr=h1) Report
   > :exclamation: No coverage uploaded for pull request base 
(`master@09c5668`). [Click here to learn what that 
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `19.35%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/kylin/pull/283/graphs/tree.svg?width=650=JawVgbgsVo=150=pr)](https://codecov.io/gh/apache/kylin/pull/283?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ## master #283   +/-   ##
   =
 Coverage  ?   21.28%   
 Complexity? 4437   
   =
 Files ? 1087   
 Lines ?69978   
 Branches  ?10125   
   =
 Hits  ?14896   
 Misses?53680   
 Partials  ? 1402
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/kylin/pull/283?src=pr=tree) | Coverage Δ 
| Complexity Δ | |
   |---|---|---|---|
   | 
[...che/kylin/storage/gtrecord/CubeSegmentScanner.java](https://codecov.io/gh/apache/kylin/pull/283/diff?src=pr=tree#diff-Y29yZS1zdG9yYWdlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9zdG9yYWdlL2d0cmVjb3JkL0N1YmVTZWdtZW50U2Nhbm5lci5qYXZh)
 | `0% <ø> (ø)` | `0 <0> (?)` | |
   | 
[...n/storage/hbase/util/ZookeeperDistributedLock.java](https://codecov.io/gh/apache/kylin/pull/283/diff?src=pr=tree#diff-c3RvcmFnZS1oYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9oYmFzZS91dGlsL1pvb2tlZXBlckRpc3RyaWJ1dGVkTG9jay5qYXZh)
 | `0% <0%> (ø)` | `0 <0> (?)` | |
   | 
[...n/java/org/apache/kylin/common/util/CheckUtil.java](https://codecov.io/gh/apache/kylin/pull/283/diff?src=pr=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi91dGlsL0NoZWNrVXRpbC5qYXZh)
 | `0% <0%> (ø)` | `0 <0> (?)` | |
   | 
[...va/org/apache/kylin/dict/AppendTrieDictionary.java](https://codecov.io/gh/apache/kylin/pull/283/diff?src=pr=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L0FwcGVuZFRyaWVEaWN0aW9uYXJ5LmphdmE=)
 | `57.5% <0%> (ø)` | `13 <0> (?)` | |
   | 
[.../apache/kylin/common/persistence/BrokenEntity.java](https://codecov.io/gh/apache/kylin/pull/283/diff?src=pr=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9wZXJzaXN0ZW5jZS9Ccm9rZW5FbnRpdHkuamF2YQ==)
 | `0% <0%> (ø)` | `0 <0> (?)` | |
   | 
[...kylin/storage/gtrecord/GTCubeStorageQueryBase.java](https://codecov.io/gh/apache/kylin/pull/283/diff?src=pr=tree#diff-Y29yZS1zdG9yYWdlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9zdG9yYWdlL2d0cmVjb3JkL0dUQ3ViZVN0b3JhZ2VRdWVyeUJhc2UuamF2YQ==)
 | `0% <0%> (ø)` | `0 <0> (?)` | |
   | 
[...he/kylin/common/persistence/FileResourceStore.java](https://codecov.io/gh/apache/kylin/pull/283/diff?src=pr=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9wZXJzaXN0ZW5jZS9GaWxlUmVzb3VyY2VTdG9yZS5qYXZh)
 | `71.11% <100%> (ø)` | `28 <0> (?)` | |
   | 
[...he/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://codecov.io/gh/apache/kylin/pull/283/diff?src=pr=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGUuamF2YQ==)
 | `72.22% <33.33%> (ø)` | `5 <0> (?)` | |
   | 
[...he/kylin/common/persistence/HDFSResourceStore.java](https://codecov.io/gh/apache/kylin/pull/283/diff?src=pr=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9wZXJzaXN0ZW5jZS9IREZTUmVzb3VyY2VTdG9yZS5qYXZh)
 | `22.11% <50%> (ø)` | `5 <0> (?)` | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/kylin/pull/283?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/kylin/pull/283?src=pr=footer). Last 
update 
[09c5668...37f3d59](https://codecov.io/gh/apache/kylin/pull/283?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues

2018-10-08 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642656#comment-16642656
 ] 

ASF GitHub Bot commented on KYLIN-3597:
---

coveralls edited a comment on issue #283: KYLIN-3597 fix code smells
URL: https://github.com/apache/kylin/pull/283#issuecomment-427846521
 
 
   ## Pull Request Test Coverage Report for [Build 
3746](https://coveralls.io/builds/19415872)
   
   * **6** of **31**   **(19.35%)**  changed or added relevant lines in **8** 
files are covered.
   * **5** unchanged lines in **3** files lost coverage.
   * Overall coverage increased (+**0.002%**) to **23.293%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-|--||---: |
   | 
[core-common/src/main/java/org/apache/kylin/common/persistence/BrokenEntity.java](https://coveralls.io/builds/19415872/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Fpersistence%2FBrokenEntity.java#L25)
 | 0 | 1 | 0.0%
   | 
[core-dictionary/src/main/java/org/apache/kylin/dict/AppendTrieDictionary.java](https://coveralls.io/builds/19415872/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2FAppendTrieDictionary.java#L120)
 | 0 | 1 | 0.0%
   | 
[core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://coveralls.io/builds/19415872/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2Flookup%2Fcache%2FRocksDBLookupTable.java#L52)
 | 1 | 3 | 33.33%
   | 
[core-common/src/main/java/org/apache/kylin/common/util/CheckUtil.java](https://coveralls.io/builds/19415872/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Futil%2FCheckUtil.java#L30)
 | 0 | 3 | 0.0%
   | 
[core-storage/src/main/java/org/apache/kylin/storage/gtrecord/GTCubeStorageQueryBase.java](https://coveralls.io/builds/19415872/source?filename=core-storage%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fgtrecord%2FGTCubeStorageQueryBase.java#L309)
 | 0 | 3 | 0.0%
   | 
[core-common/src/main/java/org/apache/kylin/common/persistence/HDFSResourceStore.java](https://coveralls.io/builds/19415872/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Fpersistence%2FHDFSResourceStore.java#L178)
 | 4 | 8 | 50.0%
   | 
[storage-hbase/src/main/java/org/apache/kylin/storage/hbase/util/ZookeeperDistributedLock.java](https://coveralls.io/builds/19415872/source?filename=storage-hbase%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fhbase%2Futil%2FZookeeperDistributedLock.java#L51)
 | 0 | 11 | 0.0%
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-|--|--: |
   | 
[core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://coveralls.io/builds/19415872/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2Flookup%2Fcache%2FRocksDBLookupTable.java#L62)
 | 1 | 80.56% |
   | 
[core-storage/src/main/java/org/apache/kylin/storage/gtrecord/CubeSegmentScanner.java](https://coveralls.io/builds/19415872/source?filename=core-storage%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fgtrecord%2FCubeSegmentScanner.java#L101)
 | 2 | 0.0% |
   | 
[core-common/src/main/java/org/apache/kylin/common/persistence/HDFSResourceStore.java](https://coveralls.io/builds/19415872/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Fpersistence%2FHDFSResourceStore.java#L179)
 | 2 | 25.0% |
   
   
   |  Totals | [![Coverage 
Status](https://coveralls.io/builds/19415872/badge)](https://coveralls.io/builds/19415872)
 |
   | :-- | --: |
   | Change from base [Build 3738](https://coveralls.io/builds/19396624): |  
0.002% |
   | Covered Lines: | 16300 |
   | Relevant Lines: | 69978 |
   
   ---
   #   - [Coveralls](https://coveralls.io)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Fix sonar reported static code issues
> -
>
> Key: KYLIN-3597
> URL: https://issues.apache.org/jira/browse/KYLIN-3597
> Project: Kylin
>  Issue Type: Improvement
>  Components: Others
>Reporter: Shaofeng SHI
>Priority: Major
> Fix For: v2.6.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues

2018-10-08 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641875#comment-16641875
 ] 

ASF GitHub Bot commented on KYLIN-3597:
---

codecov-io commented on issue #283: KYLIN-3597 fix code smells
URL: https://github.com/apache/kylin/pull/283#issuecomment-427846885
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/283?src=pr=h1) Report
   > :exclamation: No coverage uploaded for pull request base 
(`master@09c5668`). [Click here to learn what that 
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `15.62%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/kylin/pull/283/graphs/tree.svg?width=650=JawVgbgsVo=150=pr)](https://codecov.io/gh/apache/kylin/pull/283?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ## master #283   +/-   ##
   =
 Coverage  ?   21.29%   
 Complexity? 4437   
   =
 Files ? 1087   
 Lines ?69976   
 Branches  ?10125   
   =
 Hits  ?14898   
 Misses?53677   
 Partials  ? 1401
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/kylin/pull/283?src=pr=tree) | Coverage Δ 
| Complexity Δ | |
   |---|---|---|---|
   | 
[...che/kylin/storage/gtrecord/CubeSegmentScanner.java](https://codecov.io/gh/apache/kylin/pull/283/diff?src=pr=tree#diff-Y29yZS1zdG9yYWdlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9zdG9yYWdlL2d0cmVjb3JkL0N1YmVTZWdtZW50U2Nhbm5lci5qYXZh)
 | `0% <ø> (ø)` | `0 <0> (?)` | |
   | 
[...n/storage/hbase/util/ZookeeperDistributedLock.java](https://codecov.io/gh/apache/kylin/pull/283/diff?src=pr=tree#diff-c3RvcmFnZS1oYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9oYmFzZS91dGlsL1pvb2tlZXBlckRpc3RyaWJ1dGVkTG9jay5qYXZh)
 | `0% <0%> (ø)` | `0 <0> (?)` | |
   | 
[...va/org/apache/kylin/dict/AppendTrieDictionary.java](https://codecov.io/gh/apache/kylin/pull/283/diff?src=pr=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L0FwcGVuZFRyaWVEaWN0aW9uYXJ5LmphdmE=)
 | `57.5% <0%> (ø)` | `13 <0> (?)` | |
   | 
[...n/java/org/apache/kylin/common/util/CheckUtil.java](https://codecov.io/gh/apache/kylin/pull/283/diff?src=pr=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi91dGlsL0NoZWNrVXRpbC5qYXZh)
 | `0% <0%> (ø)` | `0 <0> (?)` | |
   | 
[.../apache/kylin/common/persistence/BrokenEntity.java](https://codecov.io/gh/apache/kylin/pull/283/diff?src=pr=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9wZXJzaXN0ZW5jZS9Ccm9rZW5FbnRpdHkuamF2YQ==)
 | `0% <0%> (ø)` | `0 <0> (?)` | |
   | 
[...kylin/storage/gtrecord/GTCubeStorageQueryBase.java](https://codecov.io/gh/apache/kylin/pull/283/diff?src=pr=tree#diff-Y29yZS1zdG9yYWdlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9zdG9yYWdlL2d0cmVjb3JkL0dUQ3ViZVN0b3JhZ2VRdWVyeUJhc2UuamF2YQ==)
 | `0% <0%> (ø)` | `0 <0> (?)` | |
   | 
[...he/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://codecov.io/gh/apache/kylin/pull/283/diff?src=pr=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGUuamF2YQ==)
 | `77.77% <33.33%> (ø)` | `6 <0> (?)` | |
   | 
[...he/kylin/common/persistence/HDFSResourceStore.java](https://codecov.io/gh/apache/kylin/pull/283/diff?src=pr=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9wZXJzaXN0ZW5jZS9IREZTUmVzb3VyY2VTdG9yZS5qYXZh)
 | `22.33% <40%> (ø)` | `5 <0> (?)` | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/kylin/pull/283?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/kylin/pull/283?src=pr=footer). Last 
update 
[09c5668...5e9ef99](https://codecov.io/gh/apache/kylin/pull/283?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Fix sonar reported static code issues
> -
>
> Key: KYLIN-3597
> URL: https://issues.apache.org/jira/browse/KYLIN-3597
> Project: Kylin
>  Issue Type: Improvement
>  Components: Others
>

[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues

2018-10-08 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641873#comment-16641873
 ] 

ASF GitHub Bot commented on KYLIN-3597:
---

coveralls commented on issue #283: KYLIN-3597 fix code smells
URL: https://github.com/apache/kylin/pull/283#issuecomment-427846521
 
 
   ## Pull Request Test Coverage Report for [Build 
3745](https://coveralls.io/builds/19403977)
   
   * **5** of **32**   **(15.63%)**  changed or added relevant lines in **7** 
files are covered.
   * **7** unchanged lines in **3** files lost coverage.
   * Overall coverage increased (+**0.004%**) to **23.295%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-|--||---: |
   | 
[core-common/src/main/java/org/apache/kylin/common/persistence/BrokenEntity.java](https://coveralls.io/builds/19403977/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Fpersistence%2FBrokenEntity.java#L25)
 | 0 | 1 | 0.0%
   | 
[core-dictionary/src/main/java/org/apache/kylin/dict/AppendTrieDictionary.java](https://coveralls.io/builds/19403977/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2FAppendTrieDictionary.java#L120)
 | 0 | 1 | 0.0%
   | 
[core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://coveralls.io/builds/19403977/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2Flookup%2Fcache%2FRocksDBLookupTable.java#L52)
 | 1 | 3 | 33.33%
   | 
[core-common/src/main/java/org/apache/kylin/common/util/CheckUtil.java](https://coveralls.io/builds/19403977/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Futil%2FCheckUtil.java#L30)
 | 0 | 3 | 0.0%
   | 
[core-storage/src/main/java/org/apache/kylin/storage/gtrecord/GTCubeStorageQueryBase.java](https://coveralls.io/builds/19403977/source?filename=core-storage%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fgtrecord%2FGTCubeStorageQueryBase.java#L309)
 | 0 | 3 | 0.0%
   | 
[core-common/src/main/java/org/apache/kylin/common/persistence/HDFSResourceStore.java](https://coveralls.io/builds/19403977/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Fpersistence%2FHDFSResourceStore.java#L164)
 | 4 | 10 | 40.0%
   | 
[storage-hbase/src/main/java/org/apache/kylin/storage/hbase/util/ZookeeperDistributedLock.java](https://coveralls.io/builds/19403977/source?filename=storage-hbase%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fhbase%2Futil%2FZookeeperDistributedLock.java#L51)
 | 0 | 11 | 0.0%
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-|--|--: |
   | 
[core-storage/src/main/java/org/apache/kylin/storage/gtrecord/CubeSegmentScanner.java](https://coveralls.io/builds/19403977/source?filename=core-storage%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fgtrecord%2FCubeSegmentScanner.java#L101)
 | 2 | 0.0% |
   | 
[core-common/src/main/java/org/apache/kylin/common/persistence/HDFSResourceStore.java](https://coveralls.io/builds/19403977/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Fpersistence%2FHDFSResourceStore.java#L180)
 | 2 | 25.24% |
   | 
[core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/19403977/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L449)
 | 3 | 78.42% |
   
   
   |  Totals | [![Coverage 
Status](https://coveralls.io/builds/19403977/badge)](https://coveralls.io/builds/19403977)
 |
   | :-- | --: |
   | Change from base [Build 3738](https://coveralls.io/builds/19396624): |  
0.004% |
   | Covered Lines: | 16301 |
   | Relevant Lines: | 69976 |
   
   ---
   #   - [Coveralls](https://coveralls.io)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Fix sonar reported static code issues
> -
>
> Key: KYLIN-3597
> URL: https://issues.apache.org/jira/browse/KYLIN-3597
> Project: Kylin
>  Issue Type: Improvement
>  Components: Others
>Reporter: Shaofeng SHI
>Priority: Major
> Fix For: v2.6.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Closed] (KYLIN-3596) kafka使用特殊字符或hql关键字作为key，跑cube作业的时候创建hive临时表报错

2018-10-08 Thread XiaoXiang Yu (JIRA)



 [ 
https://issues.apache.org/jira/browse/KYLIN-3596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

XiaoXiang Yu closed KYLIN-3596.
---
Resolution: Won't Fix

> kafka使用特殊字符或hql关键字作为key，跑cube作业的时候创建hive临时表报错
> -
>
> Key: KYLIN-3596
> URL: https://issues.apache.org/jira/browse/KYLIN-3596
> Project: Kylin
>  Issue Type: Bug
>  Components: Tools, Build and Test
>Affects Versions: v2.4.0
>Reporter: wlxie
>Assignee: XiaoXiang Yu
>Priority: Major
> Attachments: kafka使用关键字作为key.txt
>
>
> 各位老师，
>    在使用kafka作为Streaming Table 
> 的时候，kafka的key包含下划线开头或hql关键字的时候，在跑cube作业的时候创建hive临时表报错。有没有什么配置可以让kylin在创建hive临时表的时候统一给字段名和表名加上反引号。我尝试把hive.support.sql11.reserved.keywords设置为false，但是还是不支持下划线开头和部分关键字。具体错误请参考附件。
>          谢谢。



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues

2018-10-08 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641688#comment-16641688
 ] 

ASF GitHub Bot commented on KYLIN-3597:
---

coveralls commented on issue #282: KYLIN-3597 Close resources after they are 
used.
URL: https://github.com/apache/kylin/pull/282#issuecomment-427801287
 
 
   ## Pull Request Test Coverage Report for [Build 
3743](https://coveralls.io/builds/19401685)
   
   * **0** of **28**   **(0.0%)**  changed or added relevant lines in **2** 
files are covered.
   * **4** unchanged lines in **1** file lost coverage.
   * Overall coverage increased (+**0.0008%**) to **23.292%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-|--||---: |
   | 
[core-common/src/main/java/org/apache/kylin/common/persistence/JDBCResourceDAO.java](https://coveralls.io/builds/19401685/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Fpersistence%2FJDBCResourceDAO.java#L445)
 | 0 | 4 | 0.0%
   | 
[storage-hbase/src/main/java/org/apache/kylin/storage/hbase/steps/SparkCubeHFile.java](https://coveralls.io/builds/19401685/source?filename=storage-hbase%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fhbase%2Fsteps%2FSparkCubeHFile.java#L184)
 | 0 | 24 | 0.0%
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-|--|--: |
   | 
[core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/19401685/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L449)
 | 4 | 78.12% |
   
   
   |  Totals | [![Coverage 
Status](https://coveralls.io/builds/19401685/badge)](https://coveralls.io/builds/19401685)
 |
   | :-- | --: |
   | Change from base [Build 3738](https://coveralls.io/builds/19396624): |  
0.0008% |
   | Covered Lines: | 16301 |
   | Relevant Lines: | 69985 |
   
   ---
   #   - [Coveralls](https://coveralls.io)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Fix sonar reported static code issues
> -
>
> Key: KYLIN-3597
> URL: https://issues.apache.org/jira/browse/KYLIN-3597
> Project: Kylin
>  Issue Type: Improvement
>  Components: Others
>Reporter: Shaofeng SHI
>Priority: Major
> Fix For: v2.6.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues

2018-10-08 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641686#comment-16641686
 ] 

ASF GitHub Bot commented on KYLIN-3597:
---

codecov-io commented on issue #282: KYLIN-3597 Close resources after they are 
used.
URL: https://github.com/apache/kylin/pull/282#issuecomment-427800871
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/282?src=pr=h1) Report
   > :exclamation: No coverage uploaded for pull request base 
(`master@09c5668`). [Click here to learn what that 
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `0%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/kylin/pull/282/graphs/tree.svg?width=650=JawVgbgsVo=150=pr)](https://codecov.io/gh/apache/kylin/pull/282?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ## master #282   +/-   ##
   =
 Coverage  ?   21.28%   
 Complexity? 4437   
   =
 Files ? 1087   
 Lines ?69985   
 Branches  ?10126   
   =
 Hits  ?14897   
 Misses?53686   
 Partials  ? 1402
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/kylin/pull/282?src=pr=tree) | Coverage Δ 
| Complexity Δ | |
   |---|---|---|---|
   | 
[...ache/kylin/storage/hbase/steps/SparkCubeHFile.java](https://codecov.io/gh/apache/kylin/pull/282/diff?src=pr=tree#diff-c3RvcmFnZS1oYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9oYmFzZS9zdGVwcy9TcGFya0N1YmVIRmlsZS5qYXZh)
 | `3.53% <0%> (ø)` | `0 <0> (?)` | |
   | 
[...ache/kylin/common/persistence/JDBCResourceDAO.java](https://codecov.io/gh/apache/kylin/pull/282/diff?src=pr=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9wZXJzaXN0ZW5jZS9KREJDUmVzb3VyY2VEQU8uamF2YQ==)
 | `0% <0%> (ø)` | `0 <0> (?)` | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/kylin/pull/282?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/kylin/pull/282?src=pr=footer). Last 
update 
[09c5668...813ca5b](https://codecov.io/gh/apache/kylin/pull/282?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Fix sonar reported static code issues
> -
>
> Key: KYLIN-3597
> URL: https://issues.apache.org/jira/browse/KYLIN-3597
> Project: Kylin
>  Issue Type: Improvement
>  Components: Others
>Reporter: Shaofeng SHI
>Priority: Major
> Fix For: v2.6.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues

2018-10-08 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641683#comment-16641683
 ] 

ASF GitHub Bot commented on KYLIN-3597:
---

shaofengshi opened a new pull request #283: KYLIN-3597 fix code smells
URL: https://github.com/apache/kylin/pull/283
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Fix sonar reported static code issues
> -
>
> Key: KYLIN-3597
> URL: https://issues.apache.org/jira/browse/KYLIN-3597
> Project: Kylin
>  Issue Type: Improvement
>  Components: Others
>Reporter: Shaofeng SHI
>Priority: Major
> Fix For: v2.6.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues

2018-10-08 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641684#comment-16641684
 ] 

ASF GitHub Bot commented on KYLIN-3597:
---

asfgit commented on issue #283: KYLIN-3597 fix code smells
URL: https://github.com/apache/kylin/pull/283#issuecomment-427800168
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Fix sonar reported static code issues
> -
>
> Key: KYLIN-3597
> URL: https://issues.apache.org/jira/browse/KYLIN-3597
> Project: Kylin
>  Issue Type: Improvement
>  Components: Others
>Reporter: Shaofeng SHI
>Priority: Major
> Fix For: v2.6.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues

2018-10-08 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641673#comment-16641673
 ] 

ASF GitHub Bot commented on KYLIN-3597:
---

asfgit commented on issue #282: KYLIN-3597 Close resources after they are used.
URL: https://github.com/apache/kylin/pull/282#issuecomment-427795874
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Fix sonar reported static code issues
> -
>
> Key: KYLIN-3597
> URL: https://issues.apache.org/jira/browse/KYLIN-3597
> Project: Kylin
>  Issue Type: Improvement
>  Components: Others
>Reporter: Shaofeng SHI
>Priority: Major
> Fix For: v2.6.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues

2018-10-08 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641672#comment-16641672
 ] 

ASF GitHub Bot commented on KYLIN-3597:
---

caolijun1166 opened a new pull request #282: KYLIN-3597 Close resources after 
they are used.
URL: https://github.com/apache/kylin/pull/282
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Fix sonar reported static code issues
> -
>
> Key: KYLIN-3597
> URL: https://issues.apache.org/jira/browse/KYLIN-3597
> Project: Kylin
>  Issue Type: Improvement
>  Components: Others
>Reporter: Shaofeng SHI
>Priority: Major
> Fix For: v2.6.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (KYLIN-2924) Utilize error-prone to discover common coding mistakes

2018-10-08 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/KYLIN-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641548#comment-16641548
 ] 

ASF GitHub Bot commented on KYLIN-2924:
---

coveralls commented on issue #281: KYLIN-2924 disable google error-prone for 
travis-ci
URL: https://github.com/apache/kylin/pull/281#issuecomment-427762555
 
 
   ## Pull Request Test Coverage Report for [Build 
3742](https://coveralls.io/builds/19399562)
   
   * **0** of **0**   changed or added relevant lines in **0** files are 
covered.
   * **21** unchanged lines in **6** files lost coverage.
   * Overall coverage increased (+**0.01%**) to **23.306%**
   
   ---
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-|--|--: |
   | 
[atopcalcite/src/main/java/org/apache/calcite/sql/type/SqlTypeUtil.java](https://coveralls.io/builds/19399562/source?filename=atopcalcite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fcalcite%2Fsql%2Ftype%2FSqlTypeUtil.java#L844)
 | 1 | 0.0% |
   | 
[atopcalcite/src/main/java/org/apache/calcite/tools/Programs.java](https://coveralls.io/builds/19399562/source?filename=atopcalcite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fcalcite%2Ftools%2FPrograms.java#L328)
 | 1 | 0.0% |
   | 
[core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://coveralls.io/builds/19399562/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2Flookup%2Fcache%2FRocksDBLookupTable.java#L64)
 | 1 | 81.08% |
   | 
[core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/19399562/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L449)
 | 4 | 78.12% |
   | 
[atopcalcite/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java](https://coveralls.io/builds/19399562/source?filename=atopcalcite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fcalcite%2Fsql2rel%2FSqlToRelConverter.java#L1593)
 | 7 | 0.0% |
   | 
[atopcalcite/src/main/java/org/apache/calcite/prepare/CalcitePrepareImpl.java](https://coveralls.io/builds/19399562/source?filename=atopcalcite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fcalcite%2Fprepare%2FCalcitePrepareImpl.java#L311)
 | 7 | 0.0% |
   
   
   |  Totals | [![Coverage 
Status](https://coveralls.io/builds/19399562/badge)](https://coveralls.io/builds/19399562)
 |
   | :-- | --: |
   | Change from base [Build 3738](https://coveralls.io/builds/19396624): |  
0.01% |
   | Covered Lines: | 16295 |
   | Relevant Lines: | 69919 |
   
   ---
   #   - [Coveralls](https://coveralls.io)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Utilize error-prone to discover common coding mistakes
> --
>
> Key: KYLIN-2924
> URL: https://issues.apache.org/jira/browse/KYLIN-2924
> Project: Kylin
>  Issue Type: Improvement
>Reporter: Ted Yu
>Assignee: Billy Liu
>Priority: Major
> Fix For: v2.6.0
>
>
> http://errorprone.info/ is a tool which detects common coding mistakes.
> We should incorporate into Kylin build.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (KYLIN-2924) Utilize error-prone to discover common coding mistakes

2018-10-08 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/KYLIN-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641546#comment-16641546
 ] 

ASF GitHub Bot commented on KYLIN-2924:
---

codecov-io commented on issue #281: KYLIN-2924 disable google error-prone for 
travis-ci
URL: https://github.com/apache/kylin/pull/281#issuecomment-427762253
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/281?src=pr=h1) Report
   > :exclamation: No coverage uploaded for pull request base 
(`master@09c5668`). [Click here to learn what that 
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/kylin/pull/281/graphs/tree.svg?width=650=JawVgbgsVo=150=pr)](https://codecov.io/gh/apache/kylin/pull/281?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ## master #281   +/-   ##
   =
 Coverage  ?   21.29%   
 Complexity? 4436   
   =
 Files ? 1087   
 Lines ?69919   
 Branches  ?10101   
   =
 Hits  ?14889   
 Misses?53626   
 Partials  ? 1404
   ```
   
   
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/kylin/pull/281?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/kylin/pull/281?src=pr=footer). Last 
update 
[09c5668...7ea312f](https://codecov.io/gh/apache/kylin/pull/281?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Utilize error-prone to discover common coding mistakes
> --
>
> Key: KYLIN-2924
> URL: https://issues.apache.org/jira/browse/KYLIN-2924
> Project: Kylin
>  Issue Type: Improvement
>Reporter: Ted Yu
>Assignee: Billy Liu
>Priority: Major
> Fix For: v2.6.0
>
>
> http://errorprone.info/ is a tool which detects common coding mistakes.
> We should incorporate into Kylin build.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (KYLIN-2924) Utilize error-prone to discover common coding mistakes

2018-10-08 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/KYLIN-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641513#comment-16641513
 ] 

ASF GitHub Bot commented on KYLIN-2924:
---

shaofengshi commented on issue #281: KYLIN-2924 disable google error-prone for 
travis-ci
URL: https://github.com/apache/kylin/pull/281#issuecomment-427756893
 
 
   Just try if it can make travis-ci happy


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Utilize error-prone to discover common coding mistakes
> --
>
> Key: KYLIN-2924
> URL: https://issues.apache.org/jira/browse/KYLIN-2924
> Project: Kylin
>  Issue Type: Improvement
>Reporter: Ted Yu
>Assignee: Billy Liu
>Priority: Major
> Fix For: v2.6.0
>
>
> http://errorprone.info/ is a tool which detects common coding mistakes.
> We should incorporate into Kylin build.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (KYLIN-2924) Utilize error-prone to discover common coding mistakes

2018-10-08 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/KYLIN-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641511#comment-16641511
 ] 

ASF GitHub Bot commented on KYLIN-2924:
---

asfgit commented on issue #281: KYLIN-2924 disable google error-prone for 
travis-ci
URL: https://github.com/apache/kylin/pull/281#issuecomment-427755080
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Utilize error-prone to discover common coding mistakes
> --
>
> Key: KYLIN-2924
> URL: https://issues.apache.org/jira/browse/KYLIN-2924
> Project: Kylin
>  Issue Type: Improvement
>Reporter: Ted Yu
>Assignee: Billy Liu
>Priority: Major
> Fix For: v2.6.0
>
>
> http://errorprone.info/ is a tool which detects common coding mistakes.
> We should incorporate into Kylin build.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (KYLIN-2924) Utilize error-prone to discover common coding mistakes

2018-10-08 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/KYLIN-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641510#comment-16641510
 ] 

ASF GitHub Bot commented on KYLIN-2924:
---

shaofengshi opened a new pull request #281: KYLIN-2924 disable google 
error-prone for travis-ci
URL: https://github.com/apache/kylin/pull/281
 
 
   Travis-ci failed with message:
   "
   The job exceeded the maximum log length, and has been terminated."
   
   I try to disable errorprone check to reduce the log output.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Utilize error-prone to discover common coding mistakes
> --
>
> Key: KYLIN-2924
> URL: https://issues.apache.org/jira/browse/KYLIN-2924
> Project: Kylin
>  Issue Type: Improvement
>Reporter: Ted Yu
>Assignee: Billy Liu
>Priority: Major
> Fix For: v2.6.0
>
>
> http://errorprone.info/ is a tool which detects common coding mistakes.
> We should incorporate into Kylin build.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (KYLIN-3616) Create Intermediate Flat Hive Table失败

2018-10-08 Thread LinRongRen (JIRA)

LinRongRen created KYLIN-3616:
-

 Summary: Create Intermediate Flat Hive Table失败
 Key: KYLIN-3616
 URL: https://issues.apache.org/jira/browse/KYLIN-3616
 Project: Kylin
  Issue Type: Bug
  Components: Environment 
Affects Versions: v1.5.3
Reporter: LinRongRen
 Fix For: v1.5.3


创建cube的时候,在Monitor模块观察,执行完第一步:Count Source Table
执行第二步:Create Intermediate Flat Hive Table出现错误Error
日志提示:
total input rows = 4541
expected input rows per mapper = 100
reducers for RedistributeFlatHiveTableStep = 1
Create and distribute table, cmd: 
hive -e "SET dfs.replication=2;
SET hive.exec.compress.output=true;
SET hive.auto.convert.join.noconditionaltask=true;
SET hive.auto.convert.join.noconditionaltask.size=1;
SET 
mapreduce.map.output.compress.codec=org.apache.hadoop.io.compress.SnappyCodec;
SET 
mapreduce.output.fileoutputformat.compress.codec=org.apache.hadoop.io.compress.SnappyCodec;
SET mapred.output.compression.type=BLOCK;
SET mapreduce.job.split.metainfo.maxsize=-1;

set mapreduce.job.reduces=1;

set hive.merge.mapredfiles=false;

USE default;
DROP TABLE IF EXISTS 
kylin_intermediate_kylin_sales_cube_desc_2012010100_2012120100;
CREATE EXTERNAL TABLE IF NOT EXISTS 
kylin_intermediate_kylin_sales_cube_desc_2012010100_2012120100
(
DEFAULT_KYLIN_SALES_PART_DT date
,DEFAULT_KYLIN_SALES_LEAF_CATEG_ID bigint
,DEFAULT_KYLIN_SALES_LSTG_SITE_ID int
,DEFAULT_KYLIN_CATEGORY_GROUPINGS_META_CATEG_NAME string
,DEFAULT_KYLIN_CATEGORY_GROUPINGS_CATEG_LVL2_NAME string
,DEFAULT_KYLIN_CATEGORY_GROUPINGS_CATEG_LVL3_NAME string
,DEFAULT_KYLIN_SALES_LSTG_FORMAT_NAME string
,DEFAULT_KYLIN_SALES_PRICE decimal(19,4)
,DEFAULT_KYLIN_SALES_SELLER_ID bigint
)
ROW FORMAT DELIMITED FIELDS TERMINATED BY '\177'
STORED AS SEQUENCEFILE
LOCATION 
'/kylin/kylin_metadata/kylin-cc7811cc-3494-4db0-b24e-4a3d76d22186/kylin_intermediate_kylin_sales_cube_desc_2012010100_2012120100';
SET dfs.replication=2;
SET hive.exec.compress.output=true;
SET hive.auto.convert.join.noconditionaltask=true;
SET hive.auto.convert.join.noconditionaltask.size=1;
SET 
mapreduce.map.output.compress.codec=org.apache.hadoop.io.compress.SnappyCodec;
SET 
mapreduce.output.fileoutputformat.compress.codec=org.apache.hadoop.io.compress.SnappyCodec;
SET mapred.output.compression.type=BLOCK;
SET mapreduce.job.split.metainfo.maxsize=-1;
INSERT OVERWRITE TABLE 
kylin_intermediate_kylin_sales_cube_desc_2012010100_2012120100 SELECT
KYLIN_SALES.PART_DT
,KYLIN_SALES.LEAF_CATEG_ID
,KYLIN_SALES.LSTG_SITE_ID
,KYLIN_CATEGORY_GROUPINGS.META_CATEG_NAME
,KYLIN_CATEGORY_GROUPINGS.CATEG_LVL2_NAME
,KYLIN_CATEGORY_GROUPINGS.CATEG_LVL3_NAME
,KYLIN_SALES.LSTG_FORMAT_NAME
,KYLIN_SALES.PRICE
,KYLIN_SALES.SELLER_ID
FROM DEFAULT.KYLIN_SALES as KYLIN_SALES 
INNER JOIN DEFAULT.KYLIN_CAL_DT as KYLIN_CAL_DT
ON KYLIN_SALES.PART_DT = KYLIN_CAL_DT.CAL_DT
INNER JOIN DEFAULT.KYLIN_CATEGORY_GROUPINGS as KYLIN_CATEGORY_GROUPINGS
ON KYLIN_SALES.LEAF_CATEG_ID = KYLIN_CATEGORY_GROUPINGS.LEAF_CATEG_ID AND 
KYLIN_SALES.LSTG_SITE_ID = KYLIN_CATEGORY_GROUPINGS.SITE_ID
WHERE (KYLIN_SALES.PART_DT >= '2012-01-01' AND KYLIN_SALES.PART_DT < 
'2012-12-01')
 DISTRIBUTE BY RAND();

"

Logging initialized using configuration in 
jar:file:/home/hadoop/apps/apache-hive-1.2.1-bin/lib/hive-common-1.2.1.jar!/hive-log4j.properties
OK
Time taken: 0.884 seconds
OK
Time taken: 0.577 seconds
OK
Time taken: 0.815 seconds
Query ID = hadoop_20181008182637_13291646-6c23-4431-8a8e-401ced7aa67a
Total jobs = 1
18/10/08 18:26:54 WARN util.NativeCodeLoader: Unable to load native-hadoop 
library for your platform... using builtin-java classes where applicable
Execution log at: 
/tmp/hadoop/hadoop_20181008182637_13291646-6c23-4431-8a8e-401ced7aa67a.log
2018-10-08 18:26:57 Starting to launch local task to process map join; maximum 
memory = 518979584
2018-10-08 18:26:59 Dump the side-table for tag: 1 with group count: 144 into 
file: 
file:/tmp/hadoop/bba84efe-adae-431c-a167-14cd272ebd80/hive_2018-10-08_18-26-37_130_1316609404572806670-1/-local-10004/HashTable-Stage-3/MapJoin-mapfile01--.hashtable
2018-10-08 18:26:59 Uploaded 1 File to: 
file:/tmp/hadoop/bba84efe-adae-431c-a167-14cd272ebd80/hive_2018-10-08_18-26-37_130_1316609404572806670-1/-local-10004/HashTable-Stage-3/MapJoin-mapfile01--.hashtable
 (10893 bytes)
2018-10-08 18:26:59 Dump the side-table for tag: 0 with group count: 334 into 
file: 
file:/tmp/hadoop/bba84efe-adae-431c-a167-14cd272ebd80/hive_2018-10-08_18-26-37_130_1316609404572806670-1/-local-10004/HashTable-Stage-3/MapJoin-mapfile10--.hashtable
2018-10-08 18:26:59 Uploaded 1 File to: 
file:/tmp/hadoop/bba84efe-adae-431c-a167-14cd272ebd80/hive_2018-10-08_18-26-37_130_1316609404572806670-1/-local-10004/HashTable-Stage-3/MapJoin-mapfile10--.hashtable
 (123354 bytes)
2018-10-08 18:26:59 End of local task; Time Taken: 2.845 sec.
Execution completed successfully

[jira] [Created] (KYLIN-3615) Create Intermediate Flat Hive Table

2018-10-08 Thread LinRongRen (JIRA)

LinRongRen created KYLIN-3615:
-

 Summary: Create Intermediate Flat Hive Table
 Key: KYLIN-3615
 URL: https://issues.apache.org/jira/browse/KYLIN-3615
 Project: Kylin
  Issue Type: Bug
  Components: Environment 
Affects Versions: v1.5.3
 Environment: 集群环境:
hadoop 2.6.4
hive 1.2.1(apache-hive-2.3.3-bin)
hbase-1.1.3-bin.tar
zookeeper 3.4.5
apache-kylin-1.5.3-HBase1.x-bin.tar
Reporter: LinRongRen


在创建cube的时候,执行完第一步:Count Source Table.到第二步:Create Intermediate Flat Hive 
Table,就提示Error

日志提示:
total input rows = 4541
expected input rows per mapper = 100
reducers for RedistributeFlatHiveTableStep = 1
Create and distribute table, cmd: 
hive -e "SET dfs.replication=2;
SET hive.exec.compress.output=true;
SET hive.auto.convert.join.noconditionaltask=true;
SET hive.auto.convert.join.noconditionaltask.size=1;
SET 
mapreduce.map.output.compress.codec=org.apache.hadoop.io.compress.SnappyCodec;
SET 
mapreduce.output.fileoutputformat.compress.codec=org.apache.hadoop.io.compress.SnappyCodec;
SET mapred.output.compression.type=BLOCK;
SET mapreduce.job.split.metainfo.maxsize=-1;

set mapreduce.job.reduces=1;

set hive.merge.mapredfiles=false;

USE default;
DROP TABLE IF EXISTS 
kylin_intermediate_kylin_sales_cube_desc_2012010100_2012120100;
CREATE EXTERNAL TABLE IF NOT EXISTS 
kylin_intermediate_kylin_sales_cube_desc_2012010100_2012120100
(
DEFAULT_KYLIN_SALES_PART_DT date
,DEFAULT_KYLIN_SALES_LEAF_CATEG_ID bigint
,DEFAULT_KYLIN_SALES_LSTG_SITE_ID int
,DEFAULT_KYLIN_CATEGORY_GROUPINGS_META_CATEG_NAME string
,DEFAULT_KYLIN_CATEGORY_GROUPINGS_CATEG_LVL2_NAME string
,DEFAULT_KYLIN_CATEGORY_GROUPINGS_CATEG_LVL3_NAME string
,DEFAULT_KYLIN_SALES_LSTG_FORMAT_NAME string
,DEFAULT_KYLIN_SALES_PRICE decimal(19,4)
,DEFAULT_KYLIN_SALES_SELLER_ID bigint
)
ROW FORMAT DELIMITED FIELDS TERMINATED BY '\177'
STORED AS SEQUENCEFILE
LOCATION 
'/kylin/kylin_metadata/kylin-cc7811cc-3494-4db0-b24e-4a3d76d22186/kylin_intermediate_kylin_sales_cube_desc_2012010100_2012120100';
SET dfs.replication=2;
SET hive.exec.compress.output=true;
SET hive.auto.convert.join.noconditionaltask=true;
SET hive.auto.convert.join.noconditionaltask.size=1;
SET 
mapreduce.map.output.compress.codec=org.apache.hadoop.io.compress.SnappyCodec;
SET 
mapreduce.output.fileoutputformat.compress.codec=org.apache.hadoop.io.compress.SnappyCodec;
SET mapred.output.compression.type=BLOCK;
SET mapreduce.job.split.metainfo.maxsize=-1;
INSERT OVERWRITE TABLE 
kylin_intermediate_kylin_sales_cube_desc_2012010100_2012120100 SELECT
KYLIN_SALES.PART_DT
,KYLIN_SALES.LEAF_CATEG_ID
,KYLIN_SALES.LSTG_SITE_ID
,KYLIN_CATEGORY_GROUPINGS.META_CATEG_NAME
,KYLIN_CATEGORY_GROUPINGS.CATEG_LVL2_NAME
,KYLIN_CATEGORY_GROUPINGS.CATEG_LVL3_NAME
,KYLIN_SALES.LSTG_FORMAT_NAME
,KYLIN_SALES.PRICE
,KYLIN_SALES.SELLER_ID
FROM DEFAULT.KYLIN_SALES as KYLIN_SALES 
INNER JOIN DEFAULT.KYLIN_CAL_DT as KYLIN_CAL_DT
ON KYLIN_SALES.PART_DT = KYLIN_CAL_DT.CAL_DT
INNER JOIN DEFAULT.KYLIN_CATEGORY_GROUPINGS as KYLIN_CATEGORY_GROUPINGS
ON KYLIN_SALES.LEAF_CATEG_ID = KYLIN_CATEGORY_GROUPINGS.LEAF_CATEG_ID AND 
KYLIN_SALES.LSTG_SITE_ID = KYLIN_CATEGORY_GROUPINGS.SITE_ID
WHERE (KYLIN_SALES.PART_DT >= '2012-01-01' AND KYLIN_SALES.PART_DT < 
'2012-12-01')
 DISTRIBUTE BY RAND();

"

Logging initialized using configuration in 
jar:file:/home/hadoop/apps/apache-hive-1.2.1-bin/lib/hive-common-1.2.1.jar!/hive-log4j.properties
OK
Time taken: 0.884 seconds
OK
Time taken: 0.577 seconds
OK
Time taken: 0.815 seconds
Query ID = hadoop_20181008182637_13291646-6c23-4431-8a8e-401ced7aa67a
Total jobs = 1
18/10/08 18:26:54 WARN util.NativeCodeLoader: Unable to load native-hadoop 
library for your platform... using builtin-java classes where applicable
Execution log at: 
/tmp/hadoop/hadoop_20181008182637_13291646-6c23-4431-8a8e-401ced7aa67a.log
2018-10-08 18:26:57 Starting to launch local task to process map join;  
maximum memory = 518979584
2018-10-08 18:26:59 Dump the side-table for tag: 1 with group count: 144 
into file: 
file:/tmp/hadoop/bba84efe-adae-431c-a167-14cd272ebd80/hive_2018-10-08_18-26-37_130_1316609404572806670-1/-local-10004/HashTable-Stage-3/MapJoin-mapfile01--.hashtable
2018-10-08 18:26:59 Uploaded 1 File to: 
file:/tmp/hadoop/bba84efe-adae-431c-a167-14cd272ebd80/hive_2018-10-08_18-26-37_130_1316609404572806670-1/-local-10004/HashTable-Stage-3/MapJoin-mapfile01--.hashtable
 (10893 bytes)
2018-10-08 18:26:59 Dump the side-table for tag: 0 with group count: 334 
into file: 
file:/tmp/hadoop/bba84efe-adae-431c-a167-14cd272ebd80/hive_2018-10-08_18-26-37_130_1316609404572806670-1/-local-10004/HashTable-Stage-3/MapJoin-mapfile10--.hashtable
2018-10-08 18:26:59 Uploaded 1 File to:

[jira] [Commented] (KYLIN-2924) Utilize error-prone to discover common coding mistakes

[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues

[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues

[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues

[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues

[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues

[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues

[jira] [Closed] (KYLIN-3596) kafka使用特殊字符或hql关键字作为key，跑cube作业的时候创建hive临时表报错

[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues

[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues

[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues

[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues

[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues

[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues

[jira] [Commented] (KYLIN-2924) Utilize error-prone to discover common coding mistakes

[jira] [Commented] (KYLIN-2924) Utilize error-prone to discover common coding mistakes

[jira] [Commented] (KYLIN-2924) Utilize error-prone to discover common coding mistakes

[jira] [Commented] (KYLIN-2924) Utilize error-prone to discover common coding mistakes

[jira] [Commented] (KYLIN-2924) Utilize error-prone to discover common coding mistakes

[jira] [Created] (KYLIN-3616) Create Intermediate Flat Hive Table失败

[jira] [Created] (KYLIN-3615) Create Intermediate Flat Hive Table

21 matches

Site Navigation

Mail list logo

Footer information