[jira] [Commented] (KYLIN-3804) Advanced Snapshot Table save not friendly

2019-02-01 Thread Billy Liu (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16758834#comment-16758834
 ] 

Billy Liu commented on KYLIN-3804:
--

+1

> Advanced Snapshot Table save not friendly
> -
>
> Key: KYLIN-3804
> URL: https://issues.apache.org/jira/browse/KYLIN-3804
> Project: Kylin
>  Issue Type: Improvement
>  Components: Web 
>Reporter: Pan, Julian
>Assignee: Pan, Julian
>Priority: Critical
> Attachments: new implementation-edit.png, new 
> implementation-saved.png, not save.png, save.png
>
>
> The configuration for "Advanced Snapshot Table" in "Advance Setting" may 
> confuse customer. 
> User need click "+" to save the snapshot info.
> Change the the implementation similar with "Advanced Dictionaries". 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] coveralls commented on issue #462: KYLIN-3804 Advanced Snapshot Table save not friendly

2019-02-01 Thread GitBox
coveralls commented on issue #462: KYLIN-3804 Advanced Snapshot Table save not 
friendly
URL: https://github.com/apache/kylin/pull/462#issuecomment-459711776
 
 
   ## Pull Request Test Coverage Report for [Build 
4108](https://coveralls.io/builds/21401387)
   
   * **0** of **0**   changed or added relevant lines in **0** files are 
covered.
   * No unchanged relevant lines lost coverage.
   * Overall coverage increased (+**0.004%**) to **26.953%**
   
   ---
   
   
   
   |  Totals | [![Coverage 
Status](https://coveralls.io/builds/21401387/badge)](https://coveralls.io/builds/21401387)
 |
   | :-- | --: |
   | Change from base [Build 4103](https://coveralls.io/builds/21370739): |  
0.004% |
   | Covered Lines: | 18703 |
   | Relevant Lines: | 69390 |
   
   ---
   #   - [Coveralls](https://coveralls.io)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] asfgit commented on issue #462: KYLIN-3804 Advanced Snapshot Table save not friendly

2019-02-01 Thread GitBox
asfgit commented on issue #462: KYLIN-3804 Advanced Snapshot Table save not 
friendly
URL: https://github.com/apache/kylin/pull/462#issuecomment-459705960
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] asfgit commented on issue #462: KYLIN-3804 Advanced Snapshot Table save not friendly

2019-02-01 Thread GitBox
asfgit commented on issue #462: KYLIN-3804 Advanced Snapshot Table save not 
friendly
URL: https://github.com/apache/kylin/pull/462#issuecomment-459705963
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (KYLIN-3804) Advanced Snapshot Table save not friendly

2019-02-01 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16758255#comment-16758255
 ] 

ASF GitHub Bot commented on KYLIN-3804:
---

sanjulian commented on pull request #462: KYLIN-3804 Advanced Snapshot Table 
save not friendly
URL: https://github.com/apache/kylin/pull/462
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Advanced Snapshot Table save not friendly
> -
>
> Key: KYLIN-3804
> URL: https://issues.apache.org/jira/browse/KYLIN-3804
> Project: Kylin
>  Issue Type: Improvement
>  Components: Web 
>Reporter: Pan, Julian
>Assignee: Pan, Julian
>Priority: Critical
> Attachments: new implementation-edit.png, new 
> implementation-saved.png, not save.png, save.png
>
>
> The configuration for "Advanced Snapshot Table" in "Advance Setting" may 
> confuse customer. 
> User need click "+" to save the snapshot info.
> Change the the implementation similar with "Advanced Dictionaries". 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] asfgit commented on issue #462: KYLIN-3804 Advanced Snapshot Table save not friendly

2019-02-01 Thread GitBox
asfgit commented on issue #462: KYLIN-3804 Advanced Snapshot Table save not 
friendly
URL: https://github.com/apache/kylin/pull/462#issuecomment-459705961
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] sanjulian opened a new pull request #462: KYLIN-3804 Advanced Snapshot Table save not friendly

2019-02-01 Thread GitBox
sanjulian opened a new pull request #462: KYLIN-3804 Advanced Snapshot Table 
save not friendly
URL: https://github.com/apache/kylin/pull/462
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Updated] (KYLIN-3804) Advanced Snapshot Table save not friendly

2019-02-01 Thread Pan, Julian (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pan, Julian updated KYLIN-3804:
---
Attachment: (was: after change-edit.png)

> Advanced Snapshot Table save not friendly
> -
>
> Key: KYLIN-3804
> URL: https://issues.apache.org/jira/browse/KYLIN-3804
> Project: Kylin
>  Issue Type: Improvement
>  Components: Web 
>Reporter: Pan, Julian
>Assignee: Pan, Julian
>Priority: Critical
> Attachments: new implementation-edit.png, new 
> implementation-saved.png, not save.png, save.png
>
>
> The configuration for "Advanced Snapshot Table" in "Advance Setting" may 
> confuse customer. 
> User need click "+" to save the snapshot info.
> Change the the implementation similar with "Advanced Dictionaries". 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (KYLIN-3804) Advanced Snapshot Table save not friendly

2019-02-01 Thread Pan, Julian (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pan, Julian updated KYLIN-3804:
---
Attachment: after change-edit.png
after change-saved.png

> Advanced Snapshot Table save not friendly
> -
>
> Key: KYLIN-3804
> URL: https://issues.apache.org/jira/browse/KYLIN-3804
> Project: Kylin
>  Issue Type: Improvement
>  Components: Web 
>Reporter: Pan, Julian
>Assignee: Pan, Julian
>Priority: Critical
> Attachments: after change-edit.png, after change-saved.png, not 
> save.png, save.png
>
>
> The configuration for "Advanced Snapshot Table" in "Advance Setting" may 
> confuse customer. 
> User need click "+" to save the snapshot info.
> Change the the implementation similar with "Advanced Dictionaries". 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (KYLIN-3804) Advanced Snapshot Table save not friendly

2019-02-01 Thread Pan, Julian (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pan, Julian updated KYLIN-3804:
---
Attachment: new implementation-edit.png
new implementation-saved.png

> Advanced Snapshot Table save not friendly
> -
>
> Key: KYLIN-3804
> URL: https://issues.apache.org/jira/browse/KYLIN-3804
> Project: Kylin
>  Issue Type: Improvement
>  Components: Web 
>Reporter: Pan, Julian
>Assignee: Pan, Julian
>Priority: Critical
> Attachments: new implementation-edit.png, new 
> implementation-saved.png, not save.png, save.png
>
>
> The configuration for "Advanced Snapshot Table" in "Advance Setting" may 
> confuse customer. 
> User need click "+" to save the snapshot info.
> Change the the implementation similar with "Advanced Dictionaries". 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (KYLIN-3804) Advanced Snapshot Table save not friendly

2019-02-01 Thread Pan, Julian (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pan, Julian updated KYLIN-3804:
---
Attachment: (was: after change-saved.png)

> Advanced Snapshot Table save not friendly
> -
>
> Key: KYLIN-3804
> URL: https://issues.apache.org/jira/browse/KYLIN-3804
> Project: Kylin
>  Issue Type: Improvement
>  Components: Web 
>Reporter: Pan, Julian
>Assignee: Pan, Julian
>Priority: Critical
> Attachments: new implementation-edit.png, new 
> implementation-saved.png, not save.png, save.png
>
>
> The configuration for "Advanced Snapshot Table" in "Advance Setting" may 
> confuse customer. 
> User need click "+" to save the snapshot info.
> Change the the implementation similar with "Advanced Dictionaries". 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (KYLIN-3804) Advanced Snapshot Table save not friendly

2019-02-01 Thread Pan, Julian (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pan, Julian updated KYLIN-3804:
---
Attachment: not save.png

> Advanced Snapshot Table save not friendly
> -
>
> Key: KYLIN-3804
> URL: https://issues.apache.org/jira/browse/KYLIN-3804
> Project: Kylin
>  Issue Type: Improvement
>  Components: Web 
>Reporter: Pan, Julian
>Assignee: Pan, Julian
>Priority: Critical
> Attachments: not save.png, save.png
>
>
> The configuration for "Advanced Snapshot Table" in "Advance Setting" may 
> confuse customer. 
> User need click "+" to save the snapshot info.
> Change the the implementation similar with "Advanced Dictionaries". 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (KYLIN-3804) Advanced Snapshot Table save not friendly

2019-02-01 Thread Pan, Julian (JIRA)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pan, Julian updated KYLIN-3804:
---
Attachment: save.png

> Advanced Snapshot Table save not friendly
> -
>
> Key: KYLIN-3804
> URL: https://issues.apache.org/jira/browse/KYLIN-3804
> Project: Kylin
>  Issue Type: Improvement
>  Components: Web 
>Reporter: Pan, Julian
>Assignee: Pan, Julian
>Priority: Critical
> Attachments: not save.png, save.png
>
>
> The configuration for "Advanced Snapshot Table" in "Advance Setting" may 
> confuse customer. 
> User need click "+" to save the snapshot info.
> Change the the implementation similar with "Advanced Dictionaries". 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (KYLIN-3804) Advanced Snapshot Table save not friendly

2019-02-01 Thread Pan, Julian (JIRA)
Pan, Julian created KYLIN-3804:
--

 Summary: Advanced Snapshot Table save not friendly
 Key: KYLIN-3804
 URL: https://issues.apache.org/jira/browse/KYLIN-3804
 Project: Kylin
  Issue Type: Improvement
  Components: Web 
Reporter: Pan, Julian
Assignee: Pan, Julian


The configuration for "Advanced Snapshot Table" in "Advance Setting" may 
confuse customer. 

User need click "+" to save the snapshot info.

Change the the implementation similar with "Advanced Dictionaries". 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3803) query result not correct when lookup table is joined twice

2019-02-01 Thread Zhong Yanghong (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16758085#comment-16758085
 ] 

Zhong Yanghong commented on KYLIN-3803:
---

Should add column aliases. Otherwise, result of the second one will be overrode 
by the first one. 
{code}
select SELLER_COUNTRY.NAME as SELLER_COUNTRY_NAME, BUYER_COUNTRY.NAME as 
BUYER_COUNTRY_NAME, sum(PRICE)
{code}
{code}
FROM TEST_KYLIN_FACT
LEFT JOIN TEST_ORDER as TEST_ORDER
ON TEST_KYLIN_FACT.ORDER_ID = TEST_ORDER.ORDER_ID
LEFT JOIN EDW.TEST_CAL_DT as TEST_CAL_DT
ON TEST_KYLIN_FACT.CAL_DT = TEST_CAL_DT.CAL_DT
LEFT JOIN TEST_CATEGORY_GROUPINGS
ON TEST_KYLIN_FACT.LEAF_CATEG_ID = TEST_CATEGORY_GROUPINGS.LEAF_CATEG_ID AND 
TEST_KYLIN_FACT.LSTG_SITE_ID = TEST_CATEGORY_GROUPINGS.SITE_ID
LEFT JOIN EDW.TEST_SITES as TEST_SITES
ON TEST_KYLIN_FACT.LSTG_SITE_ID = TEST_SITES.SITE_ID
LEFT JOIN EDW.TEST_SELLER_TYPE_DIM as TEST_SELLER_TYPE_DIM
ON TEST_KYLIN_FACT.SLR_SEGMENT_CD = TEST_SELLER_TYPE_DIM.SELLER_TYPE_CD
LEFT JOIN TEST_ACCOUNT as SELLER_ACCOUNT
ON TEST_KYLIN_FACT.SELLER_ID = SELLER_ACCOUNT.ACCOUNT_ID
LEFT JOIN TEST_ACCOUNT as BUYER_ACCOUNT
ON TEST_ORDER.BUYER_ID = BUYER_ACCOUNT.ACCOUNT_ID
LEFT JOIN TEST_COUNTRY as SELLER_COUNTRY
ON SELLER_ACCOUNT.ACCOUNT_COUNTRY = SELLER_COUNTRY.COUNTRY
LEFT JOIN TEST_COUNTRY as BUYER_COUNTRY
ON BUYER_ACCOUNT.ACCOUNT_COUNTRY = BUYER_COUNTRY.COUNTRY
group by SELLER_COUNTRY.NAME, BUYER_COUNTRY.NAME
order by SELLER_COUNTRY.NAME, BUYER_COUNTRY.NAME
{code}

> query result not correct when lookup table is joined twice
> --
>
> Key: KYLIN-3803
> URL: https://issues.apache.org/jira/browse/KYLIN-3803
> Project: Kylin
>  Issue Type: Bug
>  Components: Query Engine
>Reporter: Zhong Yanghong
>Priority: Major
>
> {code}
> select SELLER_COUNTRY.NAME, BUYER_COUNTRY.NAME, sum(PRICE)
> FROM TEST_KYLIN_FACT
> LEFT JOIN TEST_ORDER as TEST_ORDER
> ON TEST_KYLIN_FACT.ORDER_ID = TEST_ORDER.ORDER_ID
> LEFT JOIN EDW.TEST_CAL_DT as TEST_CAL_DT
> ON TEST_KYLIN_FACT.CAL_DT = TEST_CAL_DT.CAL_DT
> LEFT JOIN TEST_CATEGORY_GROUPINGS
> ON TEST_KYLIN_FACT.LEAF_CATEG_ID = TEST_CATEGORY_GROUPINGS.LEAF_CATEG_ID AND 
> TEST_KYLIN_FACT.LSTG_SITE_ID = TEST_CATEGORY_GROUPINGS.SITE_ID
> LEFT JOIN EDW.TEST_SITES as TEST_SITES
> ON TEST_KYLIN_FACT.LSTG_SITE_ID = TEST_SITES.SITE_ID
> LEFT JOIN EDW.TEST_SELLER_TYPE_DIM as TEST_SELLER_TYPE_DIM
> ON TEST_KYLIN_FACT.SLR_SEGMENT_CD = TEST_SELLER_TYPE_DIM.SELLER_TYPE_CD
> LEFT JOIN TEST_ACCOUNT as SELLER_ACCOUNT
> ON TEST_KYLIN_FACT.SELLER_ID = SELLER_ACCOUNT.ACCOUNT_ID
> LEFT JOIN TEST_ACCOUNT as BUYER_ACCOUNT
> ON TEST_ORDER.BUYER_ID = BUYER_ACCOUNT.ACCOUNT_ID
> LEFT JOIN TEST_COUNTRY as SELLER_COUNTRY
> ON SELLER_ACCOUNT.ACCOUNT_COUNTRY = SELLER_COUNTRY.COUNTRY
> LEFT JOIN TEST_COUNTRY as BUYER_COUNTRY
> ON BUYER_ACCOUNT.ACCOUNT_COUNTRY = BUYER_COUNTRY.COUNTRY
> group by SELLER_COUNTRY.NAME, BUYER_COUNTRY.NAME
> order by SELLER_COUNTRY.NAME, BUYER_COUNTRY.NAME
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)