[GitHub] [kylin] codecov-io edited a comment on issue #763: how to create custom measure
codecov-io edited a comment on issue #763: how to create custom measure URL: https://github.com/apache/kylin/pull/763#issuecomment-513434521 # [Codecov](https://codecov.io/gh/apache/kylin/pull/763?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`v-3.0.0-alpha-release@ae4f2e3`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is `16.5%`. [](https://codecov.io/gh/apache/kylin/pull/763?src=pr=tree) ```diff @@ Coverage Diff@@ ## v-3.0.0-alpha-release #763 +/- ## Coverage ? 25.71% Complexity ? 6022 Files? 1387 Lines?82828 Branches ?11597 Hits ?21296 Misses ?59486 Partials ? 2046 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/763?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...a/org/apache/kylin/job/engine/JobEngineConfig.java](https://codecov.io/gh/apache/kylin/pull/763/diff?src=pr=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9lbmdpbmUvSm9iRW5naW5lQ29uZmlnLmphdmE=) | `13.55% <ø> (ø)` | `6 <0> (?)` | | | [.../storage/hbase/steps/HBaseMROutput2Transition.java](https://codecov.io/gh/apache/kylin/pull/763/diff?src=pr=tree#diff-c3RvcmFnZS1oYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9oYmFzZS9zdGVwcy9IQmFzZU1ST3V0cHV0MlRyYW5zaXRpb24uamF2YQ==) | `0% <ø> (ø)` | `0 <0> (?)` | | | [...apache/kylin/rest/response/CuboidTreeResponse.java](https://codecov.io/gh/apache/kylin/pull/763/diff?src=pr=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvcmVzcG9uc2UvQ3Vib2lkVHJlZVJlc3BvbnNlLmphdmE=) | `0% <ø> (ø)` | `0 <0> (?)` | | | [...lin/source/hive/RedistributeFlatHiveTableStep.java](https://codecov.io/gh/apache/kylin/pull/763/diff?src=pr=tree#diff-c291cmNlLWhpdmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3NvdXJjZS9oaXZlL1JlZGlzdHJpYnV0ZUZsYXRIaXZlVGFibGVTdGVwLmphdmE=) | `0% <ø> (ø)` | `0 <0> (?)` | | | [...n/java/org/apache/kylin/cube/kv/CubeDimEncMap.java](https://codecov.io/gh/apache/kylin/pull/763/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2t2L0N1YmVEaW1FbmNNYXAuamF2YQ==) | `64.28% <ø> (ø)` | `5 <0> (?)` | | | [...java/org/apache/kylin/query/util/PushDownUtil.java](https://codecov.io/gh/apache/kylin/pull/763/diff?src=pr=tree#diff-cXVlcnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3F1ZXJ5L3V0aWwvUHVzaERvd25VdGlsLmphdmE=) | `50.49% <ø> (ø)` | `4 <0> (?)` | | | [...ache/kylin/job/execution/CheckpointExecutable.java](https://codecov.io/gh/apache/kylin/pull/763/diff?src=pr=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9leGVjdXRpb24vQ2hlY2twb2ludEV4ZWN1dGFibGUuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (?)` | | | [...che/kylin/source/hive/CreateFlatHiveTableStep.java](https://codecov.io/gh/apache/kylin/pull/763/diff?src=pr=tree#diff-c291cmNlLWhpdmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3NvdXJjZS9oaXZlL0NyZWF0ZUZsYXRIaXZlVGFibGVTdGVwLmphdmE=) | `0% <ø> (ø)` | `0 <0> (?)` | | | [...kylin/dict/global/AppendTrieDictionaryBuilder.java](https://codecov.io/gh/apache/kylin/pull/763/diff?src=pr=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2dsb2JhbC9BcHBlbmRUcmllRGljdGlvbmFyeUJ1aWxkZXIuamF2YQ==) | `97.26% <ø> (ø)` | `39 <0> (?)` | | | [...apache/kylin/engine/mr/LookupSnapshotBuildJob.java](https://codecov.io/gh/apache/kylin/pull/763/diff?src=pr=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvTG9va3VwU25hcHNob3RCdWlsZEpvYi5qYXZh) | `0% <ø> (ø)` | `0 <0> (?)` | | | ... and [188 more](https://codecov.io/gh/apache/kylin/pull/763/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/763?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/763?src=pr=footer). Last update [ae4f2e3...1f026a6](https://codecov.io/gh/apache/kylin/pull/763?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[GitHub] [kylin] hit-lacus edited a comment on issue #747: KYLIN-3832 Query pushdown support postgresql
hit-lacus edited a comment on issue #747: KYLIN-3832 Query pushdown support postgresql URL: https://github.com/apache/kylin/pull/747#issuecomment-515409339 I am using docker to verify your patch, you may check this https://github.com/hit-lacus/hit-lacus.github.io/issues/62. 1. too much useless entry, they are index and system-level table  2. error varchar type  3. can not create flat table ```sql exampledb=# select * from exampledb.city; ERROR: relation "exampledb.city" does not exist 第1行select * from exampledb.city; ```  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] hit-lacus edited a comment on issue #747: KYLIN-3832 Query pushdown support postgresql
hit-lacus edited a comment on issue #747: KYLIN-3832 Query pushdown support postgresql URL: https://github.com/apache/kylin/pull/747#issuecomment-515409339 1. too much useless entry, they are index and system-level table  2. error varchar type  3. can not create flat table ```sql exampledb=# select * from exampledb.city; ERROR: relation "exampledb.city" does not exist 第1行select * from exampledb.city; ```  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] hit-lacus edited a comment on issue #747: KYLIN-3832 Query pushdown support postgresql
hit-lacus edited a comment on issue #747: KYLIN-3832 Query pushdown support postgresql URL: https://github.com/apache/kylin/pull/747#issuecomment-515409339 1. too much useless entry  2. error varchar type  3. can not create flat table ```sql exampledb=# select * from exampledb.city; ERROR: relation "exampledb.city" does not exist 第1行select * from exampledb.city; ```  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] hit-lacus commented on a change in pull request #747: KYLIN-3832 Query pushdown support postgresql
hit-lacus commented on a change in pull request #747: KYLIN-3832 Query pushdown
support postgresql
URL: https://github.com/apache/kylin/pull/747#discussion_r307687447
##
File path:
datasource-sdk/src/main/java/org/apache/kylin/sdk/datasource/adaptor/PostgresqlAdaptor.java
##
@@ -0,0 +1,100 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kylin.sdk.datasource.adaptor;
+
+import javax.sql.rowset.CachedRowSet;
+import java.sql.Connection;
+import java.sql.ResultSet;
+import java.sql.SQLException;
+import java.util.List;
+import java.util.ArrayList;
+
+
+public class PostgresqlAdaptor extends DefaultAdaptor {
+public PostgresqlAdaptor(AdaptorConfig config) throws Exception {
+super(config);
+}
+
+@Override
+public List listDatabases() throws SQLException {
+List ret = new ArrayList<>();
+try (Connection con = getConnection()) {
+ret.add(con.getCatalog());
+}
+return ret;
+}
+
+@Override
+public List listTables(String catalog) throws SQLException {
Review comment:
Better add following code to filter **INDEX**, **SYSTEM TABLE**
```java
if(tableType != null & tableType.equalsIgnoreCase("TABLE"))
ret.add(table);
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] hit-lacus commented on issue #747: KYLIN-3832 Query pushdown support postgresql
hit-lacus commented on issue #747: KYLIN-3832 Query pushdown support postgresql URL: https://github.com/apache/kylin/pull/747#issuecomment-515409339   This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] hit-lacus commented on a change in pull request #747: KYLIN-3832 Query pushdown support postgresql
hit-lacus commented on a change in pull request #747: KYLIN-3832 Query pushdown
support postgresql
URL: https://github.com/apache/kylin/pull/747#discussion_r307687447
##
File path:
datasource-sdk/src/main/java/org/apache/kylin/sdk/datasource/adaptor/PostgresqlAdaptor.java
##
@@ -0,0 +1,100 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kylin.sdk.datasource.adaptor;
+
+import javax.sql.rowset.CachedRowSet;
+import java.sql.Connection;
+import java.sql.ResultSet;
+import java.sql.SQLException;
+import java.util.List;
+import java.util.ArrayList;
+
+
+public class PostgresqlAdaptor extends DefaultAdaptor {
+public PostgresqlAdaptor(AdaptorConfig config) throws Exception {
+super(config);
+}
+
+@Override
+public List listDatabases() throws SQLException {
+List ret = new ArrayList<>();
+try (Connection con = getConnection()) {
+ret.add(con.getCatalog());
+}
+return ret;
+}
+
+@Override
+public List listTables(String catalog) throws SQLException {
Review comment:
Better add following code to filter **INDEX**, **SYSTEM TABLE**
```java
if(tableType.equalsIgnoreCase("TABLE"))
ret.add(table);
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (KYLIN-4115) Always load KafkaConsumerProperties
[ https://issues.apache.org/jira/browse/KYLIN-4115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16893707#comment-16893707 ] ASF GitHub Bot commented on KYLIN-4115: --- chenzhx commented on pull request #775: KYLIN-4115 Always load kafkaConsumerProperties URL: https://github.com/apache/kylin/pull/775 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Always load KafkaConsumerProperties > --- > > Key: KYLIN-4115 > URL: https://issues.apache.org/jira/browse/KYLIN-4115 > Project: Kylin > Issue Type: Bug > Components: NRT Streaming >Reporter: Zhixiong Chen >Assignee: Zhixiong Chen >Priority: Major > > KafkaConsumerProperties can't override by conf/kylin-kafka-consumer.xml or > “kylin.source.kafka.config-override.” -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [kylin] chenzhx opened a new pull request #775: KYLIN-4115 Always load kafkaConsumerProperties
chenzhx opened a new pull request #775: KYLIN-4115 Always load kafkaConsumerProperties URL: https://github.com/apache/kylin/pull/775 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] asfgit commented on issue #775: KYLIN-4115 Always load kafkaConsumerProperties
asfgit commented on issue #775: KYLIN-4115 Always load kafkaConsumerProperties URL: https://github.com/apache/kylin/pull/775#issuecomment-515397346 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (KYLIN-4115) Always load KafkaConsumerProperties
Zhixiong Chen created KYLIN-4115: Summary: Always load KafkaConsumerProperties Key: KYLIN-4115 URL: https://issues.apache.org/jira/browse/KYLIN-4115 Project: Kylin Issue Type: Bug Components: NRT Streaming Reporter: Zhixiong Chen Assignee: Zhixiong Chen KafkaConsumerProperties can't override by conf/kylin-kafka-consumer.xml or “kylin.source.kafka.config-override.” -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (KYLIN-4114) Provided a self-contained docker image for Kylin
[ https://issues.apache.org/jira/browse/KYLIN-4114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaoxiang Yu updated KYLIN-4114: Description: Provided a self-contained docker image for Kylin will benifit to Package/Integration Test/Demo purpose. https://issues.apache.org/jira/browse/KYLIN-4040 was:Provided a self-contained docker image for Kylin will benifit to Package/Integration Test/Demo purpose. > Provided a self-contained docker image for Kylin > > > Key: KYLIN-4114 > URL: https://issues.apache.org/jira/browse/KYLIN-4114 > Project: Kylin > Issue Type: Wish > Components: Integration >Reporter: Xiaoxiang Yu >Assignee: weibin0516 >Priority: Major > > Provided a self-contained docker image for Kylin will benifit to > Package/Integration Test/Demo purpose. > https://issues.apache.org/jira/browse/KYLIN-4040 -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Assigned] (KYLIN-4114) Provided a self-contained docker image for Kylin
[ https://issues.apache.org/jira/browse/KYLIN-4114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaoxiang Yu reassigned KYLIN-4114: --- Assignee: weibin0516 (was: Xiaoxiang Yu) > Provided a self-contained docker image for Kylin > > > Key: KYLIN-4114 > URL: https://issues.apache.org/jira/browse/KYLIN-4114 > Project: Kylin > Issue Type: Wish > Components: Integration >Reporter: Xiaoxiang Yu >Assignee: weibin0516 >Priority: Major > > Provided a self-contained docker image for Kylin will benifit to > Package/Integration Test/Demo purpose. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Assigned] (KYLIN-4114) Provided a self-contained docker image for Kylin
[ https://issues.apache.org/jira/browse/KYLIN-4114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaoxiang Yu reassigned KYLIN-4114: --- Assignee: Xiaoxiang Yu > Provided a self-contained docker image for Kylin > > > Key: KYLIN-4114 > URL: https://issues.apache.org/jira/browse/KYLIN-4114 > Project: Kylin > Issue Type: Wish > Components: Integration >Reporter: Xiaoxiang Yu >Assignee: Xiaoxiang Yu >Priority: Major > > Provided a self-contained docker image for Kylin will benifit to > Package/Integration Test/Demo purpose. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (KYLIN-4066) No planner for not ROLE_ADMIN user on WebSite
[
https://issues.apache.org/jira/browse/KYLIN-4066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16893657#comment-16893657
]
ASF GitHub Bot commented on KYLIN-4066:
---
nichunen commented on pull request #732: [KYLIN-4066] Fix No planner for not
ROLE_ADMIN user
URL: https://github.com/apache/kylin/pull/732
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> No planner for not ROLE_ADMIN user on WebSite
> -
>
> Key: KYLIN-4066
> URL: https://issues.apache.org/jira/browse/KYLIN-4066
> Project: Kylin
> Issue Type: Bug
> Components: Website
>Affects Versions: v2.6.1
> Environment: macOs
>Reporter: langdamao
>Priority: Major
> Labels: easyfix
> Fix For: Future
>
>
> There is no planner page for none ROLE_ADMIN user ,even though he has ADMIN
> access for the project.
> I found in webapp/app/partials/cubes/cube_detail.html line44
> {code:java}
> ng-if="(userService.hasRole('ROLE_ADMIN') || hasPermission(cube,
> permissions.ADMINISTRATION.mask)) && isShowCubeplanner"> ng-click="cube.visiblePage='planner';getCubePlanner(cube);">Planner
> {code}
> but other place the hasPermission function use as
> {code:java}
> hasPermission('cube',cube, permissions.ADMINISTRATION.mask)
> {code}
> the function hasPermission is defined in webapp/app/js/controllers/page.js
> line100
> {code:java}
> $scope.hasPermission = function (accessType, entity){
> ...
> if (accessType === 'cube') {
> project = entity.project
> } else if (accessType === 'project') {
> project = entity && entity.name || entity.selectedProject
> } else if (accessType === 'model') {
> project = ProjectModel.getProjectByCubeModel(entity.name)
> }
> ...
> }{code}
> I guess whether it's cause by no param of accessType.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (KYLIN-4066) No planner for not ROLE_ADMIN user on WebSite
[
https://issues.apache.org/jira/browse/KYLIN-4066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16893658#comment-16893658
]
ASF subversion and git services commented on KYLIN-4066:
Commit 1f026a6535ba00f8a60a7c6df9036ec827f08c72 in kylin's branch
refs/heads/master from langdamao
[ https://gitbox.apache.org/repos/asf?p=kylin.git;h=1f026a6 ]
[KYLIN-4066] Fix No planner for not ROLE_ADMIN user
Signed-off-by: langdamao
> No planner for not ROLE_ADMIN user on WebSite
> -
>
> Key: KYLIN-4066
> URL: https://issues.apache.org/jira/browse/KYLIN-4066
> Project: Kylin
> Issue Type: Bug
> Components: Website
>Affects Versions: v2.6.1
> Environment: macOs
>Reporter: langdamao
>Priority: Major
> Labels: easyfix
> Fix For: Future
>
>
> There is no planner page for none ROLE_ADMIN user ,even though he has ADMIN
> access for the project.
> I found in webapp/app/partials/cubes/cube_detail.html line44
> {code:java}
> ng-if="(userService.hasRole('ROLE_ADMIN') || hasPermission(cube,
> permissions.ADMINISTRATION.mask)) && isShowCubeplanner"> ng-click="cube.visiblePage='planner';getCubePlanner(cube);">Planner
> {code}
> but other place the hasPermission function use as
> {code:java}
> hasPermission('cube',cube, permissions.ADMINISTRATION.mask)
> {code}
> the function hasPermission is defined in webapp/app/js/controllers/page.js
> line100
> {code:java}
> $scope.hasPermission = function (accessType, entity){
> ...
> if (accessType === 'cube') {
> project = entity.project
> } else if (accessType === 'project') {
> project = entity && entity.name || entity.selectedProject
> } else if (accessType === 'model') {
> project = ProjectModel.getProjectByCubeModel(entity.name)
> }
> ...
> }{code}
> I guess whether it's cause by no param of accessType.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [kylin] nichunen merged pull request #732: [KYLIN-4066] Fix No planner for not ROLE_ADMIN user
nichunen merged pull request #732: [KYLIN-4066] Fix No planner for not ROLE_ADMIN user URL: https://github.com/apache/kylin/pull/732 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (KYLIN-4114) Provided a self-contained docker image for Kylin
Xiaoxiang Yu created KYLIN-4114: --- Summary: Provided a self-contained docker image for Kylin Key: KYLIN-4114 URL: https://issues.apache.org/jira/browse/KYLIN-4114 Project: Kylin Issue Type: Wish Components: Integration Reporter: Xiaoxiang Yu Provided a self-contained docker image for Kylin will benifit to Package/Integration Test/Demo purpose. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
