[jira] [Updated] (KYLIN-4159) The first step of build cube job will fail and throw "Column 'xx' in where clause is ambiguous" in jdbc datasource.

2019-09-05 Thread luguosheng (Jira)


 [ 
https://issues.apache.org/jira/browse/KYLIN-4159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

luguosheng updated KYLIN-4159:
--
Summary: The first step of build cube job will fail and throw "Column 'xx' 
in where clause is ambiguous" in jdbc datasource.  (was: The first step of job 
will fail and throw "Column 'xx' in where clause is ambiguous" in jdbc 
datasource.)

> The first step of build cube job will fail and throw "Column 'xx' in where 
> clause is ambiguous" in jdbc datasource.
> ---
>
> Key: KYLIN-4159
> URL: https://issues.apache.org/jira/browse/KYLIN-4159
> Project: Kylin
>  Issue Type: Bug
>Reporter: luguosheng
>Assignee: luguosheng
>Priority: Major
>
> Reappear:
> In the model of kylin, If we have a column used as a partition column in the 
> fact table, and there is a column in lookup table has the same name. It can 
> be reappeared。
> RootCause:
>  In jdbc datasource , we use Sqoop option "--boundary-query sql"  to split 
> data,  the sql like "select max(partition_column), min(partition_column) from 
> flat_table where flat_table.partition_column> 20120101 and 
> flat_table.partition.column < 20190101" and  there is more than one column 
> which have the same name of the "partition_column" in the flat_table. the sql 
> driver can not distinguish the table that partition_column belong to。
> How to resolve:
>  Alter the sql like: "select max(t.partition_column),min(t.partition_column) 
> from flat_table where flat_table.partition_column> 20120101 and 
> flat_table.partition.column < 20190101"
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Updated] (KYLIN-4159) The first step of job will fail and throw "Column 'xx' in where clause is ambiguous" in jdbc datasource.

2019-09-05 Thread luguosheng (Jira)


 [ 
https://issues.apache.org/jira/browse/KYLIN-4159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

luguosheng updated KYLIN-4159:
--
Description: 
Reappear:

In the model of kylin, If we have a column used as a partition column in the 
fact table, and there is a column in lookup table has the same name. It can be 
reappeared。

RootCause:

 In jdbc datasource , we use Sqoop option "--boundary-query sql"  to split 
data,  the sql like "select max(partition_column), min(partition_column) from 
flat_table where flat_table.partition_column> 20120101 and 
flat_table.partition.column < 20190101" and  there is more than one column 
which have the same name of the "partition_column" in the flat_table. the sql 
driver can not distinguish the table that partition_column belong to。

How to resolve:

 Alter the sql like: "select max(t.partition_column),min(t.partition_column) 
from flat_table where flat_table.partition_column> 20120101 and 
flat_table.partition.column < 20190101"

 

 

  was:
Reappear:

In the model of kylin, If we have a column used as a partition column in the 
fact table, and there is a column in lookup table has the same name. It can be 
reappeared。

RootCause:

 In jdbc datasource , we use Sqoop option "--boundary-query sql"  to split 
data,  the sql like "select max(partition_column), min(partition_column) from 
flat_table where flat_table.partition_column> 20120101 and 
flat_table.partition.column < 20190101" and  there is more than one column 
which have the same name of the "partition_column" in the flat_table. the sql 
driver can not distinguish the table that partition_column belong to。

How to resolve:

 ^Alter the sql like: "select max(t.partition_column),min(t.partition_column) 
from flat_table where flat_table.partition_column> 20120101 and 
flat_table.partition.column < 20190101"^

 

 


> The first step of job will fail and throw "Column 'xx' in where clause is 
> ambiguous" in jdbc datasource.
> 
>
> Key: KYLIN-4159
> URL: https://issues.apache.org/jira/browse/KYLIN-4159
> Project: Kylin
>  Issue Type: Bug
>Reporter: luguosheng
>Assignee: luguosheng
>Priority: Major
>
> Reappear:
> In the model of kylin, If we have a column used as a partition column in the 
> fact table, and there is a column in lookup table has the same name. It can 
> be reappeared。
> RootCause:
>  In jdbc datasource , we use Sqoop option "--boundary-query sql"  to split 
> data,  the sql like "select max(partition_column), min(partition_column) from 
> flat_table where flat_table.partition_column> 20120101 and 
> flat_table.partition.column < 20190101" and  there is more than one column 
> which have the same name of the "partition_column" in the flat_table. the sql 
> driver can not distinguish the table that partition_column belong to。
> How to resolve:
>  Alter the sql like: "select max(t.partition_column),min(t.partition_column) 
> from flat_table where flat_table.partition_column> 20120101 and 
> flat_table.partition.column < 20190101"
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Created] (KYLIN-4159) The first step of job will fail and throw "Column 'xx' in where clause is ambiguous" in jdbc datasource.

2019-09-05 Thread luguosheng (Jira)
luguosheng created KYLIN-4159:
-

 Summary: The first step of job will fail and throw "Column 'xx' in 
where clause is ambiguous" in jdbc datasource.
 Key: KYLIN-4159
 URL: https://issues.apache.org/jira/browse/KYLIN-4159
 Project: Kylin
  Issue Type: Bug
Reporter: luguosheng
Assignee: luguosheng


Reappear:

In the model of kylin, If we have a column used as a partition column in the 
fact table, and there is a column in lookup table has the same name. It can be 
reappeared。

RootCause:

 In jdbc datasource , we use Sqoop option "--boundary-query sql"  to split 
data,  the sql like "select max(partition_column), min(partition_column) from 
flat_table where flat_table.partition_column> 20120101 and 
flat_table.partition.column < 20190101" and  there is more than one column 
which have the same name of the "partition_column" in the flat_table. the sql 
driver can not distinguish the table that partition_column belong to。

How to resolve:

 ^Alter the sql like: "select max(t.partition_column),min(t.partition_column) 
from flat_table where flat_table.partition_column> 20120101 and 
flat_table.partition.column < 20190101"^

 

 



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[GitHub] [kylin] coveralls commented on issue #828: fix typo

2019-09-05 Thread GitBox
coveralls commented on issue #828: fix typo
URL: https://github.com/apache/kylin/pull/828#issuecomment-528350823
 
 
   ## Pull Request Test Coverage Report for [Build 
4980](https://coveralls.io/builds/25545932)
   
   * **0** of **0**   changed or added relevant lines in **0** files are 
covered.
   * **4** unchanged lines in **2** files lost coverage.
   * Overall coverage decreased (**-0.004%**) to **28.073%**
   
   ---
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-|--|--: |
   | 
[core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://coveralls.io/builds/25545932/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcuboid%2FTreeCuboidScheduler.java#L124)
 | 2 | 68.46% |
   | 
[core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java](https://coveralls.io/builds/25545932/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2Fimpl%2Fthreadpool%2FDefaultScheduler.java#L194)
 | 2 | 80.23% |
   
   
   |  Totals | [![Coverage 
Status](https://coveralls.io/builds/25545932/badge)](https://coveralls.io/builds/25545932)
 |
   | :-- | --: |
   | Change from base [Build 4977](https://coveralls.io/builds/25539064): |  
-0.004% |
   | Covered Lines: | 23447 |
   | Relevant Lines: | 83523 |
   
   ---
   #   - [Coveralls](https://coveralls.io)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (KYLIN-3921) Bump Flink version from 1.7.1 to 1.9.0

2019-09-05 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-3921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16923383#comment-16923383
 ] 

ASF subversion and git services commented on KYLIN-3921:


Commit 32c40b510af5d242fcbb7484d7ebf5fcb3e2c6e0 in kylin's branch 
refs/heads/engine-flink from yanghua
[ https://gitbox.apache.org/repos/asf?p=kylin.git;h=32c40b5 ]

[KYLIN-3921] Bump Flink version from 1.7.1 to 1.9.0


> Bump Flink version from 1.7.1 to 1.9.0
> --
>
> Key: KYLIN-3921
> URL: https://issues.apache.org/jira/browse/KYLIN-3921
> Project: Kylin
>  Issue Type: Sub-task
>  Components: Flink Engine
>Reporter: vinoyang
>Assignee: vinoyang
>Priority: Major
>
> Flink 1.9.0 has been released, it brings many big feature. I am going to 
> upgrade the version of Flink for the cube engine.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[GitHub] [kylin] nichunen merged pull request #829: [KYLIN-3921] Bump Flink version from 1.7.1 to 1.9.0

2019-09-05 Thread GitBox
nichunen merged pull request #829: [KYLIN-3921] Bump Flink version from 1.7.1 
to 1.9.0
URL: https://github.com/apache/kylin/pull/829
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [kylin] yanghua commented on issue #829: [KYLIN-3921] Bump Flink version from 1.7.1 to 1.9.0

2019-09-05 Thread GitBox
yanghua commented on issue #829: [KYLIN-3921] Bump Flink version from 1.7.1 to 
1.9.0
URL: https://github.com/apache/kylin/pull/829#issuecomment-528343067
 
 
   @nichunen I have create a new PR.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [kylin] yanghua opened a new pull request #829: [KYLIN-3921] Bump Flink version from 1.7.1 to 1.9.0

2019-09-05 Thread GitBox
yanghua opened a new pull request #829: [KYLIN-3921] Bump Flink version from 
1.7.1 to 1.9.0
URL: https://github.com/apache/kylin/pull/829
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [kylin] asf-ci commented on issue #829: [KYLIN-3921] Bump Flink version from 1.7.1 to 1.9.0

2019-09-05 Thread GitBox
asf-ci commented on issue #829: [KYLIN-3921] Bump Flink version from 1.7.1 to 
1.9.0
URL: https://github.com/apache/kylin/pull/829#issuecomment-528342756
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (KYLIN-3921) Bump Flink version from 1.7.1 to 1.9.0

2019-09-05 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-3921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16923380#comment-16923380
 ] 

ASF GitHub Bot commented on KYLIN-3921:
---

yanghua commented on pull request #829: [KYLIN-3921] Bump Flink version from 
1.7.1 to 1.9.0
URL: https://github.com/apache/kylin/pull/829
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bump Flink version from 1.7.1 to 1.9.0
> --
>
> Key: KYLIN-3921
> URL: https://issues.apache.org/jira/browse/KYLIN-3921
> Project: Kylin
>  Issue Type: Sub-task
>  Components: Flink Engine
>Reporter: vinoyang
>Assignee: vinoyang
>Priority: Major
>
> Flink 1.9.0 has been released, it brings many big feature. I am going to 
> upgrade the version of Flink for the cube engine.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[GitHub] [kylin] asf-ci commented on issue #828: fix typo

2019-09-05 Thread GitBox
asf-ci commented on issue #828: fix typo
URL: https://github.com/apache/kylin/pull/828#issuecomment-528337546
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [kylin] Sean-Gu opened a new pull request #828: fix typo

2019-09-05 Thread GitBox
Sean-Gu opened a new pull request #828: fix typo
URL: https://github.com/apache/kylin/pull/828
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (KYLIN-3921) Bump Flink version from 1.7.1 to 1.9.0

2019-09-05 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-3921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16923341#comment-16923341
 ] 

ASF subversion and git services commented on KYLIN-3921:


Commit f63e7e4f172366f8bd6b879183e1a264e3c7192b in kylin's branch 
refs/heads/engine-flink from yanghua
[ https://gitbox.apache.org/repos/asf?p=kylin.git;h=f63e7e4 ]

[KYLIN-3921] Bump Flink version from 1.7.1 to 1.9.0


> Bump Flink version from 1.7.1 to 1.9.0
> --
>
> Key: KYLIN-3921
> URL: https://issues.apache.org/jira/browse/KYLIN-3921
> Project: Kylin
>  Issue Type: Sub-task
>  Components: Flink Engine
>Reporter: vinoyang
>Assignee: vinoyang
>Priority: Major
>
> Flink 1.9.0 has been released, it brings many big feature. I am going to 
> upgrade the version of Flink for the cube engine.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (KYLIN-3921) Bump Flink version from 1.7.1 to 1.9.0

2019-09-05 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-3921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16923340#comment-16923340
 ] 

ASF GitHub Bot commented on KYLIN-3921:
---

nichunen commented on pull request #826: [KYLIN-3921] Bump Flink version from 
1.7.1 to 1.9.0
URL: https://github.com/apache/kylin/pull/826
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bump Flink version from 1.7.1 to 1.9.0
> --
>
> Key: KYLIN-3921
> URL: https://issues.apache.org/jira/browse/KYLIN-3921
> Project: Kylin
>  Issue Type: Sub-task
>  Components: Flink Engine
>Reporter: vinoyang
>Assignee: vinoyang
>Priority: Major
>
> Flink 1.9.0 has been released, it brings many big feature. I am going to 
> upgrade the version of Flink for the cube engine.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[GitHub] [kylin] nichunen merged pull request #826: [KYLIN-3921] Bump Flink version from 1.7.1 to 1.9.0

2019-09-05 Thread GitBox
nichunen merged pull request #826: [KYLIN-3921] Bump Flink version from 1.7.1 
to 1.9.0
URL: https://github.com/apache/kylin/pull/826
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Resolved] (KYLIN-4034) The table should not display in Insight page when the user has no access to the table

2019-09-05 Thread Yaqian Zhang (Jira)


 [ 
https://issues.apache.org/jira/browse/KYLIN-4034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yaqian Zhang resolved KYLIN-4034.
-
Fix Version/s: v3.0.0-beta
   Resolution: Fixed

> The table should not display in Insight page when the user has no access to 
> the table
> -
>
> Key: KYLIN-4034
> URL: https://issues.apache.org/jira/browse/KYLIN-4034
> Project: Kylin
>  Issue Type: Bug
>Affects Versions: v2.6.2
>Reporter: Na Zhai
>Assignee: Yaqian Zhang
>Priority: Major
> Fix For: v3.0.0-beta
>
>




--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[GitHub] [kylin] ZhengshuaiPENG opened a new pull request #827: #KYLIN-4158, limit not push down to storage scan level if group by is…

2019-09-05 Thread GitBox
ZhengshuaiPENG opened a new pull request #827: #KYLIN-4158, limit not push down 
to storage scan level if group by is…
URL: https://github.com/apache/kylin/pull/827
 
 
   … an expression


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (KYLIN-4158) Query failed for GroupBy an expression of column with limit in SQL

2019-09-05 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-4158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16923263#comment-16923263
 ] 

ASF GitHub Bot commented on KYLIN-4158:
---

ZhengshuaiPENG commented on pull request #827: #KYLIN-4158, limit not push down 
to storage scan level if group by is…
URL: https://github.com/apache/kylin/pull/827
 
 
   … an expression
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Query failed for GroupBy an expression of column with limit in SQL
> --
>
> Key: KYLIN-4158
> URL: https://issues.apache.org/jira/browse/KYLIN-4158
> Project: Kylin
>  Issue Type: Bug
>  Components: Query Engine
>Affects Versions: v2.6.2
>Reporter: PENG Zhengshuai
>Assignee: PENG Zhengshuai
>Priority: Major
>
> When executing a sql query, the limit should not be pushdown to storage scan 
> level if group by clause is an expression of columns.
> For example:
> {code:java}
> SELECT (CASE WHEN ("TEST_KYLIN_FACT"."LSTG_FORMAT_NAME" IN ('Auction', 
> 'FP-GTC')) THEN 'Auction' ELSE "TEST_KYLIN_FACT"."LSTG_FORMAT_NAME" END) AS 
> "LSTG_FORMAT_NAME__group_",
>   SUM("TEST_KYLIN_FACT"."PRICE") AS "sum_PRICE_ok"
> FROM "TEST_KYLIN_FACT" "TEST_KYLIN_FACT"
> GROUP BY (CASE WHEN ("TEST_KYLIN_FACT"."LSTG_FORMAT_NAME" IN ('Auction', 
> 'FP-GTC')) THEN 'Auction' ELSE "TEST_KYLIN_FACT"."LSTG_FORMAT_NAME" END)
> limit 4
> {code}
> In this SQL, group by clause is an expression, the limit should NOT be 
> push-down to storage scan level, otherwise, the result is incorrect



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[GitHub] [kylin] asf-ci commented on issue #827: #KYLIN-4158, limit not push down to storage scan level if group by is…

2019-09-05 Thread GitBox
asf-ci commented on issue #827: #KYLIN-4158, limit not push down to storage 
scan level if group by is…
URL: https://github.com/apache/kylin/pull/827#issuecomment-528301543
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Updated] (KYLIN-4158) Query failed for GroupBy an expression of column with limit in SQL

2019-09-05 Thread PENG Zhengshuai (Jira)


 [ 
https://issues.apache.org/jira/browse/KYLIN-4158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

PENG Zhengshuai updated KYLIN-4158:
---
Description: 
When executing a sql query, the limit should not be pushdown to storage scan 
level if group by clause is an expression of columns.

For example:

{code:java}
SELECT (CASE WHEN ("TEST_KYLIN_FACT"."LSTG_FORMAT_NAME" IN ('Auction', 
'FP-GTC')) THEN 'Auction' ELSE "TEST_KYLIN_FACT"."LSTG_FORMAT_NAME" END) AS 
"LSTG_FORMAT_NAME__group_",
  SUM("TEST_KYLIN_FACT"."PRICE") AS "sum_PRICE_ok"
FROM "TEST_KYLIN_FACT" "TEST_KYLIN_FACT"
GROUP BY (CASE WHEN ("TEST_KYLIN_FACT"."LSTG_FORMAT_NAME" IN ('Auction', 
'FP-GTC')) THEN 'Auction' ELSE "TEST_KYLIN_FACT"."LSTG_FORMAT_NAME" END)
limit 4
{code}

In this SQL, group by clause is an expression, the limit should NOT be 
push-down to storage scan level, otherwise, the result is incorrect

  was:
Sql limit should not be pushdown to storage level if group by clause is an 
expression of columns.

For example:

{code:java}
SELECT (CASE WHEN ("TEST_KYLIN_FACT"."LSTG_FORMAT_NAME" IN ('Auction', 
'FP-GTC')) THEN 'Auction' ELSE "TEST_KYLIN_FACT"."LSTG_FORMAT_NAME" END) AS 
"LSTG_FORMAT_NAME__group_",
  SUM("TEST_KYLIN_FACT"."PRICE") AS "sum_PRICE_ok"
FROM "TEST_KYLIN_FACT" "TEST_KYLIN_FACT"
GROUP BY (CASE WHEN ("TEST_KYLIN_FACT"."LSTG_FORMAT_NAME" IN ('Auction', 
'FP-GTC')) THEN 'Auction' ELSE "TEST_KYLIN_FACT"."LSTG_FORMAT_NAME" END)
limit 4
{code}

In this SQL, group by clause is an expression, the limit should NOT be 
push-down to storage level, otherwise, the result is incorrect


> Query failed for GroupBy an expression of column with limit in SQL
> --
>
> Key: KYLIN-4158
> URL: https://issues.apache.org/jira/browse/KYLIN-4158
> Project: Kylin
>  Issue Type: Bug
>  Components: Query Engine
>Affects Versions: v2.6.2
>Reporter: PENG Zhengshuai
>Assignee: PENG Zhengshuai
>Priority: Major
>
> When executing a sql query, the limit should not be pushdown to storage scan 
> level if group by clause is an expression of columns.
> For example:
> {code:java}
> SELECT (CASE WHEN ("TEST_KYLIN_FACT"."LSTG_FORMAT_NAME" IN ('Auction', 
> 'FP-GTC')) THEN 'Auction' ELSE "TEST_KYLIN_FACT"."LSTG_FORMAT_NAME" END) AS 
> "LSTG_FORMAT_NAME__group_",
>   SUM("TEST_KYLIN_FACT"."PRICE") AS "sum_PRICE_ok"
> FROM "TEST_KYLIN_FACT" "TEST_KYLIN_FACT"
> GROUP BY (CASE WHEN ("TEST_KYLIN_FACT"."LSTG_FORMAT_NAME" IN ('Auction', 
> 'FP-GTC')) THEN 'Auction' ELSE "TEST_KYLIN_FACT"."LSTG_FORMAT_NAME" END)
> limit 4
> {code}
> In this SQL, group by clause is an expression, the limit should NOT be 
> push-down to storage scan level, otherwise, the result is incorrect



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Created] (KYLIN-4158) Query failed for GroupBy an expression of column with limit in SQL

2019-09-05 Thread PENG Zhengshuai (Jira)
PENG Zhengshuai created KYLIN-4158:
--

 Summary: Query failed for GroupBy an expression of column with 
limit in SQL
 Key: KYLIN-4158
 URL: https://issues.apache.org/jira/browse/KYLIN-4158
 Project: Kylin
  Issue Type: Bug
  Components: Query Engine
Affects Versions: v2.6.2
Reporter: PENG Zhengshuai
Assignee: PENG Zhengshuai


Sql limit should not be pushdown to storage level if group by clause is an 
expression of columns.

For example:

{code:java}
SELECT (CASE WHEN ("TEST_KYLIN_FACT"."LSTG_FORMAT_NAME" IN ('Auction', 
'FP-GTC')) THEN 'Auction' ELSE "TEST_KYLIN_FACT"."LSTG_FORMAT_NAME" END) AS 
"LSTG_FORMAT_NAME__group_",
  SUM("TEST_KYLIN_FACT"."PRICE") AS "sum_PRICE_ok"
FROM "TEST_KYLIN_FACT" "TEST_KYLIN_FACT"
GROUP BY (CASE WHEN ("TEST_KYLIN_FACT"."LSTG_FORMAT_NAME" IN ('Auction', 
'FP-GTC')) THEN 'Auction' ELSE "TEST_KYLIN_FACT"."LSTG_FORMAT_NAME" END)
limit 4
{code}

In this SQL, group by clause is an expression, the limit should NOT be 
push-down to storage level, otherwise, the result is incorrect



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (KYLIN-3921) Bump Flink version from 1.7.1 to 1.9.0

2019-09-05 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-3921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16923129#comment-16923129
 ] 

ASF GitHub Bot commented on KYLIN-3921:
---

yanghua commented on pull request #826: [KYLIN-3921] Bump Flink version from 
1.7.1 to 1.9.0
URL: https://github.com/apache/kylin/pull/826
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bump Flink version from 1.7.1 to 1.9.0
> --
>
> Key: KYLIN-3921
> URL: https://issues.apache.org/jira/browse/KYLIN-3921
> Project: Kylin
>  Issue Type: Sub-task
>  Components: Flink Engine
>Reporter: vinoyang
>Assignee: vinoyang
>Priority: Major
>
> Flink 1.9.0 has been released, it brings many big feature. I am going to 
> upgrade the version of Flink for the cube engine.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[GitHub] [kylin] yanghua opened a new pull request #826: [KYLIN-3921] Bump Flink version from 1.7.1 to 1.9.0

2019-09-05 Thread GitBox
yanghua opened a new pull request #826: [KYLIN-3921] Bump Flink version from 
1.7.1 to 1.9.0
URL: https://github.com/apache/kylin/pull/826
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [kylin] asf-ci commented on issue #826: [KYLIN-3921] Bump Flink version from 1.7.1 to 1.9.0

2019-09-05 Thread GitBox
asf-ci commented on issue #826: [KYLIN-3921] Bump Flink version from 1.7.1 to 
1.9.0
URL: https://github.com/apache/kylin/pull/826#issuecomment-528235773
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Resolved] (KYLIN-3851) Flink cubing step : merge dictionary

2019-09-05 Thread vinoyang (Jira)


 [ 
https://issues.apache.org/jira/browse/KYLIN-3851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

vinoyang resolved KYLIN-3851.
-
Resolution: Implemented

Implemented via engine-flink: 4f04060b11e20298b84978d40582c952ed41b03d

> Flink cubing step : merge dictionary
> 
>
> Key: KYLIN-3851
> URL: https://issues.apache.org/jira/browse/KYLIN-3851
> Project: Kylin
>  Issue Type: Sub-task
>  Components: Flink Engine
>Reporter: vinoyang
>Assignee: vinoyang
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (KYLIN-4080) Project schema update event casues error reload NEW DataModelDesc

2019-09-05 Thread Yaqian Zhang (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-4080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16923096#comment-16923096
 ] 

Yaqian Zhang commented on KYLIN-4080:
-

Hi Yuzhang:

I think what you said is correct.Are you interested in fixing it and proposing 
a PR?

> Project schema update event casues error reload NEW DataModelDesc
> -
>
> Key: KYLIN-4080
> URL: https://issues.apache.org/jira/browse/KYLIN-4080
> Project: Kylin
>  Issue Type: Bug
>  Components: Metadata
>Affects Versions: v2.5.2
>Reporter: Yuzhang QIU
>Priority: Blocker
>
> Hi, dear Kylin dev team:
>When create new DataModelDesc, DataModelManager.createDataModelDese:246 
> will temporarily add the new model name into selected project(project1) 
> cache, but won't persist it. The TEMPORARY ADD operation will make the model 
> reloading successful, rather than throw "No project found for model ..." 
> exception(at ProjectManager:391).
>However, If there have another threads are processing  "Broadcasting 
> update project_schema, project1", it will clean up cache of project1 and 
> reload it, which will reset the "TEMPORARY ADD" operation. Meanwhile, the 
> model saving thread has persisted the DataModelDesc and start to reload it, 
> but will find there have "No project for this model".
>   The new model can't be created again because the conflict timestamp and 
> can't be reloaded into cache because the abrove problem. 
>How do you think about this??
>   
>Best regards
>   
>yuzhang



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Assigned] (KYLIN-4080) Project schema update event casues error reload NEW DataModelDesc

2019-09-05 Thread Yaqian Zhang (Jira)


 [ 
https://issues.apache.org/jira/browse/KYLIN-4080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yaqian Zhang reassigned KYLIN-4080:
---

Assignee: (was: Yaqian Zhang)

> Project schema update event casues error reload NEW DataModelDesc
> -
>
> Key: KYLIN-4080
> URL: https://issues.apache.org/jira/browse/KYLIN-4080
> Project: Kylin
>  Issue Type: Bug
>  Components: Metadata
>Affects Versions: v2.5.2
>Reporter: Yuzhang QIU
>Priority: Blocker
>
> Hi, dear Kylin dev team:
>When create new DataModelDesc, DataModelManager.createDataModelDese:246 
> will temporarily add the new model name into selected project(project1) 
> cache, but won't persist it. The TEMPORARY ADD operation will make the model 
> reloading successful, rather than throw "No project found for model ..." 
> exception(at ProjectManager:391).
>However, If there have another threads are processing  "Broadcasting 
> update project_schema, project1", it will clean up cache of project1 and 
> reload it, which will reset the "TEMPORARY ADD" operation. Meanwhile, the 
> model saving thread has persisted the DataModelDesc and start to reload it, 
> but will find there have "No project for this model".
>   The new model can't be created again because the conflict timestamp and 
> can't be reloaded into cache because the abrove problem. 
>How do you think about this??
>   
>Best regards
>   
>yuzhang



--
This message was sent by Atlassian Jira
(v8.3.2#803003)