[GitHub] [kylin] hit-lacus opened a new pull request, #2137: Minor fix
hit-lacus opened a new pull request, #2137: URL: https://github.com/apache/kylin/pull/2137 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. ## Branch to commit - [ ] Branch **kylin3** for v2.x to v3.x - [ ] Branch **kylin4** for v4.x - [ ] Branch **kylin5** for v5.x ## Types of changes What types of changes does your code introduce to Kylin? _Put an `x` in the boxes that apply_ - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation Update (if none of the other choices apply) ## Checklist _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._ - [ ] I have created an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail - [ ] Commit messages in my PR start with the related jira ID, like "KYLIN- Make Kylin project open-source" - [ ] Compiling and unit tests pass locally with my changes - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have added necessary documentation (if appropriate) - [ ] Any dependent changes have been merged ## Further comments If this is a relatively large or complex change, kick off the discussion at u...@kylin.apache.org or d...@kylin.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (KYLIN-5618) Unify the copywriting of the ShardBy column on the Web GUI
[ https://issues.apache.org/jira/browse/KYLIN-5618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17742714#comment-17742714 ] ASF GitHub Bot commented on KYLIN-5618: --- LauraXia123 opened a new pull request, #2136: URL: https://github.com/apache/kylin/pull/2136 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. ## Branch to commit - [ ] Branch **kylin3** for v2.x to v3.x - [ ] Branch **kylin4** for v4.x - [ ] Branch **kylin5** for v5.x ## Types of changes What types of changes does your code introduce to Kylin? _Put an `x` in the boxes that apply_ - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation Update (if none of the other choices apply) ## Checklist _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._ - [ ] I have created an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail - [ ] Commit messages in my PR start with the related jira ID, like "KYLIN- Make Kylin project open-source" - [ ] Compiling and unit tests pass locally with my changes - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have added necessary documentation (if appropriate) - [ ] Any dependent changes have been merged ## Further comments If this is a relatively large or complex change, kick off the discussion at u...@kylin.apache.org or d...@kylin.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc... > Unify the copywriting of the ShardBy column on the Web GUI > -- > > Key: KYLIN-5618 > URL: https://issues.apache.org/jira/browse/KYLIN-5618 > Project: Kylin > Issue Type: Bug >Reporter: Laura Xia >Assignee: Laura Xia >Priority: Major > Fix For: 5.0-beta > > Attachments: image-2023-07-12-11-35-54-602.png, > image-2023-07-12-11-36-02-682.png > > > !image-2023-07-12-11-35-54-602.png! > !image-2023-07-12-11-36-02-682.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [kylin] LauraXia123 opened a new pull request, #2136: KYLIN-5618，KYLIN-5619，KYLIN-5620，KYLIN-5621，KYLIN-5622，KYLIN-5623，KYLIN-5624，KYLIN-5625，KYLIN-5626，KYLIN-5627，KYLIN-5628，KYLIN-5629，KYLIN
LauraXia123 opened a new pull request, #2136: URL: https://github.com/apache/kylin/pull/2136 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. ## Branch to commit - [ ] Branch **kylin3** for v2.x to v3.x - [ ] Branch **kylin4** for v4.x - [ ] Branch **kylin5** for v5.x ## Types of changes What types of changes does your code introduce to Kylin? _Put an `x` in the boxes that apply_ - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation Update (if none of the other choices apply) ## Checklist _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._ - [ ] I have created an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail - [ ] Commit messages in my PR start with the related jira ID, like "KYLIN- Make Kylin project open-source" - [ ] Compiling and unit tests pass locally with my changes - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have added necessary documentation (if appropriate) - [ ] Any dependent changes have been merged ## Further comments If this is a relatively large or complex change, kick off the discussion at u...@kylin.apache.org or d...@kylin.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (KYLIN-5631) Logical view some issues
[ https://issues.apache.org/jira/browse/KYLIN-5631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laura Xia updated KYLIN-5631: - Fix Version/s: 5.0-beta > Logical view some issues > > > Key: KYLIN-5631 > URL: https://issues.apache.org/jira/browse/KYLIN-5631 > Project: Kylin > Issue Type: Bug >Reporter: Laura Xia >Priority: Major > Fix For: 5.0-beta > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (KYLIN-5631) Logical view some issues
Laura Xia created KYLIN-5631: Summary: Logical view some issues Key: KYLIN-5631 URL: https://issues.apache.org/jira/browse/KYLIN-5631 Project: Kylin Issue Type: Bug Reporter: Laura Xia -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (KYLIN-5631) Logical view some issues
[ https://issues.apache.org/jira/browse/KYLIN-5631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laura Xia reassigned KYLIN-5631: Assignee: Laura Xia > Logical view some issues > > > Key: KYLIN-5631 > URL: https://issues.apache.org/jira/browse/KYLIN-5631 > Project: Kylin > Issue Type: Bug >Reporter: Laura Xia >Assignee: Laura Xia >Priority: Major > Fix For: 5.0-beta > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (KYLIN-5630) Query history some css issues
[ https://issues.apache.org/jira/browse/KYLIN-5630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laura Xia updated KYLIN-5630: - Fix Version/s: 5.0-beta > Query history some css issues > - > > Key: KYLIN-5630 > URL: https://issues.apache.org/jira/browse/KYLIN-5630 > Project: Kylin > Issue Type: Bug >Reporter: Laura Xia >Priority: Major > Fix For: 5.0-beta > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (KYLIN-5630) Query history some css issues
[ https://issues.apache.org/jira/browse/KYLIN-5630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laura Xia reassigned KYLIN-5630: Assignee: Laura Xia > Query history some css issues > - > > Key: KYLIN-5630 > URL: https://issues.apache.org/jira/browse/KYLIN-5630 > Project: Kylin > Issue Type: Bug >Reporter: Laura Xia >Assignee: Laura Xia >Priority: Major > Fix For: 5.0-beta > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (KYLIN-5630) Query history some css issues
Laura Xia created KYLIN-5630: Summary: Query history some css issues Key: KYLIN-5630 URL: https://issues.apache.org/jira/browse/KYLIN-5630 Project: Kylin Issue Type: Bug Reporter: Laura Xia -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (KYLIN-5629) After the multi-level partition model is modified to a full build model, the build job fails
[ https://issues.apache.org/jira/browse/KYLIN-5629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laura Xia updated KYLIN-5629: - Fix Version/s: 5.0-beta > After the multi-level partition model is modified to a full build model, the > build job fails > > > Key: KYLIN-5629 > URL: https://issues.apache.org/jira/browse/KYLIN-5629 > Project: Kylin > Issue Type: Bug >Reporter: Laura Xia >Assignee: Laura Xia >Priority: Major > Fix For: 5.0-beta > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (KYLIN-5629) After the multi-level partition model is modified to a full build model, the build job fails
[ https://issues.apache.org/jira/browse/KYLIN-5629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laura Xia reassigned KYLIN-5629: Assignee: Laura Xia > After the multi-level partition model is modified to a full build model, the > build job fails > > > Key: KYLIN-5629 > URL: https://issues.apache.org/jira/browse/KYLIN-5629 > Project: Kylin > Issue Type: Bug >Reporter: Laura Xia >Assignee: Laura Xia >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (KYLIN-5629) After the multi-level partition model is modified to a full build model, the build job fails
Laura Xia created KYLIN-5629: Summary: After the multi-level partition model is modified to a full build model, the build job fails Key: KYLIN-5629 URL: https://issues.apache.org/jira/browse/KYLIN-5629 Project: Kylin Issue Type: Bug Reporter: Laura Xia -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (KYLIN-5628) The configuration items of kylin.source.ddl.logical-view.database are inconsistent
[ https://issues.apache.org/jira/browse/KYLIN-5628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laura Xia updated KYLIN-5628: - Fix Version/s: 5.0-beta > The configuration items of kylin.source.ddl.logical-view.database are > inconsistent > -- > > Key: KYLIN-5628 > URL: https://issues.apache.org/jira/browse/KYLIN-5628 > Project: Kylin > Issue Type: Bug >Reporter: Laura Xia >Assignee: Laura Xia >Priority: Major > Fix For: 5.0-beta > > > 参数项：kylin.source.ddl.logical-view-database=DB_logical_view -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (KYLIN-5628) The configuration items of kylin.source.ddl.logical-view.database are inconsistent
[ https://issues.apache.org/jira/browse/KYLIN-5628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laura Xia reassigned KYLIN-5628: Assignee: Laura Xia > The configuration items of kylin.source.ddl.logical-view.database are > inconsistent > -- > > Key: KYLIN-5628 > URL: https://issues.apache.org/jira/browse/KYLIN-5628 > Project: Kylin > Issue Type: Bug >Reporter: Laura Xia >Assignee: Laura Xia >Priority: Major > > 参数项：kylin.source.ddl.logical-view-database=DB_logical_view -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (KYLIN-5628) The configuration items of kylin.source.ddl.logical-view.database are inconsistent
Laura Xia created KYLIN-5628: Summary: The configuration items of kylin.source.ddl.logical-view.database are inconsistent Key: KYLIN-5628 URL: https://issues.apache.org/jira/browse/KYLIN-5628 Project: Kylin Issue Type: Bug Reporter: Laura Xia 参数项：kylin.source.ddl.logical-view-database=DB_logical_view -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (KYLIN-5627) After the logical view is created successfully, the front end does not display an entry prompting for loading
[ https://issues.apache.org/jira/browse/KYLIN-5627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laura Xia updated KYLIN-5627: - Fix Version/s: 5.0-beta > After the logical view is created successfully, the front end does not > display an entry prompting for loading > - > > Key: KYLIN-5627 > URL: https://issues.apache.org/jira/browse/KYLIN-5627 > Project: Kylin > Issue Type: Bug >Reporter: Laura Xia >Assignee: Laura Xia >Priority: Major > Fix For: 5.0-beta > > > RT -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (KYLIN-5627) After the logical view is created successfully, the front end does not display an entry prompting for loading
[ https://issues.apache.org/jira/browse/KYLIN-5627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laura Xia reassigned KYLIN-5627: Assignee: Laura Xia > After the logical view is created successfully, the front end does not > display an entry prompting for loading > - > > Key: KYLIN-5627 > URL: https://issues.apache.org/jira/browse/KYLIN-5627 > Project: Kylin > Issue Type: Bug >Reporter: Laura Xia >Assignee: Laura Xia >Priority: Major > > RT -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (KYLIN-5627) After the logical view is created successfully, the front end does not display an entry prompting for loading
Laura Xia created KYLIN-5627: Summary: After the logical view is created successfully, the front end does not display an entry prompting for loading Key: KYLIN-5627 URL: https://issues.apache.org/jira/browse/KYLIN-5627 Project: Kylin Issue Type: Bug Reporter: Laura Xia RT -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (KYLIN-5626) Copy the successfully queried SQL from the query history, because KE rearranged the SQL format with more spaces, the query fails when you query again
[ https://issues.apache.org/jira/browse/KYLIN-5626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laura Xia reassigned KYLIN-5626: Assignee: Laura Xia > Copy the successfully queried SQL from the query history, because KE > rearranged the SQL format with more spaces, the query fails when you query > again > - > > Key: KYLIN-5626 > URL: https://issues.apache.org/jira/browse/KYLIN-5626 > Project: Kylin > Issue Type: Bug >Reporter: Laura Xia >Assignee: Laura Xia >Priority: Major > Fix For: 5.0-beta > > > 从界面查询历史复制由帆软发出的灵活报表查询成功的SQL由于N 和 ‘ ‘之间多了个空格， 导致SQL查询失败 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (KYLIN-5626) Copy the successfully queried SQL from the query history, because KE rearranged the SQL format with more spaces, the query fails when you query again
[ https://issues.apache.org/jira/browse/KYLIN-5626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laura Xia updated KYLIN-5626: - Fix Version/s: 5.0-beta > Copy the successfully queried SQL from the query history, because KE > rearranged the SQL format with more spaces, the query fails when you query > again > - > > Key: KYLIN-5626 > URL: https://issues.apache.org/jira/browse/KYLIN-5626 > Project: Kylin > Issue Type: Bug >Reporter: Laura Xia >Priority: Major > Fix For: 5.0-beta > > > 从界面查询历史复制由帆软发出的灵活报表查询成功的SQL由于N 和 ‘ ‘之间多了个空格， 导致SQL查询失败 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (KYLIN-5625) Edit the custom table index, delete the ShardBy column, and build the index failed
[
https://issues.apache.org/jira/browse/KYLIN-5625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Laura Xia updated KYLIN-5625:
-
Fix Version/s: 5.0-beta
> Edit the custom table index, delete the ShardBy column, and build the index
> failed
> --
>
> Key: KYLIN-5625
> URL: https://issues.apache.org/jira/browse/KYLIN-5625
> Project: Kylin
> Issue Type: Bug
>Reporter: Laura Xia
>Assignee: Laura Xia
>Priority: Major
> Fix For: 5.0-beta
>
>
> 在后端处理手动添加明细索引请求的时候，没有检测是否 {{shard_by_columns}} 列 一定要在 {{col_order}}
> 字段中，所以添加新索引的时候是可能发生丢失 col_order
> 的情况的，这是不符合预期的，构建时也会发生错误，本地测试了下如下请求可以请求成功，但实际存储了错误的元数据
> {{curl -X POST \ http://10.1.2.168:7068/kylin/api/index_plans/table_index \
> -H 'accept: application/vnd.apache.kylin-v4+json' \
> -H 'accept-language: en' \
> -H 'authorization: Basic QURNSU46S1lMSU4=' \
> -H 'cache-control: no-cache' \
> -H 'content-type: application/json' \
> -H 'postman-token: fb63f31f-d8d2-b728-3f3b-553e38b02cb2' \
> -d
> '\{"id":"","col_order":["TF_FACTS_LEADS_DAY.NEW_INTENTIONS"],"sort_by_columns":[],
> \
>
> "shard_by_columns":["TF_FACTS_LEADS_DAY.NEW_LEADS"],"load_data":false,"index_range":"EMPTY","project":"SFM","model_id":"290c552c-c38f-ea8f-8c18-e7850d7419cc"}'}}
> 查看了前端，前端也有 bug，当勾选某个列，选择为 shard by 列，然后点击取消勾选，然后发送请求，col_order
> 中没有加上这个列，shard_by_columns 加上了这个列，就变成了和上述请求 api 同样的效果
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (KYLIN-5626) Copy the successfully queried SQL from the query history, because KE rearranged the SQL format with more spaces, the query fails when you query again
Laura Xia created KYLIN-5626: Summary: Copy the successfully queried SQL from the query history, because KE rearranged the SQL format with more spaces, the query fails when you query again Key: KYLIN-5626 URL: https://issues.apache.org/jira/browse/KYLIN-5626 Project: Kylin Issue Type: Bug Reporter: Laura Xia 从界面查询历史复制由帆软发出的灵活报表查询成功的SQL由于N 和 ‘ ‘之间多了个空格， 导致SQL查询失败 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (KYLIN-5625) Edit the custom table index, delete the ShardBy column, and build the index failed
[
https://issues.apache.org/jira/browse/KYLIN-5625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Laura Xia reassigned KYLIN-5625:
Assignee: Laura Xia
> Edit the custom table index, delete the ShardBy column, and build the index
> failed
> --
>
> Key: KYLIN-5625
> URL: https://issues.apache.org/jira/browse/KYLIN-5625
> Project: Kylin
> Issue Type: Bug
>Reporter: Laura Xia
>Assignee: Laura Xia
>Priority: Major
>
> 在后端处理手动添加明细索引请求的时候，没有检测是否 {{shard_by_columns}} 列 一定要在 {{col_order}}
> 字段中，所以添加新索引的时候是可能发生丢失 col_order
> 的情况的，这是不符合预期的，构建时也会发生错误，本地测试了下如下请求可以请求成功，但实际存储了错误的元数据
> {{curl -X POST \ http://10.1.2.168:7068/kylin/api/index_plans/table_index \
> -H 'accept: application/vnd.apache.kylin-v4+json' \
> -H 'accept-language: en' \
> -H 'authorization: Basic QURNSU46S1lMSU4=' \
> -H 'cache-control: no-cache' \
> -H 'content-type: application/json' \
> -H 'postman-token: fb63f31f-d8d2-b728-3f3b-553e38b02cb2' \
> -d
> '\{"id":"","col_order":["TF_FACTS_LEADS_DAY.NEW_INTENTIONS"],"sort_by_columns":[],
> \
>
> "shard_by_columns":["TF_FACTS_LEADS_DAY.NEW_LEADS"],"load_data":false,"index_range":"EMPTY","project":"SFM","model_id":"290c552c-c38f-ea8f-8c18-e7850d7419cc"}'}}
> 查看了前端，前端也有 bug，当勾选某个列，选择为 shard by 列，然后点击取消勾选，然后发送请求，col_order
> 中没有加上这个列，shard_by_columns 加上了这个列，就变成了和上述请求 api 同样的效果
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (KYLIN-5625) Edit the custom table index, delete the ShardBy column, and build the index failed
Laura Xia created KYLIN-5625:
Summary: Edit the custom table index, delete the ShardBy column,
and build the index failed
Key: KYLIN-5625
URL: https://issues.apache.org/jira/browse/KYLIN-5625
Project: Kylin
Issue Type: Bug
Reporter: Laura Xia
在后端处理手动添加明细索引请求的时候，没有检测是否 {{shard_by_columns}} 列 一定要在 {{col_order}}
字段中，所以添加新索引的时候是可能发生丢失 col_order
的情况的，这是不符合预期的，构建时也会发生错误，本地测试了下如下请求可以请求成功，但实际存储了错误的元数据
{{curl -X POST \ http://10.1.2.168:7068/kylin/api/index_plans/table_index \
-H 'accept: application/vnd.apache.kylin-v4+json' \
-H 'accept-language: en' \
-H 'authorization: Basic QURNSU46S1lMSU4=' \
-H 'cache-control: no-cache' \
-H 'content-type: application/json' \
-H 'postman-token: fb63f31f-d8d2-b728-3f3b-553e38b02cb2' \
-d
'\{"id":"","col_order":["TF_FACTS_LEADS_DAY.NEW_INTENTIONS"],"sort_by_columns":[],
\
"shard_by_columns":["TF_FACTS_LEADS_DAY.NEW_LEADS"],"load_data":false,"index_range":"EMPTY","project":"SFM","model_id":"290c552c-c38f-ea8f-8c18-e7850d7419cc"}'}}
查看了前端，前端也有 bug，当勾选某个列，选择为 shard by 列，然后点击取消勾选，然后发送请求，col_order
中没有加上这个列，shard_by_columns 加上了这个列，就变成了和上述请求 api 同样的效果
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
