[GitHub] [kylin] zzcclp opened a new pull request #1396: KYLIN-4705 Monitor Spark's AppMaster for QueryServer - Part II

2020-09-03 Thread GitBox
zzcclp opened a new pull request #1396: URL: https://github.com/apache/kylin/pull/1396 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure

[GitHub] [kylin] hit-lacus commented on pull request #1396: KYLIN-4705 Monitor Spark's AppMaster for QueryServer - Part II

2020-09-03 Thread GitBox
hit-lacus commented on pull request #1396: URL: https://github.com/apache/kylin/pull/1396#issuecomment-686875934 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [kylin] hit-lacus merged pull request #1396: KYLIN-4705 Monitor Spark's AppMaster for QueryServer - Part II

2020-09-03 Thread GitBox
hit-lacus merged pull request #1396: URL: https://github.com/apache/kylin/pull/1396 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kylin] zzcclp opened a new pull request #1397: KYLIN-4719 Refine kylin-defaults.properties for parquet Storage

2020-09-03 Thread GitBox
zzcclp opened a new pull request #1397: URL: https://github.com/apache/kylin/pull/1397 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure

[GitHub] [kylin] hit-lacus merged pull request #1397: KYLIN-4719 Refine kylin-defaults.properties for parquet Storage

2020-09-04 Thread GitBox
hit-lacus merged pull request #1397: URL: https://github.com/apache/kylin/pull/1397 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kylin] coveralls edited a comment on pull request #1392: KYLIN-4743 NPE when some kafka partition's offset is not exists in checkpoint

2020-09-04 Thread GitBox
coveralls edited a comment on pull request #1392: URL: https://github.com/apache/kylin/pull/1392#issuecomment-686450407 ## Pull Request Test Coverage Report for [Build 6337](https://coveralls.io/builds/33230516) * **0** of **6** **(0.0%)** changed or added relevant lines in **1**

[GitHub] [kylin] RupengWang opened a new pull request #1398: KYLIN-4748 Optimize metadata for debug on local

2020-09-04 Thread GitBox
RupengWang opened a new pull request #1398: URL: https://github.com/apache/kylin/pull/1398 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be

[GitHub] [kylin] hit-lacus opened a new pull request #1399: KYLIN-4660 Fix QueryMetricsTest

2020-09-06 Thread GitBox
hit-lacus opened a new pull request #1399: URL: https://github.com/apache/kylin/pull/1399 - QueryMetricsTest will not start a sparder context. - Skip some module because I want to make sure UT pass at 30 mins. ## Proposed changes Describe the big picture of your changes here

[GitHub] [kylin] hit-lacus commented on pull request #1399: KYLIN-4660 Fix QueryMetricsTest

2020-09-06 Thread GitBox
hit-lacus commented on pull request #1399: URL: https://github.com/apache/kylin/pull/1399#issuecomment-687810547 I will merge this. This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [kylin] hit-lacus closed pull request #1399: KYLIN-4660 Fix QueryMetricsTest

2020-09-06 Thread GitBox
hit-lacus closed pull request #1399: URL: https://github.com/apache/kylin/pull/1399 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kylin] hit-lacus opened a new pull request #1400: Just Verify If TravisCI passed

2020-09-06 Thread GitBox
hit-lacus opened a new pull request #1400: URL: https://github.com/apache/kylin/pull/1400 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be s

[GitHub] [kylin] flyaos opened a new pull request #1401: Update AbstractHadoopJob.java

2020-09-07 Thread GitBox
flyaos opened a new pull request #1401: URL: https://github.com/apache/kylin/pull/1401 ## Proposed changes Delete duplicate code in AbstractHadoopJob.java that add project resource twice. ## Types of changes What types of changes does your code introduce to Kylin? _Put a

[GitHub] [kylin] coveralls commented on pull request #1401: Update AbstractHadoopJob.java

2020-09-07 Thread GitBox
coveralls commented on pull request #1401: URL: https://github.com/apache/kylin/pull/1401#issuecomment-688131738 ## Pull Request Test Coverage Report for [Build 6345](https://coveralls.io/builds/33273673) * **0** of **0** changed or added relevant lines in **0** files are covered.

[GitHub] [kylin] hit-lacus commented on pull request #1373: KYLIN-4716 Optimize the project page

2020-09-08 Thread GitBox
hit-lacus commented on pull request #1373: URL: https://github.com/apache/kylin/pull/1373#issuecomment-689260518 This LGTM, thank you @guangxuCheng . This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kylin] hit-lacus merged pull request #1373: KYLIN-4716 Optimize the project page

2020-09-08 Thread GitBox
hit-lacus merged pull request #1373: URL: https://github.com/apache/kylin/pull/1373 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kylin] jshmchenxi opened a new pull request #1402: KYLIN-4753 Merging job stop working after Kylin upgrade

2020-09-09 Thread GitBox
jshmchenxi opened a new pull request #1402: URL: https://github.com/apache/kylin/pull/1402 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be

[GitHub] [kylin] zzcclp opened a new pull request #1403: KYLIN-4751 Fix NPE issue when run test case TestTopNUDAF

2020-09-09 Thread GitBox
zzcclp opened a new pull request #1403: URL: https://github.com/apache/kylin/pull/1403 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure

[GitHub] [kylin] zzcclp opened a new pull request #1404: KYLIN-4660 Add parameter 'skipRunIt' for maven to support running 'Integration Test'

2020-09-09 Thread GitBox
zzcclp opened a new pull request #1404: URL: https://github.com/apache/kylin/pull/1404 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be

[GitHub] [kylin] lgtm-com[bot] commented on pull request #1404: KYLIN-4660 Add parameter 'skipRunIt' for maven to support running 'Integration Test'

2020-09-09 Thread GitBox
lgtm-com[bot] commented on pull request #1404: URL: https://github.com/apache/kylin/pull/1404#issuecomment-689951663 This pull request **introduces 1 alert** when merging fe8bc3ab6bde31e93ae63480ef6ea84e245523af into f7c4ede01c6b9b46c1b007d94500038789a94fc6 - [view on LGTM.com](https://lg

[GitHub] [kylin] zzcclp commented on pull request #1404: KYLIN-4660 Add parameter 'skipRunIt' for maven to support running 'Integration Test'

2020-09-09 Thread GitBox
zzcclp commented on pull request #1404: URL: https://github.com/apache/kylin/pull/1404#issuecomment-689959610 > This pull request **introduces 1 alert** when merging [fe8bc3a](https://github.com/apache/kylin/commit/fe8bc3ab6bde31e93ae63480ef6ea84e245523af) into [f7c4ede](https://github.co

[GitHub] [kylin] jshmchenxi commented on pull request #1402: KYLIN-4753 Merging job stop working after Kylin upgrade

2020-09-09 Thread GitBox
jshmchenxi commented on pull request #1402: URL: https://github.com/apache/kylin/pull/1402#issuecomment-690015060 @shaofengshi Hi, this is a simple patch and the failed test seems to be irrelevant. Would you please take a look?

[GitHub] [kylin] hit-lacus merged pull request #1400: Just Verify If TravisCI passed

2020-09-09 Thread GitBox
hit-lacus merged pull request #1400: URL: https://github.com/apache/kylin/pull/1400 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kylin] guangxuCheng opened a new pull request #1405: KYLIN-4755 Error while compiling generated Java code when using Kylin…

2020-09-10 Thread GitBox
guangxuCheng opened a new pull request #1405: URL: https://github.com/apache/kylin/pull/1405 … UDF in "case when" ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or r

[GitHub] [kylin] coveralls commented on pull request #1405: KYLIN-4755 Error while compiling generated Java code when using Kylin…

2020-09-10 Thread GitBox
coveralls commented on pull request #1405: URL: https://github.com/apache/kylin/pull/1405#issuecomment-690108973 ## Pull Request Test Coverage Report for [Build 6356](https://coveralls.io/builds/33357071) * **0** of **0** changed or added relevant lines in **0** files are covered.

[GitHub] [kylin] hit-lacus merged pull request #1404: KYLIN-4660 Add parameter 'skipRunIt' for maven to support running 'Integration Test'

2020-09-10 Thread GitBox
hit-lacus merged pull request #1404: URL: https://github.com/apache/kylin/pull/1404 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kylin] hit-lacus commented on pull request #1404: KYLIN-4660 Add parameter 'skipRunIt' for maven to support running 'Integration Test'

2020-09-10 Thread GitBox
hit-lacus commented on pull request #1404: URL: https://github.com/apache/kylin/pull/1404#issuecomment-690143036 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [kylin] hit-lacus commented on pull request #1403: KYLIN-4751 Fix NPE issue when run test case TestTopNUDAF

2020-09-10 Thread GitBox
hit-lacus commented on pull request #1403: URL: https://github.com/apache/kylin/pull/1403#issuecomment-690153827 This looks good to me. This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [kylin] hit-lacus merged pull request #1403: KYLIN-4751 Fix NPE issue when run test case TestTopNUDAF

2020-09-10 Thread GitBox
hit-lacus merged pull request #1403: URL: https://github.com/apache/kylin/pull/1403 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kylin] guangxuCheng opened a new pull request #1406: KYLIN-4756 user/group page has duplicate information between adjacent page numbers

2020-09-10 Thread GitBox
guangxuCheng opened a new pull request #1406: URL: https://github.com/apache/kylin/pull/1406 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, b

[GitHub] [kylin] coveralls commented on pull request #1406: KYLIN-4756 user/group page has duplicate information between adjacent page numbers

2020-09-10 Thread GitBox
coveralls commented on pull request #1406: URL: https://github.com/apache/kylin/pull/1406#issuecomment-690273518 ## Pull Request Test Coverage Report for [Build 6357](https://coveralls.io/builds/33361716) * **0** of **0** changed or added relevant lines in **0** files are covered.

[GitHub] [kylin] hit-lacus opened a new pull request #1407: Prepare release for 4.0.0-alpha

2020-09-13 Thread GitBox
hit-lacus opened a new pull request #1407: URL: https://github.com/apache/kylin/pull/1407 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be s

[GitHub] [kylin] hit-lacus merged pull request #1407: Prepare release for 4.0.0-alpha

2020-09-13 Thread GitBox
hit-lacus merged pull request #1407: URL: https://github.com/apache/kylin/pull/1407 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kylin] yanghua opened a new pull request #1408: Update the documentation to specify a given container name for docker run/exec commands

2020-09-14 Thread GitBox
yanghua opened a new pull request #1408: URL: https://github.com/apache/kylin/pull/1408 ## Proposed changes Update the documentation to specify a given container name for `docker run/exec` commands ## Types of changes What types of changes does your code introduce t

[GitHub] [kylin] coveralls commented on pull request #1408: Update the documentation to specify a given container name for docker run/exec commands

2020-09-14 Thread GitBox
coveralls commented on pull request #1408: URL: https://github.com/apache/kylin/pull/1408#issuecomment-691965066 ## Pull Request Test Coverage Report for [Build 6362](https://coveralls.io/builds/33437586) * **0** of **0** changed or added relevant lines in **0** files are covered.

[GitHub] [kylin] hit-lacus merged pull request #1408: Update the documentation to specify a given container name for docker run/exec commands

2020-09-14 Thread GitBox
hit-lacus merged pull request #1408: URL: https://github.com/apache/kylin/pull/1408 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kylin] hit-lacus commented on pull request #1406: KYLIN-4756 user/group page has duplicate information between adjacent page numbers

2020-09-14 Thread GitBox
hit-lacus commented on pull request #1406: URL: https://github.com/apache/kylin/pull/1406#issuecomment-692070955 @zzcclp could please help to review this patch ? This is an automated message from the Apache Git Service. To r

[GitHub] [kylin] hit-lacus commented on pull request #1405: KYLIN-4755 Error while compiling generated Java code when using Kylin…

2020-09-14 Thread GitBox
hit-lacus commented on pull request #1405: URL: https://github.com/apache/kylin/pull/1405#issuecomment-692079514 I can reproduce this, I think I will merge this in the future. This is an automated message from the Apache Git

[GitHub] [kylin] hit-lacus commented on pull request #1401: Delete duplicate code in AbstractHadoopJob

2020-09-14 Thread GitBox
hit-lacus commented on pull request #1401: URL: https://github.com/apache/kylin/pull/1401#issuecomment-692081097 OK, this looks fine to me. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kylin] hit-lacus merged pull request #1401: Delete duplicate code in AbstractHadoopJob

2020-09-14 Thread GitBox
hit-lacus merged pull request #1401: URL: https://github.com/apache/kylin/pull/1401 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kylin] zzcclp commented on pull request #1406: KYLIN-4756 user/group page has duplicate information between adjacent page numbers

2020-09-14 Thread GitBox
zzcclp commented on pull request #1406: URL: https://github.com/apache/kylin/pull/1406#issuecomment-692396002 LGTM. BTW, there are some places missing ';' after function, could you add them? This is an automated message fr

[GitHub] [kylin] guangxuCheng commented on pull request #1406: KYLIN-4756 user/group page has duplicate information between adjacent page numbers

2020-09-14 Thread GitBox
guangxuCheng commented on pull request #1406: URL: https://github.com/apache/kylin/pull/1406#issuecomment-692414107 > LGTM. > BTW, there are some places missing ';' after function, could you add them? Thanks for review. I will add them. ---

[GitHub] [kylin] guangxuCheng commented on pull request #1406: KYLIN-4756 user/group page has duplicate information between adjacent page numbers

2020-09-14 Thread GitBox
guangxuCheng commented on pull request #1406: URL: https://github.com/apache/kylin/pull/1406#issuecomment-692419840 @zzcclp Add some missing ";" , the main change is in line 78. Thanks This is an automated message fro

[GitHub] [kylin] hit-lacus commented on pull request #1402: KYLIN-4753 Merging job stop working after Kylin upgrade

2020-09-14 Thread GitBox
hit-lacus commented on pull request #1402: URL: https://github.com/apache/kylin/pull/1402#issuecomment-692424311 @jshmchenxi Thank you for this patch, it looks good to me. This is an automated message from the Apache Git Ser

[GitHub] [kylin] codecov-commenter commented on pull request #1406: KYLIN-4756 user/group page has duplicate information between adjacent page numbers

2020-09-14 Thread GitBox
codecov-commenter commented on pull request #1406: URL: https://github.com/apache/kylin/pull/1406#issuecomment-692425263 # [Codecov](https://codecov.io/gh/apache/kylin/pull/1406?src=pr&el=h1) Report > Merging [#1406](https://codecov.io/gh/apache/kylin/pull/1406?src=pr&el=desc) into [mas

[GitHub] [kylin] coveralls edited a comment on pull request #1406: KYLIN-4756 user/group page has duplicate information between adjacent page numbers

2020-09-14 Thread GitBox
coveralls edited a comment on pull request #1406: URL: https://github.com/apache/kylin/pull/1406#issuecomment-690273518 ## Pull Request Test Coverage Report for [Build 6364](https://coveralls.io/builds/33460284) * **0** of **0** changed or added relevant lines in **0** files are c

[GitHub] [kylin] hit-lacus merged pull request #1402: KYLIN-4753 Merging job stop working after Kylin upgrade

2020-09-14 Thread GitBox
hit-lacus merged pull request #1402: URL: https://github.com/apache/kylin/pull/1402 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kylin] hit-lacus commented on pull request #1374: KYLIN-4717 Failed to build webapp

2020-09-14 Thread GitBox
hit-lacus commented on pull request #1374: URL: https://github.com/apache/kylin/pull/1374#issuecomment-692429066 @zzcclp Please help to review this. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kylin] hit-lacus commented on pull request #1406: KYLIN-4756 user/group page has duplicate information between adjacent page numbers

2020-09-14 Thread GitBox
hit-lacus commented on pull request #1406: URL: https://github.com/apache/kylin/pull/1406#issuecomment-692429861 Thank you, @guangxuCheng . I will merge this. This is an automated message from the Apache Git Service. To respo

[GitHub] [kylin] hit-lacus merged pull request #1406: KYLIN-4756 user/group page has duplicate information between adjacent page numbers

2020-09-14 Thread GitBox
hit-lacus merged pull request #1406: URL: https://github.com/apache/kylin/pull/1406 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kylin] hit-lacus commented on pull request #1392: KYLIN-4743 NPE when some kafka partition's offset is not exists in checkpoint

2020-09-14 Thread GitBox
hit-lacus commented on pull request #1392: URL: https://github.com/apache/kylin/pull/1392#issuecomment-692433519 Thank you @ggKe , looks like this patch has been fixed by https://github.com/apache/kylin/pull/1351 , so thank you for your contribution. --

[GitHub] [kylin] hit-lacus closed pull request #1392: KYLIN-4743 NPE when some kafka partition's offset is not exists in checkpoint

2020-09-14 Thread GitBox
hit-lacus closed pull request #1392: URL: https://github.com/apache/kylin/pull/1392 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kylin] zzcclp commented on pull request #1374: KYLIN-4717 Failed to build webapp

2020-09-14 Thread GitBox
zzcclp commented on pull request #1374: URL: https://github.com/apache/kylin/pull/1374#issuecomment-692448899 The root cause of this issue you met is that the version of node and npm is higher than required, the required version is below: node: lower than v10.20.X npm: lower than 6

[GitHub] [kylin] zhangayqian opened a new pull request #1409: KYLIN-4754 The Cleanup tool cannot clean the the parquet file of the …

2020-09-14 Thread GitBox
zhangayqian opened a new pull request #1409: URL: https://github.com/apache/kylin/pull/1409 …deleted cube and project ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug o

[GitHub] [kylin] zzcclp opened a new pull request #1410: KYLIN-4452 Kylin 4 with Docker

2020-09-14 Thread GitBox
zzcclp opened a new pull request #1410: URL: https://github.com/apache/kylin/pull/1410 Docker image for Apache Kylin 4 Alpha ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes

[GitHub] [kylin] hit-lacus commented on pull request #1370: KYLIN-4714 Failed to revoke role access of the project

2020-09-14 Thread GitBox
hit-lacus commented on pull request #1370: URL: https://github.com/apache/kylin/pull/1370#issuecomment-692493878 @zhangayqian , please help to check this . This is an automated message from the Apache Git Service. To respond

[GitHub] [kylin] hit-lacus merged pull request #1340: KYLIN-4679 StorageCleanupJob clean hive table support hive table prefix

2020-09-15 Thread GitBox
hit-lacus merged pull request #1340: URL: https://github.com/apache/kylin/pull/1340 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kylin] hit-lacus commented on pull request #1340: KYLIN-4679 StorageCleanupJob clean hive table support hive table prefix

2020-09-15 Thread GitBox
hit-lacus commented on pull request #1340: URL: https://github.com/apache/kylin/pull/1340#issuecomment-692624279 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [kylin] guangxuCheng commented on pull request #1374: KYLIN-4717 Failed to build webapp

2020-09-15 Thread GitBox
guangxuCheng commented on pull request #1374: URL: https://github.com/apache/kylin/pull/1374#issuecomment-693152663 `✖ 4 of 3 tests failed: 1) jpegtran should return path to jpegtran binary: AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:

[GitHub] [kylin] RupengWang opened a new pull request #1411: KYLIN-4760 Optimize TopN measure

2020-09-15 Thread GitBox
RupengWang opened a new pull request #1411: URL: https://github.com/apache/kylin/pull/1411 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be

[GitHub] [kylin] zhangayqian opened a new pull request #1412: KYLIN-4712 Optimize Optimize CubeMetaIngester.java CLI

2020-09-16 Thread GitBox
zhangayqian opened a new pull request #1412: URL: https://github.com/apache/kylin/pull/1412 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be

[GitHub] [kylin] zhangayqian opened a new pull request #1413: KYLIN-4712 Optimize CubeMetaIngester.java CLI

2020-09-16 Thread GitBox
zhangayqian opened a new pull request #1413: URL: https://github.com/apache/kylin/pull/1413 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be

[GitHub] [kylin] zzcclp commented on a change in pull request #1411: KYLIN-4760 Optimize TopN measure

2020-09-16 Thread GitBox
zzcclp commented on a change in pull request #1411: URL: https://github.com/apache/kylin/pull/1411#discussion_r489238725 ## File path: kylin-spark-project/kylin-spark-engine/src/main/scala/org/apache/kylin/engine/spark/builder/CubeDictionaryBuilder.scala ## @@ -65,6 +65,7 @@ c

[GitHub] [kylin] zzcclp commented on a change in pull request #1411: KYLIN-4760 Optimize TopN measure

2020-09-16 Thread GitBox
zzcclp commented on a change in pull request #1411: URL: https://github.com/apache/kylin/pull/1411#discussion_r489240984 ## File path: kylin-spark-project/kylin-spark-engine/src/main/scala/org/apache/kylin/engine/spark/job/CuboidAggregator.scala ## @@ -98,9 +98,22 @@ object Cu

[GitHub] [kylin] coveralls commented on pull request #1413: KYLIN-4712 Optimize CubeMetaIngester.java CLI

2020-09-16 Thread GitBox
coveralls commented on pull request #1413: URL: https://github.com/apache/kylin/pull/1413#issuecomment-693260502 ## Pull Request Test Coverage Report for [Build 6370](https://coveralls.io/builds/33496149) * **0** of **11** **(0.0%)** changed or added relevant lines in **1** file

[GitHub] [kylin] RupengWang commented on a change in pull request #1411: KYLIN-4760 Optimize TopN measure

2020-09-16 Thread GitBox
RupengWang commented on a change in pull request #1411: URL: https://github.com/apache/kylin/pull/1411#discussion_r489305886 ## File path: kylin-spark-project/kylin-spark-engine/src/main/scala/org/apache/kylin/engine/spark/job/CuboidAggregator.scala ## @@ -98,9 +98,22 @@ objec

[GitHub] [kylin] lijianfeng6666526 opened a new pull request #1414: Error while compiling statement: FAILED: SemanticException Line 1:21 Table or database name may not contain dot(.) character

2020-09-16 Thread GitBox
lijianfeng526 opened a new pull request #1414: URL: https://github.com/apache/kylin/pull/1414 INFO : Compiling command(queryId=hive_20200916191433_8b35b096-3c07-4b2f-b17a-fd4347c38aef): USE default INFO : Semantic Analysis Completed (retrial = false) INFO : Returning Hive sche

[GitHub] [kylin] hit-lacus commented on pull request #1411: KYLIN-4760 Optimize TopN measure

2020-09-16 Thread GitBox
hit-lacus commented on pull request #1411: URL: https://github.com/apache/kylin/pull/1411#issuecomment-693387007 Thank you @RupengWang @zzcclp , you are doing great job. This is an automated message from the Apache Git Servi

[GitHub] [kylin] hit-lacus merged pull request #1411: KYLIN-4760 Optimize TopN measure

2020-09-16 Thread GitBox
hit-lacus merged pull request #1411: URL: https://github.com/apache/kylin/pull/1411 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kylin] hit-lacus merged pull request #1410: KYLIN-4452 Kylin 4 with Docker

2020-09-16 Thread GitBox
hit-lacus merged pull request #1410: URL: https://github.com/apache/kylin/pull/1410 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kylin] hit-lacus commented on pull request #1410: KYLIN-4452 Kylin 4 with Docker

2020-09-16 Thread GitBox
hit-lacus commented on pull request #1410: URL: https://github.com/apache/kylin/pull/1410#issuecomment-693389878 This looks good to me. This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [kylin] hit-lacus merged pull request #1405: KYLIN-4755 Error while compiling generated Java code when using Kylin…

2020-09-16 Thread GitBox
hit-lacus merged pull request #1405: URL: https://github.com/apache/kylin/pull/1405 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kylin] hit-lacus commented on pull request #1414: Error while compiling statement: FAILED: SemanticException Line 1:21 Table or database name may not contain dot(.) character

2020-09-16 Thread GitBox
hit-lacus commented on pull request #1414: URL: https://github.com/apache/kylin/pull/1414#issuecomment-693393510 What do you want to fix ? Is it a patch to Hadoop3.X branch ? This is an automated message from the Apache Git S

[GitHub] [kylin] lijianfeng6666526 opened a new pull request #1415: Error while compiling statement: FAILED: SemanticException Line 1:21 Table or database name may not contain dot(.) character

2020-09-16 Thread GitBox
lijianfeng526 opened a new pull request #1415: URL: https://github.com/apache/kylin/pull/1415 The version is : kylin2.6.3 + hadoop3.1 **when the job cube , an error has occurred . the error is as follows** **:** ![image](https://user-images.githubusercontent.com/

[GitHub] [kylin] RupengWang opened a new pull request #1416: KYLIN-4729 Fix the hive table will be overwrited when add csv table w…

2020-09-16 Thread GitBox
RupengWang opened a new pull request #1416: URL: https://github.com/apache/kylin/pull/1416 …ith the same name ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resol

[GitHub] [kylin] zhangayqian commented on pull request #1370: KYLIN-4714 Failed to revoke role access of the project

2020-09-17 Thread GitBox
zhangayqian commented on pull request #1370: URL: https://github.com/apache/kylin/pull/1370#issuecomment-694035692 I have verify this PR. It does fixed KYLIN-4712. - Fistly, I grant two user `test` and `test_user` the project query permission. https://user-images.githubusercontent.co

[GitHub] [kylin] zhangayqian edited a comment on pull request #1370: KYLIN-4714 Failed to revoke role access of the project

2020-09-17 Thread GitBox
zhangayqian edited a comment on pull request #1370: URL: https://github.com/apache/kylin/pull/1370#issuecomment-694035692 I have verify this PR. It does fixed KYLIN-4712. - Fistly, I grant two user `test` and `test_user` the project query permission. https://user-images.githubusercon

[GitHub] [kylin] hit-lacus commented on pull request #1409: KYLIN-4754 The Cleanup tool cannot clean the the parquet file of the …

2020-09-17 Thread GitBox
hit-lacus commented on pull request #1409: URL: https://github.com/apache/kylin/pull/1409#issuecomment-694076501 This LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kylin] hit-lacus commented on pull request #1409: KYLIN-4754 The Cleanup tool cannot clean the the parquet file of the …

2020-09-17 Thread GitBox
hit-lacus commented on pull request #1409: URL: https://github.com/apache/kylin/pull/1409#issuecomment-694076347 Looks like the CI check failed for network reason. "Caused by: java.net.UnknownHostException: repository.kyligence.io: Temporary failure in name resolution" ---

[GitHub] [kylin] hit-lacus merged pull request #1409: KYLIN-4754 The Cleanup tool cannot clean the the parquet file of the …

2020-09-17 Thread GitBox
hit-lacus merged pull request #1409: URL: https://github.com/apache/kylin/pull/1409 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kylin] hit-lacus commented on pull request #1370: KYLIN-4714 Failed to revoke role access of the project

2020-09-17 Thread GitBox
hit-lacus commented on pull request #1370: URL: https://github.com/apache/kylin/pull/1370#issuecomment-694077405 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [kylin] hit-lacus merged pull request #1370: KYLIN-4714 Failed to revoke role access of the project

2020-09-17 Thread GitBox
hit-lacus merged pull request #1370: URL: https://github.com/apache/kylin/pull/1370 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kylin] hit-lacus closed pull request #1370: KYLIN-4714 Failed to revoke role access of the project

2020-09-17 Thread GitBox
hit-lacus closed pull request #1370: URL: https://github.com/apache/kylin/pull/1370 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kylin] hit-lacus merged pull request #1398: KYLIN-4748 Optimize metadata for debug on local

2020-09-17 Thread GitBox
hit-lacus merged pull request #1398: URL: https://github.com/apache/kylin/pull/1398 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kylin] hit-lacus commented on pull request #1398: KYLIN-4748 Optimize metadata for debug on local

2020-09-17 Thread GitBox
hit-lacus commented on pull request #1398: URL: https://github.com/apache/kylin/pull/1398#issuecomment-694078264 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [kylin] hit-lacus merged pull request #1351: KYLIN-4683 Fail to consume kafka when partition number get larger

2020-09-17 Thread GitBox
hit-lacus merged pull request #1351: URL: https://github.com/apache/kylin/pull/1351 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kylin] hit-lacus commented on pull request #1351: KYLIN-4683 Fail to consume kafka when partition number get larger

2020-09-17 Thread GitBox
hit-lacus commented on pull request #1351: URL: https://github.com/apache/kylin/pull/1351#issuecomment-694084949 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [kylin] hit-lacus merged pull request #1416: KYLIN-4729 Fix the hive table will be overwrited when add csv table w…

2020-09-20 Thread GitBox
hit-lacus merged pull request #1416: URL: https://github.com/apache/kylin/pull/1416 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kylin] hit-lacus commented on pull request #1416: KYLIN-4729 Fix the hive table will be overwrited when add csv table w…

2020-09-20 Thread GitBox
hit-lacus commented on pull request #1416: URL: https://github.com/apache/kylin/pull/1416#issuecomment-695755504 LGTM , thank you @RupengWang . This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [kylin] hit-lacus merged pull request #1413: KYLIN-4712 Optimize CubeMetaIngester.java CLI

2020-09-20 Thread GitBox
hit-lacus merged pull request #1413: URL: https://github.com/apache/kylin/pull/1413 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kylin] hit-lacus commented on pull request #1413: KYLIN-4712 Optimize CubeMetaIngester.java CLI

2020-09-20 Thread GitBox
hit-lacus commented on pull request #1413: URL: https://github.com/apache/kylin/pull/1413#issuecomment-695755749 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [kylin] hit-lacus commented on pull request #1412: KYLIN-4712 Optimize Optimize CubeMetaIngester.java CLI

2020-09-21 Thread GitBox
hit-lacus commented on pull request #1412: URL: https://github.com/apache/kylin/pull/1412#issuecomment-695996183 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [kylin] hit-lacus merged pull request #1412: KYLIN-4712 Optimize Optimize CubeMetaIngester.java CLI

2020-09-21 Thread GitBox
hit-lacus merged pull request #1412: URL: https://github.com/apache/kylin/pull/1412 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kylin] zhangayqian opened a new pull request #1417: KYLIN-4759 Remove hbase command from scripts in build directory

2020-09-21 Thread GitBox
zhangayqian opened a new pull request #1417: URL: https://github.com/apache/kylin/pull/1417 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be

[GitHub] [kylin] hit-lacus merged pull request #1412: KYLIN-4712 Optimize Optimize CubeMetaIngester.java CLI

2020-09-21 Thread GitBox
hit-lacus merged pull request #1412: URL: https://github.com/apache/kylin/pull/1412 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kylin] hit-lacus commented on pull request #1412: KYLIN-4712 Optimize Optimize CubeMetaIngester.java CLI

2020-09-21 Thread GitBox
hit-lacus commented on pull request #1412: URL: https://github.com/apache/kylin/pull/1412#issuecomment-695996183 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [kylin] zhangayqian opened a new pull request #1418: Upgrade spark and spring version

2020-09-22 Thread GitBox
zhangayqian opened a new pull request #1418: URL: https://github.com/apache/kylin/pull/1418 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be

[GitHub] [kylin] coveralls commented on pull request #1418: Upgrade spark and spring version

2020-09-22 Thread GitBox
coveralls commented on pull request #1418: URL: https://github.com/apache/kylin/pull/1418#issuecomment-696620575 ## Pull Request Test Coverage Report for [Build 6385](https://coveralls.io/builds/33630461) * **0** of **0** changed or added relevant lines in **0** files are covered.

[GitHub] [kylin] tianhui5 opened a new pull request #1419: KYLIN-4770: Move Kylin service on k8s from background to foreground

2020-09-22 Thread GitBox
tianhui5 opened a new pull request #1419: URL: https://github.com/apache/kylin/pull/1419 ## Proposed changes JIRA: https://issues.apache.org/jira/browse/KYLIN-4770 ## Types of changes - [x] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-break

[GitHub] [kylin] coveralls commented on pull request #1419: KYLIN-4770: Move Kylin service on k8s from background to foreground

2020-09-22 Thread GitBox
coveralls commented on pull request #1419: URL: https://github.com/apache/kylin/pull/1419#issuecomment-696676711 ## Pull Request Test Coverage Report for [Build 6386](https://coveralls.io/builds/33633402) * **0** of **0** changed or added relevant lines in **0** files are covered.

[GitHub] [kylin] hit-lacus merged pull request #1418: Upgrade spark and spring version

2020-09-22 Thread GitBox
hit-lacus merged pull request #1418: URL: https://github.com/apache/kylin/pull/1418 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

<    15   16   17   18   19   20   21   22   23   24   >