[GitHub] asfgit commented on issue #414: KYLIN-3738 Edit cube measure may make the decimal type change unexpectly

2018-12-24 Thread GitBox
asfgit commented on issue #414: KYLIN-3738 Edit cube measure may make the decimal type change unexpectly URL: https://github.com/apache/kylin/pull/414#issuecomment-449721083 Can one of the admins verify this patch? This is

[GitHub] kyotoYaho closed pull request #407: KYLIN-3540 estimate the row counts of source cuboids which are not built & remove mandatory cuboids recommendation

2018-12-24 Thread GitBox
kyotoYaho closed pull request #407: KYLIN-3540 estimate the row counts of source cuboids which are not built & remove mandatory cuboids recommendation URL: https://github.com/apache/kylin/pull/407 This is a PR merged from a forked repository. As GitHub hides the original diff on merge,

[GitHub] hit-lacus commented on a change in pull request #397: KYLIN-3722 Disable limit push down after join

2018-12-24 Thread GitBox
hit-lacus commented on a change in pull request #397: KYLIN-3722 Disable limit push down after join URL: https://github.com/apache/kylin/pull/397#discussion_r243877021 ## File path: query/src/main/java/org/apache/kylin/query/relnode/OLAPLimitRel.java ## @@ -82,7 +82,8 @@

[GitHub] shaofengshi commented on a change in pull request #397: KYLIN-3722 Disable limit push down after join

2018-12-24 Thread GitBox
shaofengshi commented on a change in pull request #397: KYLIN-3722 Disable limit push down after join URL: https://github.com/apache/kylin/pull/397#discussion_r243876893 ## File path: query/src/main/java/org/apache/kylin/query/relnode/OLAPLimitRel.java ## @@ -82,7 +82,8

[GitHub] shaofengshi closed pull request #414: KYLIN-3738 Edit cube measure may make the decimal type change unexpectly

2018-12-24 Thread GitBox
shaofengshi closed pull request #414: KYLIN-3738 Edit cube measure may make the decimal type change unexpectly URL: https://github.com/apache/kylin/pull/414 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] codecov-io commented on issue #398: Kylin 3597 fix sonar issues

2018-12-24 Thread GitBox
codecov-io commented on issue #398: Kylin 3597 fix sonar issues URL: https://github.com/apache/kylin/pull/398#issuecomment-449808086 # [Codecov](https://codecov.io/gh/apache/kylin/pull/398?src=pr=h1) Report > Merging [#398](https://codecov.io/gh/apache/kylin/pull/398?src=pr=desc) into

[GitHub] codecov-io edited a comment on issue #359: KYLIN-3628 The wrong result when a query with one lookup table

2018-12-25 Thread GitBox
codecov-io edited a comment on issue #359: KYLIN-3628 The wrong result when a query with one lookup table URL: https://github.com/apache/kylin/pull/359#issuecomment-445522483 # [Codecov](https://codecov.io/gh/apache/kylin/pull/359?src=pr=h1) Report > Merging

[GitHub] shaofengshi commented on a change in pull request #409: KYLIN-2972 CacheKey from SQLRequest should ignore the case of project…

2018-12-22 Thread GitBox
shaofengshi commented on a change in pull request #409: KYLIN-2972 CacheKey from SQLRequest should ignore the case of project… URL: https://github.com/apache/kylin/pull/409#discussion_r243750309 ## File path: server-base/src/main/java/org/apache/kylin/rest/request/SQLRequest.java

[GitHub] shaofengshi closed pull request #403: Kylin 3726: KylinSession should load spark properties from spark-defaults.conf

2018-12-22 Thread GitBox
shaofengshi closed pull request #403: Kylin 3726: KylinSession should load spark properties from spark-defaults.conf URL: https://github.com/apache/kylin/pull/403 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake

[GitHub] shaofengshi commented on issue #403: Kylin 3726: KylinSession should load spark properties from spark-defaults.conf

2018-12-22 Thread GitBox
shaofengshi commented on issue #403: Kylin 3726: KylinSession should load spark properties from spark-defaults.conf URL: https://github.com/apache/kylin/pull/403#issuecomment-449608576 Excellent, thank you Shaohui! This is

[GitHub] shaofengshi closed pull request #402: KYLIN-3724 Kylin IT test sql is unreasonable

2018-12-22 Thread GitBox
shaofengshi closed pull request #402: KYLIN-3724 Kylin IT test sql is unreasonable URL: https://github.com/apache/kylin/pull/402 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] woyumen4597 opened a new pull request #411: KYLIN-3737 refactor cache part for RDBMS

2018-12-22 Thread GitBox
woyumen4597 opened a new pull request #411: KYLIN-3737 refactor cache part for RDBMS URL: https://github.com/apache/kylin/pull/411 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] codecov-io edited a comment on issue #359: KYLIN-3628 The wrong result when a query with one lookup table

2018-12-25 Thread GitBox
codecov-io edited a comment on issue #359: KYLIN-3628 The wrong result when a query with one lookup table URL: https://github.com/apache/kylin/pull/359#issuecomment-445522483 # [Codecov](https://codecov.io/gh/apache/kylin/pull/359?src=pr=h1) Report > Merging

[GitHub] wangbo opened a new pull request #394: KYLIN-3720 add column family check when save/update cube desc

2018-12-14 Thread GitBox
wangbo opened a new pull request #394: KYLIN-3720 add column family check when save/update cube desc URL: https://github.com/apache/kylin/pull/394 This is an automated message from the Apache Git Service. To respond to the

[GitHub] asfgit commented on issue #394: KYLIN-3720 add column family check when save/update cube desc

2018-12-14 Thread GitBox
asfgit commented on issue #394: KYLIN-3720 add column family check when save/update cube desc URL: https://github.com/apache/kylin/pull/394#issuecomment-447546532 Can one of the admins verify this patch? This is an automated

[GitHub] coveralls commented on issue #394: KYLIN-3720 add column family check when save/update cube desc

2018-12-15 Thread GitBox
coveralls commented on issue #394: KYLIN-3720 add column family check when save/update cube desc URL: https://github.com/apache/kylin/pull/394#issuecomment-447548175 ## Pull Request Test Coverage Report for [Build 3966](https://coveralls.io/builds/20650531) * **0** of **14**

[GitHub] shaofengshi closed pull request #393: KYLIN-3597 improve code smell

2018-12-15 Thread GitBox
shaofengshi closed pull request #393: KYLIN-3597 improve code smell URL: https://github.com/apache/kylin/pull/393 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request

[GitHub] shaofengshi commented on a change in pull request #394: KYLIN-3720 add column family check when save/update cube desc

2018-12-15 Thread GitBox
shaofengshi commented on a change in pull request #394: KYLIN-3720 add column family check when save/update cube desc URL: https://github.com/apache/kylin/pull/394#discussion_r241949448 ## File path: server-base/src/main/java/org/apache/kylin/rest/controller/CubeController.java

[GitHub] shaofengshi closed pull request #366: KYLIN-3707 add configuration for setting isolation-level for sqoop

2018-12-15 Thread GitBox
shaofengshi closed pull request #366: KYLIN-3707 add configuration for setting isolation-level for sqoop URL: https://github.com/apache/kylin/pull/366 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] shaofengshi closed pull request #385: set JAVA_HOME before server start or stop

2018-12-13 Thread GitBox
shaofengshi closed pull request #385: set JAVA_HOME before server start or stop URL: https://github.com/apache/kylin/pull/385 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] asfgit commented on issue #392: KYLIN-3597 fix sonar issues

2018-12-13 Thread GitBox
asfgit commented on issue #392: KYLIN-3597 fix sonar issues URL: https://github.com/apache/kylin/pull/392#issuecomment-447231906 Can one of the admins verify this patch? This is an automated message from the Apache Git

[GitHub] asfgit commented on issue #385: set JAVA_HOME before server start or stop

2018-12-11 Thread GitBox
asfgit commented on issue #385: set JAVA_HOME before server start or stop URL: https://github.com/apache/kylin/pull/385#issuecomment-446208920 Can one of the admins verify this patch? This is an automated message from the

[GitHub] shopee-jin opened a new pull request #385: set JAVA_HOME before server start or stop

2018-12-11 Thread GitBox
shopee-jin opened a new pull request #385: set JAVA_HOME before server start or stop URL: https://github.com/apache/kylin/pull/385 We believe that the following scenario is fairly common in big data communities: 1. Have CDH 5.x with JDK 1.7 2. Have JDK 1.8+ for other usage

[GitHub] codecov-io commented on issue #385: set JAVA_HOME before server start or stop

2018-12-11 Thread GitBox
codecov-io commented on issue #385: set JAVA_HOME before server start or stop URL: https://github.com/apache/kylin/pull/385#issuecomment-446215883 # [Codecov](https://codecov.io/gh/apache/kylin/pull/385?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base

[GitHub] asfgit commented on issue #369: Add the logo of the company that use Kylin

2018-11-30 Thread GitBox
asfgit commented on issue #369: Add the logo of the company that use Kylin URL: https://github.com/apache/kylin/pull/369#issuecomment-443245117 Can one of the admins verify this patch? This is an automated message from the

[GitHub] codecov-io commented on issue #365: KYLIN-2578, clean deprecated config("kylin.job.lock") usage in the code.

2018-11-27 Thread GitBox
codecov-io commented on issue #365: KYLIN-2578, clean deprecated config("kylin.job.lock") usage in the code. URL: https://github.com/apache/kylin/pull/365#issuecomment-442347708 # [Codecov](https://codecov.io/gh/apache/kylin/pull/365?src=pr=h1) Report > Merging

[GitHub] asfgit commented on issue #366: KYLIN-3707 add configuration for setting isolation-level for sqoop

2018-11-28 Thread GitBox
asfgit commented on issue #366: KYLIN-3707 add configuration for setting isolation-level for sqoop URL: https://github.com/apache/kylin/pull/366#issuecomment-442398186 Can one of the admins verify this patch? This is an

[GitHub] woyumen4597 opened a new pull request #366: KYLIN-3707 add configuration for setting isolation-level for sqoop

2018-11-28 Thread GitBox
woyumen4597 opened a new pull request #366: KYLIN-3707 add configuration for setting isolation-level for sqoop URL: https://github.com/apache/kylin/pull/366 This is an automated message from the Apache Git Service. To

[GitHub] Aaaaaaron commented on issue #365: minor, remove a deprecated configuration("kylin.job.lock") usage in the code.

2018-11-28 Thread GitBox
Aaron commented on issue #365: minor, remove a deprecated configuration("kylin.job.lock") usage in the code. URL: https://github.com/apache/kylin/pull/365#issuecomment-442397780 Thanks @shaofengshi , I'v changed the commit message.

[GitHub] Aaaaaaron edited a comment on issue #365: minor, remove a deprecated configuration("kylin.job.lock") usage in the code.

2018-11-28 Thread GitBox
Aaron edited a comment on issue #365: minor, remove a deprecated configuration("kylin.job.lock") usage in the code. URL: https://github.com/apache/kylin/pull/365#issuecomment-442397780 Thanks, @shaofengshi , I'll changed the commit message.

[GitHub] shaofengshi closed pull request #365: minor, remove a deprecated configuration("kylin.job.lock") usage in the code.

2018-11-28 Thread GitBox
shaofengshi closed pull request #365: minor, remove a deprecated configuration("kylin.job.lock") usage in the code. URL: https://github.com/apache/kylin/pull/365 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake

[GitHub] coveralls commented on issue #365: KYLIN-2578, clean deprecated config("kylin.job.lock") usage in the code.

2018-11-27 Thread GitBox
coveralls commented on issue #365: KYLIN-2578, clean deprecated config("kylin.job.lock") usage in the code. URL: https://github.com/apache/kylin/pull/365#issuecomment-442347902 ## Pull Request Test Coverage Report for [Build 3898](https://coveralls.io/builds/20330244) * **0** of

[GitHub] codecov-io edited a comment on issue #365: minor, remove a deprecated configuration("kylin.job.lock") usage in the code.

2018-11-28 Thread GitBox
codecov-io edited a comment on issue #365: minor, remove a deprecated configuration("kylin.job.lock") usage in the code. URL: https://github.com/apache/kylin/pull/365#issuecomment-442347708 # [Codecov](https://codecov.io/gh/apache/kylin/pull/365?src=pr=h1) Report > :exclamation: No

[GitHub] asfgit commented on issue #367: KYLIN-3671 Improve ResourceTool and JDBCResourceStore's performance

2018-11-28 Thread GitBox
asfgit commented on issue #367: KYLIN-3671 Improve ResourceTool and JDBCResourceStore's performance URL: https://github.com/apache/kylin/pull/367#issuecomment-442712684 Can one of the admins verify this patch? This is an

[GitHub] caolijun1166 opened a new pull request #367: KYLIN-3671 Improve ResourceTool and JDBCResourceStore's performance

2018-11-28 Thread GitBox
caolijun1166 opened a new pull request #367: KYLIN-3671 Improve ResourceTool and JDBCResourceStore's performance URL: https://github.com/apache/kylin/pull/367 This is an automated message from the Apache Git Service. To

[GitHub] GinaZhai opened a new pull request #369: Add the logo of the company that use Kylin

2018-11-30 Thread GitBox
GinaZhai opened a new pull request #369: Add the logo of the company that use Kylin URL: https://github.com/apache/kylin/pull/369 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] coveralls commented on issue #367: KYLIN-3671 Improve ResourceTool and JDBCResourceStore's performance

2018-11-28 Thread GitBox
coveralls commented on issue #367: KYLIN-3671 Improve ResourceTool and JDBCResourceStore's performance URL: https://github.com/apache/kylin/pull/367#issuecomment-442716441 ## Pull Request Test Coverage Report for [Build 3902](https://coveralls.io/builds/20352450) * **266** of

[GitHub] codecov-io commented on issue #367: KYLIN-3671 Improve ResourceTool and JDBCResourceStore's performance

2018-11-28 Thread GitBox
codecov-io commented on issue #367: KYLIN-3671 Improve ResourceTool and JDBCResourceStore's performance URL: https://github.com/apache/kylin/pull/367#issuecomment-442716574 # [Codecov](https://codecov.io/gh/apache/kylin/pull/367?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #370: minor, clean deprecated configuration "kylin.job.controller.lock" in kylin-backward-compatibility.properties

2018-11-30 Thread GitBox
codecov-io commented on issue #370: minor, clean deprecated configuration "kylin.job.controller.lock" in kylin-backward-compatibility.properties URL: https://github.com/apache/kylin/pull/370#issuecomment-443405186 # [Codecov](https://codecov.io/gh/apache/kylin/pull/370?src=pr=h1) Report

[GitHub] coveralls commented on issue #370: minor, clean deprecated configuration "kylin.job.controller.lock" in kylin-backward-compatibility.properties

2018-11-30 Thread GitBox
coveralls commented on issue #370: minor, clean deprecated configuration "kylin.job.controller.lock" in kylin-backward-compatibility.properties URL: https://github.com/apache/kylin/pull/370#issuecomment-443405125 ## Pull Request Test Coverage Report for [Build

[GitHub] Aaaaaaron opened a new pull request #370: minor, clean deprecated configuration "kylin.job.controller.lock" in kylin-backward-compatibility.properties

2018-11-30 Thread GitBox
Aaron opened a new pull request #370: minor, clean deprecated configuration "kylin.job.controller.lock" in kylin-backward-compatibility.properties URL: https://github.com/apache/kylin/pull/370 Hi @shaofengshi , the previous commit don't clean this deprecated configuration completely.

[GitHub] asfgit commented on issue #370: minor, clean deprecated configuration "kylin.job.controller.lock" in kylin-backward-compatibility.properties

2018-11-30 Thread GitBox
asfgit commented on issue #370: minor, clean deprecated configuration "kylin.job.controller.lock" in kylin-backward-compatibility.properties URL: https://github.com/apache/kylin/pull/370#issuecomment-443404013 Can one of the admins verify this patch?

[GitHub] codecov-io edited a comment on issue #374: KYLIN-3597 Improve code smell

2018-12-07 Thread GitBox
codecov-io edited a comment on issue #374: KYLIN-3597 Improve code smell URL: https://github.com/apache/kylin/pull/374#issuecomment-445096812 # [Codecov](https://codecov.io/gh/apache/kylin/pull/374?src=pr=h1) Report > Merging

[GitHub] codecov-io edited a comment on issue #374: KYLIN-3597 Improve code smell

2018-12-07 Thread GitBox
codecov-io edited a comment on issue #374: KYLIN-3597 Improve code smell URL: https://github.com/apache/kylin/pull/374#issuecomment-445096812 # [Codecov](https://codecov.io/gh/apache/kylin/pull/374?src=pr=h1) Report > Merging

[GitHub] coveralls commented on issue #372: KYLIN-1111 Ignore unsupported hive column types when sync hive table

2018-12-07 Thread GitBox
coveralls commented on issue #372: KYLIN- Ignore unsupported hive column types when sync hive table URL: https://github.com/apache/kylin/pull/372#issuecomment-445424674 ## Pull Request Test Coverage Report for [Build 3912](https://coveralls.io/builds/20473062) * **5** of **15**

[GitHub] hit-lacus closed pull request #374: KYLIN-3597 Improve code smell

2018-12-07 Thread GitBox
hit-lacus closed pull request #374: KYLIN-3597 Improve code smell URL: https://github.com/apache/kylin/pull/374 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request

[GitHub] coveralls commented on issue #374: KYLIN-3597 Improve code smell

2018-12-07 Thread GitBox
coveralls commented on issue #374: KYLIN-3597 Improve code smell URL: https://github.com/apache/kylin/pull/374#issuecomment-445429198 ## Pull Request Test Coverage Report for [Build 3922](https://coveralls.io/builds/20503129) * **9** of **65** **(13.85%)** changed or added

[GitHub] coveralls edited a comment on issue #367: KYLIN-3671 Improve ResourceTool and JDBCResourceStore's performance

2018-12-07 Thread GitBox
coveralls edited a comment on issue #367: KYLIN-3671 Improve ResourceTool and JDBCResourceStore's performance URL: https://github.com/apache/kylin/pull/367#issuecomment-442716441 ## Pull Request Test Coverage Report for [Build 3917](https://coveralls.io/builds/20501631) * **266**

[GitHub] coveralls edited a comment on issue #374: KYLIN-3597 Improve code smell

2018-12-07 Thread GitBox
coveralls edited a comment on issue #374: KYLIN-3597 Improve code smell URL: https://github.com/apache/kylin/pull/374#issuecomment-445429198 ## Pull Request Test Coverage Report for [Build 3921](https://coveralls.io/builds/20502981) * **9** of **65** **(13.85%)** changed or added

[GitHub] coveralls edited a comment on issue #374: KYLIN-3597 Improve code smell

2018-12-07 Thread GitBox
coveralls edited a comment on issue #374: KYLIN-3597 Improve code smell URL: https://github.com/apache/kylin/pull/374#issuecomment-445429198 ## Pull Request Test Coverage Report for [Build 3926](https://coveralls.io/builds/20509512) * **12** of **76** **(15.79%)** changed or

[GitHub] coveralls edited a comment on issue #374: KYLIN-3597 Improve code smell

2018-12-07 Thread GitBox
coveralls edited a comment on issue #374: KYLIN-3597 Improve code smell URL: https://github.com/apache/kylin/pull/374#issuecomment-445429198 ## Pull Request Test Coverage Report for [Build 3927](https://coveralls.io/builds/20514049) * **12** of **76** **(15.79%)** changed or

[GitHub] coveralls edited a comment on issue #367: KYLIN-3671 Improve ResourceTool and JDBCResourceStore's performance

2018-12-07 Thread GitBox
coveralls edited a comment on issue #367: KYLIN-3671 Improve ResourceTool and JDBCResourceStore's performance URL: https://github.com/apache/kylin/pull/367#issuecomment-442716441 ## Pull Request Test Coverage Report for [Build 3916](https://coveralls.io/builds/20489104) * **266**

[GitHub] coveralls commented on issue #373: KYLIN-3406 Ignore execute output file lose

2018-12-07 Thread GitBox
coveralls commented on issue #373: KYLIN-3406 Ignore execute output file lose URL: https://github.com/apache/kylin/pull/373#issuecomment-445420928 ## Pull Request Test Coverage Report for [Build 3914](https://coveralls.io/builds/20480546) * **16** of **45** **(35.56%)** changed

[GitHub] coveralls edited a comment on issue #367: KYLIN-3671 Improve ResourceTool and JDBCResourceStore's performance

2018-12-07 Thread GitBox
coveralls edited a comment on issue #367: KYLIN-3671 Improve ResourceTool and JDBCResourceStore's performance URL: https://github.com/apache/kylin/pull/367#issuecomment-442716441 ## Pull Request Test Coverage Report for [Build 3918](https://coveralls.io/builds/20501661) * **267**

[GitHub] coveralls edited a comment on issue #374: KYLIN-3597 Improve code smell

2018-12-07 Thread GitBox
coveralls edited a comment on issue #374: KYLIN-3597 Improve code smell URL: https://github.com/apache/kylin/pull/374#issuecomment-445429198 ## Pull Request Test Coverage Report for [Build 3919](https://coveralls.io/builds/20502519) * **9** of **61** **(14.75%)** changed or added

[GitHub] coveralls edited a comment on issue #374: KYLIN-3597 Improve code smell

2018-12-07 Thread GitBox
coveralls edited a comment on issue #374: KYLIN-3597 Improve code smell URL: https://github.com/apache/kylin/pull/374#issuecomment-445429198 ## Pull Request Test Coverage Report for [Build 3923](https://coveralls.io/builds/20504200) * **9** of **71** **(12.68%)** changed or added

[GitHub] coveralls edited a comment on issue #374: KYLIN-3597 Improve code smell

2018-12-07 Thread GitBox
coveralls edited a comment on issue #374: KYLIN-3597 Improve code smell URL: https://github.com/apache/kylin/pull/374#issuecomment-445429198 ## Pull Request Test Coverage Report for [Build 3924](https://coveralls.io/builds/20504806) * **12** of **76** **(15.79%)** changed or

[GitHub] shaofengshi closed pull request #375: Issue 3597 fix sonar issues

2018-12-08 Thread GitBox
shaofengshi closed pull request #375: Issue 3597 fix sonar issues URL: https://github.com/apache/kylin/pull/375 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request

[GitHub] shaofengshi closed pull request #369: Add the logo of the company that use Kylin

2018-12-03 Thread GitBox
shaofengshi closed pull request #369: Add the logo of the company that use Kylin URL: https://github.com/apache/kylin/pull/369 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] hit-lacus opened a new pull request #373: KYLIN-3406 Ignore execute output file lose

2018-12-05 Thread GitBox
hit-lacus opened a new pull request #373: KYLIN-3406 Ignore execute output file lose URL: https://github.com/apache/kylin/pull/373 ## Root Cause When any single file of Kylin's metadata miss in HDFS, the "Monitor" Page will failed to display all job info and kylin process will throw

[GitHub] asfgit commented on issue #373: KYLIN-3406 Ignore execute output file lose

2018-12-05 Thread GitBox
asfgit commented on issue #373: KYLIN-3406 Ignore execute output file lose URL: https://github.com/apache/kylin/pull/373#issuecomment-444721288 Can one of the admins verify this patch? This is an automated message from the

[GitHub] hit-lacus commented on issue #373: KYLIN-3406 Ignore execute output file lose

2018-12-05 Thread GitBox
hit-lacus commented on issue #373: KYLIN-3406 Ignore execute output file lose URL: https://github.com/apache/kylin/pull/373#issuecomment-444728036 Local CI pass. This is an automated message from the Apache Git Service. To

[GitHub] codecov-io commented on issue #373: KYLIN-3406 Ignore execute output file lose

2018-12-05 Thread GitBox
codecov-io commented on issue #373: KYLIN-3406 Ignore execute output file lose URL: https://github.com/apache/kylin/pull/373#issuecomment-444725970 # [Codecov](https://codecov.io/gh/apache/kylin/pull/373?src=pr=h1) Report > Merging

[GitHub] shaofengshi commented on issue #372: KYLIN-1111 Ignore unsupported hive column types when sync hive table

2018-12-06 Thread GitBox
shaofengshi commented on issue #372: KYLIN- Ignore unsupported hive column types when sync hive table URL: https://github.com/apache/kylin/pull/372#issuecomment-444803812 Thanks Bin! Merged into the master branch! This

[GitHub] shaofengshi closed pull request #372: KYLIN-1111 Ignore unsupported hive column types when sync hive table

2018-12-06 Thread GitBox
shaofengshi closed pull request #372: KYLIN- Ignore unsupported hive column types when sync hive table URL: https://github.com/apache/kylin/pull/372 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] shaofengshi commented on issue #370: minor, clean deprecated configuration "kylin.job.controller.lock" in kylin-backward-compatibility.properties

2018-12-06 Thread GitBox
shaofengshi commented on issue #370: minor, clean deprecated configuration "kylin.job.controller.lock" in kylin-backward-compatibility.properties URL: https://github.com/apache/kylin/pull/370#issuecomment-444824316 LGTM, thank you Jiatao!

[GitHub] shaofengshi closed pull request #370: minor, clean deprecated configuration "kylin.job.controller.lock" in kylin-backward-compatibility.properties

2018-12-06 Thread GitBox
shaofengshi closed pull request #370: minor, clean deprecated configuration "kylin.job.controller.lock" in kylin-backward-compatibility.properties URL: https://github.com/apache/kylin/pull/370 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is

[GitHub] shaofengshi commented on a change in pull request #359: KYLIN-3628 The wrong result when a query with one lookup table

2018-12-06 Thread GitBox
shaofengshi commented on a change in pull request #359: KYLIN-3628 The wrong result when a query with one lookup table URL: https://github.com/apache/kylin/pull/359#discussion_r239673151 ## File path: core-cube/src/main/java/org/apache/kylin/cube/CubeInstance.java ## @@

[GitHub] hit-lacus opened a new pull request #374: KYLIN-3597 Improve code smell

2018-12-06 Thread GitBox
hit-lacus opened a new pull request #374: KYLIN-3597 Improve code smell URL: https://github.com/apache/kylin/pull/374 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] shaofengshi commented on a change in pull request #359: KYLIN-3628 The wrong result when a query with one lookup table

2018-12-06 Thread GitBox
shaofengshi commented on a change in pull request #359: KYLIN-3628 The wrong result when a query with one lookup table URL: https://github.com/apache/kylin/pull/359#discussion_r239672931 ## File path: core-cube/src/main/java/org/apache/kylin/cube/CubeInstance.java ## @@

[GitHub] shaofengshi commented on a change in pull request #359: KYLIN-3628 The wrong result when a query with one lookup table

2018-12-06 Thread GitBox
shaofengshi commented on a change in pull request #359: KYLIN-3628 The wrong result when a query with one lookup table URL: https://github.com/apache/kylin/pull/359#discussion_r239672844 ## File path: core-cube/src/main/java/org/apache/kylin/cube/CubeInstance.java ## @@

[GitHub] asfgit commented on issue #374: KYLIN-3597 Improve code smell

2018-12-06 Thread GitBox
asfgit commented on issue #374: KYLIN-3597 Improve code smell URL: https://github.com/apache/kylin/pull/374#issuecomment-445092041 Can one of the admins verify this patch? This is an automated message from the Apache Git

[GitHub] shaofengshi commented on a change in pull request #359: KYLIN-3628 The wrong result when a query with one lookup table

2018-12-06 Thread GitBox
shaofengshi commented on a change in pull request #359: KYLIN-3628 The wrong result when a query with one lookup table URL: https://github.com/apache/kylin/pull/359#discussion_r239673548 ## File path: core-cube/src/main/java/org/apache/kylin/cube/CubeInstance.java ## @@

[GitHub] codecov-io commented on issue #374: KYLIN-3597 Improve code smell

2018-12-06 Thread GitBox
codecov-io commented on issue #374: KYLIN-3597 Improve code smell URL: https://github.com/apache/kylin/pull/374#issuecomment-445096812 # [Codecov](https://codecov.io/gh/apache/kylin/pull/374?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@2979f40`).

[GitHub] codecov-io edited a comment on issue #367: KYLIN-3671 Improve ResourceTool and JDBCResourceStore's performance

2018-12-06 Thread GitBox
codecov-io edited a comment on issue #367: KYLIN-3671 Improve ResourceTool and JDBCResourceStore's performance URL: https://github.com/apache/kylin/pull/367#issuecomment-442716574 # [Codecov](https://codecov.io/gh/apache/kylin/pull/367?src=pr=h1) Report > :exclamation: No coverage

[GitHub] hit-lacus commented on issue #374: KYLIN-3597 Improve code smell

2018-12-06 Thread GitBox
hit-lacus commented on issue #374: KYLIN-3597 Improve code smell URL: https://github.com/apache/kylin/pull/374#issuecomment-445123989 CI test is running. This is an automated message from the Apache Git Service. To respond to

[GitHub] codecov-io edited a comment on issue #374: KYLIN-3597 Improve code smell

2018-12-06 Thread GitBox
codecov-io edited a comment on issue #374: KYLIN-3597 Improve code smell URL: https://github.com/apache/kylin/pull/374#issuecomment-445096812 # [Codecov](https://codecov.io/gh/apache/kylin/pull/374?src=pr=h1) Report > Merging

[GitHub] codecov-io edited a comment on issue #374: KYLIN-3597 Improve code smell

2018-12-06 Thread GitBox
codecov-io edited a comment on issue #374: KYLIN-3597 Improve code smell URL: https://github.com/apache/kylin/pull/374#issuecomment-445096812 # [Codecov](https://codecov.io/gh/apache/kylin/pull/374?src=pr=h1) Report > Merging

[GitHub] whuwb opened a new pull request #375: Issue 3597 fix sonar issues

2018-12-07 Thread GitBox
whuwb opened a new pull request #375: Issue 3597 fix sonar issues URL: https://github.com/apache/kylin/pull/375 Fix 4 issues IT : [INFO] Apache Kylin ... SUCCESS [ 8.032 s] [INFO] Apache Kylin - Core Common .

[GitHub] asfgit commented on issue #375: Issue 3597 fix sonar issues

2018-12-07 Thread GitBox
asfgit commented on issue #375: Issue 3597 fix sonar issues URL: https://github.com/apache/kylin/pull/375#issuecomment-445158933 Can one of the admins verify this patch? This is an automated message from the Apache Git

[GitHub] asfgit commented on issue #377: Kylin-3680, KYLIN-3710

2018-12-09 Thread GitBox
asfgit commented on issue #377: Kylin-3680, KYLIN-3710 URL: https://github.com/apache/kylin/pull/377#issuecomment-445718303 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To

[GitHub] Wayne1c opened a new pull request #377: Kylin-3680, KYLIN-3710

2018-12-09 Thread GitBox
Wayne1c opened a new pull request #377: Kylin-3680, KYLIN-3710 URL: https://github.com/apache/kylin/pull/377 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use

[GitHub] codecov-io commented on issue #377: Kylin-3680, KYLIN-3710

2018-12-10 Thread GitBox
codecov-io commented on issue #377: Kylin-3680, KYLIN-3710 URL: https://github.com/apache/kylin/pull/377#issuecomment-445725733 # [Codecov](https://codecov.io/gh/apache/kylin/pull/377?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@2de2b9f`). [Click

[GitHub] shaofengshi commented on issue #373: KYLIN-3406 Ignore execute output file lose

2018-12-10 Thread GitBox
shaofengshi commented on issue #373: KYLIN-3406 Ignore execute output file lose URL: https://github.com/apache/kylin/pull/373#issuecomment-445747514 Xiaoxiang, this PR has the conflict with master now (after merging the changes in resource store). Could you please rebase it with master?

[GitHub] hit-lacus commented on issue #373: KYLIN-3406 Ignore execute output file lose

2018-12-10 Thread GitBox
hit-lacus commented on issue #373: KYLIN-3406 Ignore execute output file lose URL: https://github.com/apache/kylin/pull/373#issuecomment-445748419 @shaofengshi OK, I knew it. This is an automated message from the Apache Git

[GitHub] hit-lacus opened a new pull request #378: KYLIN-3597 Improve code smell

2018-12-10 Thread GitBox
hit-lacus opened a new pull request #378: KYLIN-3597 Improve code smell URL: https://github.com/apache/kylin/pull/378 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] hit-lacus commented on issue #378: KYLIN-3597 Improve code smell

2018-12-10 Thread GitBox
hit-lacus commented on issue #378: KYLIN-3597 Improve code smell URL: https://github.com/apache/kylin/pull/378#issuecomment-445750880 Local CI test pass. This is an automated message from the Apache Git Service. To respond to

[GitHub] asfgit commented on issue #378: KYLIN-3597 Improve code smell

2018-12-10 Thread GitBox
asfgit commented on issue #378: KYLIN-3597 Improve code smell URL: https://github.com/apache/kylin/pull/378#issuecomment-445750812 Can one of the admins verify this patch? This is an automated message from the Apache Git

[GitHub] codecov-io commented on issue #378: KYLIN-3597 Improve code smell

2018-12-10 Thread GitBox
codecov-io commented on issue #378: KYLIN-3597 Improve code smell URL: https://github.com/apache/kylin/pull/378#issuecomment-445759183 # [Codecov](https://codecov.io/gh/apache/kylin/pull/378?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@684f21c`).

[GitHub] asfgit commented on issue #379: KYLIN-3597 fix sonar issues

2018-12-10 Thread GitBox
asfgit commented on issue #379: KYLIN-3597 fix sonar issues URL: https://github.com/apache/kylin/pull/379#issuecomment-445794610 Can one of the admins verify this patch? This is an automated message from the Apache Git

[GitHub] whuwb opened a new pull request #379: KYLIN-3597 fix sonar issues

2018-12-10 Thread GitBox
whuwb opened a new pull request #379: KYLIN-3597 fix sonar issues URL: https://github.com/apache/kylin/pull/379 [INFO] [INFO] Reactor Summary for Apache Kylin 2.6.0-SNAPSHOT: [INFO] [INFO] Apache Kylin

[GitHub] codecov-io commented on issue #379: KYLIN-3597 fix sonar issues

2018-12-10 Thread GitBox
codecov-io commented on issue #379: KYLIN-3597 fix sonar issues URL: https://github.com/apache/kylin/pull/379#issuecomment-445802919 # [Codecov](https://codecov.io/gh/apache/kylin/pull/379?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@684f21c`).

[GitHub] asfgit commented on issue #380: KYLIN-3416 Group by with expression can not aggregate exactly

2018-12-10 Thread GitBox
asfgit commented on issue #380: KYLIN-3416 Group by with expression can not aggregate exactly URL: https://github.com/apache/kylin/pull/380#issuecomment-445805496 Can one of the admins verify this patch? This is an automated

[GitHub] Wayne1c opened a new pull request #380: KYLIN-3416 Group by with expression can not aggregate exactly

2018-12-10 Thread GitBox
Wayne1c opened a new pull request #380: KYLIN-3416 Group by with expression can not aggregate exactly URL: https://github.com/apache/kylin/pull/380 This is an automated message from the Apache Git Service. To respond to the

[GitHub] codecov-io commented on issue #380: KYLIN-3416 Group by with expression can not aggregate exactly

2018-12-10 Thread GitBox
codecov-io commented on issue #380: KYLIN-3416 Group by with expression can not aggregate exactly URL: https://github.com/apache/kylin/pull/380#issuecomment-445814135 # [Codecov](https://codecov.io/gh/apache/kylin/pull/380?src=pr=h1) Report > :exclamation: No coverage uploaded for pull

[GitHub] shaofengshi closed pull request #379: KYLIN-3597 fix sonar issues

2018-12-10 Thread GitBox
shaofengshi closed pull request #379: KYLIN-3597 fix sonar issues URL: https://github.com/apache/kylin/pull/379 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request

[GitHub] walhl opened a new pull request #381: ProjectL2Cache don't be invalidated when adding override config in cu…

2018-12-10 Thread GitBox
walhl opened a new pull request #381: ProjectL2Cache don't be invalidated when adding override config in cu… URL: https://github.com/apache/kylin/pull/381 …be level This is an automated message from the Apache Git Service.

[GitHub] asfgit commented on issue #381: ProjectL2Cache don't be invalidated when adding override config in cu…

2018-12-10 Thread GitBox
asfgit commented on issue #381: ProjectL2Cache don't be invalidated when adding override config in cu… URL: https://github.com/apache/kylin/pull/381#issuecomment-445858219 Can one of the admins verify this patch? This is an

[GitHub] codecov-io commented on issue #381: ProjectL2Cache don't be invalidated when adding override config in cu…

2018-12-10 Thread GitBox
codecov-io commented on issue #381: ProjectL2Cache don't be invalidated when adding override config in cu… URL: https://github.com/apache/kylin/pull/381#issuecomment-445868863 # [Codecov](https://codecov.io/gh/apache/kylin/pull/381?src=pr=h1) Report > :exclamation: No coverage uploaded

[GitHub] asfgit commented on issue #368: KYLIN-3187 Forbid calls to JDK APIs that use the default locale

2018-11-30 Thread GitBox
asfgit commented on issue #368: KYLIN-3187 Forbid calls to JDK APIs that use the default locale URL: https://github.com/apache/kylin/pull/368#issuecomment-443161048 Can one of the admins verify this patch? This is an

<    1   2   3   4   5   6   7   8   9   10   >