[GitHub] [kylin] guangxuCheng commented on a change in pull request #1225: KYLIN-4511 Support project admin user to calculate column cardinality…
guangxuCheng commented on a change in pull request #1225: URL: https://github.com/apache/kylin/pull/1225#discussion_r429333754 ## File path: webapp/app/js/controllers/sourceMeta.js ## @@ -131,6 +131,39 @@ KylinApp }); }; +$scope.calCardinality = function (tableName) { + SweetAlert.swal({ +title: "", +text: "Are you sure to recalculate column cardinality?", +showCancelButton: true, +confirmButtonColor: '#DD6B55', +confirmButtonText: "Yes", +cancelButtonText: "No", +closeOnConfirm: true + }, function (isConfirm) { +if (isConfirm) { + if (!$scope.projectModel.selectedProject) { +SweetAlert.swal('', 'Please choose your project first!.', 'info'); +return; + } + loadingRequest.show(); + TableService.genCardinality({tableName: tableName, pro: $scope.projectModel.selectedProject}, {}, function () { +loadingRequest.hide(); +MessageBox.successNotify('Cardinality job was calculated successfully. Please wait a moment...'); Review comment: done This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] guangxuCheng commented on a change in pull request #1225: KYLIN-4511 Support project admin user to calculate column cardinality…
guangxuCheng commented on a change in pull request #1225: URL: https://github.com/apache/kylin/pull/1225#discussion_r429331410 ## File path: webapp/app/js/controllers/sourceMeta.js ## @@ -131,6 +131,39 @@ KylinApp }); }; +$scope.calCardinality = function (tableName) { + SweetAlert.swal({ +title: "", +text: "Are you sure to recalculate column cardinality?", +showCancelButton: true, +confirmButtonColor: '#DD6B55', +confirmButtonText: "Yes", +cancelButtonText: "No", +closeOnConfirm: true + }, function (isConfirm) { +if (isConfirm) { + if (!$scope.projectModel.selectedProject) { +SweetAlert.swal('', 'Please choose your project first!.', 'info'); Review comment: OK, 'Please choose your project first!.' is also used in the other two places. I will deal with them together This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org