[jira] [Commented] (KYLIN-3025) kylin odbc error : {fn CONVERT} for bigint type in tableau 10.4
[ https://issues.apache.org/jira/browse/KYLIN-3025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16529414#comment-16529414 ] ASF subversion and git services commented on KYLIN-3025: Commit da93c5e31c5cbb378d8cf366ccc8270c908e8d33 in kylin's branch refs/heads/2.4.x from [~Wayne0101] [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=da93c5e ] KYLIN-3025 KYLIN-3025 fix error: {fn CONVERT} for bigint type in tableau 10.4 minor, add UT > kylin odbc error : {fn CONVERT} for bigint type in tableau 10.4 > --- > > Key: KYLIN-3025 > URL: https://issues.apache.org/jira/browse/KYLIN-3025 > Project: Kylin > Issue Type: Bug > Components: Driver - ODBC >Affects Versions: v2.1.0 > Environment: Windows 10;kylin v2.2.0;tableau desktop 10.4;kylin odbc > v2.1.0 >Reporter: Hokyung Song >Assignee: Chao Long >Priority: Major > Fix For: v2.4.1, v2.5.0 > > > In Tableau Desktop version 9.3, also it works very well. > but..when I use measure field (bigint type of data) in Tableau Desktop > version 10.4, it occured query error. (decimal type field works well.) > I guess.. "{fn CONVERT}" function couldn't parsed. please support tableau > 10.4 :) > Detailed query example from tableau: > {code} > SELECT "MOMENT"."P_DT" AS "P_DT", > SUM({fn CONVERT("MOMENT"."ACTIONCOUNT", SQL_BIGINT)}) AS > "sum_ACTIONCOUNT_ok" > FROM "TEST"."MOMENT" "MOMENT" > GROUP BY "MOMENT"."P_DT" > {code} > > environment > > * kylin server : v2.2.0 > * kylin odbc (for windows client) : v2.1.0 > * tableau desktop : 10.4 > * client os : windows 10 (64bit) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3025) kylin odbc error : {fn CONVERT} for bigint type in tableau 10.4
[ https://issues.apache.org/jira/browse/KYLIN-3025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16529415#comment-16529415 ] ASF subversion and git services commented on KYLIN-3025: Commit da93c5e31c5cbb378d8cf366ccc8270c908e8d33 in kylin's branch refs/heads/2.4.x from [~Wayne0101] [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=da93c5e ] KYLIN-3025 KYLIN-3025 fix error: {fn CONVERT} for bigint type in tableau 10.4 minor, add UT > kylin odbc error : {fn CONVERT} for bigint type in tableau 10.4 > --- > > Key: KYLIN-3025 > URL: https://issues.apache.org/jira/browse/KYLIN-3025 > Project: Kylin > Issue Type: Bug > Components: Driver - ODBC >Affects Versions: v2.1.0 > Environment: Windows 10;kylin v2.2.0;tableau desktop 10.4;kylin odbc > v2.1.0 >Reporter: Hokyung Song >Assignee: Chao Long >Priority: Major > Fix For: v2.4.1, v2.5.0 > > > In Tableau Desktop version 9.3, also it works very well. > but..when I use measure field (bigint type of data) in Tableau Desktop > version 10.4, it occured query error. (decimal type field works well.) > I guess.. "{fn CONVERT}" function couldn't parsed. please support tableau > 10.4 :) > Detailed query example from tableau: > {code} > SELECT "MOMENT"."P_DT" AS "P_DT", > SUM({fn CONVERT("MOMENT"."ACTIONCOUNT", SQL_BIGINT)}) AS > "sum_ACTIONCOUNT_ok" > FROM "TEST"."MOMENT" "MOMENT" > GROUP BY "MOMENT"."P_DT" > {code} > > environment > > * kylin server : v2.2.0 > * kylin odbc (for windows client) : v2.1.0 > * tableau desktop : 10.4 > * client os : windows 10 (64bit) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3025) kylin odbc error : {fn CONVERT} for bigint type in tableau 10.4
[ https://issues.apache.org/jira/browse/KYLIN-3025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524722#comment-16524722 ] ASF GitHub Bot commented on KYLIN-3025: --- shaofengshi closed pull request #158: KYLIN-3025 fix error: {fn CONVERT} for bigint type in tableau 10.4 URL: https://github.com/apache/kylin/pull/158 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/query/src/main/java/org/apache/kylin/query/util/DefaultQueryTransformer.java b/query/src/main/java/org/apache/kylin/query/util/DefaultQueryTransformer.java index f8ab8f24d6..f32e562cb6 100644 --- a/query/src/main/java/org/apache/kylin/query/util/DefaultQueryTransformer.java +++ b/query/src/main/java/org/apache/kylin/query/util/DefaultQueryTransformer.java @@ -49,7 +49,7 @@ + S0 + "([^\\s,]+)" + S0 + "AS" + SM + "DOUBLE" + S0 + "\\)" + S0 + "\\)", Pattern.CASE_INSENSITIVE); private static final Pattern PIN_SUM_OF_FN_CONVERT = Pattern .compile(S0 + "SUM" + S0 + "\\(" + S0 + "\\{\\s*fn" + SM + "convert" + S0 + "\\(" + S0 + "([^\\s,]+)" + S0 -+ "," + S0 + "SQL_DOUBLE" + S0 + "\\)" + S0 + "\\}" + S0 + "\\)", Pattern.CASE_INSENSITIVE); ++ "," + S0 + "(SQL_DOUBLE|SQL_BIGINT)" + S0 + "\\)" + S0 + "\\}" + S0 + "\\)", Pattern.CASE_INSENSITIVE); @Override public String transform(String sql, String project, String defaultSchema) { diff --git a/query/src/test/java/org/apache/kylin/query/util/DefaultQueryTransformerTest.java b/query/src/test/java/org/apache/kylin/query/util/DefaultQueryTransformerTest.java index b6265b3795..a38b887e44 100644 --- a/query/src/test/java/org/apache/kylin/query/util/DefaultQueryTransformerTest.java +++ b/query/src/test/java/org/apache/kylin/query/util/DefaultQueryTransformerTest.java @@ -27,39 +27,43 @@ @Test public void SumOfFnConvertTransform() throws Exception { +SumOfFnConvertTransform("SQL_DOUBLE"); +SumOfFnConvertTransform("SQL_BIGINT"); +} + +private void SumOfFnConvertTransform(String dataType) throws Exception { DefaultQueryTransformer transformer = new DefaultQueryTransformer(); -String fnConvertSumSql = "select sum({fn convert(\"LSTG_SITE_ID\", SQL_DOUBLE)}) from KYLIN_SALES group by LSTG_SITE_ID"; +String fnConvertSumSql = "select sum({fn convert(\"LSTG_SITE_ID\", " + dataType + ")}) from KYLIN_SALES group by LSTG_SITE_ID"; String correctSql = transformer.transform(fnConvertSumSql, "", ""); assertTrue("select sum(\"LSTG_SITE_ID\") from KYLIN_SALES group by LSTG_SITE_ID".equalsIgnoreCase(correctSql)); //test SQL contains blank //Case one blank interval -fnConvertSumSql = "select sum ( { fn convert( \"LSTG_SITE_ID\" , SQL_DOUBLE) } ) from KYLIN_SALES group by LSTG_SITE_ID"; +fnConvertSumSql = "select sum ( { fn convert( \"LSTG_SITE_ID\" , " + dataType + ") } ) from KYLIN_SALES group by LSTG_SITE_ID"; correctSql = transformer.transform(fnConvertSumSql, "", ""); assertTrue("select sum(\"LSTG_SITE_ID\") from KYLIN_SALES group by LSTG_SITE_ID".equalsIgnoreCase(correctSql)); //Case multi blank interval -fnConvertSumSql = "select SUM ( { fn convert( \"LSTG_SITE_ID\" , SQL_DOUBLE ) } ) from KYLIN_SALES group by LSTG_SITE_ID"; +fnConvertSumSql = "select SUM ( { fn convert( \"LSTG_SITE_ID\" , " + dataType + " ) } ) from KYLIN_SALES group by LSTG_SITE_ID"; correctSql = transformer.transform(fnConvertSumSql, "", ""); assertTrue("select sum(\"LSTG_SITE_ID\") from KYLIN_SALES group by LSTG_SITE_ID".equalsIgnoreCase(correctSql)); //Case one or multi blank interval -fnConvertSumSql = "select SUM( { fn convert( \"LSTG_SITE_ID\" , SQL_DOUBLE ) } ) from KYLIN_SALES group by LSTG_SITE_ID"; +fnConvertSumSql = "select SUM( { fn convert( \"LSTG_SITE_ID\" , " + dataType + " ) } ) from KYLIN_SALES group by LSTG_SITE_ID"; correctSql = transformer.transform(fnConvertSumSql, "", ""); assertTrue("select sum(\"LSTG_SITE_ID\") from KYLIN_SALES group by LSTG_SITE_ID".equalsIgnoreCase(correctSql)); //test exception case of "... fnconvert ..." -fnConvertSumSql = "select SUM ({fnconvert(\"LSTG_SITE_ID\", SQL_DOUBLE)}) from KYLIN_SALES group by LSTG_SITE_ID"; +fnConvertSumSql = "select SUM ({fnconvert(\"LSTG_SITE_ID\", " + dataType + ")}) from KYLIN_SALES group by LSTG_SITE_ID"; correctSql = transformer.transform(fnConvertSumSql, "", ""); assertFalse("select sum(\"LSTG_SITE_ID\") from KYLIN_SALES group by
[jira] [Commented] (KYLIN-3025) kylin odbc error : {fn CONVERT} for bigint type in tableau 10.4
[ https://issues.apache.org/jira/browse/KYLIN-3025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524723#comment-16524723 ] ASF subversion and git services commented on KYLIN-3025: Commit 959ba2d53ab1922615dc75df325475d51b410f80 in kylin's branch refs/heads/master from [~Wayne0101] [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=959ba2d ] KYLIN-3025 KYLIN-3025 fix error: {fn CONVERT} for bigint type in tableau 10.4 minor, add UT > kylin odbc error : {fn CONVERT} for bigint type in tableau 10.4 > --- > > Key: KYLIN-3025 > URL: https://issues.apache.org/jira/browse/KYLIN-3025 > Project: Kylin > Issue Type: Bug > Components: Driver - ODBC >Affects Versions: v2.1.0 > Environment: Windows 10;kylin v2.2.0;tableau desktop 10.4;kylin odbc > v2.1.0 >Reporter: Hokyung Song >Assignee: Chao Long >Priority: Major > Fix For: v2.5.0 > > > In Tableau Desktop version 9.3, also it works very well. > but..when I use measure field (bigint type of data) in Tableau Desktop > version 10.4, it occured query error. (decimal type field works well.) > I guess.. "{fn CONVERT}" function couldn't parsed. please support tableau > 10.4 :) > Detailed query example from tableau: > {code} > SELECT "MOMENT"."P_DT" AS "P_DT", > SUM({fn CONVERT("MOMENT"."ACTIONCOUNT", SQL_BIGINT)}) AS > "sum_ACTIONCOUNT_ok" > FROM "TEST"."MOMENT" "MOMENT" > GROUP BY "MOMENT"."P_DT" > {code} > > environment > > * kylin server : v2.2.0 > * kylin odbc (for windows client) : v2.1.0 > * tableau desktop : 10.4 > * client os : windows 10 (64bit) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3025) kylin odbc error : {fn CONVERT} for bigint type in tableau 10.4
[ https://issues.apache.org/jira/browse/KYLIN-3025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524724#comment-16524724 ] ASF subversion and git services commented on KYLIN-3025: Commit 959ba2d53ab1922615dc75df325475d51b410f80 in kylin's branch refs/heads/master from [~Wayne0101] [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=959ba2d ] KYLIN-3025 KYLIN-3025 fix error: {fn CONVERT} for bigint type in tableau 10.4 minor, add UT > kylin odbc error : {fn CONVERT} for bigint type in tableau 10.4 > --- > > Key: KYLIN-3025 > URL: https://issues.apache.org/jira/browse/KYLIN-3025 > Project: Kylin > Issue Type: Bug > Components: Driver - ODBC >Affects Versions: v2.1.0 > Environment: Windows 10;kylin v2.2.0;tableau desktop 10.4;kylin odbc > v2.1.0 >Reporter: Hokyung Song >Assignee: Chao Long >Priority: Major > Fix For: v2.5.0 > > > In Tableau Desktop version 9.3, also it works very well. > but..when I use measure field (bigint type of data) in Tableau Desktop > version 10.4, it occured query error. (decimal type field works well.) > I guess.. "{fn CONVERT}" function couldn't parsed. please support tableau > 10.4 :) > Detailed query example from tableau: > {code} > SELECT "MOMENT"."P_DT" AS "P_DT", > SUM({fn CONVERT("MOMENT"."ACTIONCOUNT", SQL_BIGINT)}) AS > "sum_ACTIONCOUNT_ok" > FROM "TEST"."MOMENT" "MOMENT" > GROUP BY "MOMENT"."P_DT" > {code} > > environment > > * kylin server : v2.2.0 > * kylin odbc (for windows client) : v2.1.0 > * tableau desktop : 10.4 > * client os : windows 10 (64bit) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3025) kylin odbc error : {fn CONVERT} for bigint type in tableau 10.4
[ https://issues.apache.org/jira/browse/KYLIN-3025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524713#comment-16524713 ] ASF GitHub Bot commented on KYLIN-3025: --- codecov-io edited a comment on issue #158: KYLIN-3025 fix error: {fn CONVERT} for bigint type in tableau 10.4 URL: https://github.com/apache/kylin/pull/158#issuecomment-399850733 # [Codecov](https://codecov.io/gh/apache/kylin/pull/158?src=pr=h1) Report > Merging [#158](https://codecov.io/gh/apache/kylin/pull/158?src=pr=desc) into [master](https://codecov.io/gh/apache/kylin/commit/a0595c07ebfcade52f10e9ac134fa3e330fc57da?src=pr=desc) will **increase** coverage by `<.01%`. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/apache/kylin/pull/158/graphs/tree.svg?height=150=pr=JawVgbgsVo=650)](https://codecov.io/gh/apache/kylin/pull/158?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #158 +/- ## + Coverage 22.44% 22.44% +<.01% Complexity 4155 4155 Files 1034 1034 Lines 6217962179 Branches 8907 8907 + Hits 1395713959 +2 + Misses4690246900 -2 Partials 1320 1320 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/158?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ache/kylin/query/util/DefaultQueryTransformer.java](https://codecov.io/gh/apache/kylin/pull/158/diff?src=pr=tree#diff-cXVlcnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3F1ZXJ5L3V0aWwvRGVmYXVsdFF1ZXJ5VHJhbnNmb3JtZXIuamF2YQ==) | `80.76% <ø> (ø)` | `7 <0> (ø)` | :arrow_down: | | [...he/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://codecov.io/gh/apache/kylin/pull/158/diff?src=pr=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGUuamF2YQ==) | `72.97% <0%> (-5.41%)` | `5% <0%> (-1%)` | | | [...lin/dict/lookup/cache/RocksDBLookupTableCache.java](https://codecov.io/gh/apache/kylin/pull/158/diff?src=pr=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGVDYWNoZS5qYXZh) | `76.16% <0%> (-0.52%)` | `27% <0%> (ø)` | | | [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/158/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `70.21% <0%> (+0.91%)` | `7% <0%> (ø)` | :arrow_down: | | [...org/apache/kylin/rest/util/QueryRequestLimits.java](https://codecov.io/gh/apache/kylin/pull/158/diff?src=pr=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvdXRpbC9RdWVyeVJlcXVlc3RMaW1pdHMuamF2YQ==) | `40.47% <0%> (+4.76%)` | `6% <0%> (+1%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/158?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/158?src=pr=footer). Last update [a0595c0...22dad06](https://codecov.io/gh/apache/kylin/pull/158?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > kylin odbc error : {fn CONVERT} for bigint type in tableau 10.4 > --- > > Key: KYLIN-3025 > URL: https://issues.apache.org/jira/browse/KYLIN-3025 > Project: Kylin > Issue Type: Bug > Components: Driver - ODBC >Affects Versions: v2.1.0 > Environment: Windows 10;kylin v2.2.0;tableau desktop 10.4;kylin odbc > v2.1.0 >Reporter: Hokyung Song >Assignee: Chao Long >Priority: Major > Fix For: v2.5.0 > > > In Tableau Desktop version 9.3, also it works very well. > but..when I use measure field (bigint type of data) in Tableau Desktop > version 10.4, it occured query error. (decimal type field works well.) > I guess.. "{fn CONVERT}" function couldn't parsed. please support tableau > 10.4 :) > Detailed query example from tableau: > {code} > SELECT
[jira] [Commented] (KYLIN-3025) kylin odbc error : {fn CONVERT} for bigint type in tableau 10.4
[ https://issues.apache.org/jira/browse/KYLIN-3025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524691#comment-16524691 ] ASF GitHub Bot commented on KYLIN-3025: --- Wayne1c commented on issue #158: KYLIN-3025 fix error: {fn CONVERT} for bigint type in tableau 10.4 URL: https://github.com/apache/kylin/pull/158#issuecomment-400568590 I have added this change into UT. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > kylin odbc error : {fn CONVERT} for bigint type in tableau 10.4 > --- > > Key: KYLIN-3025 > URL: https://issues.apache.org/jira/browse/KYLIN-3025 > Project: Kylin > Issue Type: Bug > Components: Driver - ODBC >Affects Versions: v2.1.0 > Environment: Windows 10;kylin v2.2.0;tableau desktop 10.4;kylin odbc > v2.1.0 >Reporter: Hokyung Song >Assignee: Chao Long >Priority: Major > Fix For: v2.5.0 > > > In Tableau Desktop version 9.3, also it works very well. > but..when I use measure field (bigint type of data) in Tableau Desktop > version 10.4, it occured query error. (decimal type field works well.) > I guess.. "{fn CONVERT}" function couldn't parsed. please support tableau > 10.4 :) > Detailed query example from tableau: > {code} > SELECT "MOMENT"."P_DT" AS "P_DT", > SUM({fn CONVERT("MOMENT"."ACTIONCOUNT", SQL_BIGINT)}) AS > "sum_ACTIONCOUNT_ok" > FROM "TEST"."MOMENT" "MOMENT" > GROUP BY "MOMENT"."P_DT" > {code} > > environment > > * kylin server : v2.2.0 > * kylin odbc (for windows client) : v2.1.0 > * tableau desktop : 10.4 > * client os : windows 10 (64bit) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3025) kylin odbc error : {fn CONVERT} for bigint type in tableau 10.4
[ https://issues.apache.org/jira/browse/KYLIN-3025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16521933#comment-16521933 ] ASF GitHub Bot commented on KYLIN-3025: --- asfgit commented on issue #158: KYLIN-3025 fix error: {fn CONVERT} for bigint type in tableau 10.4 URL: https://github.com/apache/kylin/pull/158#issuecomment-399852166 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > kylin odbc error : {fn CONVERT} for bigint type in tableau 10.4 > --- > > Key: KYLIN-3025 > URL: https://issues.apache.org/jira/browse/KYLIN-3025 > Project: Kylin > Issue Type: Bug > Components: Driver - ODBC >Affects Versions: v2.1.0 > Environment: Windows 10;kylin v2.2.0;tableau desktop 10.4;kylin odbc > v2.1.0 >Reporter: Hokyung Song >Priority: Major > Fix For: v2.5.0 > > > In Tableau Desktop version 9.3, also it works very well. > but..when I use measure field (bigint type of data) in Tableau Desktop > version 10.4, it occured query error. (decimal type field works well.) > I guess.. "{fn CONVERT}" function couldn't parsed. please support tableau > 10.4 :) > Detailed query example from tableau: > {code} > SELECT "MOMENT"."P_DT" AS "P_DT", > SUM({fn CONVERT("MOMENT"."ACTIONCOUNT", SQL_BIGINT)}) AS > "sum_ACTIONCOUNT_ok" > FROM "TEST"."MOMENT" "MOMENT" > GROUP BY "MOMENT"."P_DT" > {code} > > environment > > * kylin server : v2.2.0 > * kylin odbc (for windows client) : v2.1.0 > * tableau desktop : 10.4 > * client os : windows 10 (64bit) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3025) kylin odbc error : {fn CONVERT} for bigint type in tableau 10.4
[ https://issues.apache.org/jira/browse/KYLIN-3025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16521920#comment-16521920 ] ASF GitHub Bot commented on KYLIN-3025: --- codecov-io commented on issue #158: KYLIN-3025 fix error: {fn CONVERT} for bigint type in tableau 10.4 URL: https://github.com/apache/kylin/pull/158#issuecomment-399850733 # [Codecov](https://codecov.io/gh/apache/kylin/pull/158?src=pr=h1) Report > Merging [#158](https://codecov.io/gh/apache/kylin/pull/158?src=pr=desc) into [master](https://codecov.io/gh/apache/kylin/commit/5a089adcae55a5fb5333f4e8f527ae05cca3e0d7?src=pr=desc) will **increase** coverage by `0.01%`. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/apache/kylin/pull/158/graphs/tree.svg?height=150=650=JawVgbgsVo=pr)](https://codecov.io/gh/apache/kylin/pull/158?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #158 +/- ## + Coverage 22.44% 22.45% +0.01% - Complexity 4153 4155 +2 Files 1034 1034 Lines 6217962179 Branches 8907 8907 + Hits 1395313961 +8 + Misses4690346899 -4 + Partials 1323 1319 -4 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/158?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ache/kylin/query/util/DefaultQueryTransformer.java](https://codecov.io/gh/apache/kylin/pull/158/diff?src=pr=tree#diff-cXVlcnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3F1ZXJ5L3V0aWwvRGVmYXVsdFF1ZXJ5VHJhbnNmb3JtZXIuamF2YQ==) | `80.76% <ø> (ø)` | `7 <0> (ø)` | :arrow_down: | | [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/158/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `69.6% <0%> (-0.61%)` | `7% <0%> (ø)` | | | [...a/org/apache/kylin/dict/Number2BytesConverter.java](https://codecov.io/gh/apache/kylin/pull/158/diff?src=pr=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L051bWJlcjJCeXRlc0NvbnZlcnRlci5qYXZh) | `82.53% <0%> (+0.79%)` | `18% <0%> (+1%)` | :arrow_up: | | [...g/apache/kylin/metadata/cachesync/Broadcaster.java](https://codecov.io/gh/apache/kylin/pull/158/diff?src=pr=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvY2FjaGVzeW5jL0Jyb2FkY2FzdGVyLmphdmE=) | `52.73% <0%> (+0.99%)` | `22% <0%> (ø)` | :arrow_down: | | [...g/apache/kylin/source/datagen/ColumnGenerator.java](https://codecov.io/gh/apache/kylin/pull/158/diff?src=pr=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc291cmNlL2RhdGFnZW4vQ29sdW1uR2VuZXJhdG9yLmphdmE=) | `72.29% <0%> (+1.35%)` | `8% <0%> (ø)` | :arrow_down: | | [.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/158/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=) | `66.15% <0%> (+2.3%)` | `0% <0%> (ø)` | :arrow_down: | | [...he/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://codecov.io/gh/apache/kylin/pull/158/diff?src=pr=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGUuamF2YQ==) | `78.37% <0%> (+5.4%)` | `6% <0%> (+1%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/158?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/158?src=pr=footer). Last update [5a089ad...050d242](https://codecov.io/gh/apache/kylin/pull/158?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > kylin odbc error : {fn CONVERT} for bigint type in tableau 10.4 > --- > > Key: KYLIN-3025 > URL: https://issues.apache.org/jira/browse/KYLIN-3025 > Project: Kylin > Issue Type: Bug > Components: Driver - ODBC >Affects
[jira] [Commented] (KYLIN-3025) kylin odbc error : {fn CONVERT} for bigint type in tableau 10.4
[ https://issues.apache.org/jira/browse/KYLIN-3025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16521917#comment-16521917 ] ASF GitHub Bot commented on KYLIN-3025: --- coveralls commented on issue #158: KYLIN-3025 fix error: {fn CONVERT} for bigint type in tableau 10.4 URL: https://github.com/apache/kylin/pull/158#issuecomment-399850460 ## Pull Request Test Coverage Report for [Build 3271](https://coveralls.io/builds/17668835) * **0** of **0** changed or added relevant lines in **0** files are covered. * **1** unchanged line in **1** file lost coverage. * Overall coverage increased (+**0.006%**) to **24.577%** --- | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/17668835/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L553) | 1 | 78.12% | | Totals | [![Coverage Status](https://coveralls.io/builds/17668835/badge)](https://coveralls.io/builds/17668835) | | :-- | --: | | Change from base [Build 3270](https://coveralls.io/builds/17665950): | 0.006% | | Covered Lines: | 15282 | | Relevant Lines: | 62179 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > kylin odbc error : {fn CONVERT} for bigint type in tableau 10.4 > --- > > Key: KYLIN-3025 > URL: https://issues.apache.org/jira/browse/KYLIN-3025 > Project: Kylin > Issue Type: Bug > Components: Driver - ODBC >Affects Versions: v2.1.0 > Environment: Windows 10;kylin v2.2.0;tableau desktop 10.4;kylin odbc > v2.1.0 >Reporter: Hokyung Song >Priority: Major > Fix For: v2.5.0 > > > In Tableau Desktop version 9.3, also it works very well. > but..when I use measure field (bigint type of data) in Tableau Desktop > version 10.4, it occured query error. (decimal type field works well.) > I guess.. "{fn CONVERT}" function couldn't parsed. please support tableau > 10.4 :) > Detailed query example from tableau: > {code} > SELECT "MOMENT"."P_DT" AS "P_DT", > SUM({fn CONVERT("MOMENT"."ACTIONCOUNT", SQL_BIGINT)}) AS > "sum_ACTIONCOUNT_ok" > FROM "TEST"."MOMENT" "MOMENT" > GROUP BY "MOMENT"."P_DT" > {code} > > environment > > * kylin server : v2.2.0 > * kylin odbc (for windows client) : v2.1.0 > * tableau desktop : 10.4 > * client os : windows 10 (64bit) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3025) kylin odbc error : {fn CONVERT} for bigint type in tableau 10.4
[ https://issues.apache.org/jira/browse/KYLIN-3025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16521899#comment-16521899 ] ASF GitHub Bot commented on KYLIN-3025: --- Wayne1c opened a new pull request #158: KYLIN-3025 fix error: {fn CONVERT} for bigint type in tableau 10.4 URL: https://github.com/apache/kylin/pull/158 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > kylin odbc error : {fn CONVERT} for bigint type in tableau 10.4 > --- > > Key: KYLIN-3025 > URL: https://issues.apache.org/jira/browse/KYLIN-3025 > Project: Kylin > Issue Type: Bug > Components: Driver - ODBC >Affects Versions: v2.1.0 > Environment: Windows 10;kylin v2.2.0;tableau desktop 10.4;kylin odbc > v2.1.0 >Reporter: Hokyung Song >Priority: Major > Fix For: v2.5.0 > > > In Tableau Desktop version 9.3, also it works very well. > but..when I use measure field (bigint type of data) in Tableau Desktop > version 10.4, it occured query error. (decimal type field works well.) > I guess.. "{fn CONVERT}" function couldn't parsed. please support tableau > 10.4 :) > Detailed query example from tableau: > {code} > SELECT "MOMENT"."P_DT" AS "P_DT", > SUM({fn CONVERT("MOMENT"."ACTIONCOUNT", SQL_BIGINT)}) AS > "sum_ACTIONCOUNT_ok" > FROM "TEST"."MOMENT" "MOMENT" > GROUP BY "MOMENT"."P_DT" > {code} > > environment > > * kylin server : v2.2.0 > * kylin odbc (for windows client) : v2.1.0 > * tableau desktop : 10.4 > * client os : windows 10 (64bit) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3025) kylin odbc error : {fn CONVERT} for bigint type in tableau 10.4
[ https://issues.apache.org/jira/browse/KYLIN-3025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16519487#comment-16519487 ] Shaofeng SHI commented on KYLIN-3025: - Will check it. > kylin odbc error : {fn CONVERT} for bigint type in tableau 10.4 > --- > > Key: KYLIN-3025 > URL: https://issues.apache.org/jira/browse/KYLIN-3025 > Project: Kylin > Issue Type: Bug > Components: Driver - ODBC >Affects Versions: v2.1.0 > Environment: Windows 10;kylin v2.2.0;tableau desktop 10.4;kylin odbc > v2.1.0 >Reporter: Hokyung Song >Priority: Major > > In Tableau Desktop version 9.3, also it works very well. > but..when I use measure field (bigint type of data) in Tableau Desktop > version 10.4, it occured query error. (decimal type field works well.) > I guess.. "{fn CONVERT}" function couldn't parsed. please support tableau > 10.4 :) > Detailed query example from tableau: > {code} > SELECT "MOMENT"."P_DT" AS "P_DT", > SUM({fn CONVERT("MOMENT"."ACTIONCOUNT", SQL_BIGINT)}) AS > "sum_ACTIONCOUNT_ok" > FROM "TEST"."MOMENT" "MOMENT" > GROUP BY "MOMENT"."P_DT" > {code} > > environment > > * kylin server : v2.2.0 > * kylin odbc (for windows client) : v2.1.0 > * tableau desktop : 10.4 > * client os : windows 10 (64bit) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3025) kylin odbc error : {fn CONVERT} for bigint type in tableau 10.4
[ https://issues.apache.org/jira/browse/KYLIN-3025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16511941#comment-16511941 ] Le Anh Vu commented on KYLIN-3025: -- My setup is similar and I also have this issue. When I upgrade my Tableau to 10.5, the problem no longer exist. But I can't upgrade my Tableau Server from 10.4 to 10.5 so my published workbook can't be read. The difference between tableau query in 10.4 and 10.5 is as follows: 10.4: SUM(\{fn CONVERT(1, SQL_BIGINT)}) AS "sum_Number_of_Records_ok" 10.5: SUM(1) AS "sum_Number_of_Records_ok" Can someone look at this bug? > kylin odbc error : {fn CONVERT} for bigint type in tableau 10.4 > --- > > Key: KYLIN-3025 > URL: https://issues.apache.org/jira/browse/KYLIN-3025 > Project: Kylin > Issue Type: Bug > Components: Driver - ODBC >Affects Versions: v2.1.0 > Environment: Windows 10;kylin v2.2.0;tableau desktop 10.4;kylin odbc > v2.1.0 >Reporter: Hokyung Song >Priority: Major > > In Tableau Desktop version 9.3, also it works very well. > but..when I use measure field (bigint type of data) in Tableau Desktop > version 10.4, it occured query error. (decimal type field works well.) > I guess.. "{fn CONVERT}" function couldn't parsed. please support tableau > 10.4 :) > Detailed query example from tableau: > {code} > SELECT "MOMENT"."P_DT" AS "P_DT", > SUM({fn CONVERT("MOMENT"."ACTIONCOUNT", SQL_BIGINT)}) AS > "sum_ACTIONCOUNT_ok" > FROM "TEST"."MOMENT" "MOMENT" > GROUP BY "MOMENT"."P_DT" > {code} > > environment > > * kylin server : v2.2.0 > * kylin odbc (for windows client) : v2.1.0 > * tableau desktop : 10.4 > * client os : windows 10 (64bit) -- This message was sent by Atlassian JIRA (v7.6.3#76005)