[jira] [Commented] (KYLIN-3088) Spell Error of isCubeMatch
[ https://issues.apache.org/jira/browse/KYLIN-3088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287645#comment-16287645 ] Shaofeng SHI commented on KYLIN-3088: - Merged in master branch. Thanks; > Spell Error of isCubeMatch > -- > > Key: KYLIN-3088 > URL: https://issues.apache.org/jira/browse/KYLIN-3088 > Project: Kylin > Issue Type: Bug >Reporter: Yang Hao >Assignee: Yang Hao > Attachments: KYLIN-3088.apache-master.001.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KYLIN-3088) Spell Error of isCubeMatch
[ https://issues.apache.org/jira/browse/KYLIN-3088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287469#comment-16287469 ] Yang Hao commented on KYLIN-3088: - [~Shaofengshi] Sorry, I'll notice that. Thanks for your advice > Spell Error of isCubeMatch > -- > > Key: KYLIN-3088 > URL: https://issues.apache.org/jira/browse/KYLIN-3088 > Project: Kylin > Issue Type: Bug >Reporter: Yang Hao >Assignee: Yang Hao > Attachments: KYLIN-3088.apache-master.001.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KYLIN-3088) Spell Error of isCubeMatch
[ https://issues.apache.org/jira/browse/KYLIN-3088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287257#comment-16287257 ] liyang commented on KYLIN-3088: --- If we have rules about the size of commit, we should mention clearly on the document. http://kylin.apache.org/development/howto_contribute.html Before the rules are clear, I suggest accepting such small patches. What do you think? > Spell Error of isCubeMatch > -- > > Key: KYLIN-3088 > URL: https://issues.apache.org/jira/browse/KYLIN-3088 > Project: Kylin > Issue Type: Bug >Reporter: Yang Hao >Assignee: Yang Hao > Attachments: KYLIN-3088.apache-master.001.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KYLIN-3088) Spell Error of isCubeMatch
[ https://issues.apache.org/jira/browse/KYLIN-3088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16283684#comment-16283684 ] Shaofeng SHI commented on KYLIN-3088: - I have to say, this change is too minor to worth a dedicated JIRA. Please try to consolidate more such changes together, or combine it with other changes. Thanks for the understanding. > Spell Error of isCubeMatch > -- > > Key: KYLIN-3088 > URL: https://issues.apache.org/jira/browse/KYLIN-3088 > Project: Kylin > Issue Type: Bug >Reporter: Yang Hao >Assignee: Yang Hao > Attachments: KYLIN-3088.apache-master.001.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KYLIN-3088) Spell Error of isCubeMatch
[ https://issues.apache.org/jira/browse/KYLIN-3088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16283290#comment-16283290 ] Yang Hao commented on KYLIN-3088: - OK > Spell Error of isCubeMatch > -- > > Key: KYLIN-3088 > URL: https://issues.apache.org/jira/browse/KYLIN-3088 > Project: Kylin > Issue Type: Bug >Reporter: Yang Hao >Assignee: Yang Hao > Attachments: KYLIN-3088.apache-master.001.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KYLIN-3088) Spell Error of isCubeMatch
[ https://issues.apache.org/jira/browse/KYLIN-3088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281926#comment-16281926 ] Billy Liu commented on KYLIN-3088: -- Thanks [~yanghaogn] for the patch. Could you rename the commit message to begin with KYLIN-3088 XXX? And String.equalsIgnoreCase is better way to compare in this case. > Spell Error of isCubeMatch > -- > > Key: KYLIN-3088 > URL: https://issues.apache.org/jira/browse/KYLIN-3088 > Project: Kylin > Issue Type: Bug >Reporter: Yang Hao >Assignee: Yang Hao > Attachments: KYLIN-3088.apache-master.002.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
