[jira] [Commented] (KYLIN-4496) Metric data missing
[ https://issues.apache.org/jira/browse/KYLIN-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17266803#comment-17266803 ] ASF subversion and git services commented on KYLIN-4496: Commit 7431240a7a8d868cbceba25cfb5b0d66c428cb66 in kylin's branch refs/heads/kylin-on-parquet-v2 from tianhui5 [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=7431240 ] KYLIN-4496: Metric data missing (cherry picked from commit 278aababa11fff222327ec6b6f73e659b147b8d7) > Metric data missing > --- > > Key: KYLIN-4496 > URL: https://issues.apache.org/jira/browse/KYLIN-4496 > Project: Kylin > Issue Type: Bug > Components: Metrics >Reporter: tianhui >Assignee: tianhui >Priority: Critical > Fix For: v3.1.0 > > > Metric data in memory is never flushed into file system when kylin closing, > So there is some metric data missing. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4496) Metric data missing
[ https://issues.apache.org/jira/browse/KYLIN-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17115907#comment-17115907 ] ASF subversion and git services commented on KYLIN-4496: Commit 278aababa11fff222327ec6b6f73e659b147b8d7 in kylin's branch refs/heads/master from tianhui5 [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=278aaba ] KYLIN-4496: Metric data missing > Metric data missing > --- > > Key: KYLIN-4496 > URL: https://issues.apache.org/jira/browse/KYLIN-4496 > Project: Kylin > Issue Type: Bug > Components: Metrics >Reporter: tianhui >Assignee: tianhui >Priority: Critical > Fix For: v3.1.0 > > > Metric data in memory is never flushed into file system when kylin closing, > So there is some metric data missing. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4496) Metric data missing
[ https://issues.apache.org/jira/browse/KYLIN-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17115908#comment-17115908 ] ASF GitHub Bot commented on KYLIN-4496: --- nichunen merged pull request #1210: URL: https://github.com/apache/kylin/pull/1210 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Metric data missing > --- > > Key: KYLIN-4496 > URL: https://issues.apache.org/jira/browse/KYLIN-4496 > Project: Kylin > Issue Type: Bug > Components: Metrics >Reporter: tianhui >Assignee: tianhui >Priority: Critical > Fix For: v3.1.0 > > > Metric data in memory is never flushed into file system when kylin closing, > So there is some metric data missing. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4496) Metric data missing
[ https://issues.apache.org/jira/browse/KYLIN-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114088#comment-17114088 ] ASF GitHub Bot commented on KYLIN-4496: --- kyotoYaho commented on pull request #1210: URL: https://github.com/apache/kylin/pull/1210#issuecomment-632720447 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Metric data missing > --- > > Key: KYLIN-4496 > URL: https://issues.apache.org/jira/browse/KYLIN-4496 > Project: Kylin > Issue Type: Bug > Components: Metrics >Reporter: tianhui >Assignee: tianhui >Priority: Critical > Fix For: v3.1.0 > > > Metric data in memory is never flushed into file system when kylin closing, > So there is some metric data missing. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4496) Metric data missing
[ https://issues.apache.org/jira/browse/KYLIN-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114048#comment-17114048 ] Shao Feng Shi commented on KYLIN-4496: -- [~tianhui5] thanks for the reporting! [~nju_yaho] please review. > Metric data missing > --- > > Key: KYLIN-4496 > URL: https://issues.apache.org/jira/browse/KYLIN-4496 > Project: Kylin > Issue Type: Bug > Components: Metrics >Reporter: tianhui >Assignee: tianhui >Priority: Critical > Fix For: v3.1.0 > > > Metric data in memory is never flushed into file system when kylin closing, > So there is some metric data missing. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4496) Metric data missing
[ https://issues.apache.org/jira/browse/KYLIN-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114033#comment-17114033 ] ASF GitHub Bot commented on KYLIN-4496: --- shaofengshi commented on pull request #1210: URL: https://github.com/apache/kylin/pull/1210#issuecomment-632691337 +1 the FSDataOutputStream object should be closed on closing. @kyotoYaho yanghong, please review this as well. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Metric data missing > --- > > Key: KYLIN-4496 > URL: https://issues.apache.org/jira/browse/KYLIN-4496 > Project: Kylin > Issue Type: Bug > Components: Metrics >Reporter: tianhui >Assignee: tianhui >Priority: Critical > Fix For: v3.1.0 > > > Metric data in memory is never flushed into file system when kylin closing, > So there is some metric data missing. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4496) Metric data missing
[ https://issues.apache.org/jira/browse/KYLIN-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17111998#comment-17111998 ] ASF GitHub Bot commented on KYLIN-4496: --- tianhui5 commented on pull request #1210: URL: https://github.com/apache/kylin/pull/1210#issuecomment-631371228 > @hit-lacus xiaoxiang, could you please review this? Hello, am i understand it right? Please tell me if there is any suggestion or question. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Metric data missing > --- > > Key: KYLIN-4496 > URL: https://issues.apache.org/jira/browse/KYLIN-4496 > Project: Kylin > Issue Type: Bug > Components: Metrics >Reporter: tianhui >Priority: Critical > Fix For: v3.1.0 > > > Metric data in memory is never flushed into file system when kylin closing, > So there is some metric data missing. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4496) Metric data missing
[ https://issues.apache.org/jira/browse/KYLIN-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107200#comment-17107200 ] ASF GitHub Bot commented on KYLIN-4496: --- tianhui5 opened a new pull request #1210: URL: https://github.com/apache/kylin/pull/1210 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. bug fix of jira https://issues.apache.org/jira/browse/KYLIN-4496 ## Types of changes What types of changes does your code introduce to Kylin? _Put an `x` in the boxes that apply_ - [x] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation Update (if none of the other choices apply) ## Checklist _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._ - [x] I have create an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail - [ ] Commit messages in my PR start with the related jira ID, like "KYLIN- Make Kylin project open-source" - [ ] Compiling and unit tests pass locally with my changes - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] If this change need a document change, I will prepare another pr against the `document` branch - [ ] Any dependent changes have been merged ## Further comments If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Metric data missing > --- > > Key: KYLIN-4496 > URL: https://issues.apache.org/jira/browse/KYLIN-4496 > Project: Kylin > Issue Type: Bug > Components: Metrics >Reporter: tianhui >Priority: Critical > > Metric data in memory is never flushed into file system when kylin closing, > So there is some metric data missing. -- This message was sent by Atlassian Jira (v8.3.4#803005)
