[GitHub] [kylin] codecov-commenter commented on pull request #1228: KYLIN-4508 Add more unit tests to improve test coverage

Fri, 22 May 2020 01:36:46 -0700 


codecov-commenter commented on pull request #1228:
URL: https://github.com/apache/kylin/pull/1228#issuecomment-632572024


   # [Codecov](https://codecov.io/gh/apache/kylin/pull/1228?src=pr&el=h1) Report
   > Merging 
[#1228](https://codecov.io/gh/apache/kylin/pull/1228?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/kylin/commit/7886a2498178ded085497d6204b4b367f56ce0c8&el=desc)
 will **increase** coverage by `1.10%`.
   > The diff coverage is `56.52%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/kylin/pull/1228/graphs/tree.svg?width=650&height=150&src=pr&token=JawVgbgsVo)](https://codecov.io/gh/apache/kylin/pull/1228?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1228      +/-   ##
   ============================================
   + Coverage     24.85%   25.96%   +1.10%     
   - Complexity     6266     6520     +254     
   ============================================
     Files          1453     1453              
     Lines         89225    89243      +18     
     Branches      12456    12458       +2     
   ============================================
   + Hits          22181    23173     +992     
   + Misses        64869    63810    -1059     
   - Partials       2175     2260      +85     
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/kylin/pull/1228?src=pr&el=tree) | Coverage 
Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...org/apache/kylin/metrics/lib/impl/RecordEvent.java](https://codecov.io/gh/apache/kylin/pull/1228/diff?src=pr&el=tree#diff-Y29yZS1tZXRyaWNzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9tZXRyaWNzL2xpYi9pbXBsL1JlY29yZEV2ZW50LmphdmE=)
 | `72.04% <0.00%> (+72.04%)` | `24.00 <0.00> (+24.00)` | |
   | 
[...pache/kylin/metrics/lib/impl/TimePropertyEnum.java](https://codecov.io/gh/apache/kylin/pull/1228/diff?src=pr&el=tree#diff-Y29yZS1tZXRyaWNzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9tZXRyaWNzL2xpYi9pbXBsL1RpbWVQcm9wZXJ0eUVudW0uamF2YQ==)
 | `73.68% <ø> (+73.68%)` | `4.00 <0.00> (+4.00)` | |
   | 
[...pache/kylin/engine/mr/common/JobInfoConverter.java](https://codecov.io/gh/apache/kylin/pull/1228/diff?src=pr&el=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvY29tbW9uL0pvYkluZm9Db252ZXJ0ZXIuamF2YQ==)
 | `60.29% <58.33%> (+31.61%)` | `23.00 <0.00> (+2.00)` | |
   | 
[...ache/kylin/metrics/lib/impl/BlockingReservoir.java](https://codecov.io/gh/apache/kylin/pull/1228/diff?src=pr&el=tree#diff-Y29yZS1tZXRyaWNzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9tZXRyaWNzL2xpYi9pbXBsL0Jsb2NraW5nUmVzZXJ2b2lyLmphdmE=)
 | `53.33% <66.66%> (+53.33%)` | `13.00 <2.00> (+13.00)` | |
   | 
[...he/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://codecov.io/gh/apache/kylin/pull/1228/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGUuamF2YQ==)
 | `72.97% <0.00%> (-5.41%)` | `6.00% <0.00%> (-1.00%)` | |
   | 
[...org/apache/kylin/rest/util/QueryRequestLimits.java](https://codecov.io/gh/apache/kylin/pull/1228/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvdXRpbC9RdWVyeVJlcXVlc3RMaW1pdHMuamF2YQ==)
 | `35.71% <0.00%> (-4.77%)` | `5.00% <0.00%> (-1.00%)` | |
   | 
[...he/kylin/job/impl/threadpool/DefaultScheduler.java](https://codecov.io/gh/apache/kylin/pull/1228/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9pbXBsL3RocmVhZHBvb2wvRGVmYXVsdFNjaGVkdWxlci5qYXZh)
 | `74.41% <0.00%> (-2.33%)` | `12.00% <0.00%> (ø%)` | |
   | 
[.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/1228/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=)
 | `63.84% <0.00%> (-2.31%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/1228/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh)
 | `69.30% <0.00%> (-1.83%)` | `7.00% <0.00%> (ø%)` | |
   | 
[...ache/kylin/engine/mr/common/AbstractHadoopJob.java](https://codecov.io/gh/apache/kylin/pull/1228/diff?src=pr&el=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvY29tbW9uL0Fic3RyYWN0SGFkb29wSm9iLmphdmE=)
 | `15.94% <0.00%> (+0.50%)` | `3.00% <0.00%> (+1.00%)` | |
   | ... and [35 
more](https://codecov.io/gh/apache/kylin/pull/1228/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/kylin/pull/1228?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/kylin/pull/1228?src=pr&el=footer). Last 
update 
[7886a24...984dc81](https://codecov.io/gh/apache/kylin/pull/1228?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to