[jira] [Commented] (KYLIN-3030) In the cubes table, the options of last column action are missing partly.

2017-11-23 Thread peng.jianhua (JIRA)

[ 
https://issues.apache.org/jira/browse/KYLIN-3030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265001#comment-16265001
 ] 

peng.jianhua commented on KYLIN-3030:
-

Hi [~Zhixiong Chen], thanks very much!

> In the cubes table, the options of last column action are missing partly.
> -
>
> Key: KYLIN-3030
> URL: https://issues.apache.org/jira/browse/KYLIN-3030
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Reporter: peng.jianhua
>Assignee: peng.jianhua
>  Labels: patch
> Fix For: v2.3.0
>
> Attachments: 
> 0001-KYLIN-3030-In-the-cubes-table-the-options-of-last-co.patch, 
> action_item_is_missing_partly1.png, action_item_is_missing_partly2.png
>
>
> 1. Open the Model page;
> 2. Choose one cube in table, and click the "Action" button, then you can find 
> serveral options, just like "Edit CubeDesc", "View Cube";
> 3. Then you can find the "Edit CubeDesc" option is missing partly, refer to 
> [^action_item_is_missing_partly1.png];
> 4. If you zoom out the browser window, you can even find not only "Edit 
> CubeDesc" but also "View Cube" is missing partly, refer to 
> [^action_item_is_missing_partly2.png]
> So we can modify cubes.html, add the margin-right setting for div, which can 
> give more space to options.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (KYLIN-3030) In the cubes table, the options of last column action are missing partly.

2017-11-23 Thread Zhixiong Chen (JIRA)

[ 
https://issues.apache.org/jira/browse/KYLIN-3030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264214#comment-16264214
 ] 

Zhixiong Chen commented on KYLIN-3030:
--

Hi,[~peng.jianhua].Sorry for late to check this patch.I will merge it into 
KYLIN master.
Thanks!

> In the cubes table, the options of last column action are missing partly.
> -
>
> Key: KYLIN-3030
> URL: https://issues.apache.org/jira/browse/KYLIN-3030
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Reporter: peng.jianhua
>Assignee: peng.jianhua
>  Labels: patch
> Attachments: 
> 0001-KYLIN-3030-In-the-cubes-table-the-options-of-last-co.patch, 
> action_item_is_missing_partly1.png, action_item_is_missing_partly2.png
>
>
> 1. Open the Model page;
> 2. Choose one cube in table, and click the "Action" button, then you can find 
> serveral options, just like "Edit CubeDesc", "View Cube";
> 3. Then you can find the "Edit CubeDesc" option is missing partly, refer to 
> [^action_item_is_missing_partly1.png];
> 4. If you zoom out the browser window, you can even find not only "Edit 
> CubeDesc" but also "View Cube" is missing partly, refer to 
> [^action_item_is_missing_partly2.png]
> So we can modify cubes.html, add the margin-right setting for div, which can 
> give more space to options.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (KYLIN-3030) In the cubes table, the options of last column action are missing partly.

2017-11-23 Thread peng.jianhua (JIRA)

[ 
https://issues.apache.org/jira/browse/KYLIN-3030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264201#comment-16264201
 ] 

peng.jianhua commented on KYLIN-3030:
-

Hi [~Zhixiong Chen], I have done this modification, can you help to check it? 
thanks very much.

> In the cubes table, the options of last column action are missing partly.
> -
>
> Key: KYLIN-3030
> URL: https://issues.apache.org/jira/browse/KYLIN-3030
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Reporter: peng.jianhua
>Assignee: peng.jianhua
>  Labels: patch
> Attachments: 
> 0001-KYLIN-3030-In-the-cubes-table-the-options-of-last-co.patch, 
> action_item_is_missing_partly1.png, action_item_is_missing_partly2.png
>
>
> 1. Open the Model page;
> 2. Choose one cube in table, and click the "Action" button, then you can find 
> serveral options, just like "Edit CubeDesc", "View Cube";
> 3. Then you can find the "Edit CubeDesc" option is missing partly, refer to 
> [^action_item_is_missing_partly1.png];
> 4. If you zoom out the browser window, you can even find not only "Edit 
> CubeDesc" but also "View Cube" is missing partly, refer to 
> [^action_item_is_missing_partly2.png]
> So we can modify cubes.html, add the margin-right setting for div, which can 
> give more space to options.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (KYLIN-3030) In the cubes table, the options of last column action are missing partly.

2017-11-20 Thread peng.jianhua (JIRA)

[ 
https://issues.apache.org/jira/browse/KYLIN-3030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16259001#comment-16259001
 ] 

peng.jianhua commented on KYLIN-3030:
-

Hi Zhixiong Chen, I have modified the 'Action' list like the 'Admin‘ list, 
please check, thanks.

> In the cubes table, the options of last column action are missing partly.
> -
>
> Key: KYLIN-3030
> URL: https://issues.apache.org/jira/browse/KYLIN-3030
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Reporter: peng.jianhua
>Assignee: peng.jianhua
>  Labels: patch
> Attachments: 
> 0001-KYLIN-3030-In-the-cubes-table-the-options-of-last-co.patch, 
> action_item_is_missing_partly1.png, action_item_is_missing_partly2.png
>
>
> 1. Open the Model page;
> 2. Choose one cube in table, and click the "Action" button, then you can find 
> serveral options, just like "Edit CubeDesc", "View Cube";
> 3. Then you can find the "Edit CubeDesc" option is missing partly, refer to 
> [^action_item_is_missing_partly1.png];
> 4. If you zoom out the browser window, you can even find not only "Edit 
> CubeDesc" but also "View Cube" is missing partly, refer to 
> [^action_item_is_missing_partly2.png]
> So we can modify cubes.html, add the margin-right setting for div, which can 
> give more space to options.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (KYLIN-3030) In the cubes table, the options of last column action are missing partly.

2017-11-19 Thread Zhixiong Chen (JIRA)

[ 
https://issues.apache.org/jira/browse/KYLIN-3030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16258898#comment-16258898
 ] 

Zhixiong Chen commented on KYLIN-3030:
--

Hi,[~peng.jianhua].Could you modify the 'Action' list like the 'Admin‘ list.
Thanks!

> In the cubes table, the options of last column action are missing partly.
> -
>
> Key: KYLIN-3030
> URL: https://issues.apache.org/jira/browse/KYLIN-3030
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Reporter: peng.jianhua
>Assignee: peng.jianhua
>  Labels: patch
> Attachments: 
> 0001-KYLIN-3030-In-the-cubes-table-the-options-of-last-co.patch, 
> action_item_is_missing_partly1.png, action_item_is_missing_partly2.png
>
>
> 1. Open the Model page;
> 2. Choose one cube in table, and click the "Action" button, then you can find 
> serveral options, just like "Edit CubeDesc", "View Cube";
> 3. Then you can find the "Edit CubeDesc" option is missing partly, refer to 
> [^action_item_is_missing_partly1.png];
> 4. If you zoom out the browser window, you can even find not only "Edit 
> CubeDesc" but also "View Cube" is missing partly, refer to 
> [^action_item_is_missing_partly2.png]
> So we can modify cubes.html, add the margin-right setting for div, which can 
> give more space to options.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (KYLIN-3030) In the cubes table, the options of last column action are missing partly.

2017-11-19 Thread Zhixiong Chen (JIRA)

[ 
https://issues.apache.org/jira/browse/KYLIN-3030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16258857#comment-16258857
 ] 

Zhixiong Chen commented on KYLIN-3030:
--

Hi,[~peng.jianhua].I have checked this patch.I will merge it into KYLIN master.
Thanks!

> In the cubes table, the options of last column action are missing partly.
> -
>
> Key: KYLIN-3030
> URL: https://issues.apache.org/jira/browse/KYLIN-3030
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Reporter: peng.jianhua
>Assignee: peng.jianhua
>  Labels: patch
> Attachments: 
> 0001-KYLIN-3030-In-the-cubes-table-the-options-of-last-co.patch, 
> action_item_is_missing_partly1.png, action_item_is_missing_partly2.png
>
>
> 1. Open the Model page;
> 2. Choose one cube in table, and click the "Action" button, then you can find 
> serveral options, just like "Edit CubeDesc", "View Cube";
> 3. Then you can find the "Edit CubeDesc" option is missing partly, refer to 
> [^action_item_is_missing_partly1.png];
> 4. If you zoom out the browser window, you can even find not only "Edit 
> CubeDesc" but also "View Cube" is missing partly, refer to 
> [^action_item_is_missing_partly2.png]
> So we can modify cubes.html, add the margin-right setting for div, which can 
> give more space to options.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (KYLIN-3030) In the cubes table, the options of last column action are missing partly.

2017-11-17 Thread peng.jianhua (JIRA)

[ 
https://issues.apache.org/jira/browse/KYLIN-3030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16256885#comment-16256885
 ] 

peng.jianhua commented on KYLIN-3030:
-

hi [~Zhixiong Chen], I have update the patch for your suggestion, please check 
it, thanks very much.

> In the cubes table, the options of last column action are missing partly.
> -
>
> Key: KYLIN-3030
> URL: https://issues.apache.org/jira/browse/KYLIN-3030
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Reporter: peng.jianhua
>Assignee: peng.jianhua
>  Labels: patch
> Attachments: 
> 0001-KYLIN-3030-In-the-cubes-table-the-options-of-last-co.patch, 
> action_item_is_missing_partly1.png, action_item_is_missing_partly2.png, 
> longer-option-show-1.png, longer-option-show-2.png
>
>
> 1. Open the Model page;
> 2. Choose one cube in table, and click the "Action" button, then you can find 
> serveral options, just like "Edit CubeDesc", "View Cube";
> 3. Then you can find the "Edit CubeDesc" option is missing partly, refer to 
> [^action_item_is_missing_partly1.png];
> 4. If you zoom out the browser window, you can even find not only "Edit 
> CubeDesc" but also "View Cube" is missing partly, refer to 
> [^action_item_is_missing_partly2.png]
> So we can modify cubes.html, add the margin-right setting for div, which can 
> give more space to options.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (KYLIN-3030) In the cubes table, the options of last column action are missing partly.

2017-11-17 Thread peng.jianhua (JIRA)

[ 
https://issues.apache.org/jira/browse/KYLIN-3030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16256813#comment-16256813
 ] 

peng.jianhua commented on KYLIN-3030:
-

Hi [~Zhixiong Chen], thanks for your suggestion.
I give the "max-width" to , and automatically omit the long option by 
'...', then we can give a hint to show the whole name. as follow snapshot.
May I handle it in this way? Look forward for your reply, thank you.
 !longer-option-show-1.png!
!longer-option-show-2.png!

> In the cubes table, the options of last column action are missing partly.
> -
>
> Key: KYLIN-3030
> URL: https://issues.apache.org/jira/browse/KYLIN-3030
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Reporter: peng.jianhua
>Assignee: peng.jianhua
>  Labels: patch
> Attachments: 
> 0001-KYLIN-3030-In-the-cubes-table-the-options-of-last-co.patch, 
> action_item_is_missing_partly1.png, action_item_is_missing_partly2.png, 
> longer-option-show-1.png, longer-option-show-2.png
>
>
> 1. Open the Model page;
> 2. Choose one cube in table, and click the "Action" button, then you can find 
> serveral options, just like "Edit CubeDesc", "View Cube";
> 3. Then you can find the "Edit CubeDesc" option is missing partly, refer to 
> [^action_item_is_missing_partly1.png];
> 4. If you zoom out the browser window, you can even find not only "Edit 
> CubeDesc" but also "View Cube" is missing partly, refer to 
> [^action_item_is_missing_partly2.png]
> So we can modify cubes.html, add the margin-right setting for div, which can 
> give more space to options.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (KYLIN-3030) In the cubes table, the options of last column action are missing partly.

2017-11-16 Thread Zhixiong Chen (JIRA)

[ 
https://issues.apache.org/jira/browse/KYLIN-3030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16256520#comment-16256520
 ] 

Zhixiong Chen commented on KYLIN-3030:
--

This issue is like KYLIN-3034.
You shouldn't modify 'margin-right'.
You could modify the  style.

> In the cubes table, the options of last column action are missing partly.
> -
>
> Key: KYLIN-3030
> URL: https://issues.apache.org/jira/browse/KYLIN-3030
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Reporter: peng.jianhua
>Assignee: peng.jianhua
>  Labels: patch
> Attachments: 
> 0001-KYLIN-3030-In-the-cubes-table-the-options-of-last-co.patch, 
> action_item_is_missing_partly1.png, action_item_is_missing_partly2.png
>
>
> 1. Open the Model page;
> 2. Choose one cube in table, and click the "Action" button, then you can find 
> serveral options, just like "Edit CubeDesc", "View Cube";
> 3. Then you can find the "Edit CubeDesc" option is missing partly, refer to 
> [^action_item_is_missing_partly1.png];
> 4. If you zoom out the browser window, you can even find not only "Edit 
> CubeDesc" but also "View Cube" is missing partly, refer to 
> [^action_item_is_missing_partly2.png]
> So we can modify cubes.html, add the margin-right setting for div, which can 
> give more space to options.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (KYLIN-3030) In the cubes table, the options of last column action are missing partly.

2017-11-12 Thread Shaofeng SHI (JIRA)

[ 
https://issues.apache.org/jira/browse/KYLIN-3030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16249019#comment-16249019
 ] 

Shaofeng SHI commented on KYLIN-3030:
-

Thanks jianhua; [~bob123] Guosheng, please review the patch.

> In the cubes table, the options of last column action are missing partly.
> -
>
> Key: KYLIN-3030
> URL: https://issues.apache.org/jira/browse/KYLIN-3030
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Reporter: peng.jianhua
>Assignee: peng.jianhua
>  Labels: patch
> Attachments: 
> 0001-KYLIN-3030-In-the-cubes-table-the-options-of-last-co.patch, 
> action_item_is_missing_partly1.png, action_item_is_missing_partly2.png
>
>
> 1. Open the Model page;
> 2. Choose one cube in table, and click the "Action" button, then you can find 
> serveral options, just like "Edit CubeDesc", "View Cube";
> 3. Then you can find the "Edit CubeDesc" option is missing partly, refer to 
> [^action_item_is_missing_partly1.png];
> 4. If you zoom out the browser window, you can even find not only "Edit 
> CubeDesc" but also "View Cube" is missing partly, refer to 
> [^action_item_is_missing_partly2.png]
> So we can modify cubes.html, add the margin-right setting for div, which can 
> give more space to options.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)