[jira] [Commented] (KYLIN-3521) Enable Cube Planner by default
[ https://issues.apache.org/jira/browse/KYLIN-3521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614224#comment-16614224 ] Shaofeng SHI commented on KYLIN-3521: - [~yaho] The properties in whitelist are non-sensitive properties. Some properties like username/pwd should not be exposed with the public Rest API. So we made a whitelist to control that. > Enable Cube Planner by default > -- > > Key: KYLIN-3521 > URL: https://issues.apache.org/jira/browse/KYLIN-3521 > Project: Kylin > Issue Type: Improvement >Affects Versions: v2.5.0 >Reporter: Shaofeng SHI >Assignee: Ma Gang >Priority: Minor > Fix For: v2.5.0 > > Attachments: KYLIN-3521_V2.patch, KYLIN-3521_V3.patch > > > Cube planner can significantly reduce the cuboid number that to build. As it > wasn't enabled by default in 2.3 and 2.4, many users don't know that. > > To let more user to start using it, I suggest to enable it by default. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3521) Enable Cube Planner by default
[ https://issues.apache.org/jira/browse/KYLIN-3521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605100#comment-16605100 ] ASF subversion and git services commented on KYLIN-3521: Commit 6d00ed556c192fe498df4e265bce6ef4bb969e0b in kylin's branch refs/heads/master from shaofengshi [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=6d00ed5 ] KYLIN-3521 fix ut > Enable Cube Planner by default > -- > > Key: KYLIN-3521 > URL: https://issues.apache.org/jira/browse/KYLIN-3521 > Project: Kylin > Issue Type: Improvement >Affects Versions: v2.5.0 >Reporter: Shaofeng SHI >Assignee: Ma Gang >Priority: Minor > Fix For: v2.5.0 > > Attachments: KYLIN-3521_V2.patch, KYLIN-3521_V3.patch > > > Cube planner can significantly reduce the cuboid number that to build. As it > wasn't enabled by default in 2.3 and 2.4, many users don't know that. > > To let more user to start using it, I suggest to enable it by default. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3521) Enable Cube Planner by default
[ https://issues.apache.org/jira/browse/KYLIN-3521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605086#comment-16605086 ] ASF subversion and git services commented on KYLIN-3521: Commit 8349747cad1ccfb159a152e11a5023a4e8a37f17 in kylin's branch refs/heads/2.5.x from shaofengshi [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=8349747 ] KYLIN-3521 fix ut > Enable Cube Planner by default > -- > > Key: KYLIN-3521 > URL: https://issues.apache.org/jira/browse/KYLIN-3521 > Project: Kylin > Issue Type: Improvement >Affects Versions: v2.5.0 >Reporter: Shaofeng SHI >Assignee: Ma Gang >Priority: Minor > Fix For: v2.5.0 > > Attachments: KYLIN-3521_V2.patch, KYLIN-3521_V3.patch > > > Cube planner can significantly reduce the cuboid number that to build. As it > wasn't enabled by default in 2.3 and 2.4, many users don't know that. > > To let more user to start using it, I suggest to enable it by default. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3521) Enable Cube Planner by default
[ https://issues.apache.org/jira/browse/KYLIN-3521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16604157#comment-16604157 ] Zhong Yanghong commented on KYLIN-3521: --- Hi [~Aron.tao] and [~Shaofengshi], what's the meaning of *getPropertiesWhiteList()* in *KylinConfigBase* ? Why *kylin.cube.cubeplanner.enabled* and *web.dashboard-enabled* are added? What's the criteria for those properties added? > Enable Cube Planner by default > -- > > Key: KYLIN-3521 > URL: https://issues.apache.org/jira/browse/KYLIN-3521 > Project: Kylin > Issue Type: Improvement >Affects Versions: v2.5.0 >Reporter: Shaofeng SHI >Assignee: Ma Gang >Priority: Minor > Fix For: v2.5.0 > > Attachments: KYLIN-3521_V2.patch, KYLIN-3521_V3.patch > > > Cube planner can significantly reduce the cuboid number that to build. As it > wasn't enabled by default in 2.3 and 2.4, many users don't know that. > > To let more user to start using it, I suggest to enable it by default. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3521) Enable Cube Planner by default
[ https://issues.apache.org/jira/browse/KYLIN-3521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16604139#comment-16604139 ] Ma Gang commented on KYLIN-3521: Add another patch KYLIN-3521_V3.patch to fix. Since Shaofeng is busy now, [~yaho] could you help to apply the patch. > Enable Cube Planner by default > -- > > Key: KYLIN-3521 > URL: https://issues.apache.org/jira/browse/KYLIN-3521 > Project: Kylin > Issue Type: Improvement >Affects Versions: v2.5.0 >Reporter: Shaofeng SHI >Assignee: Ma Gang >Priority: Minor > Fix For: v2.5.0 > > Attachments: KYLIN-3521_V2.patch, KYLIN-3521_V3.patch > > > Cube planner can significantly reduce the cuboid number that to build. As it > wasn't enabled by default in 2.3 and 2.4, many users don't know that. > > To let more user to start using it, I suggest to enable it by default. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3521) Enable Cube Planner by default
[ https://issues.apache.org/jira/browse/KYLIN-3521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16604115#comment-16604115 ] Ma Gang commented on KYLIN-3521: Thanks [~yichen.zhou], my bad. Why we need to check the configuration value in UT? I don't think it make any sense. Thought this patch is just make a simple configuration change..., anyway I will fix it and provide another patch. > Enable Cube Planner by default > -- > > Key: KYLIN-3521 > URL: https://issues.apache.org/jira/browse/KYLIN-3521 > Project: Kylin > Issue Type: Improvement >Affects Versions: v2.5.0 >Reporter: Shaofeng SHI >Assignee: Ma Gang >Priority: Minor > Fix For: v2.5.0 > > Attachments: KYLIN-3521_V2.patch > > > Cube planner can significantly reduce the cuboid number that to build. As it > wasn't enabled by default in 2.3 and 2.4, many users don't know that. > > To let more user to start using it, I suggest to enable it by default. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3521) Enable Cube Planner by default
[ https://issues.apache.org/jira/browse/KYLIN-3521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16603863#comment-16603863 ] Yichen Zhou commented on KYLIN-3521: It seems like KYLIN-3521_V2.patch forgot to set "kylin.cube.cubeplanner.enabled" to true in _kylin\server\src\test\java\org\apache\kylin\rest\service\AdminServiceTest.java_, which may cause build failure. [ERROR] Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.136 s <<< FAILURE! - in org.apache.kylin.rest.service.AdminServiceTest[ERROR] testGetPublicConfig(org.apache.kylin.rest.service.AdminServiceTest) Time elapsed: 0.063 s <<< FAILURE!org.junit.ComparisonFailure: expected:<...cubeplanner.enabled=[fals]e kylin.web.help= ky...> but was:<...cubeplanner.enabled=[tru]e kylin.web.help= ky...> at org.apache.kylin.rest.service.AdminServiceTest.testGetPublicConfig(AdminServiceTest.java:77) > Enable Cube Planner by default > -- > > Key: KYLIN-3521 > URL: https://issues.apache.org/jira/browse/KYLIN-3521 > Project: Kylin > Issue Type: Improvement >Affects Versions: v2.5.0 >Reporter: Shaofeng SHI >Assignee: Ma Gang >Priority: Minor > Fix For: v2.5.0 > > Attachments: KYLIN-3521_V2.patch > > > Cube planner can significantly reduce the cuboid number that to build. As it > wasn't enabled by default in 2.3 and 2.4, many users don't know that. > > To let more user to start using it, I suggest to enable it by default. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3521) Enable Cube Planner by default
[ https://issues.apache.org/jira/browse/KYLIN-3521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602888#comment-16602888 ] Shaofeng SHI commented on KYLIN-3521: - LGTM; Merged in 2.5.x and master > Enable Cube Planner by default > -- > > Key: KYLIN-3521 > URL: https://issues.apache.org/jira/browse/KYLIN-3521 > Project: Kylin > Issue Type: Improvement >Affects Versions: v2.5.0 >Reporter: Shaofeng SHI >Assignee: Ma Gang >Priority: Minor > Fix For: v2.5.0 > > Attachments: KYLIN-3521_V2.patch > > > Cube planner can significantly reduce the cuboid number that to build. As it > wasn't enabled by default in 2.3 and 2.4, many users don't know that. > > To let more user to start using it, I suggest to enable it by default. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3521) Enable Cube Planner by default
[ https://issues.apache.org/jira/browse/KYLIN-3521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602516#comment-16602516 ] ASF subversion and git services commented on KYLIN-3521: Commit 94afb6b9ca1beb26ca3d5a8238a0a9a499e61813 in kylin's branch refs/heads/master from Ma,Gang [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=94afb6b ] KYLIN-3521 Enable Cube Planner by default > Enable Cube Planner by default > -- > > Key: KYLIN-3521 > URL: https://issues.apache.org/jira/browse/KYLIN-3521 > Project: Kylin > Issue Type: Improvement >Affects Versions: v2.5.0 >Reporter: Shaofeng SHI >Assignee: Ma Gang >Priority: Minor > Fix For: v2.5.0 > > Attachments: KYLIN-3521_V2.patch > > > Cube planner can significantly reduce the cuboid number that to build. As it > wasn't enabled by default in 2.3 and 2.4, many users don't know that. > > To let more user to start using it, I suggest to enable it by default. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3521) Enable Cube Planner by default
[ https://issues.apache.org/jira/browse/KYLIN-3521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602126#comment-16602126 ] ASF subversion and git services commented on KYLIN-3521: Commit 41b4ffe27c20521bf0c676935b34a6bbcdbf2d51 in kylin's branch refs/heads/2.5.x from Ma,Gang [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=41b4ffe ] KYLIN-3521 Enable Cube Planner by default > Enable Cube Planner by default > -- > > Key: KYLIN-3521 > URL: https://issues.apache.org/jira/browse/KYLIN-3521 > Project: Kylin > Issue Type: Improvement >Affects Versions: v2.5.0 >Reporter: Shaofeng SHI >Assignee: Ma Gang >Priority: Minor > Fix For: v2.5.0 > > Attachments: KYLIN-3521.patch, KYLIN-3521_V2.patch > > > Cube planner can significantly reduce the cuboid number that to build. As it > wasn't enabled by default in 2.3 and 2.4, many users don't know that. > > To let more user to start using it, I suggest to enable it by default. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3521) Enable Cube Planner by default
[ https://issues.apache.org/jira/browse/KYLIN-3521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602041#comment-16602041 ] Ma Gang commented on KYLIN-3521: Thanks [~Shaofengshi], upload the new patch, please review, also set the "kylin.cube.cubeplanner.enabled-for-existing-cube" to true. > Enable Cube Planner by default > -- > > Key: KYLIN-3521 > URL: https://issues.apache.org/jira/browse/KYLIN-3521 > Project: Kylin > Issue Type: Improvement >Affects Versions: v2.5.0 >Reporter: Shaofeng SHI >Assignee: Ma Gang >Priority: Minor > Fix For: v2.5.0 > > Attachments: KYLIN-3521.patch, KYLIN-3521_V2.patch > > > Cube planner can significantly reduce the cuboid number that to build. As it > wasn't enabled by default in 2.3 and 2.4, many users don't know that. > > To let more user to start using it, I suggest to enable it by default. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3521) Enable Cube Planner by default
[ https://issues.apache.org/jira/browse/KYLIN-3521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602008#comment-16602008 ] Shaofeng SHI commented on KYLIN-3521: - Hi Gang, this patch didn't cover the kylin-defaults.properties, in which they are still old values: kylin.cube.cubeplanner.enabled=false kylin.cube.cubeplanner.enabled-for-existing-cube=false kylin.cube.cubeplanner.expansion-threshold=15.0 kylin.cube.cubeplanner.recommend-cache-max-size=200 kylin.cube.cubeplanner.mandatory-rollup-threshold=1000 kylin.cube.cubeplanner.algorithm-threshold-greedy=10 kylin.cube.cubeplanner.algorithm-threshold-genetic=23 Please update kylin-defaults.properties as well. Besides, do you think can "kylin.cube.cubeplanner.enabled-for-existing-cube" be true? Thanks! > Enable Cube Planner by default > -- > > Key: KYLIN-3521 > URL: https://issues.apache.org/jira/browse/KYLIN-3521 > Project: Kylin > Issue Type: Improvement >Affects Versions: v2.5.0 >Reporter: Shaofeng SHI >Assignee: Ma Gang >Priority: Minor > Fix For: v2.5.0 > > Attachments: KYLIN-3521.patch > > > Cube planner can significantly reduce the cuboid number that to build. As it > wasn't enabled by default in 2.3 and 2.4, many users don't know that. > > To let more user to start using it, I suggest to enable it by default. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3521) Enable Cube Planner by default
[ https://issues.apache.org/jira/browse/KYLIN-3521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16601754#comment-16601754 ] Ma Gang commented on KYLIN-3521: Patch upload, please help to review [~Shaofengshi] > Enable Cube Planner by default > -- > > Key: KYLIN-3521 > URL: https://issues.apache.org/jira/browse/KYLIN-3521 > Project: Kylin > Issue Type: Improvement >Affects Versions: v2.5.0 >Reporter: Shaofeng SHI >Assignee: Ma Gang >Priority: Minor > Fix For: v2.5.0 > > Attachments: KYLIN-3521.patch > > > Cube planner can significantly reduce the cuboid number that to build. As it > wasn't enabled by default in 2.3 and 2.4, many users don't know that. > > To let more user to start using it, I suggest to enable it by default. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3521) Enable Cube Planner by default
[ https://issues.apache.org/jira/browse/KYLIN-3521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16601206#comment-16601206 ] Shaofeng SHI commented on KYLIN-3521: - The restriction of "kylin.cube.aggrgroup.max-combination=4096" can be disabled, so user can create a cube with more dimensions and save directly. > Enable Cube Planner by default > -- > > Key: KYLIN-3521 > URL: https://issues.apache.org/jira/browse/KYLIN-3521 > Project: Kylin > Issue Type: Improvement >Affects Versions: v2.5.0 >Reporter: Shaofeng SHI >Priority: Minor > > Cube planner can significantly reduce the cuboid number that to build. As it > wasn't enabled by default in 2.3 and 2.4, many users don't know that. > > To let more user to start using it, I suggest to enable it by default. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3521) Enable Cube Planner by default
[ https://issues.apache.org/jira/browse/KYLIN-3521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16598408#comment-16598408 ] Yichen Zhou commented on KYLIN-3521: +1 Good feature! And maybe we can make it easier to understand and use in phase two. > Enable Cube Planner by default > -- > > Key: KYLIN-3521 > URL: https://issues.apache.org/jira/browse/KYLIN-3521 > Project: Kylin > Issue Type: Improvement >Affects Versions: v2.5.0 >Reporter: Shaofeng SHI >Priority: Minor > > Cube planner can significantly reduce the cuboid number that to build. As it > wasn't enabled by default in 2.3 and 2.4, many users don't know that. > > To let more user to start using it, I suggest to enable it by default. As > Cube planner only works when build the first segment, it only affect the > cuboid scheduler of a new Cube. Old cubes will not be affected. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3521) Enable Cube Planner by default
[ https://issues.apache.org/jira/browse/KYLIN-3521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16598396#comment-16598396 ] Pan, Julian commented on KYLIN-3521: +1 > Enable Cube Planner by default > -- > > Key: KYLIN-3521 > URL: https://issues.apache.org/jira/browse/KYLIN-3521 > Project: Kylin > Issue Type: Improvement >Affects Versions: v2.5.0 >Reporter: Shaofeng SHI >Priority: Minor > > Cube planner can significantly reduce the cuboid number that to build. As it > wasn't enabled by default in 2.3 and 2.4, many users don't know that. > > To let more user to start using it, I suggest to enable it by default. As > Cube planner only works when build the first segment, it only affect the > cuboid scheduler of a new Cube. Old cubes will not be affected. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3521) Enable Cube Planner by default
[ https://issues.apache.org/jira/browse/KYLIN-3521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16598387#comment-16598387 ] Ma Gang commented on KYLIN-3521: +1 > Enable Cube Planner by default > -- > > Key: KYLIN-3521 > URL: https://issues.apache.org/jira/browse/KYLIN-3521 > Project: Kylin > Issue Type: Improvement >Affects Versions: v2.5.0 >Reporter: Shaofeng SHI >Priority: Minor > > Cube planner can significantly reduce the cuboid number that to build. As it > wasn't enabled by default in 2.3 and 2.4, many users don't know that. > > To let more user to start using it, I suggest to enable it by default. As > Cube planner only works when build the first segment, it only affect the > cuboid scheduler of a new Cube. Old cubes will not be affected. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3521) Enable Cube Planner by default
[ https://issues.apache.org/jira/browse/KYLIN-3521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16598383#comment-16598383 ] Billy Liu commented on KYLIN-3521: -- +1 > Enable Cube Planner by default > -- > > Key: KYLIN-3521 > URL: https://issues.apache.org/jira/browse/KYLIN-3521 > Project: Kylin > Issue Type: Improvement >Affects Versions: v2.5.0 >Reporter: Shaofeng SHI >Priority: Minor > > Cube planner can significantly reduce the cuboid number that to build. As it > wasn't enabled by default in 2.3 and 2.4, many users don't know that. > > To let more user to start using it, I suggest to enable it by default. As > Cube planner only works when build the first segment, it only affect the > cuboid scheduler of a new Cube. Old cubes will not be affected. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3521) Enable Cube Planner by default
[ https://issues.apache.org/jira/browse/KYLIN-3521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16598381#comment-16598381 ] Zhong Yanghong commented on KYLIN-3521: --- +1 for enabling cube planner phase one by default. To enable phase two, currently system cubes need to be setup. > Enable Cube Planner by default > -- > > Key: KYLIN-3521 > URL: https://issues.apache.org/jira/browse/KYLIN-3521 > Project: Kylin > Issue Type: Improvement >Affects Versions: v2.5.0 >Reporter: Shaofeng SHI >Priority: Minor > > Cube planner can significantly reduce the cuboid number that to build. As it > wasn't enabled by default in 2.3 and 2.4, many users don't know that. > > To let more user to start using it, I suggest to enable it by default. As > Cube planner only works when build the first segment, it only affect the > cuboid scheduler of a new Cube. Old cubes will not be affected. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
