[jira] [Commented] (KYLIN-3575) Unclosed Connection in DriverTest
[
https://issues.apache.org/jira/browse/KYLIN-3575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16625507#comment-16625507
]
ASF subversion and git services commented on KYLIN-3575:
Commit f37be33cedba7fa4f6970d2c3082578e70a6b1a0 in kylin's branch
refs/heads/update_travis_maven from tttMelody
[ https://gitbox.apache.org/repos/asf?p=kylin.git;h=f37be33 ]
KYLIN-3575, fix unclosed JDBC connection in DriverTest.
> Unclosed Connection in DriverTest
> -
>
> Key: KYLIN-3575
> URL: https://issues.apache.org/jira/browse/KYLIN-3575
> Project: Kylin
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: jiatao.tao
>Priority: Minor
> Fix For: v2.6.0
>
>
> In testCalciteProps :
> {code}
> KylinConnection conn = (KylinConnection)
> driver.connect("jdbc:kylin:test_url/test_db", props);
> {code}
> The connection should be closed upon return.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (KYLIN-3575) Unclosed Connection in DriverTest
[
https://issues.apache.org/jira/browse/KYLIN-3575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16625451#comment-16625451
]
ASF subversion and git services commented on KYLIN-3575:
Commit f37be33cedba7fa4f6970d2c3082578e70a6b1a0 in kylin's branch
refs/heads/master from tttMelody
[ https://gitbox.apache.org/repos/asf?p=kylin.git;h=f37be33 ]
KYLIN-3575, fix unclosed JDBC connection in DriverTest.
> Unclosed Connection in DriverTest
> -
>
> Key: KYLIN-3575
> URL: https://issues.apache.org/jira/browse/KYLIN-3575
> Project: Kylin
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: jiatao.tao
>Priority: Minor
> Fix For: v2.6.0
>
>
> In testCalciteProps :
> {code}
> KylinConnection conn = (KylinConnection)
> driver.connect("jdbc:kylin:test_url/test_db", props);
> {code}
> The connection should be closed upon return.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (KYLIN-3575) Unclosed Connection in DriverTest
[
https://issues.apache.org/jira/browse/KYLIN-3575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16625450#comment-16625450
]
ASF GitHub Bot commented on KYLIN-3575:
---
shaofengshi closed pull request #242: KYLIN-3575, fix unclosed JDBC connection
in DriverTest.
URL: https://github.com/apache/kylin/pull/242
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/jdbc/src/test/java/org/apache/kylin/jdbc/DriverTest.java
b/jdbc/src/test/java/org/apache/kylin/jdbc/DriverTest.java
index 11dbcde45d..1ffec6d132 100644
--- a/jdbc/src/test/java/org/apache/kylin/jdbc/DriverTest.java
+++ b/jdbc/src/test/java/org/apache/kylin/jdbc/DriverTest.java
@@ -221,6 +221,7 @@ public void testSSLFromURL() throws SQLException {
assertEquals("test_url", ((KylinConnection) conn).getBaseUrl());
assertEquals("test_db", ((KylinConnection) conn).getProject());
assertTrue(Boolean.parseBoolean((String) ((KylinConnection)
conn).getConnectionProperties().get("ssl")));
+conn.close();
}
@Test
@@ -245,6 +246,8 @@ public void testCalciteProps() throws SQLException {
assertEquals("false",
connProps2.getProperty("kylin.query.calcite.extras-props.caseSensitive"));
assertEquals("UNCHANGED",
connProps2.getProperty("kylin.query.calcite.extras-props.unquotedCasing"));
assertEquals("BACK_TICK",
connProps2.getProperty("kylin.query.calcite.extras-props.quoting"));
+conn.close();
+conn2.close();
}
private void printResultSet(ResultSet rs) throws SQLException {
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Unclosed Connection in DriverTest
> -
>
> Key: KYLIN-3575
> URL: https://issues.apache.org/jira/browse/KYLIN-3575
> Project: Kylin
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: jiatao.tao
>Priority: Minor
> Fix For: v2.6.0
>
>
> In testCalciteProps :
> {code}
> KylinConnection conn = (KylinConnection)
> driver.connect("jdbc:kylin:test_url/test_db", props);
> {code}
> The connection should be closed upon return.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (KYLIN-3575) Unclosed Connection in DriverTest
[
https://issues.apache.org/jira/browse/KYLIN-3575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16625035#comment-16625035
]
ASF GitHub Bot commented on KYLIN-3575:
---
asfgit commented on issue #242: KYLIN-3575, fix unclosed JDBC connection in
DriverTest.
URL: https://github.com/apache/kylin/pull/242#issuecomment-423801611
Can one of the admins verify this patch?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Unclosed Connection in DriverTest
> -
>
> Key: KYLIN-3575
> URL: https://issues.apache.org/jira/browse/KYLIN-3575
> Project: Kylin
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: jiatao.tao
>Priority: Minor
>
> In testCalciteProps :
> {code}
> KylinConnection conn = (KylinConnection)
> driver.connect("jdbc:kylin:test_url/test_db", props);
> {code}
> The connection should be closed upon return.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (KYLIN-3575) Unclosed Connection in DriverTest
[
https://issues.apache.org/jira/browse/KYLIN-3575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16625034#comment-16625034
]
ASF GitHub Bot commented on KYLIN-3575:
---
asfgit commented on issue #242: KYLIN-3575, fix unclosed JDBC connection in
DriverTest.
URL: https://github.com/apache/kylin/pull/242#issuecomment-423801612
Can one of the admins verify this patch?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Unclosed Connection in DriverTest
> -
>
> Key: KYLIN-3575
> URL: https://issues.apache.org/jira/browse/KYLIN-3575
> Project: Kylin
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: jiatao.tao
>Priority: Minor
>
> In testCalciteProps :
> {code}
> KylinConnection conn = (KylinConnection)
> driver.connect("jdbc:kylin:test_url/test_db", props);
> {code}
> The connection should be closed upon return.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (KYLIN-3575) Unclosed Connection in DriverTest
[
https://issues.apache.org/jira/browse/KYLIN-3575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16625033#comment-16625033
]
ASF GitHub Bot commented on KYLIN-3575:
---
tttMelody opened a new pull request #242: KYLIN-3575, fix unclosed JDBC
connection in DriverTest.
URL: https://github.com/apache/kylin/pull/242
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Unclosed Connection in DriverTest
> -
>
> Key: KYLIN-3575
> URL: https://issues.apache.org/jira/browse/KYLIN-3575
> Project: Kylin
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: jiatao.tao
>Priority: Minor
>
> In testCalciteProps :
> {code}
> KylinConnection conn = (KylinConnection)
> driver.connect("jdbc:kylin:test_url/test_db", props);
> {code}
> The connection should be closed upon return.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (KYLIN-3575) Unclosed Connection in DriverTest
[
https://issues.apache.org/jira/browse/KYLIN-3575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16625032#comment-16625032
]
jiatao.tao commented on KYLIN-3575:
---
Thanks!
> Unclosed Connection in DriverTest
> -
>
> Key: KYLIN-3575
> URL: https://issues.apache.org/jira/browse/KYLIN-3575
> Project: Kylin
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: jiatao.tao
>Priority: Minor
>
> In testCalciteProps :
> {code}
> KylinConnection conn = (KylinConnection)
> driver.connect("jdbc:kylin:test_url/test_db", props);
> {code}
> The connection should be closed upon return.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
