[jira] [Commented] (KYLIN-4066) No planner for not ROLE_ADMIN user on WebSite
[ https://issues.apache.org/jira/browse/KYLIN-4066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933168#comment-16933168 ] Yaqian Zhang commented on KYLIN-4066: - Verified. If a Non ADMIN user have ADMIN access for the project, he could look up the Planner. !image-2019-09-19-16-26-08-142.png|width=386,height=309! > No planner for not ROLE_ADMIN user on WebSite > - > > Key: KYLIN-4066 > URL: https://issues.apache.org/jira/browse/KYLIN-4066 > Project: Kylin > Issue Type: Bug > Components: Website >Affects Versions: v2.6.1 > Environment: macOs >Reporter: langdamao >Priority: Major > Labels: easyfix > Fix For: v3.0.0-beta, v2.6.4 > > Attachments: image-2019-09-19-16-26-08-142.png > > > There is no planner page for none ROLE_ADMIN user ,even though he has ADMIN > access for the project. > I found in webapp/app/partials/cubes/cube_detail.html line44 > {code:java} > ng-if="(userService.hasRole('ROLE_ADMIN') || hasPermission(cube, > permissions.ADMINISTRATION.mask)) && isShowCubeplanner"> ng-click="cube.visiblePage='planner';getCubePlanner(cube);">Planner > {code} > but other place the hasPermission function use as > {code:java} > hasPermission('cube',cube, permissions.ADMINISTRATION.mask) > {code} > the function hasPermission is defined in webapp/app/js/controllers/page.js > line100 > {code:java} > $scope.hasPermission = function (accessType, entity){ > ... > if (accessType === 'cube') { > project = entity.project > } else if (accessType === 'project') { > project = entity && entity.name || entity.selectedProject > } else if (accessType === 'model') { > project = ProjectModel.getProjectByCubeModel(entity.name) > } > ... > }{code} > I guess whether it's cause by no param of accessType. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4066) No planner for not ROLE_ADMIN user on WebSite
[ https://issues.apache.org/jira/browse/KYLIN-4066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16908082#comment-16908082 ] ASF subversion and git services commented on KYLIN-4066: Commit 4a30ba4f373ee13286e11fb1ef5e91002866caf1 in kylin's branch refs/heads/2.6.x from langdamao [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=4a30ba4 ] [KYLIN-4066] Fix No planner for not ROLE_ADMIN user Signed-off-by: langdamao > No planner for not ROLE_ADMIN user on WebSite > - > > Key: KYLIN-4066 > URL: https://issues.apache.org/jira/browse/KYLIN-4066 > Project: Kylin > Issue Type: Bug > Components: Website >Affects Versions: v2.6.1 > Environment: macOs >Reporter: langdamao >Priority: Major > Labels: easyfix > Fix For: v2.6.4 > > > There is no planner page for none ROLE_ADMIN user ,even though he has ADMIN > access for the project. > I found in webapp/app/partials/cubes/cube_detail.html line44 > {code:java} > ng-if="(userService.hasRole('ROLE_ADMIN') || hasPermission(cube, > permissions.ADMINISTRATION.mask)) && isShowCubeplanner"> ng-click="cube.visiblePage='planner';getCubePlanner(cube);">Planner > {code} > but other place the hasPermission function use as > {code:java} > hasPermission('cube',cube, permissions.ADMINISTRATION.mask) > {code} > the function hasPermission is defined in webapp/app/js/controllers/page.js > line100 > {code:java} > $scope.hasPermission = function (accessType, entity){ > ... > if (accessType === 'cube') { > project = entity.project > } else if (accessType === 'project') { > project = entity && entity.name || entity.selectedProject > } else if (accessType === 'model') { > project = ProjectModel.getProjectByCubeModel(entity.name) > } > ... > }{code} > I guess whether it's cause by no param of accessType. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (KYLIN-4066) No planner for not ROLE_ADMIN user on WebSite
[ https://issues.apache.org/jira/browse/KYLIN-4066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16893657#comment-16893657 ] ASF GitHub Bot commented on KYLIN-4066: --- nichunen commented on pull request #732: [KYLIN-4066] Fix No planner for not ROLE_ADMIN user URL: https://github.com/apache/kylin/pull/732 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > No planner for not ROLE_ADMIN user on WebSite > - > > Key: KYLIN-4066 > URL: https://issues.apache.org/jira/browse/KYLIN-4066 > Project: Kylin > Issue Type: Bug > Components: Website >Affects Versions: v2.6.1 > Environment: macOs >Reporter: langdamao >Priority: Major > Labels: easyfix > Fix For: Future > > > There is no planner page for none ROLE_ADMIN user ,even though he has ADMIN > access for the project. > I found in webapp/app/partials/cubes/cube_detail.html line44 > {code:java} > ng-if="(userService.hasRole('ROLE_ADMIN') || hasPermission(cube, > permissions.ADMINISTRATION.mask)) && isShowCubeplanner"> ng-click="cube.visiblePage='planner';getCubePlanner(cube);">Planner > {code} > but other place the hasPermission function use as > {code:java} > hasPermission('cube',cube, permissions.ADMINISTRATION.mask) > {code} > the function hasPermission is defined in webapp/app/js/controllers/page.js > line100 > {code:java} > $scope.hasPermission = function (accessType, entity){ > ... > if (accessType === 'cube') { > project = entity.project > } else if (accessType === 'project') { > project = entity && entity.name || entity.selectedProject > } else if (accessType === 'model') { > project = ProjectModel.getProjectByCubeModel(entity.name) > } > ... > }{code} > I guess whether it's cause by no param of accessType. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (KYLIN-4066) No planner for not ROLE_ADMIN user on WebSite
[ https://issues.apache.org/jira/browse/KYLIN-4066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16893658#comment-16893658 ] ASF subversion and git services commented on KYLIN-4066: Commit 1f026a6535ba00f8a60a7c6df9036ec827f08c72 in kylin's branch refs/heads/master from langdamao [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=1f026a6 ] [KYLIN-4066] Fix No planner for not ROLE_ADMIN user Signed-off-by: langdamao > No planner for not ROLE_ADMIN user on WebSite > - > > Key: KYLIN-4066 > URL: https://issues.apache.org/jira/browse/KYLIN-4066 > Project: Kylin > Issue Type: Bug > Components: Website >Affects Versions: v2.6.1 > Environment: macOs >Reporter: langdamao >Priority: Major > Labels: easyfix > Fix For: Future > > > There is no planner page for none ROLE_ADMIN user ,even though he has ADMIN > access for the project. > I found in webapp/app/partials/cubes/cube_detail.html line44 > {code:java} > ng-if="(userService.hasRole('ROLE_ADMIN') || hasPermission(cube, > permissions.ADMINISTRATION.mask)) && isShowCubeplanner"> ng-click="cube.visiblePage='planner';getCubePlanner(cube);">Planner > {code} > but other place the hasPermission function use as > {code:java} > hasPermission('cube',cube, permissions.ADMINISTRATION.mask) > {code} > the function hasPermission is defined in webapp/app/js/controllers/page.js > line100 > {code:java} > $scope.hasPermission = function (accessType, entity){ > ... > if (accessType === 'cube') { > project = entity.project > } else if (accessType === 'project') { > project = entity && entity.name || entity.selectedProject > } else if (accessType === 'model') { > project = ProjectModel.getProjectByCubeModel(entity.name) > } > ... > }{code} > I guess whether it's cause by no param of accessType. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (KYLIN-4066) No planner for not ROLE_ADMIN user on WebSite
[ https://issues.apache.org/jira/browse/KYLIN-4066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16878498#comment-16878498 ] ASF GitHub Bot commented on KYLIN-4066: --- langdamao commented on pull request #732: [KYLIN-4066] Fix No planner for not ROLE_ADMIN user URL: https://github.com/apache/kylin/pull/732 fix issue [KYLIN-4066](https://issues.apache.org/jira/browse/KYLIN-4066) Signed-off-by: langdamao This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > No planner for not ROLE_ADMIN user on WebSite > - > > Key: KYLIN-4066 > URL: https://issues.apache.org/jira/browse/KYLIN-4066 > Project: Kylin > Issue Type: Bug > Components: Website >Affects Versions: v2.6.1 > Environment: macOs >Reporter: langdamao >Priority: Major > Labels: easyfix > Fix For: Future > > > There is no planner page for none ROLE_ADMIN user ,even though he has ADMIN > access for the project. > I found in webapp/app/partials/cubes/cube_detail.html line44 > {code:java} > ng-if="(userService.hasRole('ROLE_ADMIN') || hasPermission(cube, > permissions.ADMINISTRATION.mask)) && isShowCubeplanner"> ng-click="cube.visiblePage='planner';getCubePlanner(cube);">Planner > {code} > but other place the hasPermission function use as > {code:java} > hasPermission('cube',cube, permissions.ADMINISTRATION.mask) > {code} > the function hasPermission is defined in webapp/app/js/controllers/page.js > line100 > {code:java} > $scope.hasPermission = function (accessType, entity){ > ... > if (accessType === 'cube') { > project = entity.project > } else if (accessType === 'project') { > project = entity && entity.name || entity.selectedProject > } else if (accessType === 'model') { > project = ProjectModel.getProjectByCubeModel(entity.name) > } > ... > }{code} > I guess whether it's cause by no param of accessType. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-4066) No planner for not ROLE_ADMIN user on WebSite
[ https://issues.apache.org/jira/browse/KYLIN-4066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16877513#comment-16877513 ] XiaoXiang Yu commented on KYLIN-4066: - +1 should be modified > No planner for not ROLE_ADMIN user on WebSite > - > > Key: KYLIN-4066 > URL: https://issues.apache.org/jira/browse/KYLIN-4066 > Project: Kylin > Issue Type: Bug > Components: Website >Affects Versions: v2.6.1 > Environment: macOs >Reporter: langdamao >Priority: Major > Labels: easyfix > Fix For: Future > > > There is no planner page for none ROLE_ADMIN user ,even though he has ADMIN > access for the project. > I found in webapp/app/partials/cubes/cube_detail.html line44 > {code:java} > ng-if="(userService.hasRole('ROLE_ADMIN') || hasPermission(cube, > permissions.ADMINISTRATION.mask)) && isShowCubeplanner"> ng-click="cube.visiblePage='planner';getCubePlanner(cube);">Planner > {code} > but other place the hasPermission function use as > {code:java} > hasPermission('cube',cube, permissions.ADMINISTRATION.mask) > {code} > the function hasPermission is defined in webapp/app/js/controllers/page.js > line100 > {code:java} > $scope.hasPermission = function (accessType, entity){ > ... > if (accessType === 'cube') { > project = entity.project > } else if (accessType === 'project') { > project = entity && entity.name || entity.selectedProject > } else if (accessType === 'model') { > project = ProjectModel.getProjectByCubeModel(entity.name) > } > ... > }{code} > I guess whether it's cause by no param of accessType. -- This message was sent by Atlassian JIRA (v7.6.3#76005)