[jira] [Commented] (KYLIN-4511) Support project admin user to calculate column cardinality by web
[ https://issues.apache.org/jira/browse/KYLIN-4511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17139003#comment-17139003 ] ASF GitHub Bot commented on KYLIN-4511: --- RupengWang edited a comment on pull request #1225: URL: https://github.com/apache/kylin/pull/1225#issuecomment-643761762 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Support project admin user to calculate column cardinality by web > - > > Key: KYLIN-4511 > URL: https://issues.apache.org/jira/browse/KYLIN-4511 > Project: Kylin > Issue Type: Improvement > Components: Web >Reporter: Guangxu Cheng >Assignee: Guangxu Cheng >Priority: Major > Fix For: v3.1.0 > > Attachments: image-2020-05-21-13-56-19-962.png, > image-2020-05-21-13-57-29-350.png > > > Now only the administrator of kylin can recalculate the cardinality of the > hive table through the admin web, but the project administrator cannot. > Add an entry to calculate cardinality on the table detail web > # add calculate cardinality button > !image-2020-05-21-13-56-19-962.png|width=902,height=303! > # confirm !image-2020-05-21-13-57-29-350.png|width=901,height=280! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4511) Support project admin user to calculate column cardinality by web
[ https://issues.apache.org/jira/browse/KYLIN-4511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17135152#comment-17135152 ] ASF GitHub Bot commented on KYLIN-4511: --- RupengWang edited a comment on pull request #1225: URL: https://github.com/apache/kylin/pull/1225#issuecomment-643763642 ## Design test cases ### Prepare test env - Load one table from hive ### Case-1 测试新加入的project级别的 cardinality功能是否可用以及结果是否准确  1. 通过project级别的"Cardinality"按钮确定该功能正常可用并记录下每一行的Cardinality 2. Unload这个表 2. 通过System -> "Calculate Cardinality" 输入该表，然后验证两次的Cardinality是否相同 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Support project admin user to calculate column cardinality by web > - > > Key: KYLIN-4511 > URL: https://issues.apache.org/jira/browse/KYLIN-4511 > Project: Kylin > Issue Type: Improvement > Components: Web >Reporter: Guangxu Cheng >Assignee: Guangxu Cheng >Priority: Major > Fix For: v3.1.0 > > Attachments: image-2020-05-21-13-56-19-962.png, > image-2020-05-21-13-57-29-350.png > > > Now only the administrator of kylin can recalculate the cardinality of the > hive table through the admin web, but the project administrator cannot. > Add an entry to calculate cardinality on the table detail web > # add calculate cardinality button > !image-2020-05-21-13-56-19-962.png|width=902,height=303! > # confirm !image-2020-05-21-13-57-29-350.png|width=901,height=280! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4511) Support project admin user to calculate column cardinality by web
[
https://issues.apache.org/jira/browse/KYLIN-4511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17135150#comment-17135150
]
ASF GitHub Bot commented on KYLIN-4511:
---
RupengWang commented on pull request #1225:
URL: https://github.com/apache/kylin/pull/1225#issuecomment-643764226
### Verify test case
Case-1
1. project级别的"Cardinality"
2. admin级别的System -> Calculate Cardinality
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Support project admin user to calculate column cardinality by web
> -
>
> Key: KYLIN-4511
> URL: https://issues.apache.org/jira/browse/KYLIN-4511
> Project: Kylin
> Issue Type: Improvement
> Components: Web
>Reporter: Guangxu Cheng
>Assignee: Guangxu Cheng
>Priority: Major
> Fix For: v3.1.0
>
> Attachments: image-2020-05-21-13-56-19-962.png,
> image-2020-05-21-13-57-29-350.png
>
>
> Now only the administrator of kylin can recalculate the cardinality of the
> hive table through the admin web, but the project administrator cannot.
> Add an entry to calculate cardinality on the table detail web
> # add calculate cardinality button
> !image-2020-05-21-13-56-19-962.png|width=902,height=303!
> # confirm !image-2020-05-21-13-57-29-350.png|width=901,height=280!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (KYLIN-4511) Support project admin user to calculate column cardinality by web
[ https://issues.apache.org/jira/browse/KYLIN-4511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17135148#comment-17135148 ] ASF GitHub Bot commented on KYLIN-4511: --- RupengWang edited a comment on pull request #1225: URL: https://github.com/apache/kylin/pull/1225#issuecomment-643763642 ## Design test cases ### Prepare test env - Load one table from hive ### Case-1 1. 通过project级别的"Cardinality"按钮确定该功能正常可用并记录下每一行的Cardinality 2. Unload这个表 2. 通过System -> "Calculate Cardinality" 输入该表，然后验证两次的Cardinality是否相同 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Support project admin user to calculate column cardinality by web > - > > Key: KYLIN-4511 > URL: https://issues.apache.org/jira/browse/KYLIN-4511 > Project: Kylin > Issue Type: Improvement > Components: Web >Reporter: Guangxu Cheng >Assignee: Guangxu Cheng >Priority: Major > Fix For: v3.1.0 > > Attachments: image-2020-05-21-13-56-19-962.png, > image-2020-05-21-13-57-29-350.png > > > Now only the administrator of kylin can recalculate the cardinality of the > hive table through the admin web, but the project administrator cannot. > Add an entry to calculate cardinality on the table detail web > # add calculate cardinality button > !image-2020-05-21-13-56-19-962.png|width=902,height=303! > # confirm !image-2020-05-21-13-57-29-350.png|width=901,height=280! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4511) Support project admin user to calculate column cardinality by web
[ https://issues.apache.org/jira/browse/KYLIN-4511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17135147#comment-17135147 ] ASF GitHub Bot commented on KYLIN-4511: --- RupengWang commented on pull request #1225: URL: https://github.com/apache/kylin/pull/1225#issuecomment-643763789 ## Prepare data and env - [x] Built on commit_SHA : 5b7b0ed1bdb49cb788e95207ca8437a05fa6b6d1 - [x] Hadoop env : HDP2.4 - [x] Just sample table is OK. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Support project admin user to calculate column cardinality by web > - > > Key: KYLIN-4511 > URL: https://issues.apache.org/jira/browse/KYLIN-4511 > Project: Kylin > Issue Type: Improvement > Components: Web >Reporter: Guangxu Cheng >Assignee: Guangxu Cheng >Priority: Major > Fix For: v3.1.0 > > Attachments: image-2020-05-21-13-56-19-962.png, > image-2020-05-21-13-57-29-350.png > > > Now only the administrator of kylin can recalculate the cardinality of the > hive table through the admin web, but the project administrator cannot. > Add an entry to calculate cardinality on the table detail web > # add calculate cardinality button > !image-2020-05-21-13-56-19-962.png|width=902,height=303! > # confirm !image-2020-05-21-13-57-29-350.png|width=901,height=280! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4511) Support project admin user to calculate column cardinality by web
[ https://issues.apache.org/jira/browse/KYLIN-4511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17135146#comment-17135146 ] ASF GitHub Bot commented on KYLIN-4511: --- RupengWang commented on pull request #1225: URL: https://github.com/apache/kylin/pull/1225#issuecomment-643763642 ## Design test cases ### Prepare test env - Load one table from hive ### Case-1 1. 通过"Cardinality"按钮确定该功能正常可用并记录下每一行的Cardinality 2. Unload这个表 2. 通过System -> "Calculate Cardinality" 输入该表，然后验证两次的Cardinality是否相同 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Support project admin user to calculate column cardinality by web > - > > Key: KYLIN-4511 > URL: https://issues.apache.org/jira/browse/KYLIN-4511 > Project: Kylin > Issue Type: Improvement > Components: Web >Reporter: Guangxu Cheng >Assignee: Guangxu Cheng >Priority: Major > Fix For: v3.1.0 > > Attachments: image-2020-05-21-13-56-19-962.png, > image-2020-05-21-13-57-29-350.png > > > Now only the administrator of kylin can recalculate the cardinality of the > hive table through the admin web, but the project administrator cannot. > Add an entry to calculate cardinality on the table detail web > # add calculate cardinality button > !image-2020-05-21-13-56-19-962.png|width=902,height=303! > # confirm !image-2020-05-21-13-57-29-350.png|width=901,height=280! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4511) Support project admin user to calculate column cardinality by web
[ https://issues.apache.org/jira/browse/KYLIN-4511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17135142#comment-17135142 ] ASF GitHub Bot commented on KYLIN-4511: --- RupengWang commented on pull request #1225: URL: https://github.com/apache/kylin/pull/1225#issuecomment-643761762 ### Check list - [x] Step 1. [**OPTIONAL**]Understand background/root cause/design basically(one hour EST) . Its issue type is - [ ] bug fix - [ ] new feature - [x] enhancement - [x] Step 2. Test cases are designed and documented (30 minutes EST). - [x] Step 3. Prepare specific env, for example: - mock data (maybe some specific data type) - test env (maybe install a RDBMS instance). - [x] Step 4. Verify and make sure test cases passed. - [x] Step 5. Paste manual important steps and screenshots here (20 minutes EST). - If you find difficulty in pick most important evidence, please attach diagnosis package. - [x] Step 6. Do more check in user perspective (20 minutes EST) - [x] Doc need be updated? And if it is updated? Ask help for release manager if so. - [x] If it is a breaking change so we should notify Kylin community? Ask help for release manager if so. - [x] Step 7. Summarize this test (20 minutes EST). ### Total estimate - 4 hours for small issue from optimistic estimate. ### Note If you find some unexpected and **unrelated** error/mistake, please DO report it if it is truly a mistake, I think we may research and fix it in the future. If you find background information/root cause analysis is not complete or ambiguous, please try to contact to author or do a quick research and record what you find. It is a good chance to learn something interesting. If you find it is not easy to design testcase, please notify release manager. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Support project admin user to calculate column cardinality by web > - > > Key: KYLIN-4511 > URL: https://issues.apache.org/jira/browse/KYLIN-4511 > Project: Kylin > Issue Type: Improvement > Components: Web >Reporter: Guangxu Cheng >Assignee: Guangxu Cheng >Priority: Major > Fix For: v3.1.0 > > Attachments: image-2020-05-21-13-56-19-962.png, > image-2020-05-21-13-57-29-350.png > > > Now only the administrator of kylin can recalculate the cardinality of the > hive table through the admin web, but the project administrator cannot. > Add an entry to calculate cardinality on the table detail web > # add calculate cardinality button > !image-2020-05-21-13-56-19-962.png|width=902,height=303! > # confirm !image-2020-05-21-13-57-29-350.png|width=901,height=280! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4511) Support project admin user to calculate column cardinality by web
[ https://issues.apache.org/jira/browse/KYLIN-4511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17135143#comment-17135143 ] ASF GitHub Bot commented on KYLIN-4511: --- RupengWang edited a comment on pull request #1225: URL: https://github.com/apache/kylin/pull/1225#issuecomment-643761762 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Support project admin user to calculate column cardinality by web > - > > Key: KYLIN-4511 > URL: https://issues.apache.org/jira/browse/KYLIN-4511 > Project: Kylin > Issue Type: Improvement > Components: Web >Reporter: Guangxu Cheng >Assignee: Guangxu Cheng >Priority: Major > Fix For: v3.1.0 > > Attachments: image-2020-05-21-13-56-19-962.png, > image-2020-05-21-13-57-29-350.png > > > Now only the administrator of kylin can recalculate the cardinality of the > hive table through the admin web, but the project administrator cannot. > Add an entry to calculate cardinality on the table detail web > # add calculate cardinality button > !image-2020-05-21-13-56-19-962.png|width=902,height=303! > # confirm !image-2020-05-21-13-57-29-350.png|width=901,height=280! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4511) Support project admin user to calculate column cardinality by web
[ https://issues.apache.org/jira/browse/KYLIN-4511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17117332#comment-17117332 ] ASF GitHub Bot commented on KYLIN-4511: --- shaofengshi merged pull request #1225: URL: https://github.com/apache/kylin/pull/1225 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Support project admin user to calculate column cardinality by web > - > > Key: KYLIN-4511 > URL: https://issues.apache.org/jira/browse/KYLIN-4511 > Project: Kylin > Issue Type: Improvement > Components: Web >Reporter: Guangxu Cheng >Assignee: Guangxu Cheng >Priority: Major > Fix For: v3.1.0 > > Attachments: image-2020-05-21-13-56-19-962.png, > image-2020-05-21-13-57-29-350.png > > > Now only the administrator of kylin can recalculate the cardinality of the > hive table through the admin web, but the project administrator cannot. > Add an entry to calculate cardinality on the table detail web > # add calculate cardinality button > !image-2020-05-21-13-56-19-962.png|width=902,height=303! > # confirm !image-2020-05-21-13-57-29-350.png|width=901,height=280! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4511) Support project admin user to calculate column cardinality by web
[ https://issues.apache.org/jira/browse/KYLIN-4511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17117330#comment-17117330 ] ASF GitHub Bot commented on KYLIN-4511: --- shaofengshi commented on pull request #1225: URL: https://github.com/apache/kylin/pull/1225#issuecomment-633799198 @guangxuCheng Looks good to me; Will merge it soon, thank you! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Support project admin user to calculate column cardinality by web > - > > Key: KYLIN-4511 > URL: https://issues.apache.org/jira/browse/KYLIN-4511 > Project: Kylin > Issue Type: Improvement > Components: Web >Reporter: Guangxu Cheng >Assignee: Guangxu Cheng >Priority: Major > Fix For: v3.1.0 > > Attachments: image-2020-05-21-13-56-19-962.png, > image-2020-05-21-13-57-29-350.png > > > Now only the administrator of kylin can recalculate the cardinality of the > hive table through the admin web, but the project administrator cannot. > Add an entry to calculate cardinality on the table detail web > # add calculate cardinality button > !image-2020-05-21-13-56-19-962.png|width=902,height=303! > # confirm !image-2020-05-21-13-57-29-350.png|width=901,height=280! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4511) Support project admin user to calculate column cardinality by web
[ https://issues.apache.org/jira/browse/KYLIN-4511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116497#comment-17116497 ] Shao Feng Shi commented on KYLIN-4511: -- Merged. > Support project admin user to calculate column cardinality by web > - > > Key: KYLIN-4511 > URL: https://issues.apache.org/jira/browse/KYLIN-4511 > Project: Kylin > Issue Type: Improvement > Components: Web >Reporter: Guangxu Cheng >Assignee: Guangxu Cheng >Priority: Major > Fix For: v3.1.0 > > Attachments: image-2020-05-21-13-56-19-962.png, > image-2020-05-21-13-57-29-350.png > > > Now only the administrator of kylin can recalculate the cardinality of the > hive table through the admin web, but the project administrator cannot. > Add an entry to calculate cardinality on the table detail web > # add calculate cardinality button > !image-2020-05-21-13-56-19-962.png|width=902,height=303! > # confirm !image-2020-05-21-13-57-29-350.png|width=901,height=280! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4511) Support project admin user to calculate column cardinality by web
[ https://issues.apache.org/jira/browse/KYLIN-4511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116474#comment-17116474 ] ASF subversion and git services commented on KYLIN-4511: Commit 3605d70a392b6505b116b0b448ad0cb28fb1284f in kylin's branch refs/heads/master from Guangxu Cheng [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=3605d70 ] KYLIN-4511 Support project admin user to calculate column cardinality by web > Support project admin user to calculate column cardinality by web > - > > Key: KYLIN-4511 > URL: https://issues.apache.org/jira/browse/KYLIN-4511 > Project: Kylin > Issue Type: Improvement > Components: Web >Reporter: Guangxu Cheng >Assignee: Guangxu Cheng >Priority: Major > Fix For: v3.1.0 > > Attachments: image-2020-05-21-13-56-19-962.png, > image-2020-05-21-13-57-29-350.png > > > Now only the administrator of kylin can recalculate the cardinality of the > hive table through the admin web, but the project administrator cannot. > Add an entry to calculate cardinality on the table detail web > # add calculate cardinality button > !image-2020-05-21-13-56-19-962.png|width=902,height=303! > # confirm !image-2020-05-21-13-57-29-350.png|width=901,height=280! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4511) Support project admin user to calculate column cardinality by web
[ https://issues.apache.org/jira/browse/KYLIN-4511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17115616#comment-17115616 ] ASF GitHub Bot commented on KYLIN-4511: --- guangxuCheng commented on pull request #1225: URL: https://github.com/apache/kylin/pull/1225#issuecomment-64777 @shaofengshi . Any other concerns? Thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Support project admin user to calculate column cardinality by web > - > > Key: KYLIN-4511 > URL: https://issues.apache.org/jira/browse/KYLIN-4511 > Project: Kylin > Issue Type: Improvement > Components: Web >Reporter: Guangxu Cheng >Assignee: Guangxu Cheng >Priority: Major > Fix For: v3.1.0 > > Attachments: image-2020-05-21-13-56-19-962.png, > image-2020-05-21-13-57-29-350.png > > > Now only the administrator of kylin can recalculate the cardinality of the > hive table through the admin web, but the project administrator cannot. > Add an entry to calculate cardinality on the table detail web > # add calculate cardinality button > !image-2020-05-21-13-56-19-962.png|width=902,height=303! > # confirm !image-2020-05-21-13-57-29-350.png|width=901,height=280! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4511) Support project admin user to calculate column cardinality by web
[ https://issues.apache.org/jira/browse/KYLIN-4511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114514#comment-17114514 ] ASF GitHub Bot commented on KYLIN-4511: --- codecov-commenter edited a comment on pull request #1225: URL: https://github.com/apache/kylin/pull/1225#issuecomment-631867241 # [Codecov](https://codecov.io/gh/apache/kylin/pull/1225?src=pr=h1) Report > Merging [#1225](https://codecov.io/gh/apache/kylin/pull/1225?src=pr=desc) into [master](https://codecov.io/gh/apache/kylin/commit/7886a2498178ded085497d6204b4b367f56ce0c8=desc) will **increase** coverage by `1.05%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/kylin/pull/1225?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1225 +/- ## + Coverage 24.85% 25.91% +1.05% - Complexity 6266 6520 +254 Files 1453 1456 +3 Lines 8922589459 +234 Branches 1245612482 +26 + Hits 2218123179 +998 + Misses6486964022 -847 - Partials 2175 2258 +83 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1225?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...org/apache/kylin/rest/util/QueryRequestLimits.java](https://codecov.io/gh/apache/kylin/pull/1225/diff?src=pr=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvdXRpbC9RdWVyeVJlcXVlc3RMaW1pdHMuamF2YQ==) | `35.71% <0.00%> (-4.77%)` | `5.00% <0.00%> (-1.00%)` | | | [...che/kylin/stream/core/storage/CheckPointStore.java](https://codecov.io/gh/apache/kylin/pull/1225/diff?src=pr=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvQ2hlY2tQb2ludFN0b3JlLmphdmE=) | `63.63% <0.00%> (-3.04%)` | `21.00% <0.00%> (-1.00%)` | | | [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/1225/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `70.21% <0.00%> (-0.92%)` | `7.00% <0.00%> (ø%)` | | | [.../kylin/cache/memcached/MemcachedChunkingCache.java](https://codecov.io/gh/apache/kylin/pull/1225/diff?src=pr=tree#diff-Y2FjaGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NhY2hlL21lbWNhY2hlZC9NZW1jYWNoZWRDaHVua2luZ0NhY2hlLmphdmE=) | `39.70% <0.00%> (-0.45%)` | `15.00% <0.00%> (ø%)` | | | [...ava/org/apache/kylin/tool/JobDiagnosisInfoCLI.java](https://codecov.io/gh/apache/kylin/pull/1225/diff?src=pr=tree#diff-dG9vbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vdG9vbC9Kb2JEaWFnbm9zaXNJbmZvQ0xJLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | | | [.../org/apache/kylin/query/relnode/OLAPTableScan.java](https://codecov.io/gh/apache/kylin/pull/1225/diff?src=pr=tree#diff-cXVlcnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3F1ZXJ5L3JlbG5vZGUvT0xBUFRhYmxlU2Nhbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | | | [...va/org/apache/kylin/rest/service/QueryService.java](https://codecov.io/gh/apache/kylin/pull/1225/diff?src=pr=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VydmljZS9RdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | | | [...va/org/apache/kylin/source/hive/CLIHiveClient.java](https://codecov.io/gh/apache/kylin/pull/1225/diff?src=pr=tree#diff-c291cmNlLWhpdmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3NvdXJjZS9oaXZlL0NMSUhpdmVDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | | | [...va/org/apache/kylin/source/hive/HiveTableMeta.java](https://codecov.io/gh/apache/kylin/pull/1225/diff?src=pr=tree#diff-c291cmNlLWhpdmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3NvdXJjZS9oaXZlL0hpdmVUYWJsZU1ldGEuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | | | [...apache/kylin/job/execution/AbstractExecutable.java](https://codecov.io/gh/apache/kylin/pull/1225/diff?src=pr=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9leGVjdXRpb24vQWJzdHJhY3RFeGVjdXRhYmxlLmphdmE=) | `47.93% <0.00%> (ø)` | `51.00% <0.00%> (ø%)` | | | ... and [49 more](https://codecov.io/gh/apache/kylin/pull/1225/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1225?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by
[jira] [Commented] (KYLIN-4511) Support project admin user to calculate column cardinality by web
[ https://issues.apache.org/jira/browse/KYLIN-4511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114478#comment-17114478 ] ASF GitHub Bot commented on KYLIN-4511: --- coveralls edited a comment on pull request #1225: URL: https://github.com/apache/kylin/pull/1225#issuecomment-631864012 ## Pull Request Test Coverage Report for [Build 5936](https://coveralls.io/builds/30981977) * **0** of **0** changed or added relevant lines in **0** files are covered. * **945** unchanged lines in **22** files lost coverage. * Overall coverage increased (+**1.1%**) to **28.438%** --- | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/CalculateStatsFromBaseCuboidMapper.java](https://coveralls.io/builds/30981977/source?filename=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2Fsteps%2FCalculateStatsFromBaseCuboidMapper.java#L150) | 1 | 95.35% | | [stream-core/src/main/java/org/apache/kylin/stream/core/storage/CheckPointStore.java](https://coveralls.io/builds/30981977/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2FCheckPointStore.java#L98) | 2 | 73.74% | | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/30981977/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L449) | 3 | 78.42% | | [source-hive/src/main/java/org/apache/kylin/source/hive/HiveTableMeta.java](https://coveralls.io/builds/30981977/source?filename=source-hive%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fhive%2FHiveTableMeta.java#L70) | 3 | 0% | | [stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/ColumnarMemoryStorePersister.java](https://coveralls.io/builds/30981977/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2Fcolumnar%2FColumnarMemoryStorePersister.java#L112) | 10 | 94.92% | | [stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/SegmentMemoryStore.java](https://coveralls.io/builds/30981977/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2Fcolumnar%2FSegmentMemoryStore.java#L167) | 11 | 88.61% | | [core-metrics/src/main/java/org/apache/kylin/metrics/lib/impl/RecordEvent.java](https://coveralls.io/builds/30981977/source?filename=core-metrics%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetrics%2Flib%2Fimpl%2FRecordEvent.java#L119) | 14 | 76.34% | | [source-hive/src/main/java/org/apache/kylin/source/hive/CLIHiveClient.java](https://coveralls.io/builds/30981977/source?filename=source-hive%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fhive%2FCLIHiveClient.java#L112) | 19 | 0% | | [source-hive/src/main/java/org/apache/kylin/source/hive/HiveTableMetaBuilder.java](https://coveralls.io/builds/30981977/source?filename=source-hive%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fhive%2FHiveTableMetaBuilder.java#L39) | 19 | 0% | | [core-metrics/src/main/java/org/apache/kylin/metrics/lib/impl/BlockingReservoir.java](https://coveralls.io/builds/30981977/source?filename=core-metrics%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetrics%2Flib%2Fimpl%2FBlockingReservoir.java#L89) | 22 | 60.0% | | Totals | [](https://coveralls.io/builds/30981977) | | :-- | --: | | Change from base [Build 5911](https://coveralls.io/builds/30861301): | 1.1% | | Covered Lines: | 25440 | | Relevant Lines: | 89459 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Support project admin user to calculate column cardinality by web > - > > Key: KYLIN-4511 > URL: https://issues.apache.org/jira/browse/KYLIN-4511 > Project: Kylin > Issue Type: Improvement > Components: Web >Reporter: Guangxu Cheng >Assignee: Guangxu Cheng >Priority: Major > Fix For: v3.1.0 > > Attachments: image-2020-05-21-13-56-19-962.png, > image-2020-05-21-13-57-29-350.png > > > Now only the administrator of kylin can recalculate the cardinality of the > hive table through the admin web, but the project administrator cannot. > Add an entry to calculate cardinality on the table detail web > # add calculate cardinality button >
[jira] [Commented] (KYLIN-4511) Support project admin user to calculate column cardinality by web
[ https://issues.apache.org/jira/browse/KYLIN-4511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114215#comment-17114215 ] ASF GitHub Bot commented on KYLIN-4511: --- guangxuCheng commented on pull request #1225: URL: https://github.com/apache/kylin/pull/1225#issuecomment-632785523 The latest code cannot be obtained here after using a force-push. If it is the same tomorrow, I will close the PR and create a new one. Thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Support project admin user to calculate column cardinality by web > - > > Key: KYLIN-4511 > URL: https://issues.apache.org/jira/browse/KYLIN-4511 > Project: Kylin > Issue Type: Improvement > Components: Web >Reporter: Guangxu Cheng >Assignee: Guangxu Cheng >Priority: Major > Fix For: v3.1.0 > > Attachments: image-2020-05-21-13-56-19-962.png, > image-2020-05-21-13-57-29-350.png > > > Now only the administrator of kylin can recalculate the cardinality of the > hive table through the admin web, but the project administrator cannot. > Add an entry to calculate cardinality on the table detail web > # add calculate cardinality button > !image-2020-05-21-13-56-19-962.png|width=902,height=303! > # confirm !image-2020-05-21-13-57-29-350.png|width=901,height=280! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4511) Support project admin user to calculate column cardinality by web
[
https://issues.apache.org/jira/browse/KYLIN-4511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114199#comment-17114199
]
ASF GitHub Bot commented on KYLIN-4511:
---
guangxuCheng commented on a change in pull request #1225:
URL: https://github.com/apache/kylin/pull/1225#discussion_r429333754
##
File path: webapp/app/js/controllers/sourceMeta.js
##
@@ -131,6 +131,39 @@ KylinApp
});
};
+$scope.calCardinality = function (tableName) {
+ SweetAlert.swal({
+title: "",
+text: "Are you sure to recalculate column cardinality?",
+showCancelButton: true,
+confirmButtonColor: '#DD6B55',
+confirmButtonText: "Yes",
+cancelButtonText: "No",
+closeOnConfirm: true
+ }, function (isConfirm) {
+if (isConfirm) {
+ if (!$scope.projectModel.selectedProject) {
+SweetAlert.swal('', 'Please choose your project first!.', 'info');
+return;
+ }
+ loadingRequest.show();
+ TableService.genCardinality({tableName: tableName, pro:
$scope.projectModel.selectedProject}, {}, function () {
+loadingRequest.hide();
+MessageBox.successNotify('Cardinality job was calculated
successfully. Please wait a moment...');
Review comment:
done
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Support project admin user to calculate column cardinality by web
> -
>
> Key: KYLIN-4511
> URL: https://issues.apache.org/jira/browse/KYLIN-4511
> Project: Kylin
> Issue Type: Improvement
> Components: Web
>Reporter: Guangxu Cheng
>Assignee: Guangxu Cheng
>Priority: Major
> Fix For: v3.1.0
>
> Attachments: image-2020-05-21-13-56-19-962.png,
> image-2020-05-21-13-57-29-350.png
>
>
> Now only the administrator of kylin can recalculate the cardinality of the
> hive table through the admin web, but the project administrator cannot.
> Add an entry to calculate cardinality on the table detail web
> # add calculate cardinality button
> !image-2020-05-21-13-56-19-962.png|width=902,height=303!
> # confirm !image-2020-05-21-13-57-29-350.png|width=901,height=280!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (KYLIN-4511) Support project admin user to calculate column cardinality by web
[
https://issues.apache.org/jira/browse/KYLIN-4511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114192#comment-17114192
]
ASF GitHub Bot commented on KYLIN-4511:
---
guangxuCheng commented on a change in pull request #1225:
URL: https://github.com/apache/kylin/pull/1225#discussion_r429331410
##
File path: webapp/app/js/controllers/sourceMeta.js
##
@@ -131,6 +131,39 @@ KylinApp
});
};
+$scope.calCardinality = function (tableName) {
+ SweetAlert.swal({
+title: "",
+text: "Are you sure to recalculate column cardinality?",
+showCancelButton: true,
+confirmButtonColor: '#DD6B55',
+confirmButtonText: "Yes",
+cancelButtonText: "No",
+closeOnConfirm: true
+ }, function (isConfirm) {
+if (isConfirm) {
+ if (!$scope.projectModel.selectedProject) {
+SweetAlert.swal('', 'Please choose your project first!.', 'info');
Review comment:
OK, 'Please choose your project first!.' is also used in the other two
places. I will deal with them together
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Support project admin user to calculate column cardinality by web
> -
>
> Key: KYLIN-4511
> URL: https://issues.apache.org/jira/browse/KYLIN-4511
> Project: Kylin
> Issue Type: Improvement
> Components: Web
>Reporter: Guangxu Cheng
>Assignee: Guangxu Cheng
>Priority: Major
> Fix For: v3.1.0
>
> Attachments: image-2020-05-21-13-56-19-962.png,
> image-2020-05-21-13-57-29-350.png
>
>
> Now only the administrator of kylin can recalculate the cardinality of the
> hive table through the admin web, but the project administrator cannot.
> Add an entry to calculate cardinality on the table detail web
> # add calculate cardinality button
> !image-2020-05-21-13-56-19-962.png|width=902,height=303!
> # confirm !image-2020-05-21-13-57-29-350.png|width=901,height=280!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (KYLIN-4511) Support project admin user to calculate column cardinality by web
[
https://issues.apache.org/jira/browse/KYLIN-4511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114114#comment-17114114
]
ASF GitHub Bot commented on KYLIN-4511:
---
shaofengshi commented on a change in pull request #1225:
URL: https://github.com/apache/kylin/pull/1225#discussion_r429290527
##
File path: webapp/app/js/controllers/sourceMeta.js
##
@@ -131,6 +131,39 @@ KylinApp
});
};
+$scope.calCardinality = function (tableName) {
+ SweetAlert.swal({
+title: "",
+text: "Are you sure to recalculate column cardinality?",
+showCancelButton: true,
+confirmButtonColor: '#DD6B55',
+confirmButtonText: "Yes",
+cancelButtonText: "No",
+closeOnConfirm: true
+ }, function (isConfirm) {
+if (isConfirm) {
+ if (!$scope.projectModel.selectedProject) {
+SweetAlert.swal('', 'Please choose your project first!.', 'info');
+return;
+ }
+ loadingRequest.show();
+ TableService.genCardinality({tableName: tableName, pro:
$scope.projectModel.selectedProject}, {}, function () {
+loadingRequest.hide();
+MessageBox.successNotify('Cardinality job was calculated
successfully. Please wait a moment...');
Review comment:
Some suggestions on the sentence: 'Cardinality job has been submitted
successfully. Please wait a while to get the numbers.'
##
File path: webapp/app/js/controllers/sourceMeta.js
##
@@ -131,6 +131,39 @@ KylinApp
});
};
+$scope.calCardinality = function (tableName) {
+ SweetAlert.swal({
+title: "",
+text: "Are you sure to recalculate column cardinality?",
+showCancelButton: true,
+confirmButtonColor: '#DD6B55',
+confirmButtonText: "Yes",
+cancelButtonText: "No",
+closeOnConfirm: true
+ }, function (isConfirm) {
+if (isConfirm) {
+ if (!$scope.projectModel.selectedProject) {
+SweetAlert.swal('', 'Please choose your project first!.', 'info');
Review comment:
The message should be consistent with other parts in below: "Please
select a project." And, please avoid using "!" in the sentence as its mood is
too strong.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Support project admin user to calculate column cardinality by web
> -
>
> Key: KYLIN-4511
> URL: https://issues.apache.org/jira/browse/KYLIN-4511
> Project: Kylin
> Issue Type: Improvement
> Components: Web
>Reporter: Guangxu Cheng
>Assignee: Guangxu Cheng
>Priority: Major
> Attachments: image-2020-05-21-13-56-19-962.png,
> image-2020-05-21-13-57-29-350.png
>
>
> Now only the administrator of kylin can recalculate the cardinality of the
> hive table through the admin web, but the project administrator cannot.
> Add an entry to calculate cardinality on the table detail web
> # add calculate cardinality button
> !image-2020-05-21-13-56-19-962.png|width=902,height=303!
> # confirm !image-2020-05-21-13-57-29-350.png|width=901,height=280!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (KYLIN-4511) Support project admin user to calculate column cardinality by web
[ https://issues.apache.org/jira/browse/KYLIN-4511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17112787#comment-17112787 ] ASF GitHub Bot commented on KYLIN-4511: --- codecov-commenter commented on pull request #1225: URL: https://github.com/apache/kylin/pull/1225#issuecomment-631867241 # [Codecov](https://codecov.io/gh/apache/kylin/pull/1225?src=pr=h1) Report > Merging [#1225](https://codecov.io/gh/apache/kylin/pull/1225?src=pr=desc) into [master](https://codecov.io/gh/apache/kylin/commit/7886a2498178ded085497d6204b4b367f56ce0c8=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/kylin/pull/1225?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1225 +/- ## - Coverage 24.85% 24.84% -0.02% + Complexity 6266 6263 -3 Files 1453 1453 Lines 8922589225 Branches 1245612456 - Hits 2217522165 -10 - Misses6487464880 +6 - Partials 2176 2180 +4 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1225?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...he/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://codecov.io/gh/apache/kylin/pull/1225/diff?src=pr=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGUuamF2YQ==) | `72.97% <0.00%> (-5.41%)` | `6.00% <0.00%> (-1.00%)` | | | [...org/apache/kylin/rest/util/QueryRequestLimits.java](https://codecov.io/gh/apache/kylin/pull/1225/diff?src=pr=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvdXRpbC9RdWVyeVJlcXVlc3RMaW1pdHMuamF2YQ==) | `35.71% <0.00%> (-4.77%)` | `5.00% <0.00%> (-1.00%)` | | | [...che/kylin/stream/core/storage/CheckPointStore.java](https://codecov.io/gh/apache/kylin/pull/1225/diff?src=pr=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvQ2hlY2tQb2ludFN0b3JlLmphdmE=) | `63.63% <0.00%> (-3.04%)` | `21.00% <0.00%> (-1.00%)` | | | [.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/1225/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=) | `63.84% <0.00%> (-2.31%)` | `0.00% <0.00%> (ø%)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1225?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1225?src=pr=footer). Last update [7886a24...273fdb1](https://codecov.io/gh/apache/kylin/pull/1225?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Support project admin user to calculate column cardinality by web > - > > Key: KYLIN-4511 > URL: https://issues.apache.org/jira/browse/KYLIN-4511 > Project: Kylin > Issue Type: Improvement > Components: Web >Reporter: Guangxu Cheng >Assignee: Guangxu Cheng >Priority: Major > > Now only the administrator of kylin can recalculate the cardinality of the > hive table through the admin web, but the project administrator cannot. > Add an entry to calculate cardinality on the table detail web -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4511) Support project admin user to calculate column cardinality by web
[ https://issues.apache.org/jira/browse/KYLIN-4511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17112781#comment-17112781 ] ASF GitHub Bot commented on KYLIN-4511: --- coveralls commented on pull request #1225: URL: https://github.com/apache/kylin/pull/1225#issuecomment-631864012 ## Pull Request Test Coverage Report for [Build 5925](https://coveralls.io/builds/30936192) * **0** of **0** changed or added relevant lines in **0** files are covered. * **5** unchanged lines in **3** files lost coverage. * Overall coverage decreased (**-0.006%**) to **27.288%** --- | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://coveralls.io/builds/30936192/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2Flookup%2Fcache%2FRocksDBLookupTable.java#L62) | 1 | 81.08% | | [core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://coveralls.io/builds/30936192/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcuboid%2FTreeCuboidScheduler.java#L124) | 2 | 68.46% | | [stream-core/src/main/java/org/apache/kylin/stream/core/storage/CheckPointStore.java](https://coveralls.io/builds/30936192/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2FCheckPointStore.java#L98) | 2 | 73.74% | | Totals | [](https://coveralls.io/builds/30936192) | | :-- | --: | | Change from base [Build 5911](https://coveralls.io/builds/30861301): | -0.006% | | Covered Lines: | 24348 | | Relevant Lines: | 89225 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Support project admin user to calculate column cardinality by web > - > > Key: KYLIN-4511 > URL: https://issues.apache.org/jira/browse/KYLIN-4511 > Project: Kylin > Issue Type: Improvement > Components: Web >Reporter: Guangxu Cheng >Assignee: Guangxu Cheng >Priority: Major > > Now only the administrator of kylin can recalculate the cardinality of the > hive table through the admin web, but the project administrator cannot. > Add an entry to calculate cardinality on the table detail web -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4511) Support project admin user to calculate column cardinality by web
[ https://issues.apache.org/jira/browse/KYLIN-4511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17112765#comment-17112765 ] ASF GitHub Bot commented on KYLIN-4511: --- guangxuCheng opened a new pull request #1225: URL: https://github.com/apache/kylin/pull/1225 … by web ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. ## Types of changes What types of changes does your code introduce to Kylin? _Put an `x` in the boxes that apply_ - [ ] Bugfix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation Update (if none of the other choices apply) ## Checklist _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._ - [ x] I have create an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail - [x ] Commit messages in my PR start with the related jira ID, like "KYLIN- Make Kylin project open-source" - [ x] Compiling and unit tests pass locally with my changes - [ ] I have added tests that prove my fix is effective or that my feature works - [x ] If this change need a document change, I will prepare another pr against the `document` branch - [x ] Any dependent changes have been merged ## Further comments If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Support project admin user to calculate column cardinality by web > - > > Key: KYLIN-4511 > URL: https://issues.apache.org/jira/browse/KYLIN-4511 > Project: Kylin > Issue Type: Improvement > Components: Web >Reporter: Guangxu Cheng >Assignee: Guangxu Cheng >Priority: Major > > Now only the administrator of kylin can recalculate the cardinality of the > hive table through the admin web, but the project administrator cannot. > Add an entry to calculate cardinality on the table detail web -- This message was sent by Atlassian Jira (v8.3.4#803005)
